ArrayDuplicateKeys::pass() - Code Metrics - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

ArrayDuplicateKeys::pass() B
last analyzed 2019-02-27 06:44 UTC

↳ Parent: ArrayDuplicateKeys

Complexity

Conditions	7
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
cc	7
nc	4
nop	2
dl	0
loc	33
ccs	0
cts	19
cp	0
crap	56
rs	8.4586
c	0
b	0
f	0

<?php
/**
 * @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Expression;

use PhpParser\Node\Expr;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;

class ArrayDuplicateKeys implements Pass\AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    const DESCRIPTION = <<<DESC
This inspection reports any duplicated keys on array creation expression.
If multiple elements in the array declaration use the same key, only the last
one will be used as all others are overwritten.
DESC;

    /**
     * @param Expr\Array_ $expr
     * @param Context $context
     * @return bool
     */
    public function pass(Expr\Array_ $expr, Context $context)
    {
        $result = false;
        $keys = [];

        /** @var Expr\ArrayItem $item */
        foreach ($expr->items as $item) {
            $compiledKey = $context->getExpressionCompiler()->compile($item->key);
            if (!$compiledKey->isTypeKnown() || !$compiledKey->isScalar() || !$compiledKey->hasValue()) {
                continue;
            }

            $key = $compiledKey->getValue();

            if (isset($keys[$key])) {
                $context->notice(
                    'array.duplicate_keys',
                    sprintf(
                        'Duplicate array key "%s" in array definition (previously declared in line %d).',
                        $item->key instanceof Expr\Variable ? sprintf('$%s (resolved value: "%s")', $item->key->name, $key) : $key,
                        $keys[$key]->getLine()
                    ),
                    $item
                );

                $result = true;
            }

            $keys[$key] = $item;
        }

        return $result;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Expr\Array_::class
        ];
    }
}


1			<?php
2			/**
3			* @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
4			*/
5
6			namespace PHPSA\Analyzer\Pass\Expression;
7
8			use PhpParser\Node\Expr;
9			use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
10			use PHPSA\Analyzer\Pass;
11			use PHPSA\Context;
12
13			class ArrayDuplicateKeys implements Pass\AnalyzerPassInterface
14			{
15			use DefaultMetadataPassTrait;
16
17			const DESCRIPTION = <<<DESC
18			This inspection reports any duplicated keys on array creation expression.
19			If multiple elements in the array declaration use the same key, only the last
20			one will be used as all others are overwritten.
21			DESC;
22
23			/**
24			* @param Expr\Array_ $expr
25			* @param Context $context
26			* @return bool
27			*/
28			public function pass(Expr\Array_ $expr, Context $context)
29			{
30			$result = false;
31			$keys = [];
32
33			/** @var Expr\ArrayItem $item */
34			foreach ($expr->items as $item) {
35			$compiledKey = $context->getExpressionCompiler()->compile($item->key);
36			if (!$compiledKey->isTypeKnown() \|\| !$compiledKey->isScalar() \|\| !$compiledKey->hasValue()) {
37			continue;
38			}
39
40			$key = $compiledKey->getValue();
41
42			if (isset($keys[$key])) {
43			$context->notice(
44			'array.duplicate_keys',
45			sprintf(
46			'Duplicate array key "%s" in array definition (previously declared in line %d).',
47			$item->key instanceof Expr\Variable ? sprintf('$%s (resolved value: "%s")', $item->key->name, $key) : $key,
48			$keys[$key]->getLine()
49			),
50			$item
51			);
52
53			$result = true;
54			}
55
56			$keys[$key] = $item;
57			}
58
59			return $result;
60			}
61
62			/**
63			* @return array
64			*/
65			public function getRegister()
66			{
67			return [
68			Expr\Array_::class
69			];
70			}
71			}
72

ovr / phpsa

ArrayDuplicateKeys::pass() B last analyzed 2019-02-27 06:44 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ArrayDuplicateKeys::pass() B
last analyzed 2019-02-27 06:44 UTC