PHPSA\Compiler\Expression\StaticPropertyFetch

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	compile()	0	35	4

<?php
/**
 * PHP Smart Analysis project 2015-2016
 *
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Definition\ClassDefinition;

class StaticPropertyFetch extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\StaticPropertyFetch';

    /**
     * {expr}::${expr};
     *
     * @param \PhpParser\Node\Expr\StaticPropertyFetch $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $expressionCompiler = $context->getExpressionCompiler();
        $leftCE = $expressionCompiler->compile($expr->class);

        if ($leftCE->isObject()) {
            $name = $expr->name;

            /** @var ClassDefinition $classDefinition */
            $classDefinition = $context->scope;
            if (!$classDefinition->hasProperty($name, true)) {
                $context->notice(
                    'language_error',
                    sprintf('Static property $%s does not exist in %s scope', $name, $expr->class),
                    $expr
                );

                return new CompiledExpression();
            }

            $property = $classDefinition->getPropertyStatement($name, true);

$name is of type object<PhpParser\Node\VarLikeIdentifier>|object<PhpParser\Node\Expr>, but the function expects a string.

            if (!$property->isStatic()) {
                $context->notice(
                    'language_error',
                    sprintf('Property $%s is not static but was called in a static way', $name),
                    $expr
                );
            }

            return $expressionCompiler->compile($property);

It seems like $property defined by $classDefinition->getPropertyStatement($name, true) on line 45 can be null; however, PHPSA\Compiler\Expression::compile() does not accept null, maybe add an additional type check?

        }

        $context->debug('Unknown static property fetch', $expr);
        return new CompiledExpression();
    }
}