Inspection of "Update XML.php (#455)" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c21849...b4931b )

by Carlos

created 2016-07-16 11:32 UTC

Status

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -54,7 +54,7 @@  discard block
 block discarded – undo
      * @param string $url
      * @param array  $options
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
      * @param string       $url
      * @param array|string $options
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
      * @param string|array $options
      * @param int          $encodeOption
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
      * @param array  $files
      * @param array  $form
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
     /**
      * Return GuzzleHttp\Client instance.
      *
-     * @return \GuzzleHttp\Client.
+     * @return HttpClient
      */
     public function getClient()
     {
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
      * @param string $method
      * @param array  $options
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */

Please login to merge, or discard this patch.

src/Payment/MerchantPay/API.php 1 patch

Doc Comments +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -77,7 +77,6 @@  discard block
 block discarded – undo
      * Send MerchantPay.
      *
      * @param array  $params
-     * @param string $type
      *
      * @return \EasyWeChat\Support\Collection
      */
@@ -137,7 +136,7 @@  discard block
 block discarded – undo
     /**
      * Parse Response XML to array.
      *
-     * @param \Psr\Http\Message\ResponseInterface|string $response
+     * @param ResponseInterface $response
      *
      * @return \EasyWeChat\Support\Collection
      */

Please login to merge, or discard this patch.

src/Payment/API.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -418,7 +418,7 @@
 block discarded – undo
     /**
      * Parse Response XML to array.
      *
-     * @param string|\Psr\Http\Message\ResponseInterface $response
+     * @param ResponseInterface $response
      *
      * @return \EasyWeChat\Support\Collection
      */

Please login to merge, or discard this patch.

src/Notice/Notice.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -80,7 +80,7 @@  discard block
 block discarded – undo
      * @param int $industryOne
      * @param int $industryTwo
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function setIndustry($industryOne, $industryTwo)
     {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
     /**
      * Get industry.
      *
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function getIndustry()
     {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
      *
      * @param string $shortId
      *
-     * @return string
+     * @return \EasyWeChat\Support\Collection
      */
     public function addTemplate($shortId)
     {
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
     /**
      * Get all private template.
      *
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function getAllPrivateTemplate()
     {
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
      *
      * @param int $templateId
      * 
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function delPrivateTemplate($templateId)
     {
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
      *
      * @param $data
      *
-     * @return mixed
+     * @return \EasyWeChat\Support\Collection
      *
      * @throws \EasyWeChat\Core\Exceptions\InvalidArgumentException
      */

Please login to merge, or discard this patch.

src/Support/XML.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -91,8 +91,8 @@
 block discarded – undo
     /**
      * Object to array.
      *
-     * @param string $data
      *
+     * @param SimpleXMLElement $obj
      * @return array
      */
     protected static function normalize($obj)

Please login to merge, or discard this patch.

src/Staff/Session.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@  discard block
 block discarded – undo
      *
      * @param string $account
      *
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function lists($account)
     {
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
     /**
      * List all waiters of $account.
      *
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function waiters()
     {
@@ -59,9 +59,9 @@  discard block
 block discarded – undo
      * Create a session.
      *
      * @param string $account
-     * @param string $openid
+     * @param string $openId
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function create($account, $openId)
     {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
      * @param string $account
      * @param string $openId
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function close($account, $openId)
     {
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
      *
      * @param string $openId
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function get($openId)
     {

Please login to merge, or discard this patch.

		@@ -418,7 +418,7 @@
		block discarded – undo
418	418	/**
419	419	* Parse Response XML to array.
420	420	*
421		- * @param string\|\Psr\Http\Message\ResponseInterface $response
	421	+ * @param ResponseInterface $response
422	422	*
423	423	* @return \EasyWeChat\Support\Collection
424	424	*/

		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	* @param string $url
55	55	* @param array $options
56	56	*
57		- * @return array\|bool
	57	+ * @return ResponseInterface
58	58	*
59	59	* @throws HttpException
60	60	*/
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	* @param string $url
70	70	* @param array\|string $options
71	71	*
72		- * @return array\|bool
	72	+ * @return ResponseInterface
73	73	*
74	74	* @throws HttpException
75	75	*/
		@@ -87,7 +87,7 @@ discard block
		block discarded – undo
87	87	* @param string\|array $options
88	88	* @param int $encodeOption
89	89	*
90		- * @return array\|bool
	90	+ * @return ResponseInterface
91	91	*
92	92	* @throws HttpException
93	93	*/
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	* @param array $files
106	106	* @param array $form
107	107	*
108		- * @return array\|bool
	108	+ * @return ResponseInterface
109	109	*
110	110	* @throws HttpException
111	111	*/
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	/**
145	145	* Return GuzzleHttp\Client instance.
146	146	*
147		- * @return \GuzzleHttp\Client.
	147	+ * @return HttpClient
148	148	*/
149	149	public function getClient()
150	150	{
		@@ -186,7 +186,7 @@ discard block
		block discarded – undo
186	186	* @param string $method
187	187	* @param array $options
188	188	*
189		- * @return array\|bool
	189	+ * @return ResponseInterface
190	190	*
191	191	* @throws HttpException
192	192	*/

		@@ -77,7 +77,6 @@ discard block
		block discarded – undo
77	77	* Send MerchantPay.
78	78	*
79	79	* @param array $params
80		- * @param string $type
81	80	*
82	81	* @return \EasyWeChat\Support\Collection
83	82	*/
		@@ -137,7 +136,7 @@ discard block
		block discarded – undo
137	136	/**
138	137	* Parse Response XML to array.
139	138	*
140		- * @param \Psr\Http\Message\ResponseInterface\|string $response
	139	+ * @param ResponseInterface $response
141	140	*
142	141	* @return \EasyWeChat\Support\Collection
143	142	*/

		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	* @param int $industryOne
81	81	* @param int $industryTwo
82	82	*
83		- * @return bool
	83	+ * @return \EasyWeChat\Support\Collection
84	84	*/
85	85	public function setIndustry($industryOne, $industryTwo)
86	86	{
		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	/**
96	96	* Get industry.
97	97	*
98		- * @return array
	98	+ * @return \EasyWeChat\Support\Collection
99	99	*/
100	100	public function getIndustry()
101	101	{
		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	*
109	109	* @param string $shortId
110	110	*
111		- * @return string
	111	+ * @return \EasyWeChat\Support\Collection
112	112	*/
113	113	public function addTemplate($shortId)
114	114	{
		@@ -120,7 +120,7 @@ discard block
		block discarded – undo
120	120	/**
121	121	* Get all private template.
122	122	*
123		- * @return array
	123	+ * @return \EasyWeChat\Support\Collection
124	124	*/
125	125	public function getAllPrivateTemplate()
126	126	{
		@@ -133,7 +133,7 @@ discard block
		block discarded – undo
133	133	*
134	134	* @param int $templateId
135	135	*
136		- * @return array
	136	+ * @return \EasyWeChat\Support\Collection
137	137	*/
138	138	public function delPrivateTemplate($templateId)
139	139	{
		@@ -146,7 +146,7 @@ discard block
		block discarded – undo
146	146	*
147	147	* @param $data
148	148	*
149		- * @return mixed
	149	+ * @return \EasyWeChat\Support\Collection
150	150	*
151	151	* @throws \EasyWeChat\Core\Exceptions\InvalidArgumentException
152	152	*/

		@@ -91,8 +91,8 @@
		block discarded – undo
91	91	/**
92	92	* Object to array.
93	93	*
94		- * @param string $data
95	94	*
	95	+ * @param SimpleXMLElement $obj
96	96	* @return array
97	97	*/
98	98	protected static function normalize($obj)

		@@ -38,7 +38,7 @@ discard block
		block discarded – undo
38	38	*
39	39	* @param string $account
40	40	*
41		- * @return array
	41	+ * @return \EasyWeChat\Support\Collection
42	42	*/
43	43	public function lists($account)
44	44	{
		@@ -48,7 +48,7 @@ discard block
		block discarded – undo
48	48	/**
49	49	* List all waiters of $account.
50	50	*
51		- * @return array
	51	+ * @return \EasyWeChat\Support\Collection
52	52	*/
53	53	public function waiters()
54	54	{
		@@ -59,9 +59,9 @@ discard block
		block discarded – undo
59	59	* Create a session.
60	60	*
61	61	* @param string $account
62		- * @param string $openid
	62	+ * @param string $openId
63	63	*
64		- * @return bool
	64	+ * @return \EasyWeChat\Support\Collection
65	65	*/
66	66	public function create($account, $openId)
67	67	{
		@@ -79,7 +79,7 @@ discard block
		block discarded – undo
79	79	* @param string $account
80	80	* @param string $openId
81	81	*
82		- * @return bool
	82	+ * @return \EasyWeChat\Support\Collection
83	83	*/
84	84	public function close($account, $openId)
85	85	{
		@@ -96,7 +96,7 @@ discard block
		block discarded – undo
96	96	*
97	97	* @param string $openId
98	98	*
99		- * @return bool
	99	+ * @return \EasyWeChat\Support\Collection
100	100	*/
101	101	public function get($openId)
102	102	{

overtrue / wechat

Push — master ( c21849...b4931b )

Status

Category

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch