Inspection of "better implementation for prepare oauth callback u..." - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#414)

by light

created 2016-05-17 08:47 UTC

Status

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -54,7 +54,7 @@  discard block
 block discarded – undo
      * @param string $url
      * @param array  $options
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
      * @param string       $url
      * @param array|string $options
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
      * @param string|array $options
      * @param int          $encodeOption
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
      * @param array  $files
      * @param array  $form
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
     /**
      * Return GuzzleHttp\Client instance.
      *
-     * @return \GuzzleHttp\Client.
+     * @return HttpClient
      */
     public function getClient()
     {
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
      * @param string $method
      * @param array  $options
      *
-     * @return array|bool
+     * @return ResponseInterface
      *
      * @throws HttpException
      */

Please login to merge, or discard this patch.

src/Payment/MerchantPay/API.php 1 patch

Doc Comments +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -77,7 +77,6 @@  discard block
 block discarded – undo
      * Send MerchantPay.
      *
      * @param array  $params
-     * @param string $type
      *
      * @return \EasyWeChat\Support\Collection
      */
@@ -137,7 +136,7 @@  discard block
 block discarded – undo
     /**
      * Parse Response XML to array.
      *
-     * @param \Psr\Http\Message\ResponseInterface|string $response
+     * @param ResponseInterface $response
      *
      * @return \EasyWeChat\Support\Collection
      */

Please login to merge, or discard this patch.

src/Payment/API.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -418,7 +418,7 @@
 block discarded – undo
     /**
      * Parse Response XML to array.
      *
-     * @param string|\Psr\Http\Message\ResponseInterface $response
+     * @param ResponseInterface $response
      *
      * @return \EasyWeChat\Support\Collection
      */

Please login to merge, or discard this patch.

src/Notice/Notice.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -80,7 +80,7 @@  discard block
 block discarded – undo
      * @param int $industryOne
      * @param int $industryTwo
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function setIndustry($industryOne, $industryTwo)
     {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
     /**
      * Get industry.
      *
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function getIndustry()
     {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
      *
      * @param string $shortId
      *
-     * @return string
+     * @return \EasyWeChat\Support\Collection
      */
     public function addTemplate($shortId)
     {
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
     /**
      * Get all private template.
      *
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function getAllPrivateTemplate()
     {
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
      *
      * @param int $templateId
      * 
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function delPrivateTemplate($templateId)
     {
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
      *
      * @param $data
      *
-     * @return mixed
+     * @return \EasyWeChat\Support\Collection
      *
      * @throws \EasyWeChat\Core\Exceptions\InvalidArgumentException
      */

Please login to merge, or discard this patch.

src/User/Tag.php 1 patch

Doc Comments +10 added lines, -11 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@  discard block
 block discarded – undo
      *
      * @param string $name
      *
-     * @return int
+     * @return \EasyWeChat\Support\Collection
      */
     public function create($name)
     {
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
     /**
      * List all tags.
      *
-     * @return array
+     * @return \EasyWeChat\Support\Collection
      */
     public function lists()
     {
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
      * @param int    $tagId
      * @param string $name
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function update($tagId, $name)
     {
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
      *
      * @param int $tagId
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function delete($tagId)
     {
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
      *
      * @param string $openId
      *
-     * @return int
+     * @return \EasyWeChat\Support\Collection
      */
     public function userTags($openId)
     {
@@ -115,9 +115,8 @@  discard block
 block discarded – undo
     /**
      * Get users from a tag.
      *
-     * @param string $openId
      *
-     * @return int
+     * @return \EasyWeChat\Support\Collection
      */
     public function usersOfTag($tagId)
     {
@@ -130,9 +129,9 @@  discard block
 block discarded – undo
      * Batch tag users.
      *
      * @param array $openIds
-     * @param int   $tagid
+     * @param int   $tagId
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function batchTagUsers(array $openIds, $tagId)
     {
@@ -148,9 +147,9 @@  discard block
 block discarded – undo
      * Untag users from a tag.
      *
      * @param array $openIds
-     * @param int   $tagid
+     * @param int   $tagId
      *
-     * @return bool
+     * @return \EasyWeChat\Support\Collection
      */
     public function batchUntagUsers(array $openIds, $tagId)
     {

Please login to merge, or discard this patch.

		@@ -418,7 +418,7 @@
		block discarded – undo
418	418	/**
419	419	* Parse Response XML to array.
420	420	*
421		- * @param string\|\Psr\Http\Message\ResponseInterface $response
	421	+ * @param ResponseInterface $response
422	422	*
423	423	* @return \EasyWeChat\Support\Collection
424	424	*/

		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	* @param string $url
55	55	* @param array $options
56	56	*
57		- * @return array\|bool
	57	+ * @return ResponseInterface
58	58	*
59	59	* @throws HttpException
60	60	*/
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	* @param string $url
70	70	* @param array\|string $options
71	71	*
72		- * @return array\|bool
	72	+ * @return ResponseInterface
73	73	*
74	74	* @throws HttpException
75	75	*/
		@@ -87,7 +87,7 @@ discard block
		block discarded – undo
87	87	* @param string\|array $options
88	88	* @param int $encodeOption
89	89	*
90		- * @return array\|bool
	90	+ * @return ResponseInterface
91	91	*
92	92	* @throws HttpException
93	93	*/
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	* @param array $files
106	106	* @param array $form
107	107	*
108		- * @return array\|bool
	108	+ * @return ResponseInterface
109	109	*
110	110	* @throws HttpException
111	111	*/
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	/**
145	145	* Return GuzzleHttp\Client instance.
146	146	*
147		- * @return \GuzzleHttp\Client.
	147	+ * @return HttpClient
148	148	*/
149	149	public function getClient()
150	150	{
		@@ -186,7 +186,7 @@ discard block
		block discarded – undo
186	186	* @param string $method
187	187	* @param array $options
188	188	*
189		- * @return array\|bool
	189	+ * @return ResponseInterface
190	190	*
191	191	* @throws HttpException
192	192	*/

		@@ -77,7 +77,6 @@ discard block
		block discarded – undo
77	77	* Send MerchantPay.
78	78	*
79	79	* @param array $params
80		- * @param string $type
81	80	*
82	81	* @return \EasyWeChat\Support\Collection
83	82	*/
		@@ -137,7 +136,7 @@ discard block
		block discarded – undo
137	136	/**
138	137	* Parse Response XML to array.
139	138	*
140		- * @param \Psr\Http\Message\ResponseInterface\|string $response
	139	+ * @param ResponseInterface $response
141	140	*
142	141	* @return \EasyWeChat\Support\Collection
143	142	*/

		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	* @param int $industryOne
81	81	* @param int $industryTwo
82	82	*
83		- * @return bool
	83	+ * @return \EasyWeChat\Support\Collection
84	84	*/
85	85	public function setIndustry($industryOne, $industryTwo)
86	86	{
		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	/**
96	96	* Get industry.
97	97	*
98		- * @return array
	98	+ * @return \EasyWeChat\Support\Collection
99	99	*/
100	100	public function getIndustry()
101	101	{
		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	*
109	109	* @param string $shortId
110	110	*
111		- * @return string
	111	+ * @return \EasyWeChat\Support\Collection
112	112	*/
113	113	public function addTemplate($shortId)
114	114	{
		@@ -120,7 +120,7 @@ discard block
		block discarded – undo
120	120	/**
121	121	* Get all private template.
122	122	*
123		- * @return array
	123	+ * @return \EasyWeChat\Support\Collection
124	124	*/
125	125	public function getAllPrivateTemplate()
126	126	{
		@@ -133,7 +133,7 @@ discard block
		block discarded – undo
133	133	*
134	134	* @param int $templateId
135	135	*
136		- * @return array
	136	+ * @return \EasyWeChat\Support\Collection
137	137	*/
138	138	public function delPrivateTemplate($templateId)
139	139	{
		@@ -146,7 +146,7 @@ discard block
		block discarded – undo
146	146	*
147	147	* @param $data
148	148	*
149		- * @return mixed
	149	+ * @return \EasyWeChat\Support\Collection
150	150	*
151	151	* @throws \EasyWeChat\Core\Exceptions\InvalidArgumentException
152	152	*/

		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41	*
42	42	* @param string $name
43	43	*
44		- * @return int
	44	+ * @return \EasyWeChat\Support\Collection
45	45	*/
46	46	public function create($name)
47	47	{
		@@ -55,7 +55,7 @@ discard block
		block discarded – undo
55	55	/**
56	56	* List all tags.
57	57	*
58		- * @return array
	58	+ * @return \EasyWeChat\Support\Collection
59	59	*/
60	60	public function lists()
61	61	{
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	* @param int $tagId
69	69	* @param string $name
70	70	*
71		- * @return bool
	71	+ * @return \EasyWeChat\Support\Collection
72	72	*/
73	73	public function update($tagId, $name)
74	74	{
		@@ -87,7 +87,7 @@ discard block
		block discarded – undo
87	87	*
88	88	* @param int $tagId
89	89	*
90		- * @return bool
	90	+ * @return \EasyWeChat\Support\Collection
91	91	*/
92	92	public function delete($tagId)
93	93	{
		@@ -103,7 +103,7 @@ discard block
		block discarded – undo
103	103	*
104	104	* @param string $openId
105	105	*
106		- * @return int
	106	+ * @return \EasyWeChat\Support\Collection
107	107	*/
108	108	public function userTags($openId)
109	109	{
		@@ -115,9 +115,8 @@ discard block
		block discarded – undo
115	115	/**
116	116	* Get users from a tag.
117	117	*
118		- * @param string $openId
119	118	*
120		- * @return int
	119	+ * @return \EasyWeChat\Support\Collection
121	120	*/
122	121	public function usersOfTag($tagId)
123	122	{
		@@ -130,9 +129,9 @@ discard block
		block discarded – undo
130	129	* Batch tag users.
131	130	*
132	131	* @param array $openIds
133		- * @param int $tagid
	132	+ * @param int $tagId
134	133	*
135		- * @return bool
	134	+ * @return \EasyWeChat\Support\Collection
136	135	*/
137	136	public function batchTagUsers(array $openIds, $tagId)
138	137	{
		@@ -148,9 +147,9 @@ discard block
		block discarded – undo
148	147	* Untag users from a tag.
149	148	*
150	149	* @param array $openIds
151		- * @param int $tagid
	150	+ * @param int $tagId
152	151	*
153		- * @return bool
	152	+ * @return \EasyWeChat\Support\Collection
154	153	*/
155	154	public function batchUntagUsers(array $openIds, $tagId)
156	155	{

overtrue / wechat

Pull Request — master (#414)

Status

Category

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +10 added lines, -11 removed lines patch added patch discarded remove patch