GlobalVariablesPassTest::testInvalidAlias() - Code Metrics - Inspection of "Graphql schema language configuration" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#277)

by Jérémiah

created 2018-01-25 07:47 UTC

GlobalVariablesPassTest::testInvalidAlias() A

↳ Parent: GlobalVariablesPassTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	1

<?php

namespace Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler;

use Overblog\GraphQLBundle\DependencyInjection\Compiler\GlobalVariablesPass;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;

class GlobalVariablesPassTest extends TestCase
{
    /**
     * @param mixed $invalidAlias
     *
     * @dataProvider invalidAliasProvider
     */
    public function testInvalidAlias($invalidAlias)
    {
        /** @var ContainerBuilder|MockObject $container */
        $container = $this->getMockBuilder(ContainerBuilder::class)
            ->setMethods(['findTaggedServiceIds', 'findDefinition'])
            ->getMock();
        $container->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('findTaggedServiceIds')
            ->willReturn([
                'my-id' => [
                    ['alias' => $invalidAlias],
                ],
            ]);

        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('Service "my-id" tagged "overblog_graphql.global_variable" should have a valid "alias" attribute.');

        (new GlobalVariablesPass())->process($container);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function invalidAliasProvider()

    {
        return [
            [null],
            [new \stdClass()],
            [[]],
            [true],
            [false],
            [''],
        ];
    }
}


Scrutinizer GitHub App not installed

Pull Request — master (#277)

GlobalVariablesPassTest::testInvalidAlias() A

Complexity

Size

Duplication

Importance

Available Fixes

1		<?php
2
3		namespace Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler;
4
5		use Overblog\GraphQLBundle\DependencyInjection\Compiler\GlobalVariablesPass;
6		use PHPUnit\Framework\MockObject\MockObject;
7		use PHPUnit\Framework\TestCase;
8		use Symfony\Component\DependencyInjection\ContainerBuilder;
9
10		class GlobalVariablesPassTest extends TestCase
11		{
12		/**
13		* @param mixed $invalidAlias
14		*
15		* @dataProvider invalidAliasProvider
16		*/
17		public function testInvalidAlias($invalidAlias)
18		{
19		/** @var ContainerBuilder\|MockObject $container */
20		$container = $this->getMockBuilder(ContainerBuilder::class)
21		->setMethods(['findTaggedServiceIds', 'findDefinition'])
22		->getMock();
23		$container->expects($this->once())
		0 ignored issues – show Bug introduced 2018-01-25 08:08 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit\Framework\MockObject\MockObject`, but not in `Symfony\Component\Depend...ection\ContainerBuilder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
24		->method('findTaggedServiceIds')
25		->willReturn([
26		'my-id' => [
27		['alias' => $invalidAlias],
28		],
29		]);
30
31		$this->expectException(\InvalidArgumentException::class);
32		$this->expectExceptionMessage('Service "my-id" tagged "overblog_graphql.global_variable" should have a valid "alias" attribute.');
33
34		(new GlobalVariablesPass())->process($container);
		0 ignored issues – show Bug introduced 2018-01-25 08:08 UTC by Report Bug Copy Issue Report It seems like `$container` defined by `$this->getMockBuilder(\S...efinition'))->getMock()` on line `20` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Overblog\GraphQLBundle\D...ariablesPass::process()` does only seem to accept `object<Symfony\Component...ction\ContainerBuilder>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
35		}
36
37	View Code Duplication	public function invalidAliasProvider()
		0 ignored issues – show Duplication introduced 2018-01-25 08:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		return [
40		[null],
41		[new \stdClass()],
42		[[]],
43		[true],
44		[false],
45		[''],
46		];
47		}
48		}
49

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#277)

GlobalVariablesPassTest::testInvalidAlias() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like