Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler\GlobalVariablesPassTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	39
Duplicated Lines	28.21 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testInvalidAlias()	0	19	1
A	invalidAliasProvider()	11	11	1

<?php

namespace Overblog\GraphQLBundle\Tests\DependencyInjection\Compiler;

use Overblog\GraphQLBundle\DependencyInjection\Compiler\GlobalVariablesPass;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;

class GlobalVariablesPassTest extends TestCase
{
    /**
     * @param mixed $invalidAlias
     *
     * @dataProvider invalidAliasProvider
     */
    public function testInvalidAlias($invalidAlias)
    {
        /** @var ContainerBuilder|MockObject $container */
        $container = $this->getMockBuilder(ContainerBuilder::class)
            ->setMethods(['findTaggedServiceIds', 'findDefinition'])
            ->getMock();
        $container->expects($this->once())

The method expects does only exist in PHPUnit\Framework\MockObject\MockObject, but not in Symfony\Component\DependencyInjection\ContainerBuilder.

            ->method('findTaggedServiceIds')
            ->willReturn([
                'my-id' => [
                    ['alias' => $invalidAlias],
                ],
            ]);

        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('Service "my-id" tagged "overblog_graphql.global_variable" should have a valid "alias" attribute.');

        (new GlobalVariablesPass())->process($container);

It seems like $container defined by $this->getMockBuilder(\Symfony\Component\DependencyInjection\ContainerBuilder::class)->setMethods(array('findTaggedServiceIds', 'findDefinition'))->getMock() on line 20 can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Overblog\GraphQLBundle\DependencyInjection\Compiler\GlobalVariablesPass::process() does only seem to accept object<Symfony\Component\DependencyInjection\ContainerBuilder>, maybe add an additional type check?

    }

    public function invalidAliasProvider()

This method seems to be duplicated in your project.

    {
        return [
            [null],
            [new \stdClass()],
            [[]],
            [true],
            [false],
            [''],
        ];
    }
}