overblog / GraphQLBundle

DependencyInjection/TypesConfiguration.php

Doc Comments +4 added lines

@@ -152,6 +152,10 @@
             ->end();
     }
 
+    /**
+     * @param string $typeToTreat
+     * @param string $definitionBuilderClass
+     */
     private function relayNormalizer($typeToTreat, $definitionBuilderClass)
     {
         return function ($types) use ($typeToTreat, $definitionBuilderClass) {

Spacing +11 added lines, -11 removed lines

@@ -36,7 +36,7 @@ 
         $rootNode = $treeBuilder->root('overblog_graphql_types');
 
         $configTypeKeys = array_map(
-            function ($type) {
+            function($type) {
                 return $this->normalizedConfigTypeKey($type);
             },
             self::$types
@@ -49,7 +49,7 @@ 
             ->prototype('array')
                 // config is the unique config entry allowed
                 ->beforeNormalization()
-                    ->ifTrue(function ($v) use ($configTypeKeys) {
+                    ->ifTrue(function($v) use ($configTypeKeys) {
                         if (!empty($v) && is_array($v)) {
                             $keys = array_keys($v);
                             foreach ($configTypeKeys as $configTypeKey) {
@@ -64,16 +64,16 @@ 
                         ->thenInvalid(
                             sprintf(
                                 'Don\'t use internal config keys %s, replace it by "config" instead.',
-                                implode(', ',  $configTypeKeys)
+                                implode(', ', $configTypeKeys)
                             )
                         )
                 ->end()
                 // config is renamed _{TYPE}_config
                 ->beforeNormalization()
-                    ->ifTrue(function ($v) {
+                    ->ifTrue(function($v) {
                         return isset($v['type']) && is_string($v['type']);
                     })
-                    ->then(function ($v) {
+                    ->then(function($v) {
                         $key = $this->normalizedConfigTypeKey($v['type']);
 
                         if (empty($v[$key])) {
@@ -96,10 +96,10 @@ 
                 ->end()
                 // _{TYPE}_config is renamed config
                 ->validate()
-                    ->ifTrue(function ($v) {
+                    ->ifTrue(function($v) {
                         return isset($v[$this->normalizedConfigTypeKey($v['type'])]);
                     })
-                    ->then(function ($v) {
+                    ->then(function($v) {
                         $key = $this->normalizedConfigTypeKey($v['type']);
                         $v['config'] = $v[$key];
                         unset($v[$key]);
@@ -115,7 +115,7 @@ 
 
     private function addBeforeNormalization(ArrayNodeDefinition $node)
     {
-        $typeKeyExists = function ($types) {
+        $typeKeyExists = function($types) {
             return !empty($types) && is_array($types);
         };
 
@@ -123,7 +123,7 @@ 
             // set type config.name
             ->beforeNormalization()
                 ->ifTrue($typeKeyExists)
-                ->then(function ($types) {
+                ->then(function($types) {
                     foreach ($types as $name => &$type) {
                         $type['config'] = isset($type['config']) && is_array($type['config']) ? $type['config'] : [];
                         $type['config']['name'] = $name;
@@ -149,7 +149,7 @@ 
             ->end()
             // normalized relay-mutation-payload
             ->beforeNormalization()
-                ->ifTrue(function ($types) {
+                ->ifTrue(function($types) {
                     return !empty($types) && is_array($types);
                 })
                 ->then($this->relayNormalizer('relay-mutation-payload', 'Overblog\GraphQLBundle\Relay\Mutation\PayloadDefinition'))
@@ -158,7 +158,7 @@ 
 
     private function relayNormalizer($typeToTreat, $definitionBuilderClass)
     {
-        return function ($types) use ($typeToTreat, $definitionBuilderClass) {
+        return function($types) use ($typeToTreat, $definitionBuilderClass) {
             foreach ($types as $name => $type) {
                 if (isset($type['type']) && is_string($type['type']) && $typeToTreat === $type['type']) {
                     $config = isset($type['config']) && is_array($type['config']) ? $type['config'] : [];

Config/TypeDefinition.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
         $node = $builder->root('name', 'scalar');
         $node->isRequired();
         $node->validate()
-            ->ifTrue(function ($name) {
+            ->ifTrue(function($name) {
                 return !preg_match('/^[_a-z][_0-9a-z]*$/i', $name);
             })
                 ->thenInvalid('Invalid type name "%s". (see https://facebook.github.io/graphql/#Name)')

Tests/Resolver/Toto.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
     public function getPrivatePropertyWithoutGetterUsingCallBack()
     {
-        return function () {
+        return function() {
             return $this->privatePropertyWithoutGetter;
         };
     }

DependencyInjection/Compiler/TypesPass.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     private function processConfig(array $configs)
     {
         return array_map(
-            function ($v) {
+            function($v) {
                 if (is_array($v)) {
                     return call_user_func([$this, 'processConfig'], $v);
                 } elseif (is_string($v) && 0 === strpos($v, '@=')) {

DependencyInjection/OverblogGraphQLTypesExtension.php

Spacing +2 added lines, -2 removed lines

@@ -104,8 +104,8 @@
         // from config
         if (!empty($config['definitions']['mappings']['types'])) {
             $typesMappings = array_filter(array_map(
-                function (array $typeMapping) use ($container) {
-                    $params = $this->detectConfigFiles($container, $typeMapping['dir'],  $typeMapping['type']);
+                function(array $typeMapping) use ($container) {
+                    $params = $this->detectConfigFiles($container, $typeMapping['dir'], $typeMapping['type']);
 
                     return $params;
                 },

Tests/Request/ExecutorTest.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
             'fields' => [
                 'myField' => [
                     'type' => Type::boolean(),
-                    'resolve' => function () {
+                    'resolve' => function() {
                         return false;
                     },
                 ],

Config/TypeWithOutputFieldsDefinition.php

Spacing +5 added lines, -5 removed lines

@@ -132,10 +132,10 @@ 
         $prototype
             // build args if argsBuilder exists
             ->beforeNormalization()
-                ->ifTrue(function ($field) {
+                ->ifTrue(function($field) {
                     return isset($field['argsBuilder']);
                 })
-                ->then(function ($field) {
+                ->then(function($field) {
                     $argsBuilderName = null;
 
                     if (is_string($field['argsBuilder'])) {
@@ -156,7 +156,7 @@ 
             ->end()
             // build field if builder exists
             ->beforeNormalization()
-                ->always(function ($field) {
+                ->always(function($field) {
                     $fieldBuilderName = null;
 
                     if (isset($field['builder']) && is_string($field['builder'])) {
@@ -197,10 +197,10 @@ 
                     ->prototype('array')
                         // Allow arg type short syntax (Arg: Type => Arg: {type: Type})
                         ->beforeNormalization()
-                            ->ifTrue(function ($options) {
+                            ->ifTrue(function($options) {
                                 return is_string($options);
                             })
-                            ->then(function ($options) {
+                            ->then(function($options) {
                                 return ['type' => $options];
                             })
                         ->end()

Doc Comments +6 added lines

@@ -54,6 +54,9 @@ 
         self::$fieldBuilderClassMap[$name] = $fieldBuilderClass;
     }
 
+    /**
+     * @param string $type
+     */
     protected static function checkBuilderClass($builderClass, $type)
     {
         $interface = 'Overblog\\GraphQLBundle\\Definition\\Builder\\MappingInterface';
@@ -116,6 +119,9 @@ 
         throw new InvalidConfigurationException(sprintf('%s builder "%s" not found.', ucfirst($type), $name));
     }
 
+    /**
+     * @param string $name
+     */
     protected function outputFieldsSelection($name)
     {
         $builder = new TreeBuilder();

Relay/Connection/Paginator.php

Spacing +3 added lines, -3 removed lines

@@ -58,7 +58,7 @@ 
 
         $entities = call_user_func($this->fetcher, $offset, $limit);
 
-        return $this->handleEntities($entities, function ($entities) use ($args, $offset, $total) {
+        return $this->handleEntities($entities, function($entities) use ($args, $offset, $total) {
             return ConnectionBuilder::connectionFromArraySlice($entities, $args, [
                 'sliceStart' => $offset,
                 'arrayLength' => $total,
@@ -81,13 +81,13 @@ 
         if (!is_numeric(ConnectionBuilder::cursorToOffset($args['after'])) || !$args['after']) {
             $entities = call_user_func($this->fetcher, $offset, $limit + 1);
 
-            return $this->handleEntities($entities, function ($entities) use ($args) {
+            return $this->handleEntities($entities, function($entities) use ($args) {
                 return ConnectionBuilder::connectionFromArray($entities, $args);
             });
         } else {
             $entities = call_user_func($this->fetcher, $offset, $limit + 2);
 
-            return $this->handleEntities($entities, function ($entities) use ($args, $offset) {
+            return $this->handleEntities($entities, function($entities) use ($args, $offset) {
                 return ConnectionBuilder::connectionFromArraySlice($entities, $args, [
                     'sliceStart' => $offset,
                     'arrayLength' => $offset + count($entities),

Tests/Relay/Connection/PaginatorTest.php

Spacing +15 added lines, -15 removed lines

@@ -55,7 +55,7 @@ 
 
     public function testForward()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(0, $offset);
             $this->assertSame(5, $limit); // Includes the extra element to check if next page is available
 
@@ -71,7 +71,7 @@ 
 
     public function testForwardAfterInMiddle()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(2, $offset);
             $this->assertSame(3, $limit); // Includes the extra element to check if next page is available
 
@@ -87,7 +87,7 @@ 
 
     public function testForwardAfterAtTheEnd()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(2, $offset);
             $this->assertSame(4, $limit); // Includes the extra element to check if next page is available
 
@@ -103,7 +103,7 @@ 
 
     public function testForwardAfterLast()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(4, $offset);
             $this->assertSame(7, $limit); // Includes the extra element to check if next page is available
 
@@ -119,7 +119,7 @@ 
 
     public function testForwardAfterWithUnvalidCursorAndSlice()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(0, $offset);
             $this->assertSame(5, $limit); // Includes the extra element to check if next page is available
 
@@ -136,7 +136,7 @@ 
 
     public function testBackward()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(2, $offset);
             $this->assertSame(3, $limit);
 
@@ -153,7 +153,7 @@ 
 
     public function testBackwardWithLimitEqualsToTotal()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(0, $offset);
             $this->assertSame(5, $limit);
 
@@ -170,7 +170,7 @@ 
 
     public function testBackwardBeforeLast()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(4, $limit);
 
             return $this->getData($offset);
@@ -185,7 +185,7 @@ 
 
     public function testBackwardPartialBeforeInMiddle()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(1, $offset);
             $this->assertSame(2, $limit);
 
@@ -201,7 +201,7 @@ 
 
     public function testAutoBackward()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(1, $offset);
             $this->assertSame(4, $limit);
 
@@ -218,7 +218,7 @@ 
 
     public function testAutoForward()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(0, $offset);
             $this->assertSame(5, $limit); // Includes the extra element to check if next page is available
 
@@ -234,7 +234,7 @@ 
 
     public function testAutoBackwardWithCallable()
     {
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(1, $offset);
             $this->assertSame(4, $limit);
 
@@ -242,7 +242,7 @@ 
         });
 
         $countCalled = false;
-        $result = $paginator->auto(new Argument(['last' => 4]), function () use (&$countCalled) {
+        $result = $paginator->auto(new Argument(['last' => 4]), function() use (&$countCalled) {
             $countCalled = true;
 
             return 5;
@@ -265,7 +265,7 @@ 
 
         $this->assertSame(5, call_user_func_array($callable, ['array' => $this->data]));
 
-        $paginator = new Paginator(function ($offset, $limit) {
+        $paginator = new Paginator(function($offset, $limit) {
             $this->assertSame(1, $offset);
             $this->assertSame(4, $limit);
 
@@ -292,7 +292,7 @@ 
 
         $promise->expects($this->once())->method('then');
 
-        $paginator = new Paginator(function ($offset, $limit) use ($promise) {
+        $paginator = new Paginator(function($offset, $limit) use ($promise) {
             $this->assertSame(0, $offset);
             $this->assertSame(5, $limit);