overblog / GraphQLBundle

Tests/Functional/Relay/Connection/ConnectionTest.php

Indentation +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
         $expectedData = [
             'user' => [
                 'friends' => [
-                   'totalCount' => 4,
+                    'totalCount' => 4,
                     'edges'     => [
                         [
                             'friendshipTime' => 'Yesterday',

Tests/DIContainerMockTrait.php

Doc Comments +3 added lines

@@ -13,6 +13,9 @@
 
 trait DIContainerMockTrait
 {
+    /**
+     * @return null|\Symfony\Component\DependencyInjection\ContainerInterface
+     */
     private function getDIContainerMock(array $services = [], array $parameters = [])
     {
         $container = $this->getMock('Symfony\\Component\\DependencyInjection\\Container', ['get', 'getParameter', 'has']);

Tests/Functional/Controller/GraphControllerTest.php

Spacing +1 added lines, -1 removed lines

@@ -165,7 +165,7 @@
         $client->request('POST', '/?batch', [], [], ['CONTENT_TYPE' => 'application/json'], json_encode($data));
         $result = $client->getResponse()->getContent();
 
-        $expected  = [
+        $expected = [
             'friends' => ['data' => $this->expectedData],
             'friendsTotalCount' => ['data' => ['user' => ['friends' => ['totalCount' => 4]]]],
         ];

DependencyInjection/Configuration.php

Spacing +3 added lines, -3 removed lines

@@ -111,12 +111,12 @@
         $node
             ->info('Disabled if equal to false.')
             ->beforeNormalization()
-                ->ifTrue(function ($v) { return false === $v; })
-                ->then(function () use ($disabledValue) { return $disabledValue; })
+                ->ifTrue(function($v) { return false === $v; })
+                ->then(function() use ($disabledValue) { return $disabledValue; })
             ->end()
             ->defaultFalse()
             ->validate()
-                ->ifTrue(function ($v) { return $v < 0; })
+                ->ifTrue(function($v) { return $v < 0; })
                 ->thenInvalid('"overblog_graphql.security.'.$name.'" must be greater or equal to 0.')
             ->end()
         ;

DependencyInjection/OverblogGraphQLTypesExtension.php

Spacing +2 added lines, -2 removed lines

@@ -127,9 +127,9 @@
         // from config
         if (!empty($config['definitions']['mappings']['types'])) {
             $typesMappings = array_filter(array_map(
-                function (array $typeMapping) use ($container) {
+                function(array $typeMapping) use ($container) {
 
-                    $params = $this->detectConfigFiles($container, $typeMapping['dir'],  $typeMapping['type']);
+                    $params = $this->detectConfigFiles($container, $typeMapping['dir'], $typeMapping['type']);
 
                     return $params;
                 },

Tests/Functional/app/Mutation/SimpleMutationWithThunkFieldsMutation.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 {
     private static $hasMutate = false;
 
-    public static function hasMutate($reset  = false)
+    public static function hasMutate($reset = false)
     {
         $hasMutate = self::$hasMutate;
 

Config/TypeWithOutputFieldsDefinition.php

Doc Comments +6 added lines

@@ -51,6 +51,9 @@ 
         self::$fieldBuilderClassMap[$name] = $fieldBuilderClass;
     }
 
+    /**
+     * @param string $type
+     */
     protected static function checkBuilderClass($builderClass, $type)
     {
         $interface = 'Overblog\\GraphQLBundle\\Definition\\Builder\\MappingInterface';
@@ -113,6 +116,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     protected function outputFieldsSelection($name, $withAccess = false)
     {
         $builder = new TreeBuilder();

Spacing +3 added lines, -3 removed lines

@@ -127,10 +127,10 @@ 
         $prototype
             // build args if argsBuilder exists
             ->beforeNormalization()
-                ->ifTrue(function ($field) {
+                ->ifTrue(function($field) {
                     return isset($field['argsBuilder']);
                 })
-                ->then(function ($field) {
+                ->then(function($field) {
                     $argsBuilderName = null;
 
                     if (is_string($field['argsBuilder'])) {
@@ -156,7 +156,7 @@ 
             ->end()
             // build field if builder exists
             ->beforeNormalization()
-                ->always(function ($field) {
+                ->always(function($field) {
                     $fieldBuilderName = null;
 
                     if (isset($field['builder']) && is_string($field['builder'])) {

DependencyInjection/TypesConfiguration.php

Doc Comments +4 added lines

@@ -152,6 +152,10 @@
             ->end();
     }
 
+    /**
+     * @param string $typeToTreat
+     * @param string $definitionBuilderClass
+     */
     private function relayNormalizer($typeToTreat, $definitionBuilderClass)
     {
         return function ($types) use ($typeToTreat, $definitionBuilderClass) {

Spacing +11 added lines, -11 removed lines

@@ -36,7 +36,7 @@ 
         $rootNode = $treeBuilder->root('overblog_graphql_types');
 
         $configTypeKeys = array_map(
-            function ($type) {
+            function($type) {
                 return $this->normalizedConfigTypeKey($type);
             },
             static::$types
@@ -49,7 +49,7 @@ 
             ->prototype('array')
                 // config is the unique config entry allowed
                 ->beforeNormalization()
-                    ->ifTrue(function ($v) use ($configTypeKeys) {
+                    ->ifTrue(function($v) use ($configTypeKeys) {
                         if (!empty($v) && is_array($v)) {
                             $keys = array_keys($v);
                             foreach ($configTypeKeys as $configTypeKey) {
@@ -64,16 +64,16 @@ 
                         ->thenInvalid(
                             sprintf(
                                 'Don\'t use internal config keys %s, replace it by "config" instead.',
-                                implode(', ',  $configTypeKeys)
+                                implode(', ', $configTypeKeys)
                             )
                         )
                 ->end()
                 // config is renamed _{TYPE}_config
                 ->beforeNormalization()
-                    ->ifTrue(function ($v) {
+                    ->ifTrue(function($v) {
                         return isset($v['type']) && is_string($v['type']);
                     })
-                    ->then(function ($v) {
+                    ->then(function($v) {
                         $key = $this->normalizedConfigTypeKey($v['type']);
 
                         if (empty($v[$key])) {
@@ -96,10 +96,10 @@ 
                 ->end()
                 // _{TYPE}_config is renamed config
                 ->validate()
-                    ->ifTrue(function ($v) {
+                    ->ifTrue(function($v) {
                         return isset($v[$this->normalizedConfigTypeKey($v['type'])]);
                     })
-                    ->then(function ($v) {
+                    ->then(function($v) {
                         $key = $this->normalizedConfigTypeKey($v['type']);
                         $v['config'] = $v[$key];
                         unset($v[$key]);
@@ -115,13 +115,13 @@ 
 
     private function addBeforeNormalization(ArrayNodeDefinition $node)
     {
-        $typeKeyExists = function ($types) { return !empty($types) && is_array($types); };
+        $typeKeyExists = function($types) { return !empty($types) && is_array($types); };
 
         $node
             // set type config.name
             ->beforeNormalization()
                 ->ifTrue($typeKeyExists)
-                ->then(function ($types) {
+                ->then(function($types) {
                     foreach ($types as $name => &$type) {
                         $type['config'] = isset($type['config']) && is_array($type['config']) ? $type['config'] : [];
                         $type['config']['name'] = $name;
@@ -147,14 +147,14 @@ 
             ->end()
             // normalized relay-mutation-payload
             ->beforeNormalization()
-                ->ifTrue(function ($types) { return !empty($types) && is_array($types); })
+                ->ifTrue(function($types) { return !empty($types) && is_array($types); })
                 ->then($this->relayNormalizer('relay-mutation-payload', 'Overblog\GraphQLBundle\Relay\Mutation\PayloadDefinition'))
             ->end();
     }
 
     private function relayNormalizer($typeToTreat, $definitionBuilderClass)
     {
-        return function ($types) use ($typeToTreat, $definitionBuilderClass) {
+        return function($types) use ($typeToTreat, $definitionBuilderClass) {
             foreach ($types as $name => $type) {
                 if (isset($type['type']) && is_string($type['type']) && $typeToTreat === $type['type']) {
                     $config = isset($type['config']) && is_array($type['config']) ? $type['config'] : [];

Config/TypeDefinition.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
         $node = $builder->root('name', 'scalar');
         $node->isRequired();
         $node->validate()
-            ->ifTrue(function ($name) {
+            ->ifTrue(function($name) {
                 return !preg_match('/^[_a-z][_0-9a-z]*$/i', $name);
             })
                 ->thenInvalid('Invalid type name "%s". (see https://facebook.github.io/graphql/#Name)')