ContactEntityNameProvider::getName() - Code Metrics - Inspection of "Merge remote-tracking branch 'remotes/dev/master'" - orocrm/crm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c2375b...0b658a )

unknown

created 2016-05-19 06:27 UTC

ContactEntityNameProvider::getName() A

↳ Parent: ContactEntityNameProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	4
rs	10
cc	2
eloc	2
nc	2
nop	3

<?php

namespace OroCRM\Bundle\ContactBundle\Provider;

use Oro\Bundle\LocaleBundle\Provider\EntityNameProvider;

class ContactEntityNameProvider extends EntityNameProvider
{
    const CLASS_NAME = 'OroCRM\Bundle\ContactBundle\Entity\Contact';

    /**
     * {@inheritdoc}
     */
    public function getName($format, $locale, $entity)
    {
        return is_a($entity, static::CLASS_NAME) ? parent::getName($format, $locale, $entity) : false;

    }

    /**
     * {@inheritdoc}
     */
    public function getNameDQL($format, $locale, $className, $alias)
    {
        return $className === self::CLASS_NAME ? parent::getNameDQL($format, $locale, $className, $alias) : false;

    }
}


1			<?php
2
3			namespace OroCRM\Bundle\ContactBundle\Provider;
4
5			use Oro\Bundle\LocaleBundle\Provider\EntityNameProvider;
6
7			class ContactEntityNameProvider extends EntityNameProvider
8			{
9			const CLASS_NAME = 'OroCRM\Bundle\ContactBundle\Entity\Contact';
10
11			/**
12			* {@inheritdoc}
13			*/
14			public function getName($format, $locale, $entity)
15			{
16			return is_a($entity, static::CLASS_NAME) ? parent::getName($format, $locale, $entity) : false;
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-05-06 06:13 UTC by Report Bug Copy Issue Report The expression `is_a($entity, static::CL...cale, $entity) : false;` of type `string\|false` adds `false` to the return on line 16 which is incompatible with the return type declared by the interface `Oro\Bundle\EntityBundle\...viderInterface::getName` of type `string`. It seems like you forgot to handle an error condition. Loading history...
17			}
18
19			/**
20			* {@inheritdoc}
21			*/
22			public function getNameDQL($format, $locale, $className, $alias)
23			{
24			return $className === self::CLASS_NAME ? parent::getNameDQL($format, $locale, $className, $alias) : false;
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-05-19 06:36 UTC by Report Bug Copy Issue Report The expression `$className === self::CLA...sName, $alias) : false;` of type `string\|false` adds `false` to the return on line 24 which is incompatible with the return type declared by the interface `Oro\Bundle\EntityBundle\...erInterface::getNameDQL` of type `string`. It seems like you forgot to handle an error condition. Loading history...
25			}
26			}
27

orocrm / crm

Push — master ( c2375b...0b658a )

ContactEntityNameProvider::getName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like