OroCRM\Bundle\ContactBundle\Provider\ContactEntityNameProvider

Complexity

Total Complexity

4

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	4	2
A	getNameDQL()	0	4	2

<?php

namespace OroCRM\Bundle\ContactBundle\Provider;

use Oro\Bundle\LocaleBundle\Provider\EntityNameProvider;

class ContactEntityNameProvider extends EntityNameProvider
{
    const CLASS_NAME = 'OroCRM\Bundle\ContactBundle\Entity\Contact';

    /**
     * {@inheritdoc}
     */
    public function getName($format, $locale, $entity)
    {
        return is_a($entity, static::CLASS_NAME) ? parent::getName($format, $locale, $entity) : false;

The expression is_a($entity, static::CLASS_NAME) ? parent::getName($format, $locale, $entity) : false; of type string|false adds false to the return on line 16 which is incompatible with the return type declared by the interface Oro\Bundle\EntityBundle\Provider\EntityNameProviderInterface::getName of type string. It seems like you forgot to handle an error condition.

    }

    /**
     * {@inheritdoc}
     */
    public function getNameDQL($format, $locale, $className, $alias)
    {
        return $className === self::CLASS_NAME ? parent::getNameDQL($format, $locale, $className, $alias) : false;

The expression $className === self::CLASS_NAME ? parent::getNameDQL($format, $locale, $className, $alias) : false; of type string|false adds false to the return on line 24 which is incompatible with the return type declared by the interface Oro\Bundle\EntityBundle\Provider\EntityNameProviderInterface::getNameDQL of type string. It seems like you forgot to handle an error condition.

    }
}