Completed
Pull Request — 1.9 (#190)
by Ivan
21:53 queued 10:29
created
src/OroCRM/Bundle/AccountBundle/Entity/Account.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     /**
239 239
      * Returns the account unique id.
240 240
      *
241
-     * @return mixed
241
+     * @return integer
242 242
      */
243 243
     public function getId()
244 244
     {
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
     /**
326 326
      * Get contacts collection
327 327
      *
328
-     * @return Collection|Contact[]
328
+     * @return ArrayCollection
329 329
      */
330 330
     public function getContacts()
331 331
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,15 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityRepository;
7
-
8 7
 use Doctrine\Common\DataFixtures\AbstractFixture;
9 8
 use Doctrine\Common\Persistence\ObjectManager;
10
-
11 9
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
12 10
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 11
 use Symfony\Component\DependencyInjection\ContainerInterface;
14 12
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15
-
16 13
 use Oro\Bundle\UserBundle\Entity\UserManager;
17 14
 use Oro\Bundle\UserBundle\Entity\User;
18 15
 
Please login to merge, or discard this patch.
Bundle/ActivityContactBundle/Command/ActivityContactRecalculateCommand.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -2,19 +2,14 @@  discard block
 block discarded – undo
2 2
 
3 3
 namespace OroCRM\Bundle\ActivityContactBundle\Command;
4 4
 
5
-use Doctrine\ORM\Query;
6 5
 use Doctrine\ORM\QueryBuilder;
7
-
8 6
 use Psr\Log\AbstractLogger;
9
-
10 7
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
11 8
 use Symfony\Component\Console\Input\InputInterface;
12 9
 use Symfony\Component\Console\Output\OutputInterface;
13 10
 use Symfony\Component\PropertyAccess\PropertyAccess;
14
-
15 11
 use Oro\Component\PropertyAccess\PropertyAccessor;
16 12
 use Oro\Component\Log\OutputLogger;
17
-
18 13
 use Oro\Bundle\ActivityBundle\Event\ActivityEvent;
19 14
 use Oro\Bundle\ActivityListBundle\Entity\ActivityList;
20 15
 use Oro\Bundle\ActivityListBundle\Entity\Repository\ActivityListRepository;
@@ -24,7 +19,6 @@  discard block
 block discarded – undo
24 19
 use Oro\Bundle\EntityConfigBundle\Config\ConfigInterface;
25 20
 use Oro\Bundle\EntityConfigBundle\Provider\ConfigProvider;
26 21
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
27
-
28 22
 use OroCRM\Bundle\ActivityContactBundle\EntityConfig\ActivityScope;
29 23
 use OroCRM\Bundle\ActivityContactBundle\EventListener\ActivityListener;
30 24
 use OroCRM\Bundle\ActivityContactBundle\Provider\ActivityContactProvider;
Please login to merge, or discard this patch.
OroCRM/Bundle/ActivityContactBundle/Provider/ActivityContactProvider.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     /**
60 60
      * Return list of supported activity classes
61 61
      *
62
-     * @return array
62
+     * @return integer[]
63 63
      */
64 64
     public function getSupportedActivityClasses()
65 65
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     /**
70 70
      * Check if given entity class is supports
71 71
      *
72
-     * @param $activityClass
72
+     * @param string $activityClass
73 73
      *
74 74
      * @return bool
75 75
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ActivityContactBundle/Provider/CallDirectionProvider.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -56,6 +56,7 @@
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * {@inheritdoc}
59
+     * @param Call $activity
59 60
      */
60 61
     public function getDate($activity)
61 62
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ActivityContactBundle/Provider/EmailDirectionProvider.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -126,6 +126,7 @@  discard block
 block discarded – undo
126 126
 
127 127
     /**
128 128
      * {@inheritdoc}
129
+     * @param Email $activity
129 130
      */
130 131
     public function getDate($activity)
131 132
     {
@@ -202,7 +203,7 @@  discard block
 block discarded – undo
202 203
     }
203 204
 
204 205
     /**
205
-     * @param object $target
206
+     * @param EmailHolderInterface $target
206 207
      * @return string
207 208
      */
208 209
     protected function getTargetEmail($target)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
Bundle/AnalyticsBundle/Tests/Unit/Validator/CategoriesValidatorTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@
 block discarded – undo
270 270
     }
271 271
 
272 272
     /**
273
-     * @param array $items
273
+     * @param RFMMetricCategory[] $items
274 274
      *
275 275
      * @return PersistentCollection
276 276
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/AnalyticsBundle/Validator/CategoriesValidator.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     /**
19 19
      * Validate collection.
20 20
      *
21
-     * @param PersistentCollection|RFMMetricCategory[] $value
21
+     * @param PersistentCollection $value
22 22
      * @param CategoriesConstraint $constraint
23 23
      *
24 24
      * {@inheritdoc}
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/CallBundle/Tests/Unit/EventListener/CallListenerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
 
164 164
     /**
165 165
      * @param array $expectedUnsets
166
-     * @param array $parametersData
166
+     * @param array $parameters
167 167
      * @return BuildBefore
168 168
      */
169 169
     protected function createBuildBeforeEvent(array $expectedUnsets, array $parameters)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/CampaignBundle/Controller/EmailCampaignController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
      * )
143 143
      *
144 144
      * @param EmailCampaign $entity
145
-     * @return array
145
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
146 146
      */
147 147
     public function sendAction(EmailCampaign $entity)
148 148
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.