Completed
Pull Request — 1.9 (#190)
by Ivan
21:53 queued 10:29
created
Tests/Performance/DataFixtures/Accounts/LoadCrmAccountsData.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -294,8 +294,8 @@  discard block
 block discarded – undo
294 294
     /**
295 295
      * Persist object
296 296
      *
297
-     * @param mixed $manager
298
-     * @param mixed $object
297
+     * @param Account $manager
298
+     * @param Account $object
299 299
      */
300 300
     private function persist($manager, $object)
301 301
     {
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
     /**
306 306
      * Flush objects
307 307
      *
308
-     * @param mixed $manager
308
+     * @param Account $manager
309 309
      */
310 310
     private function flush($manager)
311 311
     {
Please login to merge, or discard this patch.
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -5,26 +5,20 @@
 block discarded – undo
5 5
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
6 6
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
7 7
 use Symfony\Component\DependencyInjection\ContainerInterface;
8
-
9 8
 use Doctrine\Common\Collections\Collection;
10 9
 use Doctrine\Common\DataFixtures\AbstractFixture;
11 10
 use Doctrine\Common\Persistence\ObjectManager;
12
-
13 11
 use Doctrine\ORM\EntityManager;
14 12
 use Doctrine\ORM\EntityRepository;
15
-
16 13
 use OroCRM\Bundle\AccountBundle\Entity\Account;
17 14
 use OroCRM\Bundle\ContactBundle\Entity\Contact;
18
-
19 15
 use Oro\Bundle\AddressBundle\Entity\Country;
20 16
 use Oro\Bundle\AddressBundle\Entity\Region;
21
-
22 17
 use OroCRM\Bundle\ContactBundle\Entity\ContactAddress;
23 18
 use OroCRM\Bundle\ContactBundle\Entity\ContactEmail;
24 19
 use OroCRM\Bundle\ContactBundle\Entity\ContactPhone;
25 20
 use OroCRM\Bundle\ContactBundle\Entity\Group;
26 21
 use OroCRM\Bundle\ContactBundle\Entity\Source;
27
-
28 22
 use Oro\Bundle\UserBundle\Entity\User;
29 23
 use Oro\Bundle\UserBundle\Entity\UserManager;
30 24
 
Please login to merge, or discard this patch.
Tests/Performance/DataFixtures/Users/LoadCrmUsersData.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -260,7 +260,7 @@
 block discarded – undo
260 260
     /**
261 261
      * Persist object
262 262
      *
263
-     * @param mixed $object
263
+     * @param User $object
264 264
      * @return void
265 265
      */
266 266
     private function persist($object)
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,15 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityRepository;
7
-
8 7
 use Doctrine\Common\DataFixtures\AbstractFixture;
9 8
 use Doctrine\Common\Persistence\ObjectManager;
10
-
11 9
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
12 10
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 11
 use Symfony\Component\DependencyInjection\ContainerInterface;
14 12
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15
-
16 13
 use Oro\Bundle\UserBundle\Entity\UserManager;
17 14
 use Oro\Bundle\UserBundle\Entity\User;
18 15
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/TestFrameworkBundle/Tests/Performance/LoadTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/AccountBundle/Controller/Api/Rest/AccountController.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Doctrine\DBAL\Types\Type;
6 6
 use Doctrine\DBAL\Schema\Schema;
7
-
8 7
 use Oro\Bundle\MigrationBundle\Migration\QueryBag;
9 8
 use Oro\Bundle\MigrationBundle\Migration\Migration;
10 9
 use Oro\Bundle\MigrationBundle\Migration\SqlMigrationQuery;
@@ -12,15 +11,11 @@  discard block
 block discarded – undo
12 11
 use Oro\Bundle\MigrationBundle\Migration\OrderedMigrationInterface;
13 12
 use Oro\Bundle\MigrationBundle\Migration\Extension\NameGeneratorAwareInterface;
14 13
 use Oro\Bundle\MigrationBundle\Tools\DbIdentifierNameGenerator;
15
-
16 14
 use Oro\Bundle\ActivityListBundle\Migration\Extension\ActivityListExtension;
17
-
18 15
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
19 16
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendDbIdentifierNameGenerator;
20
-
21 17
 use Oro\Bundle\EntityExtendBundle\Migration\Extension\ExtendExtension;
22 18
 use Oro\Bundle\EntityExtendBundle\Migration\Extension\ExtendExtensionAwareInterface;
23
-
24 19
 use Oro\Bundle\ActivityBundle\EntityConfig\ActivityScope;
25 20
 use Oro\Bundle\ActivityListBundle\Tools\ActivityListEntityConfigDumperExtension;
26 21
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/AccountBundle/Controller/Api/Soap/AccountController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
OroCRM/Bundle/AccountBundle/Tests/Unit/Form/Handler/AccountHandlerTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/AccountBundle/Tests/Unit/Form/Type/AccountTypeTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ActivityContactBundle/EventListener/ActivityListener.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,15 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityRepository;
7
-
8 7
 use Doctrine\Common\DataFixtures\AbstractFixture;
9 8
 use Doctrine\Common\Persistence\ObjectManager;
10
-
11 9
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
12 10
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 11
 use Symfony\Component\DependencyInjection\ContainerInterface;
14 12
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15
-
16 13
 use Oro\Bundle\UserBundle\Entity\UserManager;
17 14
 use Oro\Bundle\UserBundle\Entity\User;
18 15
 
Please login to merge, or discard this patch.
Bundle/ActivityContactBundle/Tools/ActivityContactConfigDumperExtension.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.