Completed
Pull Request — 1.9 (#190)
by Ivan
21:53 queued 10:29
created
Bundle/MarketingListBundle/Provider/ContactInformationFieldsProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param string|object $entityOrClass
63
+     * @param string $entityOrClass
64 64
      * @param string|null $type
65 65
      * @return array
66 66
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
OroCRM/Bundle/MarketingListBundle/Tests/Unit/Entity/MarketingListTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -136,6 +136,10 @@
 block discarded – undo
136 136
         $this->assertInstanceOf('\DateTime', $this->entity->getUpdatedAt());
137 137
     }
138 138
 
139
+    /**
140
+     * @param string $entityClass
141
+     * @param string $entityShortName
142
+     */
139 143
     protected function assertCollectionMethods($entityClass, $entityShortName)
140 144
     {
141 145
         $addMethodName = 'add' . $entityShortName;
Please login to merge, or discard this patch.
src/OroCRM/Bundle/SalesBundle/Controller/Api/Rest/SalesFunnelController.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Form\FormInterface;
6 6
 use Symfony\Component\HttpFoundation\Response;
7
-
8 7
 use FOS\RestBundle\Controller\Annotations\NamePrefix;
9 8
 use FOS\RestBundle\Controller\Annotations\RouteResource;
10 9
 use FOS\RestBundle\Controller\Annotations\QueryParam;
11 10
 use FOS\RestBundle\Routing\ClassResourceInterface;
12
-
13 11
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
14
-
15 12
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
16 13
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
17
-
18 14
 use Oro\Bundle\SoapBundle\Form\Handler\ApiFormHandler;
19 15
 use Oro\Bundle\SoapBundle\Controller\Api\Rest\RestController;
20 16
 use Oro\Bundle\SoapBundle\Entity\Manager\ApiEntityManager;
Please login to merge, or discard this patch.
src/OroCRM/Bundle/SalesBundle/Entity/Lead.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -962,7 +962,7 @@
 block discarded – undo
962 962
     /**
963 963
      * Get opportunities
964 964
      *
965
-     * @return Opportunity[]
965
+     * @return ArrayCollection
966 966
      */
967 967
     public function getOpportunities()
968 968
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/SalesBundle/Provider/ForecastOfOpportunities.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -179,8 +179,8 @@
 block discarded – undo
179 179
     }
180 180
 
181 181
     /**
182
-     * @param $dataType
183
-     * @param $lessIsBetter
182
+     * @param string $dataType
183
+     * @param boolean $lessIsBetter
184 184
      * @param $pastResult
185 185
      * @param $deviation
186 186
      * @param $result
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
Bundle/SalesBundle/Tests/Functional/Fixture/LoadSalesBundleFixtures.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@
 block discarded – undo
181 181
     }
182 182
 
183 183
     /**
184
-     * @return Channel
184
+     * @return LoadSalesBundleFixtures
185 185
      */
186 186
     protected function createChannel()
187 187
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,15 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityRepository;
7
-
8 7
 use Doctrine\Common\DataFixtures\AbstractFixture;
9 8
 use Doctrine\Common\Persistence\ObjectManager;
10
-
11 9
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
12 10
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 11
 use Symfony\Component\DependencyInjection\ContainerInterface;
14 12
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15
-
16 13
 use Oro\Bundle\UserBundle\Entity\UserManager;
17 14
 use Oro\Bundle\UserBundle\Entity\User;
18 15
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/TaskBundle/Entity/Task.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -322,7 +322,7 @@
 block discarded – undo
322 322
     }
323 323
 
324 324
     /**
325
-     * @return mixed|null
325
+     * @return integer|null
326 326
      */
327 327
     public function getOwnerId()
328 328
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,15 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityRepository;
7
-
8 7
 use Doctrine\Common\DataFixtures\AbstractFixture;
9 8
 use Doctrine\Common\Persistence\ObjectManager;
10
-
11 9
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
12 10
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 11
 use Symfony\Component\DependencyInjection\ContainerInterface;
14 12
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15
-
16 13
 use Oro\Bundle\UserBundle\Entity\UserManager;
17 14
 use Oro\Bundle\UserBundle\Entity\User;
18 15
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/TaskBundle/Tests/Unit/Fixtures/Entity/Task.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
     }
229 229
 
230 230
     /**
231
-     * @return mixed|null
231
+     * @return integer|null
232 232
      */
233 233
     public function getOwnerId()
234 234
     {
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     }
277 277
 
278 278
     /**
279
-     * @return WorkflowStep
279
+     * @return WorkflowItem
280 280
      */
281 281
     public function getWorkflowStep()
282 282
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/TaskBundle/Tests/Unit/Form/Handler/TaskHandlerTest.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -340,8 +340,8 @@
 block discarded – undo
340 340
     }
341 341
 
342 342
     /**
343
-     * @param mixed $obj
344
-     * @param mixed $val
343
+     * @param User $obj
344
+     * @param integer $val
345 345
      */
346 346
     protected function setId($obj, $val)
347 347
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,15 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityRepository;
7
-
8 7
 use Doctrine\Common\DataFixtures\AbstractFixture;
9 8
 use Doctrine\Common\Persistence\ObjectManager;
10
-
11 9
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
12 10
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 11
 use Symfony\Component\DependencyInjection\ContainerInterface;
14 12
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15
-
16 13
 use Oro\Bundle\UserBundle\Entity\UserManager;
17 14
 use Oro\Bundle\UserBundle\Entity\User;
18 15
 
Please login to merge, or discard this patch.