Completed
Pull Request — 1.9 (#190)
by Ivan
21:53 queued 10:29
created
Bundle/MagentoBundle/Tests/Functional/Fixture/LoadRFMCategoryData.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,9 +113,9 @@
 block discarded – undo
113 113
     }
114 114
 
115 115
     /**
116
-     * @param object $entity
116
+     * @param RFMMetricCategory $entity
117 117
      * @param array $data
118
-     * @param array $excludeProperties
118
+     * @param string[] $excludeProperties
119 119
      */
120 120
     public function setEntityPropertyValues($entity, array $data, array $excludeProperties = [])
121 121
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
OroCRM/Bundle/MagentoBundle/Tests/Functional/Fixture/LoadRFMOrderData.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,9 +114,9 @@
 block discarded – undo
114 114
     }
115 115
 
116 116
     /**
117
-     * @param object $entity
117
+     * @param Order $entity
118 118
      * @param array $data
119
-     * @param array $excludeProperties
119
+     * @param string[] $excludeProperties
120 120
      */
121 121
     public function setEntityPropertyValues($entity, array $data, array $excludeProperties = [])
122 122
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
OroCRM/Bundle/MagentoBundle/Tests/Unit/Form/Handler/CustomerHandlerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
     }
169 169
 
170 170
     /**
171
-     * @return object
171
+     * @return Customer
172 172
      */
173 173
     protected function getObject()
174 174
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
Bundle/MagentoBundle/Tests/Unit/Provider/MagentoConnectorTestCase.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -289,7 +289,7 @@
 block discarded – undo
289 289
      * @param mixed        $stepExecutionMock
290 290
      * @param null|Channel $channel
291 291
      *
292
-     * @param null         $context
292
+     * @param Context         $context
293 293
      *
294 294
      * @return AbstractMagentoConnector
295 295
      */
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Form\FormInterface;
6 6
 use Symfony\Component\HttpFoundation\Response;
7
-
8 7
 use FOS\RestBundle\Controller\Annotations\NamePrefix;
9 8
 use FOS\RestBundle\Controller\Annotations\RouteResource;
10 9
 use FOS\RestBundle\Controller\Annotations\QueryParam;
11 10
 use FOS\RestBundle\Routing\ClassResourceInterface;
12
-
13 11
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
14
-
15 12
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
16 13
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
17
-
18 14
 use Oro\Bundle\SoapBundle\Form\Handler\ApiFormHandler;
19 15
 use Oro\Bundle\SoapBundle\Controller\Api\Rest\RestController;
20 16
 use Oro\Bundle\SoapBundle\Entity\Manager\ApiEntityManager;
Please login to merge, or discard this patch.
Tests/Unit/Provider/NewsletterSubscriberInitialSyncProcessorTest.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,10 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace OroCRM\Bundle\MagentoBundle\Tests\Unit\Provider;
4 4
 
5
-use Doctrine\ORM\Query\Expr;
6
-
7 5
 use OroCRM\Bundle\MagentoBundle\Entity\MagentoSoapTransport;
8
-use OroCRM\Bundle\MagentoBundle\Provider\Connector\InitialNewsletterSubscriberConnector;
9 6
 use OroCRM\Bundle\MagentoBundle\Provider\NewsletterSubscriberInitialSyncProcessor;
10 7
 use OroCRM\Bundle\MagentoBundle\Tests\Unit\Provider\Stub\InitialConnector;
11 8
 
Please login to merge, or discard this patch.
Bundle/MagentoBundle/Tests/Unit/Provider/Reader/ContextReaderTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
     }
88 88
 
89 89
     /**
90
-     * @return array
90
+     * @return \stdClass[]
91 91
      */
92 92
     protected function getData()
93 93
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
OroCRM/Bundle/MagentoBundle/Tests/Unit/Service/AutomaticDiscoveryTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
 
170 170
     /**
171 171
      * @param \PHPUnit_Framework_MockObject_MockObject $qb
172
-     * @param object $entity
172
+     * @param Customer $entity
173 173
      * @param int|null $id
174 174
      * @param array $config
175 175
      * @param AutomaticDiscovery $service
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/MarketingListBundle/Entity/MarketingListItem.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@
 block discarded – undo
82 82
     }
83 83
 
84 84
     /**
85
-     * @return int
85
+     * @return string
86 86
      */
87 87
     public function getEntityId()
88 88
     {
Please login to merge, or discard this patch.
src/OroCRM/Bundle/MarketingListBundle/Entity/MarketingListRemovedItem.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 
100 100
     /**
101 101
      * @param \Datetime $createdAt
102
-     * @return MarketingListItem
102
+     * @return MarketingListRemovedItem
103 103
      */
104 104
     public function setCreatedAt(\Datetime $createdAt)
105 105
     {
Please login to merge, or discard this patch.