Completed
Pull Request — 1.9 (#190)
by Ivan
21:53 queued 10:29
created
src/OroCRM/Bundle/MagentoBundle/ImportExport/Strategy/CartStrategy.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
 
161 161
     /**
162 162
      * @param Cart $entity
163
-     * @return null
163
+     * @return boolean
164 164
      */
165 165
     protected function hasContactInfo(Cart $entity)
166 166
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
MagentoBundle/ImportExport/Strategy/StrategyHelper/DoctrineHelper.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
     /**
24 24
      * @param mixed        $entity             New entity
25 25
      * @param string       $entityName         Class name
26
-     * @param string|array $criteria           Fieldname to find existing entity
26
+     * @param string $criteria           Fieldname to find existing entity
27 27
      * @param array        $excludedProperties Excluded properties
28 28
      *
29 29
      * @return mixed
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
     }
96 96
 
97 97
     /**
98
-     * @param $entityName
98
+     * @param string $entityName
99 99
      *
100 100
      * @return \Doctrine\ORM\EntityManager
101 101
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/MagentoBundle/Migrations/Data/ORM/LoadRegions.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
     /**
59 59
      * @param array $regionData
60 60
      *
61
-     * @return null|Region
61
+     * @return Region
62 62
      */
63 63
     protected function getRegion(array $regionData)
64 64
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/MagentoBundle/Model/ChannelSettingsProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
     }
172 172
 
173 173
     /**
174
-     * @param mixed $channelId
174
+     * @param integer $channelId
175 175
      */
176 176
     protected function validateChannelId($channelId)
177 177
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/MagentoBundle/Provider/InitialScheduleProcessor.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -178,7 +178,7 @@
 block discarded – undo
178 178
     }
179 179
 
180 180
     /**
181
-     * @param object $entity
181
+     * @param Integration $entity
182 182
      * @return Integration
183 183
      */
184 184
     protected function reloadEntity($entity)
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,15 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityRepository;
7
-
8 7
 use Doctrine\Common\DataFixtures\AbstractFixture;
9 8
 use Doctrine\Common\Persistence\ObjectManager;
10
-
11 9
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
12 10
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 11
 use Symfony\Component\DependencyInjection\ContainerInterface;
14 12
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15
-
16 13
 use Oro\Bundle\UserBundle\Entity\UserManager;
17 14
 use Oro\Bundle\UserBundle\Entity\User;
18 15
 
Please login to merge, or discard this patch.
Bundle/MagentoBundle/Provider/Iterator/AbstractPageableSoapIterator.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
     /**
260 260
      * Load entities ids list
261 261
      *
262
-     * @return true|null true when there are ids retrieved
262
+     * @return null|boolean true when there are ids retrieved
263 263
      */
264 264
     protected function findEntitiesToProcess()
265 265
     {
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
     /**
298 298
      * Retrieve store ids for given website
299 299
      *
300
-     * @param $websiteId
300
+     * @param integer $websiteId
301 301
      *
302 302
      * @return array
303 303
      * @throws \LogicException
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/MagentoBundle/Service/AutomaticDiscovery.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@
 block discarded – undo
82 82
     }
83 83
 
84 84
     /**
85
-     * @param object $entity
85
+     * @param \OroCRM\Bundle\MagentoBundle\Entity\Customer $entity
86 86
      * @return object|null
87 87
      */
88 88
     public function discoverSimilar($entity)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
MagentoBundle/Service/AutomaticDiscovery/AddressDiscoveryStrategy.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@
 block discarded – undo
165 165
 
166 166
     /**
167 167
      * @param QueryBuilder $qb
168
-     * @param $alias
168
+     * @param string $alias
169 169
      * @param $address
170 170
      * @param array $fields
171 171
      * @param array $configuration
Please login to merge, or discard this patch.
OroCRM/Bundle/MagentoBundle/Tests/Functional/Fixture/LoadCustomerData.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,8 +61,8 @@
 block discarded – undo
61 61
 
62 62
 
63 63
     /**
64
-     * @param $firstName
65
-     * @param $lastname
64
+     * @param string $firstName
65
+     * @param string $lastname
66 66
      */
67 67
     protected function createCustomer($firstName, $lastname)
68 68
     {
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Form\FormInterface;
6 6
 use Symfony\Component\HttpFoundation\Response;
7
-
8 7
 use FOS\RestBundle\Controller\Annotations\NamePrefix;
9 8
 use FOS\RestBundle\Controller\Annotations\RouteResource;
10 9
 use FOS\RestBundle\Controller\Annotations\QueryParam;
11 10
 use FOS\RestBundle\Routing\ClassResourceInterface;
12
-
13 11
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
14
-
15 12
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
16 13
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
17
-
18 14
 use Oro\Bundle\SoapBundle\Form\Handler\ApiFormHandler;
19 15
 use Oro\Bundle\SoapBundle\Controller\Api\Rest\RestController;
20 16
 use Oro\Bundle\SoapBundle\Entity\Manager\ApiEntityManager;
Please login to merge, or discard this patch.