Completed
Pull Request — master (#205)
by Matheus
13:03
created
Bundle/ActivityContactBundle/Command/ActivityContactRecalculateCommand.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -2,19 +2,14 @@  discard block
 block discarded – undo
2 2
 
3 3
 namespace OroCRM\Bundle\ActivityContactBundle\Command;
4 4
 
5
-use Doctrine\ORM\Query;
6 5
 use Doctrine\ORM\QueryBuilder;
7
-
8 6
 use Psr\Log\AbstractLogger;
9
-
10 7
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
11 8
 use Symfony\Component\Console\Input\InputInterface;
12 9
 use Symfony\Component\Console\Output\OutputInterface;
13 10
 use Symfony\Component\PropertyAccess\PropertyAccess;
14
-
15 11
 use Oro\Component\PropertyAccess\PropertyAccessor;
16 12
 use Oro\Component\Log\OutputLogger;
17
-
18 13
 use Oro\Bundle\ActivityBundle\Event\ActivityEvent;
19 14
 use Oro\Bundle\ActivityListBundle\Entity\ActivityList;
20 15
 use Oro\Bundle\ActivityListBundle\Entity\Repository\ActivityListRepository;
@@ -24,7 +19,6 @@  discard block
 block discarded – undo
24 19
 use Oro\Bundle\EntityConfigBundle\Config\ConfigInterface;
25 20
 use Oro\Bundle\EntityConfigBundle\Provider\ConfigProvider;
26 21
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
27
-
28 22
 use OroCRM\Bundle\ActivityContactBundle\EntityConfig\ActivityScope;
29 23
 use OroCRM\Bundle\ActivityContactBundle\EventListener\ActivityListener;
30 24
 use OroCRM\Bundle\ActivityContactBundle\Provider\ActivityContactProvider;
Please login to merge, or discard this patch.
OroCRM/Bundle/ActivityContactBundle/Provider/ActivityContactProvider.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     /**
60 60
      * Return list of supported activity classes
61 61
      *
62
-     * @return array
62
+     * @return integer[]
63 63
      */
64 64
     public function getSupportedActivityClasses()
65 65
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     /**
70 70
      * Check if given entity class is supports
71 71
      *
72
-     * @param $activityClass
72
+     * @param string $activityClass
73 73
      *
74 74
      * @return bool
75 75
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ActivityContactBundle/Provider/EmailDirectionProvider.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -126,6 +126,7 @@  discard block
 block discarded – undo
126 126
 
127 127
     /**
128 128
      * {@inheritdoc}
129
+     * @param Email $activity
129 130
      */
130 131
     public function getDate($activity)
131 132
     {
@@ -202,7 +203,7 @@  discard block
 block discarded – undo
202 203
     }
203 204
 
204 205
     /**
205
-     * @param object $target
206
+     * @param EmailHolderInterface $target
206 207
      * @return string
207 208
      */
208 209
     protected function getTargetEmail($target)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
Bundle/AnalyticsBundle/Tests/Unit/Validator/CategoriesValidatorTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@
 block discarded – undo
270 270
     }
271 271
 
272 272
     /**
273
-     * @param array $items
273
+     * @param RFMMetricCategory[] $items
274 274
      *
275 275
      * @return PersistentCollection
276 276
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/AnalyticsBundle/Validator/CategoriesValidator.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     /**
19 19
      * Validate collection.
20 20
      *
21
-     * @param PersistentCollection|RFMMetricCategory[] $value
21
+     * @param PersistentCollection $value
22 22
      * @param CategoriesConstraint $constraint
23 23
      *
24 24
      * {@inheritdoc}
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
OroCRM/Bundle/CampaignBundle/Tests/Unit/Model/EmailCampaignSenderTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -366,6 +366,9 @@
 block discarded – undo
366 366
         $this->sender->send($campaign);
367 367
     }
368 368
 
369
+    /**
370
+     * @param string[] $fields
371
+     */
369 372
     protected function assertFieldsCall($fields, MarketingList $marketingList)
370 373
     {
371 374
         $this->contactInformationFieldsProvider->expects($this->once())
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ChannelBundle/Autocomplete/ChannelLimitationHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 
16 16
     /**
17 17
      * @param string $entityName
18
-     * @param array  $properties
18
+     * @param string[]  $properties
19 19
      * @param string $channelRelationName
20 20
      * @param string $channelSearchPropertyName
21 21
      */
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ChannelBundle/Entity/LifetimeValueHistory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
     }
92 92
 
93 93
     /**
94
-     * @return bool
94
+     * @return string
95 95
      */
96 96
     public function getStatus()
97 97
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Validator\Constraint;
6 6
 use Symfony\Component\Validator\ConstraintValidator;
7
-
8 7
 use OroCRM\Bundle\TaskBundle\Validator\Constraints\DueDateRequired;
9 8
 use OroCRM\Bundle\TaskBundle\Entity\Task;
10 9
 
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ChannelBundle/Form/Handler/ChannelHandler.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
     /**
105 105
      * Returns form instance
106 106
      *
107
-     * @return FormInterface
107
+     * @return \Symfony\Component\Form\FormView
108 108
      */
109 109
     public function getFormView()
110 110
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.