Completed
Pull Request — master (#205)
by Matheus
13:03
created
OroCRM/Bundle/ContactBundle/Tests/Unit/Form/Handler/ContactHandlerTest.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,12 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace OroCRM\Bundle\ContactBundle\Tests\Unit\Form\Handler;
4 4
 
5
-use Doctrine\Common\Persistence\ObjectManager;
6
-
7 5
 use Doctrine\ORM\EntityManagerInterface;
8 6
 use Symfony\Component\Form\FormInterface;
9 7
 use Symfony\Component\HttpFoundation\Request;
10
-
11 8
 use OroCRM\Bundle\ContactBundle\Entity\Contact;
12 9
 use OroCRM\Bundle\AccountBundle\Entity\Account;
13 10
 use OroCRM\Bundle\ContactBundle\Form\Handler\ContactHandler;
Please login to merge, or discard this patch.
OroCRM/Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadAccountData.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,12 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace OroCRM\Bundle\DemoDataBundle\Migrations\Data\Demo\ORM;
4 4
 
5
-use Symfony\Component\DependencyInjection\ContainerInterface;
6
-use Symfony\Component\DependencyInjection\ContainerAwareInterface;
7
-
8 5
 use Doctrine\Common\Persistence\ObjectManager;
9 6
 use Doctrine\Common\DataFixtures\DependentFixtureInterface;
10
-
11 7
 use OroCRM\Bundle\AccountBundle\Entity\Account;
12 8
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
13 9
 
Please login to merge, or discard this patch.
Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadBusinessUnitData.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
     /**
102 102
      * @param EntityManager $manager
103
-     * @param mixed         $object
103
+     * @param BusinessUnit         $object
104 104
      */
105 105
     private function persistAndFlush($manager, $object)
106 106
     {
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
     /**
112 112
      * @param EntityManager $manager
113
-     * @param mixed         $object
113
+     * @param BusinessUnit         $object
114 114
      */
115 115
     private function persist($manager, $object)
116 116
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadLeadsData.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -233,8 +233,8 @@  discard block
 block discarded – undo
233 233
     /**
234 234
      * Persist object
235 235
      *
236
-     * @param mixed $manager
237
-     * @param mixed $object
236
+     * @param EntityManager $manager
237
+     * @param Lead $object
238 238
      */
239 239
     private function persist($manager, $object)
240 240
     {
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
     /**
245 245
      * Flush objects
246 246
      *
247
-     * @param mixed $manager
247
+     * @param EntityManager $manager
248 248
      */
249 249
     private function flush($manager)
250 250
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
OroCRM/Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadPintabsData.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     /**
146 146
      * Persist object
147 147
      *
148
-     * @param mixed $manager
148
+     * @param EntityManager $manager
149 149
      * @param mixed $object
150 150
      */
151 151
     private function persist($manager, $object)
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
     /**
157 157
      * Flush objects
158 158
      *
159
-     * @param mixed $manager
159
+     * @param EntityManager $manager
160 160
      */
161 161
     private function flush($manager)
162 162
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
OroCRM/Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadReportData.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -91,8 +91,8 @@  discard block
 block discarded – undo
91 91
     /**
92 92
      * Persist object
93 93
      *
94
-     * @param mixed $manager
95
-     * @param mixed $object
94
+     * @param EntityManager $manager
95
+     * @param Report $object
96 96
      */
97 97
     private function persist($manager, $object)
98 98
     {
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     /**
103 103
      * Flush objects
104 104
      *
105
-     * @param mixed $manager
105
+     * @param EntityManager $manager
106 106
      */
107 107
     private function flush($manager)
108 108
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadSalesFunnelData.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -273,7 +273,7 @@
 block discarded – undo
273 273
     /**
274 274
      * Flush objects
275 275
      *
276
-     * @param mixed $manager
276
+     * @param EntityManager $manager
277 277
      */
278 278
     private function flush($manager)
279 279
     {
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Form\FormInterface;
6 6
 use Symfony\Component\HttpFoundation\Response;
7
-
8 7
 use FOS\RestBundle\Controller\Annotations\NamePrefix;
9 8
 use FOS\RestBundle\Controller\Annotations\RouteResource;
10 9
 use FOS\RestBundle\Controller\Annotations\QueryParam;
11 10
 use FOS\RestBundle\Routing\ClassResourceInterface;
12
-
13 11
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
14
-
15 12
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
16 13
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
17
-
18 14
 use Oro\Bundle\SoapBundle\Form\Handler\ApiFormHandler;
19 15
 use Oro\Bundle\SoapBundle\Controller\Api\Rest\RestController;
20 16
 use Oro\Bundle\SoapBundle\Entity\Manager\ApiEntityManager;
Please login to merge, or discard this patch.
src/OroCRM/Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadUserData.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@
 block discarded – undo
132 132
 
133 133
     /**
134 134
      * @param ObjectManager $manager
135
-     * @param $name
135
+     * @param string $name
136 136
      * @return BusinessUnit
137 137
      */
138 138
     protected function getBusinessUnit(ObjectManager $manager, $name)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.
src/OroCRM/Bundle/DemoDataBundle/Migrations/Data/Demo/ORM/LoadUsersData.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
      * @param  string    $firstName
130 130
      * @param  string    $lastName
131 131
      * @param  \DateTime $birthday
132
-     * @param  mixed     $role
132
+     * @param  Role     $role
133 133
      * @return User
134 134
      */
135 135
     private function createUser($username, $email, $firstName, $lastName, $birthday, $role)
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     /**
256 256
      * Persist object
257 257
      *
258
-     * @param  mixed $object
258
+     * @param  User $object
259 259
      * @return void
260 260
      */
261 261
     private function persist($object)
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
     }
275 275
 
276 276
     /**
277
-     * @param $name
277
+     * @param string $name
278 278
      * @return BusinessUnit
279 279
      */
280 280
     protected function getBusinessUnit($name)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\TestFrameworkBundle\Tests\Performance;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Console\Application;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\DependencyInjection\Container;
9
-
10 8
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 9
 
12 10
 class LoadTest extends WebTestCase
Please login to merge, or discard this patch.