GroupDefinitionAwareRolloutTest::testGroupDefinitionAware() - Code Metrics - opensoft/OpensoftRolloutBundle - Measure and Improve Code Quality continuously with Scrutinizer

testGroupDefinitionAware() A
last analyzed 2019-05-31 16:24 UTC

↳ Parent: GroupDefinitionAwareRolloutTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Opensoft\RolloutBundle\Tests\Rollout;

use Opensoft\Rollout\RolloutUserInterface;
use Opensoft\Rollout\Storage\ArrayStorage;
use Opensoft\RolloutBundle\Rollout\GroupDefinitionAwareRollout;

/**
 * @author Richard Fullmer <[email protected]>
 */
class GroupDefinitionAwareRolloutTest extends \PHPUnit_Framework_TestCase
{
    public function testGroupDefinitionAware()
    {
        $group = $this->getMockBuilder('Opensoft\RolloutBundle\Rollout\GroupDefinitionInterface')->getMock();
        $group->expects($this->once())->method('getName')->will($this->returnValue('test_group'));

        $callback = function (RolloutUserInterface $user) {
            return $user->name == 'test_user';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        };

        $group->expects($this->once())->method('getCallback')->will($this->returnValue($callback));

        $rollout = new GroupDefinitionAwareRollout(new ArrayStorage());

        $rollout->addGroupDefinition($group);

        $this->assertEquals(1, count($rollout->getGroupDefinitions()));
        $this->assertTrue($rollout->isActiveInGroup('test_group', new User('test_user')));
        $this->assertFalse($rollout->isActiveInGroup('test_group', new User('other_user')));
    }
}

class User implements RolloutUserInterface
{
    public $name;

    /**
     * @param string $name
     */
    public function __construct($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getRolloutIdentifier()
    {
        return '';
    }
}


1			<?php
2
3			namespace Opensoft\RolloutBundle\Tests\Rollout;
4
5			use Opensoft\Rollout\RolloutUserInterface;
6			use Opensoft\Rollout\Storage\ArrayStorage;
7			use Opensoft\RolloutBundle\Rollout\GroupDefinitionAwareRollout;
8
9			/**
10			* @author Richard Fullmer <[email protected]>
11			*/
12			class GroupDefinitionAwareRolloutTest extends \PHPUnit_Framework_TestCase
13			{
14			public function testGroupDefinitionAware()
15			{
16			$group = $this->getMockBuilder('Opensoft\RolloutBundle\Rollout\GroupDefinitionInterface')->getMock();
17			$group->expects($this->once())->method('getName')->will($this->returnValue('test_group'));
18
19			$callback = function (RolloutUserInterface $user) {
20			return $user->name == 'test_user';
			0 ignored issues – show Bug introduced 2016-08-24 17:05 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `Opensoft\Rollout\RolloutUserInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
21			};
22
23			$group->expects($this->once())->method('getCallback')->will($this->returnValue($callback));
24
25			$rollout = new GroupDefinitionAwareRollout(new ArrayStorage());
26
27			$rollout->addGroupDefinition($group);
28
29			$this->assertEquals(1, count($rollout->getGroupDefinitions()));
30			$this->assertTrue($rollout->isActiveInGroup('test_group', new User('test_user')));
31			$this->assertFalse($rollout->isActiveInGroup('test_group', new User('other_user')));
32			}
33			}
34
35			class User implements RolloutUserInterface
36			{
37			public $name;
38
39			/**
40			* @param string $name
41			*/
42			public function __construct($name)
43			{
44			$this->name = $name;
45			}
46
47			/**
48			* @return string
49			*/
50			public function getRolloutIdentifier()
51			{
52			return '';
53			}
54			}
55

opensoft / OpensoftRolloutBundle

GitHub Access Token became invalid

testGroupDefinitionAware() A last analyzed 2019-05-31 16:24 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

testGroupDefinitionAware() A
last analyzed 2019-05-31 16:24 UTC