Opensoft\RolloutBundle\Tests\Rollout\GroupDefinitionAwareRolloutTest

Complexity

Total Complexity

1

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testGroupDefinitionAware()	0	19	1

<?php

namespace Opensoft\RolloutBundle\Tests\Rollout;

use Opensoft\Rollout\RolloutUserInterface;
use Opensoft\Rollout\Storage\ArrayStorage;
use Opensoft\RolloutBundle\Rollout\GroupDefinitionAwareRollout;

/**
 * @author Richard Fullmer <richard.fullmer@opensoftdev.com>
 */
class GroupDefinitionAwareRolloutTest extends \PHPUnit_Framework_TestCase
{
    public function testGroupDefinitionAware()
    {
        $group = $this->getMockBuilder('Opensoft\RolloutBundle\Rollout\GroupDefinitionInterface')->getMock();
        $group->expects($this->once())->method('getName')->will($this->returnValue('test_group'));

        $callback = function (RolloutUserInterface $user) {
            return $user->name == 'test_user';

Accessing name on the interface Opensoft\Rollout\RolloutUserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        };

        $group->expects($this->once())->method('getCallback')->will($this->returnValue($callback));

        $rollout = new GroupDefinitionAwareRollout(new ArrayStorage());

        $rollout->addGroupDefinition($group);

        $this->assertEquals(1, count($rollout->getGroupDefinitions()));
        $this->assertTrue($rollout->isActiveInGroup('test_group', new User('test_user')));
        $this->assertFalse($rollout->isActiveInGroup('test_group', new User('other_user')));
    }
}

class User implements RolloutUserInterface
{
    public $name;

    /**
     * @param string $name
     */
    public function __construct($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getRolloutIdentifier()
    {
        return '';
    }
}