ongr-io / SettingsBundle

Event/SettingChangeEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     /**
      * Constructor.
      *
-     * @param Action $action
+     * @param string $action
      */
     public function __construct($action)
     {

Settings/General/SettingsContainer.php

Doc Comments +1 added lines, -1 removed lines

@@ -120,7 +120,7 @@
     }
 
     /**
-     * @param array $profiles
+     * @param string[] $profiles
      */
     public function setProfiles($profiles)
     {

Settings/General/SettingsManager.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use ONGR\ElasticsearchBundle\ORM\Manager;
 use ONGR\SettingsBundle\Document\Setting;
 use ONGR\SettingsBundle\Event\SettingChangeEvent;
-use Exception;
 
 /**
  * Class SettingsManager responsible for managing settings actions.

Tests/Functional/Controller/PersonalSettingsControllerTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 namespace ONGR\SettingsBundle\Tests\Functional\Controller;
 
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
-use ONGR\SettingsBundle\Tests\Functional\PreparePersonalData;
-use ONGR\SettingsBundle\Tests\Functional\PrepareAdminData;
 use ONGR\ElasticsearchBundle\Test\ElasticsearchTestCase;
 use Symfony\Bundle\FrameworkBundle\Client;
 

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
 
         // Try to change value through change setting action.
         $data[0] = ['foo_setting_1', false];
-        $data[1] = ['foo_setting_non_existent', false ];
+        $data[1] = ['foo_setting_non_existent', false];
 
         foreach ($data as $case) {
             $client->request('get', '/admin/setting/change/' . base64_encode($case[0]));

Tests/Functional/Twig/GeneralSettingsWidgetExtensionTest.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace ONGR\SettingsBundle\Tests\Functional\Twig;
 
 use ONGR\SettingsBundle\Exception\SettingNotFoundException;
-use ONGR\SettingsBundle\Settings\Personal\PersonalSettingsManager;
 use ONGR\SettingsBundle\Twig\GeneralSettingsWidgetExtension;
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
 use ONGR\SettingsBundle\Settings\General\SettingsContainerInterface;

Tests/Functional/Twig/PersonalSettingWidgetExtensionTest.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
 use ONGR\ElasticsearchBundle\Test\ElasticsearchTestCase;
 use Symfony\Bundle\FrameworkBundle\Client;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 /**
  * Tests for testing settings TWIG extension functionality.

Tests/Unit/DependencyInjection/Security/SessionlessAuthenticationFactoryTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getFirewallsDetails()
     {

Tests/Unit/Settings/General/SettingsContainerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
      * @param bool  $miss
      * @param array $settings
      *
-     * @return \PHPUnit_Framework_MockObject_MockObject|PoolInterface
+     * @return PoolInterface
      */
     private function getPool($miss = true, $settings = [])
     {

Tests/Unit/Settings/General/SettingsManagerTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -127,7 +127,7 @@ 
     /**
      * Returns mock of SettingsManager.
      *
-     * @param object $ormManagerMock
+     * @param Manager $ormManagerMock
      *
      * @return SettingsManager
      */
@@ -143,7 +143,7 @@ 
     /**
      * Returns mock of event dispatcher.
      *
-     * @return EventDispatcherInterface|MockObject
+     * @return EventDispatcherInterface
      */
     protected function getEventDispatcherMock()
     {

Spacing +2 added lines, -2 removed lines

@@ -166,10 +166,10 @@
         $cases[1] = ['name' => 'bar_name', 'profile' => true];
 
         // Case No 3. Array.
-        $cases[2] = ['name' => 'bar_name', 'profile' => ['value1', 'value2'] ];
+        $cases[2] = ['name' => 'bar_name', 'profile' => ['value1', 'value2']];
 
         // Case No 3. Object.
-        $cases[3] = ['name' => 'bar_name', 'profile' => $this->getOrmRepositoryMock() ];
+        $cases[3] = ['name' => 'bar_name', 'profile' => $this->getOrmRepositoryMock()];
 
         return $cases;
     }