ongr-io / SettingsBundle

Event/SettingChangeEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     /**
      * Constructor.
      *
-     * @param Action $action
+     * @param string $action
      */
     public function __construct($action)
     {

Settings/General/SettingsContainer.php

Doc Comments +1 added lines, -1 removed lines

@@ -120,7 +120,7 @@
     }
 
     /**
-     * @param array $profiles
+     * @param string[] $profiles
      */
     public function setProfiles($profiles)
     {

Settings/General/SettingsManager.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use ONGR\ElasticsearchBundle\ORM\Manager;
 use ONGR\SettingsBundle\Document\Setting;
 use ONGR\SettingsBundle\Event\SettingChangeEvent;
-use Exception;
 
 /**
  * Class SettingsManager responsible for managing settings actions.

Tests/Functional/Controller/PersonalSettingsControllerTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 namespace ONGR\SettingsBundle\Tests\Functional\Controller;
 
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
-use ONGR\SettingsBundle\Tests\Functional\PreparePersonalData;
-use ONGR\SettingsBundle\Tests\Functional\PrepareAdminData;
 use ONGR\ElasticsearchBundle\Test\ElasticsearchTestCase;
 use Symfony\Bundle\FrameworkBundle\Client;
 

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
 
         // Try to change value through change setting action.
         $data[0] = ['foo_setting_1', false];
-        $data[1] = ['foo_setting_non_existent', false ];
+        $data[1] = ['foo_setting_non_existent', false];
 
         foreach ($data as $case) {
             $client->request('get', '/admin/setting/change/' . base64_encode($case[0]));

Tests/Unit/Settings/General/SettingsContainerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
      * @param bool  $miss
      * @param array $settings
      *
-     * @return \PHPUnit_Framework_MockObject_MockObject|PoolInterface
+     * @return PoolInterface
      */
     private function getPool($miss = true, $settings = [])
     {

Twig/HiddenExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
     }
 
     /**
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {

Twig/WrapperExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     /**
      * Returns list of new Twig functions.
      *
-     * @return array
+     * @return \Twig_SimpleFilter[]
      */
     public function getFilters()
     {

EventListener/SettingsCookieListener.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     ) {
         $settingsMap = $this->generalSettingsManager->getSettingsMap();
         $cookiesServiceNames = array_map(
-            function ($setting) {
+            function($setting) {
                 return $setting['cookie'];
             },
             $settingsMap

Tests/Functional/Controller/UserControllerTest.php

Indentation +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
         if ($shouldSucceed) {
             $this->assertContains(' already logged in', $response->getContent());
 
-             // Assert correct cookie has been set.
+                // Assert correct cookie has been set.
             /** @var Cookie $cookie */
             $cookie = $client->getCookieJar()->get('ongr_settings_user_auth');
             $this->assertSame('ongr_settings_user_auth', $cookie->getName());