ongr-io / SettingsBundle

DependencyInjection/ONGRSettingsExtension.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
         // Set profiles.
         $container->setParameter('ongr_settings.settings_container.profiles', $config['profiles']);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services/twig_extension.yml');
         $loader->load('services/personal_settings.yml');
         $loader->load('services/general_settings.yml');

Tests/app/AppKernel.php

Spacing +1 added lines, -1 removed lines

@@ -46,6 +46,6 @@
      */
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
-        $loader->load(__DIR__ . '/config/config_' . $this->getEnvironment() . '.yml');
+        $loader->load(__DIR__.'/config/config_'.$this->getEnvironment().'.yml');
     }
 }

Controller/SettingsController.php

Unused Use Statements -2 removed lines

@@ -11,9 +11,7 @@
 
 namespace ONGR\SettingsBundle\Controller;
 
-use ONGR\ElasticsearchBundle\Result\Aggregation\AggregationValue;
 use ONGR\ElasticsearchBundle\Service\Repository;
-use ONGR\ElasticsearchDSL\Aggregation\TermsAggregation;
 use ONGR\SettingsBundle\Document\Setting;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\JsonResponse;

Doc Comments -1 removed lines

@@ -71,7 +71,6 @@
     /**
      * Returns a json list of profiles
      *
-     * @param Request $request
      *
      * @return Response
      */

Controller/ProfilesController.php

Braces +3 added lines, -1 removed lines

@@ -65,7 +65,9 @@
             $profiles[] = $agg->getValue('key');
         }
 
-        if (empty($profiles) || !in_array('default', $profiles)) array_unshift($profiles, 'default');
+        if (empty($profiles) || !in_array('default', $profiles)) {
+            array_unshift($profiles, 'default');
+        }
 
         return new JsonResponse($profiles);
     }

Unused Use Statements -4 removed lines

@@ -14,11 +14,7 @@
 use ONGR\ElasticsearchBundle\Result\DocumentIterator;
 use ONGR\ElasticsearchBundle\Service\Repository;
 use ONGR\ElasticsearchDSL\Aggregation\TermsAggregation;
-use ONGR\ElasticsearchDSL\Aggregation\TopHitsAggregation;
-use ONGR\ElasticsearchDSL\Search;
 use ONGR\ElasticsearchBundle\Result\Aggregation\AggregationValue;
-use ONGR\SettingsBundle\Document\Setting;
-use ONGR\SettingsBundle\Service\SettingsManager;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;

Document/Setting.php

Doc Comments +1 added lines, -1 removed lines

@@ -150,7 +150,7 @@
     /**
      * Set profile.
      *
-     * @param string|array $profile
+     * @param string[] $profile
      */
     public function setProfile($profile)
     {

Tests/Unit/Service/SettingsManagerTest.php

Spacing +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
             'value' => 'foo',
         ];
 
-        $this->manager->expects($this->once())->method('persist')->with($this->callback(function ($obj) {return $obj instanceof Setting;}))->willReturn(null);
+        $this->manager->expects($this->once())->method('persist')->with($this->callback(function($obj) {return $obj instanceof Setting; }))->willReturn(null);
         $this->manager->expects($this->once())->method('persist')->willReturn(null);
 
         $manager = new SettingsManager($this->repository, $this->getMock('Symfony\Component\EventDispatcher\EventDispatcherInterface'));
@@ -383,7 +383,7 @@ 
         $activeProfilesSetting = 'active_profiles';
 
         $this->repository->expects($this->any())->method('findOneBy')->willReturnCallback(
-            function ($arg) use ($activeProfilesSetting) {
+            function($arg) use ($activeProfilesSetting) {
                 $settingName = $arg['name'];
                 $setting = new Setting();
                 switch ($settingName) {
@@ -426,7 +426,7 @@ 
         $this->cookie->expects($this->any())->method('getValue')->willReturn(['foo']);
         $this->cache->expects($this->any())->method('contains')->willReturn(true);
         $this->cache->expects($this->any())->method('fetch')->willReturnCallback(
-            function ($arg) use ($activeProfilesSetting) {
+            function($arg) use ($activeProfilesSetting) {
                 if ($arg == $activeProfilesSetting) {
                     return ['foo'];
                 }