ongr-io / SettingsBundle

Controller/SettingsManagerController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use ONGR\SettingsBundle\Settings\General\SettingsManager;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;

ONGRSettingsBundle.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use ONGR\SettingsBundle\DependencyInjection\Compiler\SettingAwareFactoryPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
-use ONGR\SettingsBundle\DependencyInjection\Security\SessionlessAuthenticationFactory;
 
 /**
  * This class is used to register component into Symfony app kernel.

Service/FormValidator.php

Spacing +7 added lines, -8 removed lines

@@ -39,28 +39,27 @@ 
             $return['error'] = 'You must set a name to the setting. ';
         }
         if (count($return['profiles']) == 0) {
-            $return['error'] = $return['error'].'At least 1 profile has to be set. ';
+            $return['error'] = $return['error'] . 'At least 1 profile has to be set. ';
         }
         switch ($return['type']) {
             case 'bool':
                 $request->request->get('setting-boolean') == 'true' ?
-                    $return['value'] = true :
-                    $return['value'] = false;
+                    $return['value'] = true : $return['value'] = false;
                 break;
             case 'string':
                 $return['value'] = $request->request->get('setting-default');
                 if ($return['value'] == '') {
-                    $return['error'] = $return['error'].'You must set a value to the setting. ';
+                    $return['error'] = $return['error'] . 'You must set a value to the setting. ';
                 }
                 break;
             case 'object':
                 try {
                     $return['value'] = json_encode($parser->parse($request->request->get('setting-object')));
                 } catch (\Exception $e) {
-                    $return['error'] = $return['error'].'Passed setting value does not contain valid yaml. ';
+                    $return['error'] = $return['error'] . 'Passed setting value does not contain valid yaml. ';
                 }
                 if ($return['value'] == '') {
-                    $return['error'] = $return['error'].'You must set a value to the setting. ';
+                    $return['error'] = $return['error'] . 'You must set a value to the setting. ';
                 }
                 break;
             case 'array':
@@ -71,7 +70,7 @@ 
                     }
                 }
                 if (count($return['value']) == 0 || $return['value'][0] == '') {
-                    $return['error'] = $return['error'].'You must set a value to the setting. ';
+                    $return['error'] = $return['error'] . 'You must set a value to the setting. ';
                 }
                 break;
         }
@@ -100,7 +99,7 @@ 
         }
         foreach ($profiles as $profile) {
             if ($return['name'] == $profile['name']) {
-                $return['error'] = 'The profile `'.$profile['name'].'` is already set.';
+                $return['error'] = 'The profile `' . $profile['name'] . '` is already set.';
                 return $return;
             }
         }

Controller/ProfileController.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
         }
         try {
             $profileManager->createProfile($data['name'], $data['description']);
-        }catch (\Exception $e) {
+        } catch (\Exception $e) {
             $cache->save('settings_errors', $e->getMessage());
             return new RedirectResponse($this->generateUrl('ongr_settings_profile_add'));
         }

Braces +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
         }
         try {
             $profileManager->createProfile($data['name'], $data['description']);
-        }catch (\Exception $e) {
+        } catch (\Exception $e) {
             $cache->save('settings_errors', $e->getMessage());
             return new RedirectResponse($this->generateUrl('ongr_settings_profile_add'));
         }

Settings/Personal/SettingsStructure.php

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
     public function ensureSettingStash(array $setting)
     {
         if (!isset($setting['stash'])) {
-            $setting['stash'] = 'ongr_settings.settings.';//.$setting['id'];
+            $setting['stash'] = 'ongr_settings.settings.'; //.$setting['id'];
         }
 
         return $setting;

Controller/PersonalSettingsController.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     {
         $manager = $this->getPersonalSettingsManager();
         // Handle form.
-        $settingsData = $manager->getSettings();//$this->get('stash')->getItem('ongr_settings')->get();
+        $settingsData = $manager->getSettings(); //$this->get('stash')->getItem('ongr_settings')->get();
         $settingsMap = $manager->getSettingsMap();
         $options = [
             'settingsStructure' => $settingsMap,