Polygon::fromPoints() - Code Metrics - Inspection of "showcase tests" - ondrej-bouda/ivory - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e6b195...a64aa1 )

by Ondřej

created 2017-02-19 19:42 UTC

Polygon::fromPoints() B

↳ Parent: Polygon

Complexity

Conditions	5
Paths	5

Size

Total Lines	19
Code Lines	12

Duplication

Lines	11
Ratio	57.89 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	11
loc	19
rs	8.8571
cc	5
eloc	12
nc	5
nop	1

<?php
namespace Ivory\Value;

/**
 * Representation of a polygon on a plane.
 *
 * The objects are immutable.
 */
class Polygon

{
    /** @var Point[] */
    private $points;


    /**
     * Creates a new polygon defined by the list of its vertices.
     *
     * @param Point[]|float[][] $points
     * @return Polygon
     */
    public static function fromPoints($points): Polygon
    {
        if (count($points) == 0) {
            throw new \InvalidArgumentException('points');
        }

        $normalized = [];
        foreach ($points as $i => $point) {

            if ($point instanceof Point) {
                $normalized[] = $point;
            } elseif (is_array($point)) {
                $normalized[] = Point::fromCoords($point[0], $point[1]);
            } else {
                throw new \InvalidArgumentException("points[$i]");
            }
        }

        return new Polygon($normalized);
    }

    private function __construct($points)
    {
        $this->points = $points;
    }

    /**
     * @return Point[] the list of vertices determining this polygon
     */
    public function getPoints()
    {
        return $this->points;
    }

    /**
     * Computes the area of the polygon.
     *
     * The algorithm taken from http://alienryderflex.com/polygon_area/
     *
     * @return float area of the polygon
     */
    public function getArea(): float
    {
        $area = 0;

        $from = $this->points[count($this->points) - 1];
        foreach ($this->points as $to) {
            $area += ($to->getX() + $from->getX()) * ($to->getY() - $from->getY());
            $from = $to;
        }

        return abs($area) / 2;
    }

    public function __toString()
    {
        return '(' . implode(',', $this->points) . ')';
    }
}


1		<?php
2		namespace Ivory\Value;
3
4		/**
5		* Representation of a polygon on a plane.
6		*
7		* The objects are immutable.
8		*/
9		class Polygon
		0 ignored issues – show Coding Style introduced 2017-02-14 22:32 UTC by Report Bug Copy Issue Report Since you have declared the constructor as private, maybe you should also declare the class as final. Loading history...
10		{
11		/** @var Point[] */
12		private $points;
13
14
15		/**
16		* Creates a new polygon defined by the list of its vertices.
17		*
18		* @param Point[]\|float[][] $points
19		* @return Polygon
20		*/
21		public static function fromPoints($points): Polygon
22		{
23		if (count($points) == 0) {
24		throw new \InvalidArgumentException('points');
25		}
26
27		$normalized = [];
28	View Code Duplication	foreach ($points as $i => $point) {
		0 ignored issues – show Duplication introduced 2017-02-07 21:33 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		if ($point instanceof Point) {
30		$normalized[] = $point;
31		} elseif (is_array($point)) {
32		$normalized[] = Point::fromCoords($point[0], $point[1]);
33		} else {
34		throw new \InvalidArgumentException("points[$i]");
35		}
36		}
37
38		return new Polygon($normalized);
39		}
40
41		private function __construct($points)
42		{
43		$this->points = $points;
44		}
45
46		/**
47		* @return Point[] the list of vertices determining this polygon
48		*/
49		public function getPoints()
50		{
51		return $this->points;
52		}
53
54		/**
55		* Computes the area of the polygon.
56		*
57		* The algorithm taken from http://alienryderflex.com/polygon_area/
58		*
59		* @return float area of the polygon
60		*/
61		public function getArea(): float
62		{
63		$area = 0;
64
65		$from = $this->points[count($this->points) - 1];
66		foreach ($this->points as $to) {
67		$area += ($to->getX() + $from->getX()) * ($to->getY() - $from->getY());
68		$from = $to;
69		}
70
71		return abs($area) / 2;
72		}
73
74		public function __toString()
75		{
76		return '(' . implode(',', $this->points) . ')';
77		}
78		}
79

ondrej-bouda / ivory

Push — master ( e6b195...a64aa1 )

Polygon::fromPoints() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like