Ivory\Value\Polygon

Complexity

Total Complexity

10

Size/Duplication

Total Lines	70
Duplicated Lines	15.71 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	fromPoints()	11	19	5
A	__construct()	0	4	1
A	getPoints()	0	4	1
A	getArea()	0	12	2
A	__toString()	0	4	1

<?php
namespace Ivory\Value;

/**
 * Representation of a polygon on a plane.
 *
 * The objects are immutable.
 */
class Polygon

Since you have declared the constructor as private, maybe you should also declare the class as final.

{
    /** @var Point[] */
    private $points;


    /**
     * Creates a new polygon defined by the list of its vertices.
     *
     * @param Point[]|float[][] $points
     * @return Polygon
     */
    public static function fromPoints($points): Polygon
    {
        if (count($points) == 0) {
            throw new \InvalidArgumentException('points');
        }

        $normalized = [];
        foreach ($points as $i => $point) {

This code seems to be duplicated across your project.

            if ($point instanceof Point) {
                $normalized[] = $point;
            } elseif (is_array($point)) {
                $normalized[] = Point::fromCoords($point[0], $point[1]);
            } else {
                throw new \InvalidArgumentException("points[$i]");
            }
        }

        return new Polygon($normalized);
    }

    private function __construct($points)
    {
        $this->points = $points;
    }

    /**
     * @return Point[] the list of vertices determining this polygon
     */
    public function getPoints()
    {
        return $this->points;
    }

    /**
     * Computes the area of the polygon.
     *
     * The algorithm taken from http://alienryderflex.com/polygon_area/
     *
     * @return float area of the polygon
     */
    public function getArea(): float
    {
        $area = 0;

        $from = $this->points[count($this->points) - 1];
        foreach ($this->points as $to) {
            $area += ($to->getX() + $from->getX()) * ($to->getY() - $from->getY());
            $from = $to;
        }

        return abs($area) / 2;
    }

    public function __toString()
    {
        return '(' . implode(',', $this->points) . ')';
    }
}