Issues in DbUtils.php (master) - Issues in master - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

Issues (387)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/utils/DbUtils.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * laravel-money-manager-ex
 *
 * This File belongs to to Project laravel-money-manager-ex
 *
 * @author Oliver Kaufmann <[email protected]>
 * @version 1.0
 */

namespace Tests\utils;

use App\Models\Model;

trait DbUtils
{
    /**
     * Assert that a given where condition does not matches a soft deleted record
     * From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
     *
     * @param string $table
     * @param array  $data
     * @param string $connection
     *
     * @return $this
     */
    protected function assertSeeIsNotSoftDeletedInDatabase($table, array $data, $connection = null)

    {
        $database = $this->app->make('db');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $connection = $connection ?: $database->getDefaultConnection();

        $count = $database->connection($connection)
            ->table($table)
            ->where($data)
            ->whereNull('deleted_at')
            ->count();

        $this->assertGreaterThan(0, $count, sprintf(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
        ));

        return $this;
    }

    /**
     * Assert that a given where condition matches a soft deleted record
     * From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
     *
     * @param string $table
     * @param array  $data
     * @param string $connection
     *
     * @return $this
     */
    protected function assertIsSoftDeletedInDatabase($table, array $data, $connection = null)

    {
        $database = $this->app->make('db');

        $connection = $connection ?: $database->getDefaultConnection();

        $count = $database->connection($connection)
            ->table($table)
            ->where($data)
            ->whereNotNull('deleted_at')
            ->count();

        $this->assertGreaterThan(0, $count, sprintf(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
        ));

        return $this;
    }

    /**
     * Assert that a given where condition exists in the database and return the first occurrence.
     *
     * @param string $table
     * @param array  $data
     * @param string $connection
     *
     * @return Model
     */
    protected function assertDatabaseHasOnceAndReturnFirst($table, array $data, $connection = null)
    {
        $constraint = new HasInDatabaseOnce($this->getConnection($connection), $data);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertThat(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $table, $constraint
        );

        $entry = $constraint->getEntry();

        return $entry;
    }
}


1		<?php
2		/*
3		* laravel-money-manager-ex
4		*
5		* This File belongs to to Project laravel-money-manager-ex
6		*
7		* @author Oliver Kaufmann <[email protected]>
8		* @version 1.0
9		*/
10
11		namespace Tests\utils;
12
13		use App\Models\Model;
14
15		trait DbUtils
16		{
17		/**
18		* Assert that a given where condition does not matches a soft deleted record
19		* From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
20		*
21		* @param string $table
22		* @param array $data
23		* @param string $connection
24		*
25		* @return $this
26		*/
27	View Code Duplication	protected function assertSeeIsNotSoftDeletedInDatabase($table, array $data, $connection = null)
		0 ignored issues – show Duplication introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$database = $this->app->make('db');
		0 ignored issues – show Bug introduced 2017-06-07 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30
31		$connection = $connection ?: $database->getDefaultConnection();
32
33		$count = $database->connection($connection)
34		->table($table)
35		->where($data)
36		->whereNull('deleted_at')
37		->count();
38
39		$this->assertGreaterThan(0, $count, sprintf(
		0 ignored issues – show Bug introduced 2017-06-07 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `assertGreaterThan()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40		'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
41		));
42
43		return $this;
44		}
45
46		/**
47		* Assert that a given where condition matches a soft deleted record
48		* From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
49		*
50		* @param string $table
51		* @param array $data
52		* @param string $connection
53		*
54		* @return $this
55		*/
56	View Code Duplication	protected function assertIsSoftDeletedInDatabase($table, array $data, $connection = null)
		0 ignored issues – show Duplication introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$database = $this->app->make('db');
59
60		$connection = $connection ?: $database->getDefaultConnection();
61
62		$count = $database->connection($connection)
63		->table($table)
64		->where($data)
65		->whereNotNull('deleted_at')
66		->count();
67
68		$this->assertGreaterThan(0, $count, sprintf(
		0 ignored issues – show Bug introduced 2017-06-07 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `assertGreaterThan()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
69		'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
70		));
71
72		return $this;
73		}
74
75		/**
76		* Assert that a given where condition exists in the database and return the first occurrence.
77		*
78		* @param string $table
79		* @param array $data
80		* @param string $connection
81		*
82		* @return Model
83		*/
84		protected function assertDatabaseHasOnceAndReturnFirst($table, array $data, $connection = null)
85		{
86		$constraint = new HasInDatabaseOnce($this->getConnection($connection), $data);
		0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getConnection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
87		$this->assertThat(
		0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `assertThat()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
88		$table, $constraint
89		);
90
91		$entry = $constraint->getEntry();
92
93		return $entry;
94		}
95		}
96

GitHub Access Token became invalid

Issues (387)

Security Analysis not enabled

tests/utils/DbUtils.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

Issues (387)

Security Analysis not enabled

tests/utils/DbUtils.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like