Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | trait DbUtils |
||
16 | { |
||
17 | /** |
||
18 | * Assert that a given where condition does not matches a soft deleted record |
||
19 | * From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row. |
||
20 | * |
||
21 | * @param string $table |
||
22 | * @param array $data |
||
23 | * @param string $connection |
||
24 | * |
||
25 | * @return $this |
||
26 | */ |
||
27 | View Code Duplication | protected function assertSeeIsNotSoftDeletedInDatabase($table, array $data, $connection = null) |
|
45 | |||
46 | /** |
||
47 | * Assert that a given where condition matches a soft deleted record |
||
48 | * From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row. |
||
49 | * |
||
50 | * @param string $table |
||
51 | * @param array $data |
||
52 | * @param string $connection |
||
53 | * |
||
54 | * @return $this |
||
55 | */ |
||
56 | View Code Duplication | protected function assertIsSoftDeletedInDatabase($table, array $data, $connection = null) |
|
74 | |||
75 | /** |
||
76 | * Assert that a given where condition exists in the database and return the first occurrence. |
||
77 | * |
||
78 | * @param string $table |
||
79 | * @param array $data |
||
80 | * @param string $connection |
||
81 | * |
||
82 | * @return Model |
||
83 | */ |
||
84 | protected function assertDatabaseHasOnceAndReturnFirst($table, array $data, $connection = null) |
||
95 | } |
||
96 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.