TransactionController::create() - Code Metrics - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

TransactionController::create() A
last analyzed 2017-10-18 00:22 UTC

↳ Parent: TransactionController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use App\Http\Requests\TransactionRequest;
use App\Models\Transaction;
use App\Services\TransactionService;
use Auth;
use Illuminate\Http\Request;

class TransactionController extends Controller
{
    /**
     * @var TransactionService
     */
    private $transactionService;

    /**
     * TransactionController constructor.
     *
     * @param TransactionService $transactionService
     */
    public function __construct(TransactionService $transactionService)
    {
        $this->transactionService = $transactionService;
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('transactions.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param TransactionRequest|Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(TransactionRequest $request)

    {
        $files = $request->file('attachments');

        $data = collect($request->all());
        $this->transactionService->createTransactionWithUsage(Auth::user(), $data, $files);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return redirect()->route('home')->with('status', __('mmex.created'));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param TransactionRequest|Request $request
     * @param int                        $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(TransactionRequest $request, $id)

    {
        $files = $request->file('attachments');

        $data = collect($request->all());
        $this->transactionService->updateTransactionWithUsage(Auth::user(), $id, $data, $files);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return redirect()->route('home')->with('status', __('mmex.updated'));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        abort_unless(Auth::user()->transactions()->whereId($id)->exists(), 403);

        Transaction::destroy($id);
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\Http\Requests\TransactionRequest;
6		use App\Models\Transaction;
7		use App\Services\TransactionService;
8		use Auth;
9		use Illuminate\Http\Request;
10
11		class TransactionController extends Controller
12		{
13		/**
14		* @var TransactionService
15		*/
16		private $transactionService;
17
18		/**
19		* TransactionController constructor.
20		*
21		* @param TransactionService $transactionService
22		*/
23		public function __construct(TransactionService $transactionService)
24		{
25		$this->transactionService = $transactionService;
26		}
27
28		/**
29		* Show the form for creating a new resource.
30		*
31		* @return \Illuminate\Http\Response
32		*/
33		public function create()
34		{
35		return view('transactions.create');
36		}
37
38		/**
39		* Store a newly created resource in storage.
40		*
41		* @param TransactionRequest\|Request $request
42		*
43		* @return \Illuminate\Http\Response
44		*/
45	View Code Duplication	public function store(TransactionRequest $request)
		0 ignored issues – show Duplication introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		$files = $request->file('attachments');
48
49		$data = collect($request->all());
50		$this->transactionService->createTransactionWithUsage(Auth::user(), $data, $files);
		0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report It seems like `$files` defined by `$request->file('attachments')` on line `47` can also be of type `object<Illuminate\Http\UploadedFile>`; however, `App\Services\Transaction...eTransactionWithUsage()` does only seem to accept `null\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
51
52		return redirect()->route('home')->with('status', __('mmex.created'));
53		}
54
55		/**
56		* Update the specified resource in storage.
57		*
58		* @param TransactionRequest\|Request $request
59		* @param int $id
60		*
61		* @return \Illuminate\Http\Response
62		*/
63	View Code Duplication	public function update(TransactionRequest $request, $id)
		0 ignored issues – show Duplication introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$files = $request->file('attachments');
66
67		$data = collect($request->all());
68		$this->transactionService->updateTransactionWithUsage(Auth::user(), $id, $data, $files);
		0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report It seems like `$files` defined by `$request->file('attachments')` on line `65` can also be of type `object<Illuminate\Http\UploadedFile>`; however, `App\Services\Transaction...eTransactionWithUsage()` does only seem to accept `null\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
69
70		return redirect()->route('home')->with('status', __('mmex.updated'));
71		}
72
73		/**
74		* Remove the specified resource from storage.
75		*
76		* @param int $id
77		*
78		* @return \Illuminate\Http\Response
79		*/
80		public function destroy($id)
81		{
82		abort_unless(Auth::user()->transactions()->whereId($id)->exists(), 403);
83
84		Transaction::destroy($id);
85		}
86		}
87

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

TransactionController::create() A last analyzed 2017-10-18 00:22 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TransactionController::create() A
last analyzed 2017-10-18 00:22 UTC