App\Http\Controllers\TransactionController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	76
Duplicated Lines	23.68 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	3
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	create()	0	4	1
A	store()	9	9	1
A	update()	9	9	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\TransactionRequest;
use App\Models\Transaction;
use App\Services\TransactionService;
use Auth;
use Illuminate\Http\Request;

class TransactionController extends Controller
{
    /**
     * @var TransactionService
     */
    private $transactionService;

    /**
     * TransactionController constructor.
     *
     * @param TransactionService $transactionService
     */
    public function __construct(TransactionService $transactionService)
    {
        $this->transactionService = $transactionService;
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('transactions.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param TransactionRequest|Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(TransactionRequest $request)

This method seems to be duplicated in your project.

    {
        $files = $request->file('attachments');

        $data = collect($request->all());
        $this->transactionService->createTransactionWithUsage(Auth::user(), $data, $files);

It seems like $files defined by $request->file('attachments') on line 47 can also be of type object<Illuminate\Http\UploadedFile>; however, App\Services\TransactionService::createTransactionWithUsage() does only seem to accept null|array, maybe add an additional type check?

        return redirect()->route('home')->with('status', __('mmex.created'));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param TransactionRequest|Request $request
     * @param int                        $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(TransactionRequest $request, $id)

This method seems to be duplicated in your project.

    {
        $files = $request->file('attachments');

        $data = collect($request->all());
        $this->transactionService->updateTransactionWithUsage(Auth::user(), $id, $data, $files);

It seems like $files defined by $request->file('attachments') on line 65 can also be of type object<Illuminate\Http\UploadedFile>; however, App\Services\TransactionService::updateTransactionWithUsage() does only seem to accept null|array, maybe add an additional type check?

        return redirect()->route('home')->with('status', __('mmex.updated'));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        abort_unless(Auth::user()->transactions()->whereId($id)->exists(), 403);

        Transaction::destroy($id);
    }
}