AddressRepository::findByProvinceName() - Code Metrics - odiseoteam/SyliusReportPlugin - Measure and Improve Code Quality continuously with Scrutinizer

AddressRepository::findByProvinceName() A
last analyzed 2021-10-12 13:38 UTC

↳ Parent: AddressRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	7
c	1
b	0
f	1
nc	1
nop	1
dl	0
loc	9
rs	10

<?php

declare(strict_types=1);

namespace Odiseo\SyliusReportPlugin\Repository;

use Sylius\Bundle\CoreBundle\Doctrine\ORM\AddressRepository as BaseAddressRepository;
use Sylius\Component\Addressing\Model\Province;

/**
 * @author Diego D'amico <[email protected]>
 */
class AddressRepository extends BaseAddressRepository implements AddressRepositoryInterface
{
    /**
     * @inheritdoc
     */
    public function findByCityName(string $cityName): array
    {
        return $this->createQueryBuilder('o')

            ->andWhere('o.city LIKE :city')
            ->setParameter('city', '%' . $cityName . '%')
            ->getQuery()
            ->getResult()
        ;
    }

    /**
     * @inheritdoc
     */
    public function findByProvinceName(string $provinceName): array
    {
        return $this->createQueryBuilder('o')

            ->leftJoin(Province::class, 'p', 'WITH', 'p.code = o.provinceCode')
            ->where('o.provinceName LIKE :province')
            ->orWhere('p.name LIKE :province')
            ->setParameter('province', '%' . $provinceName . '%')
            ->getQuery()
            ->getResult()
        ;
    }

    /**
     * @inheritdoc
     */
    public function findByPostcode(string $postcode): array
    {
        return $this->createQueryBuilder('o')

            ->andWhere('o.postcode LIKE :postcode')
            ->setParameter('postcode', '%' . $postcode . '%')
            ->getQuery()
            ->getResult()
        ;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Odiseo\SyliusReportPlugin\Repository;
6
7			use Sylius\Bundle\CoreBundle\Doctrine\ORM\AddressRepository as BaseAddressRepository;
8			use Sylius\Component\Addressing\Model\Province;
9
10			/**
11			* @author Diego D'amico <[email protected]>
12			*/
13			class AddressRepository extends BaseAddressRepository implements AddressRepositoryInterface
14			{
15			/**
16			* @inheritdoc
17			*/
18			public function findByCityName(string $cityName): array
19			{
20			return $this->createQueryBuilder('o')
			0 ignored issues – show Bug Best Practice introduced 2021-08-31 16:51 UTC by Report Bug Copy Issue Report The expression `return $this->createQuer...getQuery()->getResult()` could return the type `integer` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
21			->andWhere('o.city LIKE :city')
22			->setParameter('city', '%' . $cityName . '%')
23			->getQuery()
24			->getResult()
25			;
26			}
27
28			/**
29			* @inheritdoc
30			*/
31			public function findByProvinceName(string $provinceName): array
32			{
33			return $this->createQueryBuilder('o')
			0 ignored issues – show Bug Best Practice introduced 2021-08-31 16:51 UTC by Report Bug Copy Issue Report The expression `return $this->createQuer...getQuery()->getResult()` could return the type `integer` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
34			->leftJoin(Province::class, 'p', 'WITH', 'p.code = o.provinceCode')
35			->where('o.provinceName LIKE :province')
36			->orWhere('p.name LIKE :province')
37			->setParameter('province', '%' . $provinceName . '%')
38			->getQuery()
39			->getResult()
40			;
41			}
42
43			/**
44			* @inheritdoc
45			*/
46			public function findByPostcode(string $postcode): array
47			{
48			return $this->createQueryBuilder('o')
			0 ignored issues – show Bug Best Practice introduced 2021-08-31 16:51 UTC by Report Bug Copy Issue Report The expression `return $this->createQuer...getQuery()->getResult()` could return the type `integer` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
49			->andWhere('o.postcode LIKE :postcode')
50			->setParameter('postcode', '%' . $postcode . '%')
51			->getQuery()
52			->getResult()
53			;
54			}
55			}
56

odiseoteam / SyliusReportPlugin

GitHub Access Token became invalid

AddressRepository::findByProvinceName() A last analyzed 2021-10-12 13:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AddressRepository::findByProvinceName() A
last analyzed 2021-10-12 13:38 UTC