Odiseo\SyliusReportPlugin\Repository\AddressRepository

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	findByProvinceName()	0	9	1
A	findByPostcode()	0	7	1
A	findByCityName()	0	7	1

<?php

declare(strict_types=1);

namespace Odiseo\SyliusReportPlugin\Repository;

use Sylius\Bundle\CoreBundle\Doctrine\ORM\AddressRepository as BaseAddressRepository;
use Sylius\Component\Addressing\Model\Province;

/**
 * @author Diego D'amico <diego@odiseo.com.ar>
 */
class AddressRepository extends BaseAddressRepository implements AddressRepositoryInterface
{
    /**
     * @inheritdoc
     */
    public function findByCityName(string $cityName): array
    {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->andWhere('o.city LIKE :city')->setParameter('city', '%' . $cityName . '%')->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->andWhere('o.city LIKE :city')
            ->setParameter('city', '%' . $cityName . '%')
            ->getQuery()
            ->getResult()
        ;
    }

    /**
     * @inheritdoc
     */
    public function findByProvinceName(string $provinceName): array
    {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->leftJoin(Sylius\Component\Addressing\Model\Province::class, 'p', 'WITH', 'p.code = o.provinceCode')->where('o.provinceName LIKE :province')->orWhere('p.name LIKE :province')->setParameter('province', '%' . $provinceName . '%')->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->leftJoin(Province::class, 'p', 'WITH', 'p.code = o.provinceCode')
            ->where('o.provinceName LIKE :province')
            ->orWhere('p.name LIKE :province')
            ->setParameter('province', '%' . $provinceName . '%')
            ->getQuery()
            ->getResult()
        ;
    }

    /**
     * @inheritdoc
     */
    public function findByPostcode(string $postcode): array
    {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->andWhere('o.postcode LIKE :postcode')->setParameter('postcode', '%' . $postcode . '%')->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->andWhere('o.postcode LIKE :postcode')
            ->setParameter('postcode', '%' . $postcode . '%')
            ->getQuery()
            ->getResult()
        ;
    }
}