Passed
Pull Request — v1 (#22)
by
unknown
07:21 queued 40s
created
src/variables/TranscoderVariable.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@
 block discarded – undo
155 155
     {
156 156
         $result = '';
157 157
         $filePath = parse_url($url, PHP_URL_PATH);
158
-        $filePath = $_SERVER['DOCUMENT_ROOT'] . $filePath;
158
+        $filePath = $_SERVER['DOCUMENT_ROOT'].$filePath;
159 159
         if (file_exists($filePath)) {
160 160
             $urlParams = [
161 161
                 'url' => $url,
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      *
31 31
      * @param $filePath
32 32
      * @param $videoOptions
33
-	 * @bool $generate 
33
+     * @bool $generate 
34 34
      *
35 35
      * @return string
36 36
      */
Please login to merge, or discard this patch.
src/controllers/DefaultController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -84,12 +84,12 @@  discard block
 block discarded – undo
84 84
 
85 85
                     // rawDuration is in 00:00:00.00 format. This converts it to seconds.
86 86
                     $ar = array_reverse(explode(':', $rawDuration));
87
-                    $duration = (float)$ar[0];
87
+                    $duration = (float) $ar[0];
88 88
                     if (!empty($ar[1])) {
89
-                        $duration += (int)$ar[1] * 60;
89
+                        $duration += (int) $ar[1] * 60;
90 90
                     }
91 91
                     if (!empty($ar[2])) {
92
-                        $duration += (int)$ar[2] * 60 * 60;
92
+                        $duration += (int) $ar[2] * 60 * 60;
93 93
                     }
94 94
                 } else {
95 95
                     $duration = 'unknown'; // with GIF as input, duration is unknown
@@ -106,12 +106,12 @@  discard block
 block discarded – undo
106 106
 
107 107
                 //rawTime is in 00:00:00.00 format. This converts it to seconds.
108 108
                 $ar = array_reverse(explode(':', $rawTime));
109
-                $time = (float)$ar[0];
109
+                $time = (float) $ar[0];
110 110
                 if (!empty($ar[1])) {
111
-                    $time += (int)$ar[1] * 60;
111
+                    $time += (int) $ar[1] * 60;
112 112
                 }
113 113
                 if (!empty($ar[2])) {
114
-                    $time += (int)$ar[2] * 60 * 60;
114
+                    $time += (int) $ar[2] * 60 * 60;
115 115
                 }
116 116
 
117 117
                 //calculate the progress
Please login to merge, or discard this patch.
src/helpers/Manifest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
         $cache = Craft::$app->getCache();
301 301
         $file = $cache->getOrSet(
302 302
             self::CACHE_KEY.$path,
303
-            function () use ($path) {
303
+            function() use ($path) {
304 304
                 $result = null;
305 305
                 $string = @file_get_contents($path);
306 306
                 if ($string) {
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
     protected static function combinePaths(string ...$paths): string
328 328
     {
329 329
         $last_key = \count($paths) - 1;
330
-        array_walk($paths, function (&$val, $key) use ($last_key) {
330
+        array_walk($paths, function(&$val, $key) use ($last_key) {
331 331
             switch ($key) {
332 332
                 case 0:
333 333
                     $val = rtrim($val, '/ ');
Please login to merge, or discard this patch.
src/services/Transcode.php 2 patches
Indentation   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -95,14 +95,14 @@  discard block
 block discarded – undo
95 95
 	    	    
96 96
         $result = '';
97 97
         $settings = Transcoder::$plugin->getSettings();
98
-		$subfolder = '';
98
+        $subfolder = '';
99 99
 		
100
-		// sub folder check
101
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
102
-			$subfolder = $filePath->folderPath;
103
-		}
100
+        // sub folder check
101
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
102
+            $subfolder = $filePath->folderPath;
103
+        }
104 104
 
105
-		// file path
105
+        // file path
106 106
         $filePath = $this->getAssetPath($filePath);
107 107
 				
108 108
         if (!empty($filePath)) {
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
                 
204 204
             // skip encoding
205 205
             } elseif (!$generate) {
206
-	            $result = "";
206
+                $result = "";
207 207
             } else {
208 208
                 // Kick off the transcoding
209 209
                 $pid = $this->executeShellCommand($ffmpegCmd);
@@ -232,12 +232,12 @@  discard block
 block discarded – undo
232 232
     {		
233 233
         $result = null;
234 234
         $settings = Transcoder::$plugin->getSettings();
235
-		$subfolder = '';
235
+        $subfolder = '';
236 236
 		
237
-		// sub folder check
238
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
239
-			$subfolder = $filePath->folderPath;
240
-		}
237
+        // sub folder check
238
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
239
+            $subfolder = $filePath->folderPath;
240
+        }
241 241
 		        
242 242
         $filePath = $this->getAssetPath($filePath);
243 243
 
@@ -324,12 +324,12 @@  discard block
 block discarded – undo
324 324
     {
325 325
         $result = '';
326 326
         $settings = Transcoder::$plugin->getSettings();
327
-		$subfolder = '';
327
+        $subfolder = '';
328 328
 		
329
-		// sub folder check
330
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
331
-			$subfolder = $filePath->folderPath;
332
-		}
329
+        // sub folder check
330
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
331
+            $subfolder = $filePath->folderPath;
332
+        }
333 333
 		
334 334
         $filePath = $this->getAssetPath($filePath);
335 335
 
@@ -588,12 +588,12 @@  discard block
 block discarded – undo
588 588
     {
589 589
         $result = '';
590 590
         $settings = Transcoder::$plugin->getSettings();
591
-		$subfolder = '';
591
+        $subfolder = '';
592 592
 		
593
-		// sub folder check
594
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
595
-			$subfolder = $filePath->folderPath;
596
-		}
593
+        // sub folder check
594
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
595
+            $subfolder = $filePath->folderPath;
596
+        }
597 597
 		        
598 598
         $filePath = $this->getAssetPath($filePath);
599 599
 
Please login to merge, or discard this patch.
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 		$subfolder = '';
99 99
 		
100 100
 		// sub folder check
101
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
101
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
102 102
 			$subfolder = $filePath->folderPath;
103 103
 		}
104 104
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
         $filePath = $this->getAssetPath($filePath);
107 107
 				
108 108
         if (!empty($filePath)) {
109
-            $destVideoPath = $settings['transcoderPaths']['video'] . $subfolder ?? $settings['transcoderPaths']['default'];
109
+            $destVideoPath = $settings['transcoderPaths']['video'].$subfolder ?? $settings['transcoderPaths']['default'];
110 110
             $destVideoPath = Craft::getAlias($destVideoPath);           
111 111
             $videoOptions = $this->coalesceOptions('defaultVideoOptions', $videoOptions);
112 112
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
             // If the video file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
200 200
             if (file_exists($destVideoPath) && (@filemtime($destVideoPath) >= @filemtime($filePath))) {
201
-                $url = $settings['transcoderUrls']['video'] . $subfolder ?? $settings['transcoderUrls']['default'];
201
+                $url = $settings['transcoderUrls']['video'].$subfolder ?? $settings['transcoderUrls']['default'];
202 202
                 $result = Craft::getAlias($url).$destVideoFile;
203 203
                 
204 204
             // skip encoding
@@ -235,14 +235,14 @@  discard block
 block discarded – undo
235 235
 		$subfolder = '';
236 236
 		
237 237
 		// sub folder check
238
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
238
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
239 239
 			$subfolder = $filePath->folderPath;
240 240
 		}
241 241
 		        
242 242
         $filePath = $this->getAssetPath($filePath);
243 243
 
244 244
         if (!empty($filePath)) {
245
-            $destThumbnailPath = $settings['transcoderPaths']['thumbnail'] . $subfolder ?? $settings['transcoderPaths']['default'];
245
+            $destThumbnailPath = $settings['transcoderPaths']['thumbnail'].$subfolder ?? $settings['transcoderPaths']['default'];
246 246
             $destThumbnailPath = Craft::getAlias($destThumbnailPath);
247 247
 
248 248
             $thumbnailOptions = $this->coalesceOptions('defaultThumbnailOptions', $thumbnailOptions);
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
             if ($asPath) {
304 304
                 $result = $destThumbnailPath;
305 305
             } else {
306
-                $url = $settings['transcoderUrls']['thumbnail'] . $subfolder ?? $settings['transcoderUrls']['default'];
306
+                $url = $settings['transcoderUrls']['thumbnail'].$subfolder ?? $settings['transcoderUrls']['default'];
307 307
                 $result = Craft::getAlias($url).$destThumbnailFile;
308 308
             }
309 309
         }
@@ -327,14 +327,14 @@  discard block
 block discarded – undo
327 327
 		$subfolder = '';
328 328
 		
329 329
 		// sub folder check
330
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
330
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
331 331
 			$subfolder = $filePath->folderPath;
332 332
 		}
333 333
 		
334 334
         $filePath = $this->getAssetPath($filePath);
335 335
 
336 336
         if (!empty($filePath)) {
337
-            $destAudioPath = $settings['transcoderPaths']['audio'] . $subfolder ?? $settings['transcoderPaths']['default'];
337
+            $destAudioPath = $settings['transcoderPaths']['audio'].$subfolder ?? $settings['transcoderPaths']['default'];
338 338
             $destAudioPath = Craft::getAlias($destAudioPath);
339 339
 
340 340
             $audioOptions = $this->coalesceOptions('defaultAudioOptions', $audioOptions);
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
                 .' -y '.escapeshellarg($destAudioPath);
393 393
             
394 394
             if (!$audioOptions['synchronous']) {
395
-                $ffmpegCmd .=' 1> '.$progressFile.' 2>&1 & echo $!';
395
+                $ffmpegCmd .= ' 1> '.$progressFile.' 2>&1 & echo $!';
396 396
                 // Make sure there isn't a lockfile for this audio file already
397 397
                 $lockFile = sys_get_temp_dir().DIRECTORY_SEPARATOR.$destAudioFile.'.lock';
398 398
                 $oldPid = @file_get_contents($lockFile);
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
 
410 410
             // If the audio file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
411 411
             if (file_exists($destAudioPath) && (@filemtime($destAudioPath) >= @filemtime($filePath))) {
412
-                $url = $settings['transcoderUrls']['audio'] . $subfolder ?? $settings['transcoderUrls']['default'];
412
+                $url = $settings['transcoderUrls']['audio'].$subfolder ?? $settings['transcoderUrls']['default'];
413 413
                 $result = Craft::getAlias($url).$destAudioFile;
414 414
             } else {
415 415
                 // Kick off the transcoding
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
                 
418 418
                 if ($audioOptions['synchronous']) {
419 419
                     Craft::info($ffmpegCmd, __METHOD__);
420
-                    $url = $settings['transcoderUrls']['audio'] . $subfolder ?? $settings['transcoderUrls']['default'];
420
+                    $url = $settings['transcoderUrls']['audio'].$subfolder ?? $settings['transcoderUrls']['default'];
421 421
                     $result = Craft::getAlias($url).$destAudioFile;
422 422
                 } else {
423 423
                     Craft::info($ffmpegCmd."\nffmpeg PID: ".$pid, __METHOD__);
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
                     && (strpos($summaryResult['videoFrameRate'], '/') !== false)
493 493
                 ) {
494 494
                     $parts = explode('/', $summaryResult['videoFrameRate']);
495
-                    $summaryResult['videoFrameRate'] = (float)$parts[0] / (float)$parts[1];
495
+                    $summaryResult['videoFrameRate'] = (float) $parts[0] / (float) $parts[1];
496 496
                 }
497 497
                 $result = $summaryResult;
498 498
             }
@@ -604,7 +604,7 @@  discard block
 block discarded – undo
604 604
 		$subfolder = '';
605 605
 		
606 606
 		// sub folder check
607
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
607
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
608 608
 			$subfolder = $filePath->folderPath;
609 609
 		}
610 610
 		        
@@ -612,7 +612,7 @@  discard block
 block discarded – undo
612 612
 
613 613
         if (!empty($filePath)) {
614 614
             // Dest path
615
-            $destVideoPath = $settings['transcoderPaths']['gif'] . $subfolder ?? $settings['transcoderPaths']['default'];
615
+            $destVideoPath = $settings['transcoderPaths']['gif'].$subfolder ?? $settings['transcoderPaths']['default'];
616 616
             $destVideoPath = Craft::getAlias($destVideoPath);
617 617
 
618 618
             // Options
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
 
667 667
             // If the video file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
668 668
             if (file_exists($destVideoPath) && (@filemtime($destVideoPath) >= @filemtime($filePath))) {
669
-                $url = $settings['transcoderUrls']['gif'] . $subfolder ?? $settings['transcoderUrls']['default'];
669
+                $url = $settings['transcoderUrls']['gif'].$subfolder ?? $settings['transcoderUrls']['default'];
670 670
                 $result = Craft::getAlias($url).$destVideoFile;
671 671
             } else {
672 672
                 // Kick off the transcoding
@@ -752,14 +752,14 @@  discard block
 block discarded – undo
752 752
                 // If it's local, get a path to the file
753 753
                 if ($assetVolume instanceof Local) {
754 754
                     $sourcePath = rtrim($assetVolume->path, DIRECTORY_SEPARATOR);
755
-                    $sourcePath .= '' === $sourcePath ? '': DIRECTORY_SEPARATOR;
755
+                    $sourcePath .= '' === $sourcePath ? '' : DIRECTORY_SEPARATOR;
756 756
                     $folderPath = '';
757 757
                     try {
758 758
                         $folderPath = rtrim($asset->getFolder()->path, DIRECTORY_SEPARATOR);
759 759
                     } catch (InvalidConfigException $e) {
760 760
                         Craft::error($e->getMessage(), __METHOD__);
761 761
                     }
762
-                    $folderPath .= '' === $folderPath ? '': DIRECTORY_SEPARATOR;
762
+                    $folderPath .= '' === $folderPath ? '' : DIRECTORY_SEPARATOR;
763 763
 
764 764
                     $filePath = $sourcePath.$folderPath.$asset->filename;
765 765
                 } else {
Please login to merge, or discard this patch.
src/Transcoder.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
         Event::on(
132 132
             CraftVariable::class,
133 133
             CraftVariable::EVENT_INIT,
134
-            function (Event $event) {
134
+            function(Event $event) {
135 135
                 /** @var CraftVariable $variable */
136 136
                 $variable = $event->sender;
137 137
                 $variable->set('transcoder', TranscoderVariable::class);
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
         Event::on(
150 150
             Assets::class,
151 151
             Assets::EVENT_GET_THUMB_PATH,
152
-            function (AssetThumbEvent $event) {
152
+            function(AssetThumbEvent $event) {
153 153
                 Craft::debug(
154 154
                     'Assets::EVENT_GET_THUMB_PATH',
155 155
                     __METHOD__
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
             Event::on(
167 167
                 ClearCaches::class,
168 168
                 ClearCaches::EVENT_REGISTER_CACHE_OPTIONS,
169
-                function (RegisterCacheOptionsEvent $event) {
169
+                function(RegisterCacheOptionsEvent $event) {
170 170
                     $event->options[] = [
171 171
                         'key' => 'transcoder',
172 172
                         'label' => Craft::t('transcoder', 'Transcoder caches'),
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
         Event::on(
180 180
             Plugins::class,
181 181
             Plugins::EVENT_AFTER_INSTALL_PLUGIN,
182
-            function (PluginEvent $event) {
182
+            function(PluginEvent $event) {
183 183
                 if ($event->plugin === $this) {
184 184
                     $request = Craft::$app->getRequest();
185 185
                     if ($request->isCpRequest) {
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
         Event::on(
205 205
             UrlManager::class,
206 206
             UrlManager::EVENT_REGISTER_SITE_URL_RULES,
207
-            function (RegisterUrlRulesEvent $event) {
207
+            function(RegisterUrlRulesEvent $event) {
208 208
                 Craft::debug(
209 209
                     'UrlManager::EVENT_REGISTER_SITE_URL_RULES',
210 210
                     __METHOD__
Please login to merge, or discard this patch.