Passed
Pull Request — v1 (#11)
by
unknown
09:01 queued 05:34
created
src/variables/TranscoderVariable.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      *
31 31
      * @param $filePath
32 32
      * @param $videoOptions
33
-	 * @bool $generate 
33
+     * @bool $generate 
34 34
      *
35 35
      * @return string
36 36
      */
Please login to merge, or discard this patch.
src/services/Transcode.php 2 patches
Indentation   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -95,14 +95,14 @@  discard block
 block discarded – undo
95 95
 	    	    
96 96
         $result = '';
97 97
         $settings = Transcoder::$plugin->getSettings();
98
-		$subfolder = '';
98
+        $subfolder = '';
99 99
 		
100
-		// sub folder check
101
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
102
-			$subfolder = $filePath->folderPath;
103
-		}
100
+        // sub folder check
101
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
102
+            $subfolder = $filePath->folderPath;
103
+        }
104 104
 
105
-		// file path
105
+        // file path
106 106
         $filePath = $this->getAssetPath($filePath);
107 107
 				
108 108
         if (!empty($filePath)) {
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
                 
204 204
             // skip encoding
205 205
             } elseif (!$generate) {
206
-	            $result = "";
206
+                $result = "";
207 207
             } else {
208 208
                 // Kick off the transcoding
209 209
                 $pid = $this->executeShellCommand($ffmpegCmd);
@@ -232,12 +232,12 @@  discard block
 block discarded – undo
232 232
     {		
233 233
         $result = null;
234 234
         $settings = Transcoder::$plugin->getSettings();
235
-		$subfolder = '';
235
+        $subfolder = '';
236 236
 		
237
-		// sub folder check
238
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
239
-			$subfolder = $filePath->folderPath;
240
-		}
237
+        // sub folder check
238
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
239
+            $subfolder = $filePath->folderPath;
240
+        }
241 241
 		        
242 242
         $filePath = $this->getAssetPath($filePath);
243 243
 
@@ -324,12 +324,12 @@  discard block
 block discarded – undo
324 324
     {
325 325
         $result = '';
326 326
         $settings = Transcoder::$plugin->getSettings();
327
-		$subfolder = '';
327
+        $subfolder = '';
328 328
 		
329
-		// sub folder check
330
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
331
-			$subfolder = $filePath->folderPath;
332
-		}
329
+        // sub folder check
330
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
331
+            $subfolder = $filePath->folderPath;
332
+        }
333 333
 		
334 334
         $filePath = $this->getAssetPath($filePath);
335 335
 
@@ -588,12 +588,12 @@  discard block
 block discarded – undo
588 588
     {
589 589
         $result = '';
590 590
         $settings = Transcoder::$plugin->getSettings();
591
-		$subfolder = '';
591
+        $subfolder = '';
592 592
 		
593
-		// sub folder check
594
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
595
-			$subfolder = $filePath->folderPath;
596
-		}
593
+        // sub folder check
594
+        if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
595
+            $subfolder = $filePath->folderPath;
596
+        }
597 597
 		        
598 598
         $filePath = $this->getAssetPath($filePath);
599 599
 
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 		$subfolder = '';
99 99
 		
100 100
 		// sub folder check
101
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
101
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
102 102
 			$subfolder = $filePath->folderPath;
103 103
 		}
104 104
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
         $filePath = $this->getAssetPath($filePath);
107 107
 				
108 108
         if (!empty($filePath)) {
109
-            $destVideoPath = $settings['transcoderPaths']['video'] . $subfolder ?? $settings['transcoderPaths']['default'];
109
+            $destVideoPath = $settings['transcoderPaths']['video'].$subfolder ?? $settings['transcoderPaths']['default'];
110 110
             $destVideoPath = Craft::getAlias($destVideoPath);           
111 111
             $videoOptions = $this->coalesceOptions('defaultVideoOptions', $videoOptions);
112 112
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
             // If the video file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
200 200
             if (file_exists($destVideoPath) && (@filemtime($destVideoPath) >= @filemtime($filePath))) {
201
-                $url = $settings['transcoderUrls']['video'] . $subfolder ?? $settings['transcoderUrls']['default'];
201
+                $url = $settings['transcoderUrls']['video'].$subfolder ?? $settings['transcoderUrls']['default'];
202 202
                 $result = Craft::getAlias($url).$destVideoFile;
203 203
                 
204 204
             // skip encoding
@@ -235,14 +235,14 @@  discard block
 block discarded – undo
235 235
 		$subfolder = '';
236 236
 		
237 237
 		// sub folder check
238
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
238
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
239 239
 			$subfolder = $filePath->folderPath;
240 240
 		}
241 241
 		        
242 242
         $filePath = $this->getAssetPath($filePath);
243 243
 
244 244
         if (!empty($filePath)) {
245
-            $destThumbnailPath = $settings['transcoderPaths']['thumbnail'] . $subfolder ?? $settings['transcoderPaths']['default'];
245
+            $destThumbnailPath = $settings['transcoderPaths']['thumbnail'].$subfolder ?? $settings['transcoderPaths']['default'];
246 246
             $destThumbnailPath = Craft::getAlias($destThumbnailPath);
247 247
 
248 248
             $thumbnailOptions = $this->coalesceOptions('defaultThumbnailOptions', $thumbnailOptions);
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
             if ($asPath) {
304 304
                 $result = $destThumbnailPath;
305 305
             } else {
306
-                $url = $settings['transcoderUrls']['thumbnail'] . $subfolder ?? $settings['transcoderUrls']['default'];
306
+                $url = $settings['transcoderUrls']['thumbnail'].$subfolder ?? $settings['transcoderUrls']['default'];
307 307
                 $result = Craft::getAlias($url).$destThumbnailFile;
308 308
             }
309 309
         }
@@ -327,14 +327,14 @@  discard block
 block discarded – undo
327 327
 		$subfolder = '';
328 328
 		
329 329
 		// sub folder check
330
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
330
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
331 331
 			$subfolder = $filePath->folderPath;
332 332
 		}
333 333
 		
334 334
         $filePath = $this->getAssetPath($filePath);
335 335
 
336 336
         if (!empty($filePath)) {
337
-            $destAudioPath = $settings['transcoderPaths']['audio'] . $subfolder ?? $settings['transcoderPaths']['default'];
337
+            $destAudioPath = $settings['transcoderPaths']['audio'].$subfolder ?? $settings['transcoderPaths']['default'];
338 338
             $destAudioPath = Craft::getAlias($destAudioPath);
339 339
 
340 340
             $audioOptions = $this->coalesceOptions('defaultAudioOptions', $audioOptions);
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
 
405 405
             // If the audio file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
406 406
             if (file_exists($destAudioPath) && (@filemtime($destAudioPath) >= @filemtime($filePath))) {
407
-                $url = $settings['transcoderUrls']['audio'] . $subfolder ?? $settings['transcoderUrls']['default'];
407
+                $url = $settings['transcoderUrls']['audio'].$subfolder ?? $settings['transcoderUrls']['default'];
408 408
                 $result = Craft::getAlias($url).$destAudioFile;
409 409
             } else {
410 410
                 // Kick off the transcoding
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
                     && (strpos($summaryResult['videoFrameRate'], '/') !== false)
480 480
                 ) {
481 481
                     $parts = explode('/', $summaryResult['videoFrameRate']);
482
-                    $summaryResult['videoFrameRate'] = (float)$parts[0] / (float)$parts[1];
482
+                    $summaryResult['videoFrameRate'] = (float) $parts[0] / (float) $parts[1];
483 483
                 }
484 484
                 $result = $summaryResult;
485 485
             }
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
 		$subfolder = '';
592 592
 		
593 593
 		// sub folder check
594
-		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
594
+		if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
595 595
 			$subfolder = $filePath->folderPath;
596 596
 		}
597 597
 		        
@@ -599,7 +599,7 @@  discard block
 block discarded – undo
599 599
 
600 600
         if (!empty($filePath)) {
601 601
             // Dest path
602
-            $destVideoPath = $settings['transcoderPaths']['gif'] . $subfolder ?? $settings['transcoderPaths']['default'];
602
+            $destVideoPath = $settings['transcoderPaths']['gif'].$subfolder ?? $settings['transcoderPaths']['default'];
603 603
             $destVideoPath = Craft::getAlias($destVideoPath);
604 604
 
605 605
             // Options
@@ -653,7 +653,7 @@  discard block
 block discarded – undo
653 653
 
654 654
             // If the video file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
655 655
             if (file_exists($destVideoPath) && (@filemtime($destVideoPath) >= @filemtime($filePath))) {
656
-                $url = $settings['transcoderUrls']['gif'] . $subfolder ?? $settings['transcoderUrls']['default'];
656
+                $url = $settings['transcoderUrls']['gif'].$subfolder ?? $settings['transcoderUrls']['default'];
657 657
                 $result = Craft::getAlias($url).$destVideoFile;
658 658
             } else {
659 659
                 // Kick off the transcoding
@@ -739,14 +739,14 @@  discard block
 block discarded – undo
739 739
                 // If it's local, get a path to the file
740 740
                 if ($assetVolume instanceof Local) {
741 741
                     $sourcePath = rtrim($assetVolume->path, DIRECTORY_SEPARATOR);
742
-                    $sourcePath .= '' === $sourcePath ? '': DIRECTORY_SEPARATOR;
742
+                    $sourcePath .= '' === $sourcePath ? '' : DIRECTORY_SEPARATOR;
743 743
                     $folderPath = '';
744 744
                     try {
745 745
                         $folderPath = rtrim($asset->getFolder()->path, DIRECTORY_SEPARATOR);
746 746
                     } catch (InvalidConfigException $e) {
747 747
                         Craft::error($e->getMessage(), __METHOD__);
748 748
                     }
749
-                    $folderPath .= '' === $folderPath ? '': DIRECTORY_SEPARATOR;
749
+                    $folderPath .= '' === $folderPath ? '' : DIRECTORY_SEPARATOR;
750 750
 
751 751
                     $filePath = $sourcePath.$folderPath.$asset->filename;
752 752
                 } else {
Please login to merge, or discard this patch.
src/config.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -57,11 +57,11 @@
 block discarded – undo
57 57
     // Use a md5 hash for the filenames instead of parameterized naming
58 58
     'useHashedNames' => false,
59 59
 
60
-	// if a upload location has a subfolder defined, add this to the transcoder paths too
61
-	'createSubfolders' => true,
60
+    // if a upload location has a subfolder defined, add this to the transcoder paths too
61
+    'createSubfolders' => true,
62 62
 	
63
-	// clear caches when somebody clears all caches from the CP?
64
-	'clearCaches' => false,
63
+    // clear caches when somebody clears all caches from the CP?
64
+    'clearCaches' => false,
65 65
 	
66 66
     // Preset video encoders
67 67
     'videoEncoders' => [
Please login to merge, or discard this patch.
src/Transcoder.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
         $transcoderPaths = Transcoder::$plugin->getSettings()->transcoderPaths;
92 92
         $clearCaches = Transcoder::$plugin->getSettings()->clearCaches;
93 93
         
94
-        if($clearCaches) {
94
+        if ($clearCaches) {
95 95
             foreach ($transcoderPaths as $key => $value) {
96 96
                 $dir = Craft::getAlias($value);
97 97
                 try {
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         Event::on(
134 134
             CraftVariable::class,
135 135
             CraftVariable::EVENT_INIT,
136
-            function (Event $event) {
136
+            function(Event $event) {
137 137
                 /** @var CraftVariable $variable */
138 138
                 $variable = $event->sender;
139 139
                 $variable->set('transcoder', TranscoderVariable::class);
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         Event::on(
151 151
             Assets::class,
152 152
             Assets::EVENT_GET_THUMB_PATH,
153
-            function (AssetThumbEvent $event) {
153
+            function(AssetThumbEvent $event) {
154 154
                 Craft::debug(
155 155
                     'Assets::EVENT_GET_THUMB_PATH',
156 156
                     __METHOD__
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
         Event::on(
167 167
             ClearCaches::class,
168 168
             ClearCaches::EVENT_REGISTER_CACHE_OPTIONS,
169
-            function (RegisterCacheOptionsEvent $event) {
169
+            function(RegisterCacheOptionsEvent $event) {
170 170
                 $event->options[] = [
171 171
                     'key' => 'transcoder',
172 172
                     'label' => Craft::t('transcoder', 'Transcoder caches'),
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
         Event::on(
179 179
             Plugins::class,
180 180
             Plugins::EVENT_AFTER_INSTALL_PLUGIN,
181
-            function (PluginEvent $event) {
181
+            function(PluginEvent $event) {
182 182
                 if ($event->plugin === $this) {
183 183
                     $request = Craft::$app->getRequest();
184 184
                     if ($request->isCpRequest) {
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
         Event::on(
204 204
             UrlManager::class,
205 205
             UrlManager::EVENT_REGISTER_SITE_URL_RULES,
206
-            function (RegisterUrlRulesEvent $event) {
206
+            function(RegisterUrlRulesEvent $event) {
207 207
                 Craft::debug(
208 208
                     'UrlManager::EVENT_REGISTER_SITE_URL_RULES',
209 209
                     __METHOD__
Please login to merge, or discard this patch.