View GitHub Repository craft-instantanalytics-ga4

Schedule Inspection
Subscribe
Passed
Push — develop-v3 ( b9b839...d1e783 )
by Andrew
05:38
created
Status
Category
Toggle Patches
src/services/ServicesTrait.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -33,8 +33,8 @@  discard block
 
 block discarded – undo
33 33 
         // so we can't extract it from the passed in $config
34 34 
         $majorVersion = '3';
35 35 
         // Dev server container name & port are based on the major version of this plugin
36 
-        $devPort = 3000 + (int)$majorVersion;
37 
-        $versionName = 'v' . $majorVersion;
36 
+        $devPort = 3000 + (int) $majorVersion;
37 
+        $versionName = 'v'.$majorVersion;
38 38 
         // Merge in the passed config, so it our config can be overridden by Plugins::pluginConfigs['vite']
39 39 
         // ref: https://github.com/craftcms/cms/issues/1989
40 40 
         $config = ArrayHelper::merge([
 
@@ -46,8 +46,8 @@  discard block
 
 block discarded – undo
46 46 
                     'assetClass' => InstantAnalyticsAsset::class,
47 47 
                     'checkDevServer' => true,
48 48 
                     'class' => VitePluginService::class,
49 
-                    'devServerInternal' => 'http://craft-instantanalytics-ga4-' . $versionName . '-buildchain-dev:' . $devPort,
50 
-                    'devServerPublic' => 'http://localhost:' . $devPort,
49 
+                    'devServerInternal' => 'http://craft-instantanalytics-ga4-'.$versionName.'-buildchain-dev:'.$devPort,
50 
+                    'devServerPublic' => 'http://localhost:'.$devPort,
51 51 
                     'errorEntry' => 'src/js/app.ts',
52 52 
                     'useDevServer' => true,
53 53 
                 ],
Please login to merge, or discard this patch.