nozavroni / csvelte

src/CSVelte/Taster.php

Doc Comments +5 added lines, -1 removed lines

@@ -189,6 +189,7 @@ 
      * replaceQuotedSpecialChars method which (at least to me) makes more sense.
      *
      * @param string The string to replace quoted strings within
+     * @param string $data
      * @return string The input string with quoted strings removed
      * @todo Replace code that uses this method with the replaceQuotedSpecialChars
      *     method instead. I think it's cleaner.
@@ -559,7 +560,7 @@ 
      * Determine whether a particular string of data has quotes around it.
      *
      * @param string The data to check
-     * @return boolean Whether the data is quoted or not
+     * @return integer Whether the data is quoted or not
      */
     protected function isQuoted($data)
     {
@@ -607,6 +608,8 @@ 
      *
      * @param string The string to do the replacements on
      * @param string The delimiter character to replace
+     * @param string $data
+     * @param string $delim
      * @return string The data with replacements performed
      * @todo I could probably pass in (maybe optionally) the newline character I
      *     want to replace as well. I'll do that if I need to.
@@ -632,6 +635,7 @@ 
      * to be practical.
      *
      * @param string The string of data to check the type of
+     * @param string $data
      * @return string One of the TYPE_ string constants above
      */
     protected function lickType($data)

Spacing +16 added lines, -16 removed lines

@@ -215,16 +215,16 @@ 
     {
         $str = $this->removeQuotedStrings($this->sample);
         $eols = [
-            self::EOL_WINDOWS => "\r\n",  // 0x0D - 0x0A - Windows, DOS OS/2
-            self::EOL_UNIX    => "\n",    // 0x0A -      - Unix, OSX
-            self::EOL_TRS80   => "\r",    // 0x0D -      - Apple ][, TRS80
+            self::EOL_WINDOWS => "\r\n", // 0x0D - 0x0A - Windows, DOS OS/2
+            self::EOL_UNIX    => "\n", // 0x0A -      - Unix, OSX
+            self::EOL_TRS80   => "\r", // 0x0D -      - Apple ][, TRS80
         ];
 
         $curCount = 0;
         // @todo This should return a default maybe?
         $curEol = PHP_EOL;
-        foreach($eols as $k => $eol) {
-            if( ($count = substr_count($str, $eol)) > $curCount) {
+        foreach ($eols as $k => $eol) {
+            if (($count = substr_count($str, $eol)) > $curCount) {
                 $curCount = $count;
                 $curEol = $eol;
             }
@@ -256,12 +256,12 @@ 
         $patterns = [];
         // delim can be anything but line breaks, quotes, alphanumeric, underscore, backslash, or any type of spaces
         $antidelims = implode(array("\r", "\n", "\w", preg_quote('"', '/'), preg_quote("'", '/')/*, preg_quote('\\', '/')*/, preg_quote(chr(self::SPACE), '/')));
-        $delim = '(?P<delim>[^' . $antidelims . '])';
+        $delim = '(?P<delim>[^'.$antidelims.'])';
         $quote = '(?P<quoteChar>"|\'|`)'; // @todo I think MS Excel uses some strange encoding for fancy open/close quotes
-        $patterns[] = '/' . $delim . ' ?' . $quote . '.*?\2\1/ms'; // ,"something", - anything but whitespace or quotes followed by a possible space followed by a quote followed by anything followed by same quote, followed by same anything but whitespace
-        $patterns[] = '/(?:^|\n)' . $quote . '.*?\1' . $delim . ' ?/ms'; // 'something', - beginning of line or line break, followed by quote followed by anything followed by quote followed by anything but whitespace or quotes
-        $patterns[] = '/' . $delim . ' ?' . $quote . '.*?\2(?:^|\n)/ms'; // ,'something' - anything but whitespace or quote followed by possible space followed by quote followed by anything followed by quote, followed by end of line
-        $patterns[] = '/(?:^|\n)' . $quote . '.*?\2(?:$|\n)/ms'; // 'something' - beginning of line followed by quote followed by anything followed by quote followed by same quote followed by end of line
+        $patterns[] = '/'.$delim.' ?'.$quote.'.*?\2\1/ms'; // ,"something", - anything but whitespace or quotes followed by a possible space followed by a quote followed by anything followed by same quote, followed by same anything but whitespace
+        $patterns[] = '/(?:^|\n)'.$quote.'.*?\1'.$delim.' ?/ms'; // 'something', - beginning of line or line break, followed by quote followed by anything followed by quote followed by anything but whitespace or quotes
+        $patterns[] = '/'.$delim.' ?'.$quote.'.*?\2(?:^|\n)/ms'; // ,'something' - anything but whitespace or quote followed by possible space followed by quote followed by anything followed by quote, followed by end of line
+        $patterns[] = '/(?:^|\n)'.$quote.'.*?\2(?:$|\n)/ms'; // 'something' - beginning of line followed by quote followed by anything followed by quote followed by same quote followed by end of line
         foreach ($patterns as $pattern) {
             // @todo I had to add the error suppression char here because it was
             //     causing undefined offset errors with certain data sets. strange...
@@ -530,7 +530,7 @@ 
             if ($types->contains(self::DATA_NONNUMERIC)) {
                 // allow for a SMALL amount of error here
                 $counts = collect([self::DATA_SPECIAL => 0, self::DATA_NONNUMERIC => 0]);
-                $freq->get('quoted')->walk(function ($type) use (&$counts) {
+                $freq->get('quoted')->walk(function($type) use (&$counts) {
                     $counts->increment($type);
                 });
                 // @todo is all this even necessary? seems unnecessary to me...
@@ -651,13 +651,13 @@ 
                 $day = '[0-3]?[0-9]';
                 $sep = '[\/\.\-]?';
                 $time = '([0-2]?[0-9](:[0-5][0-9]){1,2}(am|pm)?|[01]?[0-9](am|pm))';
-                $date = '(' . $month . $sep . $day . $sep . $year . '|' . $day . $sep . $month . $sep . $year . '|' . $year . $sep . $month . $sep . $day . ')';
+                $date = '('.$month.$sep.$day.$sep.$year.'|'.$day.$sep.$month.$sep.$year.'|'.$year.$sep.$month.$sep.$day.')';
                 $dt = new DateTime($data);
-                $dt->setTime(0,0,0);
+                $dt->setTime(0, 0, 0);
                 $now = new DateTime();
-                $now->setTime(0,0,0);
+                $now->setTime(0, 0, 0);
                 $diff = $dt->diff($now);
-                $diffDays = (integer) $diff->format( "%R%a" );
+                $diffDays = (integer) $diff->format("%R%a");
                 if ($diffDays === 0) {
                     // then this is most likely a time string...
                     if (preg_match("/^{$time}$/i", $data)) {
@@ -666,7 +666,7 @@ 
                 }
                 if (preg_match("/^{$date}$/i", $data)) {
                     return self::TYPE_DATE;
-                } elseif(preg_match("/^{$date} {$time}$/i")) {
+                } elseif (preg_match("/^{$date} {$time}$/i")) {
                     return self::TYPE_DATETIME;
                 }
             } catch (\Exception $e) {

Braces +34 added lines, -12 removed lines

@@ -169,7 +169,9 @@ 
         try {
             list($quoteChar, $delimiter) = $this->lickQuoteAndDelim();
         } catch (TasterException $e) {
-            if ($e->getCode() !== TasterException::ERR_QUOTE_AND_DELIM) throw $e;
+            if ($e->getCode() !== TasterException::ERR_QUOTE_AND_DELIM) {
+                throw $e;
+            }
             $quoteChar = '"';
             $delimiter = $this->lickDelimiter($lineTerminator);
         }
@@ -265,7 +267,9 @@ 
         foreach ($patterns as $pattern) {
             // @todo I had to add the error suppression char here because it was
             //     causing undefined offset errors with certain data sets. strange...
-            if (@preg_match_all($pattern, $this->sample, $matches) && $matches) break;
+            if (@preg_match_all($pattern, $this->sample, $matches) && $matches) {
+                break;
+            }
         }
         if ($matches) {
             try {
@@ -388,7 +392,9 @@ 
                  // if somehow we STILL can't come to a consensus, then fall back to a
                  // "preferred delimiters" list...
                  foreach ($this->delims as $key => $val) {
-                    if ($delim = array_search($val, $decision)) return $delim;
+                    if ($delim = array_search($val, $decision)) {
+                        return $delim;
+                    }
                  }
              }
         }
@@ -431,7 +437,9 @@ 
             return $delims[collect($delims)->map(function($delim) use (&$distrib, $lines) {
                 $linedist = collect();
                 $lines->walk(function($line, $line_no) use (&$linedist, $delim) {
-                    if (!strlen($line)) return;
+                    if (!strlen($line)) {
+                        return;
+                    }
                     $sectstot = 10;
                     $sectlen = (int) (strlen($line) / $sectstot);
                     $sections = collect(str_split($line, $sectlen))
@@ -519,8 +527,12 @@ 
         $quoting_styles = $quoting_styles->filter(function($val) { return (bool) $val; });
         // if quoting_styles still has QUOTE_ALL or QUOTE_NONE, then return
         // whichever of them it is, we don't need to do anything else
-        if ($quoting_styles->has(Flavor::QUOTE_ALL)) return Flavor::QUOTE_ALL;
-        if ($quoting_styles->has(Flavor::QUOTE_NONE)) return Flavor::QUOTE_NONE;
+        if ($quoting_styles->has(Flavor::QUOTE_ALL)) {
+            return Flavor::QUOTE_ALL;
+        }
+        if ($quoting_styles->has(Flavor::QUOTE_NONE)) {
+            return Flavor::QUOTE_NONE;
+        }
         if (count($types) == 1) {
             $style = $types->getValueAtPosition(0);
             if ($quoting_styles->has($style)) {
@@ -537,7 +549,9 @@ 
                 if ($most = $counts->max()) {
                     $least = $counts->min();
                     $err_margin = $least / $most;
-                    if ($err_margin < 1) return Flavor::QUOTE_NONNUMERIC;
+                    if ($err_margin < 1) {
+                        return Flavor::QUOTE_NONNUMERIC;
+                    }
                 }
             }
         }
@@ -712,7 +726,9 @@ 
                 $field = str_replace(self::PLACEHOLDER_DELIM, $delim, $field);
                 // @todo Need a Collection::setTableField($x, $y) method
                 //       See notes in green binder about refactoring Collection
-                if (!$types->has($line_no)) $types->set($line_no, collect());
+                if (!$types->has($line_no)) {
+                    $types->set($line_no, collect());
+                }
                 $types->get($line_no)->set($colpos, [
                     'type' => $this->lickType($this->unQuote($field)),
                     'length' => strlen($field)
@@ -735,12 +751,18 @@ 
                     extract($possibleHeader->get($col_no, null, true), EXTR_PREFIX_ALL, "header");
                     if ($header_type == self::TYPE_STRING) {
                         // use length
-                        if ($length != $header_length) $hasHeader++;
-                        else $hasHeader--;
+                        if ($length != $header_length) {
+                            $hasHeader++;
+                        } else {
+                            $hasHeader--;
+                        }
                     } else {
                         // use data type
-                        if ($type != $header_type) $hasHeader++;
-                        else $hasHeader--;
+                        if ($type != $header_type) {
+                            $hasHeader++;
+                        } else {
+                            $hasHeader--;
+                        }
                     }
                 } catch (OutOfBoundsException $e) {
                     // failure...

Indentation +25 added lines, -25 removed lines

@@ -290,20 +290,20 @@ 
         throw new TasterException("quoteChar and delimiter cannot be determined", TasterException::ERR_QUOTE_AND_DELIM);
     }
 
-     /**
-      * Take a list of likely delimiter characters and find the one that occurs
-      * the most consistent amount of times within the provided data.
-      *
-      * @param string The character(s) used for newlines
-      * @return string One of four Flavor::QUOTING_* constants
-      * @see \CSVelte\Flavor for possible quote style constants
-      * @todo Refactor this method--It needs more thorough testing against a wider
-      *     variety of CSV data to be sure it works reliably. And I'm sure there
-      *     are many performance and logic improvements that could be made. This
-      *     is essentially a first draft.
-      * @todo Can't use replaceQuotedSpecialChars rather than removeQuotedStrings
-      *     because the former requires u to know the delimiter
-      */
+        /**
+         * Take a list of likely delimiter characters and find the one that occurs
+         * the most consistent amount of times within the provided data.
+         *
+         * @param string The character(s) used for newlines
+         * @return string One of four Flavor::QUOTING_* constants
+         * @see \CSVelte\Flavor for possible quote style constants
+         * @todo Refactor this method--It needs more thorough testing against a wider
+         *     variety of CSV data to be sure it works reliably. And I'm sure there
+         *     are many performance and logic improvements that could be made. This
+         *     is essentially a first draft.
+         * @todo Can't use replaceQuotedSpecialChars rather than removeQuotedStrings
+         *     because the former requires u to know the delimiter
+         */
     protected function lickDelimiter($eol = "\n")
     {
         $frequencies = [];
@@ -380,16 +380,16 @@ 
              *     which one has the best distribution, return that one.
              */
 
-             $decision = $dups->get($max);
-             try {
-                 return $this->guessDelimByDistribution($decision, $eol);
-             } catch (TasterException $e) {
-                 // if somehow we STILL can't come to a consensus, then fall back to a
-                 // "preferred delimiters" list...
-                 foreach ($this->delims as $key => $val) {
+                $decision = $dups->get($max);
+                try {
+                    return $this->guessDelimByDistribution($decision, $eol);
+                } catch (TasterException $e) {
+                    // if somehow we STILL can't come to a consensus, then fall back to a
+                    // "preferred delimiters" list...
+                    foreach ($this->delims as $key => $val) {
                     if ($delim = array_search($val, $decision)) return $delim;
-                 }
-             }
+                    }
+                }
         }
         return $delims
             ->sort()
@@ -446,8 +446,8 @@ 
             })->map(function($dists) {
                 return $dists->average();
             })->sort()
-              ->reverse()
-              ->getKeyAtPosition(0)];
+                ->reverse()
+                ->getKeyAtPosition(0)];
         } catch (Exception $e) {
             throw new TasterException("delimiter cannot be determined by distribution", TasterException::ERR_DELIMITER);
         }

src/CSVelte/Reader/FilteredIterator.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 
     public function toArray()
     {
-        return array_map(function($row){
+        return array_map(function($row) {
             return $row->toArray();
         }, iterator_to_array($this));
     }

src/CSVelte/Flavor.php

Spacing +2 added lines, -2 removed lines

@@ -192,7 +192,7 @@ 
     protected function assertValidAttribute($attr)
     {
         if (!property_exists(self::class, $attr))
-            throw new InvalidArgumentException("Unknown attribute: " . $attr);
+            throw new InvalidArgumentException("Unknown attribute: ".$attr);
     }
 
     /**
@@ -241,7 +241,7 @@ 
      */
     public function __set($attr, $val)
     {
-        throw new ImmutableException("Cannot change attributes on an immutable object: " . self::class . "::\$" . $attr);
+        throw new ImmutableException("Cannot change attributes on an immutable object: ".self::class."::\$".$attr);
     }
 
     public function toArray()

Braces +3 added lines, -2 removed lines

@@ -191,8 +191,9 @@
      */
     protected function assertValidAttribute($attr)
     {
-        if (!property_exists(self::class, $attr))
-            throw new InvalidArgumentException("Unknown attribute: " . $attr);
+        if (!property_exists(self::class, $attr)) {
+                    throw new InvalidArgumentException("Unknown attribute: " . $attr);
+        }
     }
 
     /**

src/CSVelte/Table/AbstractRow.php

Indentation +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
     public function __construct($fields)
     {
         $this->setFields($fields)
-             ->rewind();
+                ->rewind();
     }
 
     protected function setFields($fields)

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
             } elseif ($fields instanceof Iterator) {
                 $fields = iterator_to_array($fields);
             } else {
-                throw new InvalidArgumentException(__CLASS__ . " requires an array, got: " . gettype($fields));
+                throw new InvalidArgumentException(__CLASS__." requires an array, got: ".gettype($fields));
             }
         }
         $this->fields = collect(array_values($fields));

Braces +3 added lines, -1 removed lines

@@ -152,7 +152,9 @@
     public function next()
     {
         $this->position++;
-        if ($this->valid()) return $this->current();
+        if ($this->valid()) {
+            return $this->current();
+        }
     }
 
     /**

src/CSVelte/Traits/IsReadable.php

Braces +3 added lines, -1 removed lines

@@ -45,7 +45,9 @@
     {
         $size = 0;
         $buffer = false;
-        if (!is_array($eol)) $eol = array($eol);
+        if (!is_array($eol)) {
+            $eol = array($eol);
+        }
         while (!$this->eof()) {
             // Using a loose equality here to match on '' and false.
             if (null == ($byte = $this->read(1))) {

src/CSVelte/Reader.php

Indentation +2 added lines, -2 removed lines

@@ -91,8 +91,8 @@
     public function __construct($input, $flavor = null)
     {
         $this->setSource($input)
-             ->setFlavor($flavor)
-             ->rewind();
+                ->setFlavor($flavor)
+                ->rewind();
     }
 
     /**

Braces +18 added lines, -6 removed lines

@@ -104,7 +104,9 @@ 
      */
     protected function setFlavor($flavor = null)
     {
-        if (is_array($flavor)) $flavor = new Flavor($flavor);
+        if (is_array($flavor)) {
+            $flavor = new Flavor($flavor);
+        }
         $taster = new Taster($this->source);
         // @todo put this inside a try/catch
         if (is_null($flavor)) {
@@ -159,7 +161,9 @@ 
                     $this->header = new HeaderRow($parsed);
                 } else {
                     $this->current = new Row($parsed);
-                    if ($this->header) $this->current->setHeaderRow($this->header);
+                    if ($this->header) {
+                        $this->current->setHeaderRow($this->header);
+                    }
                 }
             } catch (EndOfFileException $e) {
                 $this->current = false;
@@ -183,7 +187,9 @@ 
         $eol = $f->lineTerminator;
         try {
             do {
-                if (!isset($lines)) $lines = array();
+                if (!isset($lines)) {
+                    $lines = array();
+                }
                 if (false === ($line = $this->source->readLine($eol))) {
                     throw new EndOfFileException("End of file reached: " . $this->source->getName());
                 }
@@ -191,7 +197,9 @@ 
             } while ($this->inQuotedString(end($lines), $f->quoteChar, $f->escapeChar));
         } catch (EndOfFileException $e) {
             // only throw the exception if we don't already have lines in the buffer
-            if (!count($lines)) throw $e;
+            if (!count($lines)) {
+                throw $e;
+            }
         }
         return rtrim(implode($eol, $lines), $eol);
     }
@@ -211,14 +219,18 @@ 
     {
         if (!empty($line)) {
             do {
-                if (!isset($i)) $i = 0;
+                if (!isset($i)) {
+                    $i = 0;
+                }
                 $c = $line[$i++];
                 if ($this->escape) {
                     $this->escape = false;
                     continue;
                 }
                 $this->escape = ($c == $escapeChar);
-                if ($c == $quoteChar) $this->open = !$this->open;
+                if ($c == $quoteChar) {
+                    $this->open = !$this->open;
+                }
             } while ($i < strlen($line));
         }
         return $this->open;

Spacing +3 added lines, -3 removed lines

@@ -283,7 +283,7 @@ 
      */
     protected function replaceQuotedSpecialChars($data, $delim, $quo, $eol)
     {
-        return preg_replace_callback('/(['. preg_quote($quo, '/') . '])(.*)\1/imsU', function($matches) use ($delim, $eol) {
+        return preg_replace_callback('/(['.preg_quote($quo, '/').'])(.*)\1/imsU', function($matches) use ($delim, $eol) {
             $ret = str_replace($eol, self::PLACEHOLDER_NEWLINE, $matches[0]);
             $ret = str_replace($delim, self::PLACEHOLDER_DELIM, $ret);
             return $ret;
@@ -335,7 +335,7 @@ 
      */
     protected function unEscape($str, $esc, $quo)
     {
-        return str_replace($esc . $quo, $quo, $str);
+        return str_replace($esc.$quo, $quo, $str);
     }
 
     /**
@@ -476,7 +476,7 @@ 
      */
     public function toArray()
     {
-        return array_map(function($row){
+        return array_map(function($row) {
             return $row->toArray();
         }, iterator_to_array($this));
     }

src/CSVelte/CSVelte.php

Spacing +2 added lines, -2 removed lines

@@ -123,7 +123,7 @@ 
     {
         self::assertFileExists($filename);
         if (!is_readable($filename)) {
-            throw new IOException('Permission denied for: ' . $filename, IOException::ERR_FILE_PERMISSION_DENIED);
+            throw new IOException('Permission denied for: '.$filename, IOException::ERR_FILE_PERMISSION_DENIED);
         }
     }
 
@@ -137,7 +137,7 @@ 
     protected static function assertFileExists($filename)
     {
         if (!file_exists($filename)) {
-            throw new IOException('File does not exist: ' . $filename, IOException::ERR_FILE_NOT_FOUND);
+            throw new IOException('File does not exist: '.$filename, IOException::ERR_FILE_NOT_FOUND);
         }
     }
 }

src/CSVelte/Autoloader.php

Spacing +5 added lines, -5 removed lines

@@ -62,10 +62,10 @@ 
         $paths = $this->getPaths();
         if ($rp = realpath($path)) {
             if (in_array($rp, $paths)) return true;
-            $this->paths []= $rp;
+            $this->paths [] = $rp;
             return true;
         }
-        $this->paths []= $path;
+        $this->paths [] = $path;
         return false;
     }
 
@@ -113,14 +113,14 @@ 
      */
     public function load($className)
     {
-        if(class_exists($className)) {
+        if (class_exists($className)) {
             return;
         }
         $fqcp = str_replace(self::NAMESPACE_SEPARATOR, DIRECTORY_SEPARATOR, $className);
         $paths = $this->getPaths();
         foreach ($paths as $path) {
-            $classPath = $path . DIRECTORY_SEPARATOR . $fqcp . '.php';
-            if(file_exists($classPath) && is_readable($classPath)) {
+            $classPath = $path.DIRECTORY_SEPARATOR.$fqcp.'.php';
+            if (file_exists($classPath) && is_readable($classPath)) {
                 require_once($classPath);
                 return;
             }

Braces +3 added lines, -1 removed lines

@@ -61,7 +61,9 @@
     {
         $paths = $this->getPaths();
         if ($rp = realpath($path)) {
-            if (in_array($rp, $paths)) return true;
+            if (in_array($rp, $paths)) {
+                return true;
+            }
             $this->paths []= $rp;
             return true;
         }

src/CSVelte/Exception/HeaderException.php

Indentation -1 removed lines

@@ -19,7 +19,6 @@
 if (if $file->hasHeader()) {
     $header = $file->getHeader()
 }
-
  * you can instead simply call $header->getHeader() and handle this exception if
  * said file has no header
  *