notamedia / console-jedi

src/Application/Application.php

Braces +7 added lines, -14 removed lines

@@ -105,8 +105,7 @@ 
         {
             $output->writeln(PHP_EOL . '<error>No configuration loaded.</error> ' 
                 . 'Please run <info>init</info> command first');
-        }
-        else
+        } else
         {
             switch ($this->getBitrixStatus())
             {
@@ -179,8 +178,7 @@ 
             if ($cliFile === false)
             {
                 continue;
-            }
-            elseif (!Loader::includeModule($module['ID']))
+            } elseif (!Loader::includeModule($module['ID']))
             {
                 continue;
             }
@@ -224,8 +222,7 @@ 
         if ($filesystem->isAbsolutePath($this->configuration['web-dir']))
         {
             $this->setDocumentRoot($this->configuration['web-dir']);
-        }
-        else
+        } else
         {
             $this->setDocumentRoot($this->getRoot() . '/' . $this->configuration['web-dir']);
         }
@@ -258,8 +255,7 @@ 
         if ($this->bitrixStatus === static::BITRIX_STATUS_COMPLETE)
         {
             return static::BITRIX_STATUS_COMPLETE;
-        }
-        elseif (!$this->checkBitrix())
+        } elseif (!$this->checkBitrix())
         {
             return static::BITRIX_STATUS_UNAVAILABLE;
         }
@@ -284,8 +280,7 @@ 
             {
                 $this->bitrixStatus = static::BITRIX_STATUS_COMPLETE;
             }
-        }
-        catch (ConnectionException $e)
+        } catch (ConnectionException $e)
         {
             $this->bitrixStatus = static::BITRIX_STATUS_NO_DB_CONNECTION;
         }
@@ -363,12 +358,10 @@ 
             if (preg_match("#[^\\\\/a-zA-Z0-9_]#", $file))
             {
                 return false;
-            }
-            elseif ($arFile[0] === 'bitrix')
+            } elseif ($arFile[0] === 'bitrix')
             {
                 return false;
-            }
-            elseif ($arFile[2] !== 'tests')
+            } elseif ($arFile[2] !== 'tests')
             {
                 return false;
             }

Spacing +15 added lines, -15 removed lines

@@ -108,7 +108,7 @@ 
 
         if ($this->getConfiguration() === null)
         {
-            $output->writeln(PHP_EOL . '<error>No configuration loaded.</error> ' 
+            $output->writeln(PHP_EOL.'<error>No configuration loaded.</error> ' 
                 . 'Please run <info>init</info> command first');
         }
         else
@@ -116,18 +116,18 @@ 
             switch ($this->getBitrixStatus())
             {
                 case static::BITRIX_STATUS_UNAVAILABLE:
-                    $output->writeln(PHP_EOL . sprintf('<error>No Bitrix kernel found in %s.</error> ' 
+                    $output->writeln(PHP_EOL.sprintf('<error>No Bitrix kernel found in %s.</error> ' 
                             . 'Please run <info>env:init</info> command to configure', $this->getDocumentRoot()));
                     break;
 
                 case static::BITRIX_STATUS_NO_DB_CONNECTION:
-                    $output->writeln(PHP_EOL . '<error>Bitrix database connection is unavailable.</error>');
+                    $output->writeln(PHP_EOL.'<error>Bitrix database connection is unavailable.</error>');
                     break;
 
                 case static::BITRIX_STATUS_COMPLETE:
                     if ($this->getCommandName($input) === null)
                     {
-                        $output->writeln(PHP_EOL . sprintf('Using Bitrix <info>kernel v%s</info>.</info>', SM_VERSION),
+                        $output->writeln(PHP_EOL.sprintf('Using Bitrix <info>kernel v%s</info>.</info>', SM_VERSION),
                             OutputInterface::VERBOSITY_VERY_VERBOSE);
                     }
                     break;
@@ -179,7 +179,7 @@ 
 
         foreach (ModuleManager::getInstalledModules() as $module)
         {
-            $cliFile = getLocalPath('modules/' . $module['ID'] . '/cli.php');
+            $cliFile = getLocalPath('modules/'.$module['ID'].'/cli.php');
 
             if ($cliFile === false)
             {
@@ -190,7 +190,7 @@ 
                 continue;
             }
 
-            $config = include_once $this->getDocumentRoot() . $cliFile;
+            $config = include_once $this->getDocumentRoot().$cliFile;
 
             if (isset($config['commands']) && is_array($config['commands']))
             {
@@ -221,7 +221,7 @@ 
         
         if (!is_array($this->configuration))
         {
-            throw new ConfigurationException('Configuration file ' . $path . ' must return an array');
+            throw new ConfigurationException('Configuration file '.$path.' must return an array');
         }
 
         //TODO-fox: Проверка на указание в качестве относительного пути /
@@ -236,7 +236,7 @@ 
         }
         else
         {
-            $this->setDocumentRoot($this->getRoot() . '/' . $this->configuration['web-dir']);
+            $this->setDocumentRoot($this->getRoot().'/'.$this->configuration['web-dir']);
         }
 
         if (!is_dir($_SERVER['DOCUMENT_ROOT']))
@@ -287,7 +287,7 @@ 
                 /** @noinspection PhpUnusedLocalVariableInspection */
                 $DB, $DBType, $DBHost, $DBLogin, $DBPassword, $DBName, $DBDebug, $DBDebugToFile, $APPLICATION, $USER, $DBSQLServerType;
 
-            require_once $_SERVER['DOCUMENT_ROOT'] . '/bitrix/modules/main/include/prolog_before.php';
+            require_once $_SERVER['DOCUMENT_ROOT'].'/bitrix/modules/main/include/prolog_before.php';
             
             if (defined('B_PROLOG_INCLUDED') && B_PROLOG_INCLUDED === true)
             {
@@ -310,8 +310,8 @@ 
     public function checkBitrix()
     {
         if (
-            !is_file($_SERVER['DOCUMENT_ROOT'] . '/bitrix/.settings.php') 
-            && !is_file($_SERVER['DOCUMENT_ROOT'] . '/bitrix/.settings_extra.php')
+            !is_file($_SERVER['DOCUMENT_ROOT'].'/bitrix/.settings.php') 
+            && !is_file($_SERVER['DOCUMENT_ROOT'].'/bitrix/.settings_extra.php')
         )
         {
             return false;
@@ -357,7 +357,7 @@ 
         
         $this->initializeBitrix();
         
-        spl_autoload_register(function ($className) {
+        spl_autoload_register(function($className) {
             $file = ltrim($className, "\\");
             $file = strtr($file, Loader::ALPHA_UPPER, Loader::ALPHA_LOWER);
             $file = str_replace('\\', '/', $file);
@@ -382,18 +382,18 @@ 
                 return false;
             }
 
-            $module = array_shift($arFile) . '.' . array_shift($arFile);
+            $module = array_shift($arFile).'.'.array_shift($arFile);
 
             if (!Loader::includeModule($module))
             {
                 return false;
             }
 
-            $path = getLocalPath('/modules/' . $module . '/' . implode('/', $arFile) . '.php');
+            $path = getLocalPath('/modules/'.$module.'/'.implode('/', $arFile).'.php');
 
             if ($path !== false)
             {
-                include_once $this->getDocumentRoot() . $path;
+                include_once $this->getDocumentRoot().$path;
             }
         });
     }

src/Application/Exception/BitrixException.php

Braces +1 added lines, -2 removed lines

@@ -41,8 +41,7 @@
 		if ($ex = $APPLICATION->GetException())
 		{
 			throw new static($message ? $message . ': ' . $ex->GetString() : $ex->GetString());
-		}
-		else
+		} else
 		{
 			throw new static($message ? $message : 'Unknown exception');
 		}

Indentation +30 added lines, -30 removed lines

@@ -14,37 +14,37 @@
  */
 class BitrixException extends \RuntimeException
 {
-	public static function hasException(\CMain $APPLICATION = null)
-	{
-		if (null === $APPLICATION)
-		{
-			$APPLICATION = $GLOBALS['APPLICATION'];
-		}
+    public static function hasException(\CMain $APPLICATION = null)
+    {
+        if (null === $APPLICATION)
+        {
+            $APPLICATION = $GLOBALS['APPLICATION'];
+        }
 
-		return is_object($APPLICATION->GetException());
-	}
+        return is_object($APPLICATION->GetException());
+    }
 
-	/**
-	 * Check for legacy bitrix exception, throws new self if any
-	 *
-	 * @param string $message [optional] Additional error message
-	 * @param \CMain $APPLICATION [optional] $APPLICATION instance
-	 * @throws static
-	 */
-	public static function generate($message = null, \CMain $APPLICATION = null)
-	{
-		if (null === $APPLICATION)
-		{
-			$APPLICATION = $GLOBALS['APPLICATION'];
-		}
+    /**
+     * Check for legacy bitrix exception, throws new self if any
+     *
+     * @param string $message [optional] Additional error message
+     * @param \CMain $APPLICATION [optional] $APPLICATION instance
+     * @throws static
+     */
+    public static function generate($message = null, \CMain $APPLICATION = null)
+    {
+        if (null === $APPLICATION)
+        {
+            $APPLICATION = $GLOBALS['APPLICATION'];
+        }
 
-		if ($ex = $APPLICATION->GetException())
-		{
-			throw new static($message ? $message . ': ' . $ex->GetString() : $ex->GetString());
-		}
-		else
-		{
-			throw new static($message ? $message : 'Unknown exception');
-		}
-	}
+        if ($ex = $APPLICATION->GetException())
+        {
+            throw new static($message ? $message . ': ' . $ex->GetString() : $ex->GetString());
+        }
+        else
+        {
+            throw new static($message ? $message : 'Unknown exception');
+        }
+    }
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
 		if ($ex = $APPLICATION->GetException())
 		{
-			throw new static($message ? $message . ': ' . $ex->GetString() : $ex->GetString());
+			throw new static($message ? $message.': '.$ex->GetString() : $ex->GetString());
 		}
 		else
 		{

src/Environment/Command/InitCommand.php

Braces +12 added lines, -20 removed lines

@@ -86,8 +86,7 @@ 
         if (!is_array($environments))
         {
             throw new \Exception('File with description of environments is missing');
-        }
-        elseif (count($environments) == 0)
+        } elseif (count($environments) == 0)
         {
             throw new \Exception('Environments not found in description file');
         }
@@ -100,8 +99,7 @@ 
             {
                 throw new \Exception('Invalid environment code!');
             }
-        }
-        else
+        } else
         {
             foreach ($environments as $code => $environment)
             {
@@ -171,8 +169,7 @@ 
             if ($item->isDir())
             {
                 $fs->mkdir($itemPath);
-            }
-            else
+            } else
             {
                 $fs->copy($item, $itemPath, true);
             }
@@ -227,10 +224,10 @@ 
         if ($app->getConfiguration())
         {
             $app->addCommands(ModuleCommand::getCommands());
-            if ($app->getBitrixStatus() != \Notamedia\ConsoleJedi\Application\Application::BITRIX_STATUS_COMPLETE)
-                throw new BitrixException('Bitrix core is not available');
-        }
-        else
+            if ($app->getBitrixStatus() != \Notamedia\ConsoleJedi\Application\Application::BITRIX_STATUS_COMPLETE) {
+                            throw new BitrixException('Bitrix core is not available');
+            }
+        } else
         {
             throw new BitrixException('No configuration loaded');
         }
@@ -265,14 +262,12 @@ 
 
                 $bar->clear();
                 $output->writeln($message . '<info>ok</info>');
-            }
-            catch (ModuleInstallException $e)
+            } catch (ModuleInstallException $e)
             {
                 $bar->clear();
                 $output->writeln($e->getMessage(), OutputInterface::VERBOSITY_VERBOSE);
                 $output->writeln($message . '<comment>not registered</comment> (install it in admin panel)');
-            }
-            catch (ModuleException $e)
+            } catch (ModuleException $e)
             {
                 $bar->clear();
                 $output->writeln($e->getMessage(), OutputInterface::VERBOSITY_VERBOSE);
@@ -346,8 +341,7 @@ 
                 if ($serverId && !$input->getOption('memcache-cold-start'))
                 {
                     $memcache->Resume($serverId);
-                }
-                else
+                } else
                 {
                     $exception = $APPLICATION->GetException();
                     $message = 'Invalid memcache config with index ' . $index;
@@ -391,13 +385,11 @@ 
                     if (isset($value['value']) && isset($value['siteId']))
                     {
                         Option::set($module, $code, $value['value'], $value['siteId']);
-                    }
-                    else
+                    } else
                     {
                         $output->writeln('<error>Invalid option for module "' . $module . '" with code "' . $code. '"</error>');
                     }
-                }
-                else
+                } else
                 {
                     Option::set($module, $code, $value);
 

Spacing +19 added lines, -19 removed lines

@@ -74,14 +74,14 @@ 
             throw new \Exception('Config env-dir is missing');
         }
         
-        $dir = $this->getApplication()->getRoot() . '/' . $this->getApplication()->getConfiguration()['env-dir'];
+        $dir = $this->getApplication()->getRoot().'/'.$this->getApplication()->getConfiguration()['env-dir'];
 
         if (!is_dir($dir))
         {
-            throw new \Exception('Directory ' . $dir . ' is missing');
+            throw new \Exception('Directory '.$dir.' is missing');
         }
 
-        $environments = include $dir . '/index.php';
+        $environments = include $dir.'/index.php';
 
         if (!is_array($environments))
         {
@@ -118,8 +118,8 @@ 
             throw new \Exception('Environment path not found!');
         }
 
-        $this->dir = $dir . '/' . $environments[$code]['path'];
-        $this->config = include $this->dir . '/config.php';
+        $this->dir = $dir.'/'.$environments[$code]['path'];
+        $this->config = include $this->dir.'/config.php';
     }
 
     /**
@@ -134,11 +134,11 @@ 
                 
         foreach ($this->config as $config => $settings)
         {
-            $method = 'configure' . ucfirst($config);
+            $method = 'configure'.ucfirst($config);
 
             if (!in_array($method, $this->bootstrap) && method_exists($this, $method))
             {
-                $output->writeln('<comment>Setup "' . $config . '"</comment>');
+                $output->writeln('<comment>Setup "'.$config.'"</comment>');
                 $this->$method($input, $output, $settings);
             }
         }
@@ -166,7 +166,7 @@ 
                 continue;
             }
             
-            $itemPath = $this->getApplication()->getRoot() . '/' . $iterator->getSubPathName();
+            $itemPath = $this->getApplication()->getRoot().'/'.$iterator->getSubPathName();
             
             if ($item->isDir())
             {
@@ -177,7 +177,7 @@ 
                 $fs->copy($item, $itemPath, true);
             }
 
-            $output->writeln('   ' . $itemPath);
+            $output->writeln('   '.$itemPath);
         }
     }
     
@@ -207,8 +207,8 @@ 
             throw new \InvalidArgumentException('Config "licenseKey" must be string type.');
         }
         
-        $licenseFileContent = "<" . "? $" . "LICENSE_KEY = \"" . EscapePHPString($licenseKey) . "\"; ?" . ">";
-        File::putFileContents(Application::getDocumentRoot() . BX_ROOT . '/license_key.php', $licenseFileContent);
+        $licenseFileContent = "<"."? $"."LICENSE_KEY = \"".EscapePHPString($licenseKey)."\"; ?".">";
+        File::putFileContents(Application::getDocumentRoot().BX_ROOT.'/license_key.php', $licenseFileContent);
     }
 
     /**
@@ -251,7 +251,7 @@ 
 
         foreach ($modules as $moduleName)
         {
-            $message = "\r" . '   module:load ' . $moduleName . ': ';
+            $message = "\r".'   module:load '.$moduleName.': ';
 
             try
             {
@@ -264,19 +264,19 @@ 
                 (new Module($moduleName))->load()->register();
 
                 $bar->clear();
-                $output->writeln($message . '<info>ok</info>');
+                $output->writeln($message.'<info>ok</info>');
             }
             catch (ModuleInstallException $e)
             {
                 $bar->clear();
                 $output->writeln($e->getMessage(), OutputInterface::VERBOSITY_VERBOSE);
-                $output->writeln($message . '<comment>not registered</comment> (install it in admin panel)');
+                $output->writeln($message.'<comment>not registered</comment> (install it in admin panel)');
             }
             catch (ModuleException $e)
             {
                 $bar->clear();
                 $output->writeln($e->getMessage(), OutputInterface::VERBOSITY_VERBOSE);
-                $output->writeln($message . '<error>FAILED</error>');
+                $output->writeln($message.'<error>FAILED</error>');
             }
             $bar->advance();
         }
@@ -350,14 +350,14 @@ 
                 else
                 {
                     $exception = $APPLICATION->GetException();
-                    $message = 'Invalid memcache config with index ' . $index;
+                    $message = 'Invalid memcache config with index '.$index;
 
                     if ($exception->GetString())
                     {
                         $message = str_replace('<br>', "\n", $exception->GetString());
                     }
 
-                    $output->writeln('<error>' . $message . '</error>');
+                    $output->writeln('<error>'.$message.'</error>');
                 }
             }
         }
@@ -394,14 +394,14 @@ 
                     }
                     else
                     {
-                        $output->writeln('<error>Invalid option for module "' . $module . '" with code "' . $code. '"</error>');
+                        $output->writeln('<error>Invalid option for module "'.$module.'" with code "'.$code.'"</error>');
                     }
                 }
                 else
                 {
                     Option::set($module, $code, $value);
 
-                    $output->writeln('   option: "' . $code . '", module: "' . $module . '"');
+                    $output->writeln('   option: "'.$code.'", module: "'.$module.'"');
                 }
             }
         }

src/Module/Module.php

Braces +2 added lines, -4 removed lines

@@ -73,8 +73,7 @@ 
 		try
 		{
 			$this->getObject();
-		}
-		catch (Exception\ModuleNotFoundException $e)
+		} catch (Exception\ModuleNotFoundException $e)
 		{
 			return false;
 		}
@@ -342,8 +341,7 @@ 
 					\CEventLog::Log("INFO", "MP_MODULE_DOWNLOADED", "main", $key, $value);
 				}
 			}
-		}
-		else
+		} else
 		{
 			throw new Exception\ModuleUpdateException('[CL04] UpdateStepModules failed. ' . $errorMessage, $this->getName());
 		}

Indentation +391 added lines, -391 removed lines

@@ -18,395 +18,395 @@
  */
 class Module
 {
-	/** @var string */
-	private $name;
-
-	/** @var \CModule */
-	private $object;
-
-	/** @var bool */
-	private $beta = false;
-
-	/**
-	 * @param string $moduleName
-	 */
-	public function __construct($moduleName)
-	{
-		$this->name = $this->normalizeName($moduleName);
-	}
-
-	/**
-	 * @param string $moduleName
-	 * @return string
-	 */
-	protected function normalizeName($moduleName)
-	{
-		return preg_replace("/[^a-zA-Z0-9_.]+/i", "", trim($moduleName));
-	}
-
-	/**
-	 * @return \CModule
-	 */
-	protected function &getObject()
-	{
-		if (!isset($this->object))
-		{
-			$this->object = \CModule::CreateModuleObject($this->name);
-		}
-
-		if (!is_object($this->object) || !($this->object instanceof \CModule))
-		{
-			unset($this->object);
-			throw new Exception\ModuleNotFoundException('Module not found or incorrect', $this->name);
-		}
-
-		return $this->object;
-	}
-
-	/**
-	 * Checks for module and module object existence
-	 *
-	 * @return bool
-	 */
-	public function exist()
-	{
-		try
-		{
-			$this->getObject();
-		}
-		catch (Exception\ModuleNotFoundException $e)
-		{
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * Check if module exists and installed
-	 *
-	 * @return bool
-	 */
-	public function isRegistered()
-	{
-		return ModuleManager::isModuleInstalled($this->name) && $this->exist();
-	}
-
-	/**
-	 * @return bool true for marketplace modules, false for kernel modules
-	 */
-	public function isThirdParty()
-	{
-		return strpos($this->name, '.') !== false;
-	}
-
-	/**
-	 * Install module
-	 *
-	 * @throws Exception\ModuleException
-	 * @throws BitrixException
-	 */
-	public function register()
-	{
-		if (!$this->isRegistered())
-		{
-			$moduleObject =& $this->getObject();
-
-			/**
-			 * It's important to check if module class defines InstallDB method (it must register module)
-			 * Thus absent InstallDB indicates that the module does not support automatic installation
-			 */
-			if ((new \ReflectionClass($moduleObject))->getMethod('InstallDB')->class !== get_class($moduleObject))
-			{
-				throw new Exception\ModuleInstallException(
-					'Missing InstallDB method. This module does not support automatic installation',
-					$this->name
-				);
-			}
-
-			if (!$moduleObject->InstallDB() && BitrixException::hasException())
-			{
-				throw new Exception\ModuleInstallException(
-					get_class($moduleObject) . '::InstallDB() returned false',
-					$this->name
-				);
-			}
-
-			$moduleObject->InstallEvents();
-
-			/** @noinspection PhpVoidFunctionResultUsedInspection */
-			if (!$moduleObject->InstallFiles() && BitrixException::hasException())
-			{
-				throw new Exception\ModuleInstallException(
-					get_class($moduleObject) . '::InstallFiles() returned false',
-					$this->name
-				);
-			}
-
-			if (!$this->isRegistered())
-			{
-				throw new Exception\ModuleInstallException(
-					'Module was not registered. Probably it does not support automatic installation.',
-					$this->name
-				);
-			}
-		}
-
-		return $this;
-	}
-
-	/**
-	 * Download module from marketplace
-	 *
-	 * @return $this
-	 */
-	public function load()
-	{
-		if (!$this->isRegistered())
-		{
-			if (!$this->exist())
-			{
-				require_once($_SERVER["DOCUMENT_ROOT"] . '/bitrix/modules/main/classes/general/update_client_partner.php');
-
-				if (!\CUpdateClientPartner::LoadModuleNoDemand(
-					$this->getName(),
-					$strError,
-					$this->isBeta() ? 'N' : 'Y',
-					LANGUAGE_ID)
-				)
-				{
-					throw new Exception\ModuleLoadException($strError, $this->getName());
-				}
-			}
-		}
-
-		return $this;
-	}
-
-	/**
-	 * Uninstall module
-	 *
-	 * @throws Exception\ModuleException
-	 * @throws BitrixException
-	 */
-	public function unRegister()
-	{
-		$moduleObject = $this->getObject();
-
-		if ($this->isRegistered())
-		{
-			/**
-			 * It's important to check if module class defines UnInstallDB method (it should unregister module)
-			 * Thus absent UnInstallDB indicates that the module does not support automatic uninstallation
-			 */
-			if ((new \ReflectionClass($moduleObject))->getMethod('UnInstallDB')->class !== get_class($moduleObject))
-			{
-				throw new Exception\ModuleUninstallException(
-					'Missing UnInstallDB method. This module does not support automatic uninstallation',
-					$this->name
-				);
-			}
-
-			/** @noinspection PhpVoidFunctionResultUsedInspection */
-			if (!$moduleObject->UnInstallFiles() && BitrixException::hasException())
-			{
-				throw new Exception\ModuleUninstallException(
-					get_class($moduleObject) . '::UnInstallFiles() returned false',
-					$this->name
-				);
-			}
-
-			$moduleObject->UnInstallEvents();
-
-			/** @noinspection PhpVoidFunctionResultUsedInspection */
-			if (!$moduleObject->UnInstallDB() && BitrixException::hasException())
-			{
-				throw new Exception\ModuleUninstallException(
-					get_class($moduleObject) . '::UnInstallFiles() returned false',
-					$this->name
-				);
-			}
-
-			if ($this->isRegistered())
-			{
-				throw new Exception\ModuleUninstallException('Module was not unregistered', $this->name);
-			}
-		}
-
-		return $this;
-	}
-
-	/**
-	 * Uninstall and remove module directory
-	 */
-	public function remove()
-	{
-		if ($this->isRegistered())
-		{
-			$this->unRegister();
-		}
-
-		$path = getLocalPath('modules/' . $this->getName());
-
-		if ($path)
-		{
-			(new Filesystem())->remove($_SERVER['DOCUMENT_ROOT'] . $path);
-		}
-
-		unset($this->object);
-
-		return $this;
-	}
-
-	/**
-	 * Update module
-	 *
-	 * It must be called repeatedly until the method returns false.
-	 * After each call php must be restarted (new process created) to update module class and function definitions.
-	 *
-	 * @param array $modulesUpdated [optional]
-	 * @return bool
-	 */
-	public function update(&$modulesUpdated = null)
-	{
-		require_once($_SERVER["DOCUMENT_ROOT"] . '/bitrix/modules/main/classes/general/update_client_partner.php');
-
-		if (!$this->isThirdParty())
-		{
-			throw new Exception\ModuleUpdateException('Kernel module updates are currently not supported.', $this->getName());
-		}
-
-		// ensures module existence
-		$this->getObject();
-
-		$errorMessage = $updateDescription = null;
-		$loadResult = \CUpdateClientPartner::LoadModulesUpdates(
-			$errorMessage,
-			$updateDescription,
-			LANGUAGE_ID,
-			$this->isBeta() ? 'N' : 'Y',
-			[$this->getName()],
-			true
-		);
-		switch ($loadResult)
-		{
-			// archive loaded
-			case "S":
-				return $this->update($modulesUpdated);
-
-			// error
-			case "E":
-				throw new Exception\ModuleUpdateException($errorMessage, $this->getName());
-
-			// finished installing updates
-			case "F":
-				return false;
-
-			// need to process loaded update
-			case 'U':
-				break;
-		}
-
-		/** @var string Temp directory with update files */
-		$updateDir = null;
-
-		if (!\CUpdateClientPartner::UnGzipArchive($updateDir, $errorMessage, true))
-		{
-			throw new Exception\ModuleUpdateException('[CL02] UnGzipArchive failed. ' . $errorMessage, $this->getName());
-		}
-
-		$this->validateUpdate($updateDir);
-
-		if (isset($updateDescription["DATA"]["#"]["NOUPDATES"]))
-		{
-			\CUpdateClientPartner::ClearUpdateFolder($_SERVER["DOCUMENT_ROOT"] . "/bitrix/updates/" . $updateDir);
-			return false;
-		}
-
-		$modulesUpdated = $updateDescr = [];
-		if (isset($updateDescription["DATA"]["#"]["ITEM"]))
-		{
-			foreach ($updateDescription["DATA"]["#"]["ITEM"] as $moduleInfo)
-			{
-				$modulesUpdated[$moduleInfo["@"]["NAME"]] = $moduleInfo["@"]["VALUE"];
-				$updateDescr[$moduleInfo["@"]["NAME"]] = $moduleInfo["@"]["DESCR"];
-			}
-		}
-
-		if (\CUpdateClientPartner::UpdateStepModules($updateDir, $errorMessage))
-		{
-			foreach ($modulesUpdated as $key => $value)
-			{
-				if (Option::set('main', 'event_log_marketplace', "Y") === "Y")
-				{
-					\CEventLog::Log("INFO", "MP_MODULE_DOWNLOADED", "main", $key, $value);
-				}
-			}
-		}
-		else
-		{
-			throw new Exception\ModuleUpdateException('[CL04] UpdateStepModules failed. ' . $errorMessage, $this->getName());
-		}
-
-		return true;
-	}
-
-	/**
-	 * Check update files
-	 * 
-	 * @param string $updateDir
-	 */
-	protected function validateUpdate($updateDir)
-	{
-		$errorMessage = null;
-		if (!\CUpdateClientPartner::CheckUpdatability($updateDir, $errorMessage))
-		{
-			throw new Exception\ModuleUpdateException('[CL03] CheckUpdatability failed. ' . $errorMessage, $this->getName());
-		}
-
-		if (isset($updateDescription["DATA"]["#"]["ERROR"]))
-		{
-			$errorMessage = "";
-			foreach ($updateDescription["DATA"]["#"]["ERROR"] as $errorDescription)
-			{
-				$errorMessage .= "[" . $errorDescription["@"]["TYPE"] . "] " . $errorDescription["#"];
-			}
-			throw new Exception\ModuleUpdateException($errorMessage, $this->getName());
-		}
-	}
-
-	/**
-	 * Returns module name
-	 *
-	 * @return string
-	 */
-	public function getName()
-	{
-		return $this->name;
-	}
-
-	/**
-	 * Beta releases allowed?
-	 *
-	 * @return boolean
-	 */
-	public function isBeta()
-	{
-		return $this->beta;
-	}
-
-	/**
-	 * Set beta releases installation
-	 *
-	 * @param boolean $beta
-	 */
-	public function setBeta($beta = true)
-	{
-		$this->beta = $beta;
-	}
-
-	public function getVersion()
-	{
-		return $this->getObject()->MODULE_VERSION;
-	}
+    /** @var string */
+    private $name;
+
+    /** @var \CModule */
+    private $object;
+
+    /** @var bool */
+    private $beta = false;
+
+    /**
+     * @param string $moduleName
+     */
+    public function __construct($moduleName)
+    {
+        $this->name = $this->normalizeName($moduleName);
+    }
+
+    /**
+     * @param string $moduleName
+     * @return string
+     */
+    protected function normalizeName($moduleName)
+    {
+        return preg_replace("/[^a-zA-Z0-9_.]+/i", "", trim($moduleName));
+    }
+
+    /**
+     * @return \CModule
+     */
+    protected function &getObject()
+    {
+        if (!isset($this->object))
+        {
+            $this->object = \CModule::CreateModuleObject($this->name);
+        }
+
+        if (!is_object($this->object) || !($this->object instanceof \CModule))
+        {
+            unset($this->object);
+            throw new Exception\ModuleNotFoundException('Module not found or incorrect', $this->name);
+        }
+
+        return $this->object;
+    }
+
+    /**
+     * Checks for module and module object existence
+     *
+     * @return bool
+     */
+    public function exist()
+    {
+        try
+        {
+            $this->getObject();
+        }
+        catch (Exception\ModuleNotFoundException $e)
+        {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * Check if module exists and installed
+     *
+     * @return bool
+     */
+    public function isRegistered()
+    {
+        return ModuleManager::isModuleInstalled($this->name) && $this->exist();
+    }
+
+    /**
+     * @return bool true for marketplace modules, false for kernel modules
+     */
+    public function isThirdParty()
+    {
+        return strpos($this->name, '.') !== false;
+    }
+
+    /**
+     * Install module
+     *
+     * @throws Exception\ModuleException
+     * @throws BitrixException
+     */
+    public function register()
+    {
+        if (!$this->isRegistered())
+        {
+            $moduleObject =& $this->getObject();
+
+            /**
+             * It's important to check if module class defines InstallDB method (it must register module)
+             * Thus absent InstallDB indicates that the module does not support automatic installation
+             */
+            if ((new \ReflectionClass($moduleObject))->getMethod('InstallDB')->class !== get_class($moduleObject))
+            {
+                throw new Exception\ModuleInstallException(
+                    'Missing InstallDB method. This module does not support automatic installation',
+                    $this->name
+                );
+            }
+
+            if (!$moduleObject->InstallDB() && BitrixException::hasException())
+            {
+                throw new Exception\ModuleInstallException(
+                    get_class($moduleObject) . '::InstallDB() returned false',
+                    $this->name
+                );
+            }
+
+            $moduleObject->InstallEvents();
+
+            /** @noinspection PhpVoidFunctionResultUsedInspection */
+            if (!$moduleObject->InstallFiles() && BitrixException::hasException())
+            {
+                throw new Exception\ModuleInstallException(
+                    get_class($moduleObject) . '::InstallFiles() returned false',
+                    $this->name
+                );
+            }
+
+            if (!$this->isRegistered())
+            {
+                throw new Exception\ModuleInstallException(
+                    'Module was not registered. Probably it does not support automatic installation.',
+                    $this->name
+                );
+            }
+        }
+
+        return $this;
+    }
+
+    /**
+     * Download module from marketplace
+     *
+     * @return $this
+     */
+    public function load()
+    {
+        if (!$this->isRegistered())
+        {
+            if (!$this->exist())
+            {
+                require_once($_SERVER["DOCUMENT_ROOT"] . '/bitrix/modules/main/classes/general/update_client_partner.php');
+
+                if (!\CUpdateClientPartner::LoadModuleNoDemand(
+                    $this->getName(),
+                    $strError,
+                    $this->isBeta() ? 'N' : 'Y',
+                    LANGUAGE_ID)
+                )
+                {
+                    throw new Exception\ModuleLoadException($strError, $this->getName());
+                }
+            }
+        }
+
+        return $this;
+    }
+
+    /**
+     * Uninstall module
+     *
+     * @throws Exception\ModuleException
+     * @throws BitrixException
+     */
+    public function unRegister()
+    {
+        $moduleObject = $this->getObject();
+
+        if ($this->isRegistered())
+        {
+            /**
+             * It's important to check if module class defines UnInstallDB method (it should unregister module)
+             * Thus absent UnInstallDB indicates that the module does not support automatic uninstallation
+             */
+            if ((new \ReflectionClass($moduleObject))->getMethod('UnInstallDB')->class !== get_class($moduleObject))
+            {
+                throw new Exception\ModuleUninstallException(
+                    'Missing UnInstallDB method. This module does not support automatic uninstallation',
+                    $this->name
+                );
+            }
+
+            /** @noinspection PhpVoidFunctionResultUsedInspection */
+            if (!$moduleObject->UnInstallFiles() && BitrixException::hasException())
+            {
+                throw new Exception\ModuleUninstallException(
+                    get_class($moduleObject) . '::UnInstallFiles() returned false',
+                    $this->name
+                );
+            }
+
+            $moduleObject->UnInstallEvents();
+
+            /** @noinspection PhpVoidFunctionResultUsedInspection */
+            if (!$moduleObject->UnInstallDB() && BitrixException::hasException())
+            {
+                throw new Exception\ModuleUninstallException(
+                    get_class($moduleObject) . '::UnInstallFiles() returned false',
+                    $this->name
+                );
+            }
+
+            if ($this->isRegistered())
+            {
+                throw new Exception\ModuleUninstallException('Module was not unregistered', $this->name);
+            }
+        }
+
+        return $this;
+    }
+
+    /**
+     * Uninstall and remove module directory
+     */
+    public function remove()
+    {
+        if ($this->isRegistered())
+        {
+            $this->unRegister();
+        }
+
+        $path = getLocalPath('modules/' . $this->getName());
+
+        if ($path)
+        {
+            (new Filesystem())->remove($_SERVER['DOCUMENT_ROOT'] . $path);
+        }
+
+        unset($this->object);
+
+        return $this;
+    }
+
+    /**
+     * Update module
+     *
+     * It must be called repeatedly until the method returns false.
+     * After each call php must be restarted (new process created) to update module class and function definitions.
+     *
+     * @param array $modulesUpdated [optional]
+     * @return bool
+     */
+    public function update(&$modulesUpdated = null)
+    {
+        require_once($_SERVER["DOCUMENT_ROOT"] . '/bitrix/modules/main/classes/general/update_client_partner.php');
+
+        if (!$this->isThirdParty())
+        {
+            throw new Exception\ModuleUpdateException('Kernel module updates are currently not supported.', $this->getName());
+        }
+
+        // ensures module existence
+        $this->getObject();
+
+        $errorMessage = $updateDescription = null;
+        $loadResult = \CUpdateClientPartner::LoadModulesUpdates(
+            $errorMessage,
+            $updateDescription,
+            LANGUAGE_ID,
+            $this->isBeta() ? 'N' : 'Y',
+            [$this->getName()],
+            true
+        );
+        switch ($loadResult)
+        {
+            // archive loaded
+            case "S":
+                return $this->update($modulesUpdated);
+
+            // error
+            case "E":
+                throw new Exception\ModuleUpdateException($errorMessage, $this->getName());
+
+            // finished installing updates
+            case "F":
+                return false;
+
+            // need to process loaded update
+            case 'U':
+                break;
+        }
+
+        /** @var string Temp directory with update files */
+        $updateDir = null;
+
+        if (!\CUpdateClientPartner::UnGzipArchive($updateDir, $errorMessage, true))
+        {
+            throw new Exception\ModuleUpdateException('[CL02] UnGzipArchive failed. ' . $errorMessage, $this->getName());
+        }
+
+        $this->validateUpdate($updateDir);
+
+        if (isset($updateDescription["DATA"]["#"]["NOUPDATES"]))
+        {
+            \CUpdateClientPartner::ClearUpdateFolder($_SERVER["DOCUMENT_ROOT"] . "/bitrix/updates/" . $updateDir);
+            return false;
+        }
+
+        $modulesUpdated = $updateDescr = [];
+        if (isset($updateDescription["DATA"]["#"]["ITEM"]))
+        {
+            foreach ($updateDescription["DATA"]["#"]["ITEM"] as $moduleInfo)
+            {
+                $modulesUpdated[$moduleInfo["@"]["NAME"]] = $moduleInfo["@"]["VALUE"];
+                $updateDescr[$moduleInfo["@"]["NAME"]] = $moduleInfo["@"]["DESCR"];
+            }
+        }
+
+        if (\CUpdateClientPartner::UpdateStepModules($updateDir, $errorMessage))
+        {
+            foreach ($modulesUpdated as $key => $value)
+            {
+                if (Option::set('main', 'event_log_marketplace', "Y") === "Y")
+                {
+                    \CEventLog::Log("INFO", "MP_MODULE_DOWNLOADED", "main", $key, $value);
+                }
+            }
+        }
+        else
+        {
+            throw new Exception\ModuleUpdateException('[CL04] UpdateStepModules failed. ' . $errorMessage, $this->getName());
+        }
+
+        return true;
+    }
+
+    /**
+     * Check update files
+     * 
+     * @param string $updateDir
+     */
+    protected function validateUpdate($updateDir)
+    {
+        $errorMessage = null;
+        if (!\CUpdateClientPartner::CheckUpdatability($updateDir, $errorMessage))
+        {
+            throw new Exception\ModuleUpdateException('[CL03] CheckUpdatability failed. ' . $errorMessage, $this->getName());
+        }
+
+        if (isset($updateDescription["DATA"]["#"]["ERROR"]))
+        {
+            $errorMessage = "";
+            foreach ($updateDescription["DATA"]["#"]["ERROR"] as $errorDescription)
+            {
+                $errorMessage .= "[" . $errorDescription["@"]["TYPE"] . "] " . $errorDescription["#"];
+            }
+            throw new Exception\ModuleUpdateException($errorMessage, $this->getName());
+        }
+    }
+
+    /**
+     * Returns module name
+     *
+     * @return string
+     */
+    public function getName()
+    {
+        return $this->name;
+    }
+
+    /**
+     * Beta releases allowed?
+     *
+     * @return boolean
+     */
+    public function isBeta()
+    {
+        return $this->beta;
+    }
+
+    /**
+     * Set beta releases installation
+     *
+     * @param boolean $beta
+     */
+    public function setBeta($beta = true)
+    {
+        $this->beta = $beta;
+    }
+
+    public function getVersion()
+    {
+        return $this->getObject()->MODULE_VERSION;
+    }
 }
\ No newline at end of file

Spacing +14 added lines, -14 removed lines

@@ -110,7 +110,7 @@ 
 	{
 		if (!$this->isRegistered())
 		{
-			$moduleObject =& $this->getObject();
+			$moduleObject = & $this->getObject();
 
 			/**
 			 * It's important to check if module class defines InstallDB method (it must register module)
@@ -127,7 +127,7 @@ 
 			if (!$moduleObject->InstallDB() && BitrixException::hasException())
 			{
 				throw new Exception\ModuleInstallException(
-					get_class($moduleObject) . '::InstallDB() returned false',
+					get_class($moduleObject).'::InstallDB() returned false',
 					$this->name
 				);
 			}
@@ -138,7 +138,7 @@ 
 			if (!$moduleObject->InstallFiles() && BitrixException::hasException())
 			{
 				throw new Exception\ModuleInstallException(
-					get_class($moduleObject) . '::InstallFiles() returned false',
+					get_class($moduleObject).'::InstallFiles() returned false',
 					$this->name
 				);
 			}
@@ -166,7 +166,7 @@ 
 		{
 			if (!$this->exist())
 			{
-				require_once($_SERVER["DOCUMENT_ROOT"] . '/bitrix/modules/main/classes/general/update_client_partner.php');
+				require_once($_SERVER["DOCUMENT_ROOT"].'/bitrix/modules/main/classes/general/update_client_partner.php');
 
 				if (!\CUpdateClientPartner::LoadModuleNoDemand(
 					$this->getName(),
@@ -211,7 +211,7 @@ 
 			if (!$moduleObject->UnInstallFiles() && BitrixException::hasException())
 			{
 				throw new Exception\ModuleUninstallException(
-					get_class($moduleObject) . '::UnInstallFiles() returned false',
+					get_class($moduleObject).'::UnInstallFiles() returned false',
 					$this->name
 				);
 			}
@@ -222,7 +222,7 @@ 
 			if (!$moduleObject->UnInstallDB() && BitrixException::hasException())
 			{
 				throw new Exception\ModuleUninstallException(
-					get_class($moduleObject) . '::UnInstallFiles() returned false',
+					get_class($moduleObject).'::UnInstallFiles() returned false',
 					$this->name
 				);
 			}
@@ -246,11 +246,11 @@ 
 			$this->unRegister();
 		}
 
-		$path = getLocalPath('modules/' . $this->getName());
+		$path = getLocalPath('modules/'.$this->getName());
 
 		if ($path)
 		{
-			(new Filesystem())->remove($_SERVER['DOCUMENT_ROOT'] . $path);
+			(new Filesystem())->remove($_SERVER['DOCUMENT_ROOT'].$path);
 		}
 
 		unset($this->object);
@@ -269,7 +269,7 @@ 
 	 */
 	public function update(&$modulesUpdated = null)
 	{
-		require_once($_SERVER["DOCUMENT_ROOT"] . '/bitrix/modules/main/classes/general/update_client_partner.php');
+		require_once($_SERVER["DOCUMENT_ROOT"].'/bitrix/modules/main/classes/general/update_client_partner.php');
 
 		if (!$this->isThirdParty())
 		{
@@ -312,14 +312,14 @@ 
 
 		if (!\CUpdateClientPartner::UnGzipArchive($updateDir, $errorMessage, true))
 		{
-			throw new Exception\ModuleUpdateException('[CL02] UnGzipArchive failed. ' . $errorMessage, $this->getName());
+			throw new Exception\ModuleUpdateException('[CL02] UnGzipArchive failed. '.$errorMessage, $this->getName());
 		}
 
 		$this->validateUpdate($updateDir);
 
 		if (isset($updateDescription["DATA"]["#"]["NOUPDATES"]))
 		{
-			\CUpdateClientPartner::ClearUpdateFolder($_SERVER["DOCUMENT_ROOT"] . "/bitrix/updates/" . $updateDir);
+			\CUpdateClientPartner::ClearUpdateFolder($_SERVER["DOCUMENT_ROOT"]."/bitrix/updates/".$updateDir);
 			return false;
 		}
 
@@ -345,7 +345,7 @@ 
 		}
 		else
 		{
-			throw new Exception\ModuleUpdateException('[CL04] UpdateStepModules failed. ' . $errorMessage, $this->getName());
+			throw new Exception\ModuleUpdateException('[CL04] UpdateStepModules failed. '.$errorMessage, $this->getName());
 		}
 
 		return true;
@@ -361,7 +361,7 @@ 
 		$errorMessage = null;
 		if (!\CUpdateClientPartner::CheckUpdatability($updateDir, $errorMessage))
 		{
-			throw new Exception\ModuleUpdateException('[CL03] CheckUpdatability failed. ' . $errorMessage, $this->getName());
+			throw new Exception\ModuleUpdateException('[CL03] CheckUpdatability failed. '.$errorMessage, $this->getName());
 		}
 
 		if (isset($updateDescription["DATA"]["#"]["ERROR"]))
@@ -369,7 +369,7 @@ 
 			$errorMessage = "";
 			foreach ($updateDescription["DATA"]["#"]["ERROR"] as $errorDescription)
 			{
-				$errorMessage .= "[" . $errorDescription["@"]["TYPE"] . "] " . $errorDescription["#"];
+				$errorMessage .= "[".$errorDescription["@"]["TYPE"]."] ".$errorDescription["#"];
 			}
 			throw new Exception\ModuleUpdateException($errorMessage, $this->getName());
 		}

src/Module/Exception/ModuleException.php

Indentation +11 added lines, -11 removed lines

@@ -8,15 +8,15 @@
 
 class ModuleException extends \RuntimeException
 {
-	/**
-	 * ModuleException constructor.
-	 *
-	 * @param string $message
-	 * @param int $moduleName
-	 * @param \Exception|null $previous
-	 */
-	public function __construct($message, $moduleName, \Exception $previous = null)
-	{
-		parent::__construct("[$moduleName] " . $message, 0, $previous);
-	}
+    /**
+     * ModuleException constructor.
+     *
+     * @param string $message
+     * @param int $moduleName
+     * @param \Exception|null $previous
+     */
+    public function __construct($message, $moduleName, \Exception $previous = null)
+    {
+        parent::__construct("[$moduleName] " . $message, 0, $previous);
+    }
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -17,6 +17,6 @@
 	 */
 	public function __construct($message, $moduleName, \Exception $previous = null)
 	{
-		parent::__construct("[$moduleName] " . $message, 0, $previous);
+		parent::__construct("[$moduleName] ".$message, 0, $previous);
 	}
 }
\ No newline at end of file

src/Module/Command/RegisterCommand.php

Indentation +18 added lines, -18 removed lines

@@ -17,24 +17,24 @@
  */
 class RegisterCommand extends ModuleCommand
 {
-	/**
-	 * {@inheritdoc}
-	 */
-	protected function configure()
-	{
-		parent::configure();
+    /**
+     * {@inheritdoc}
+     */
+    protected function configure()
+    {
+        parent::configure();
 
-		$this->setName('module:register')
-			->setDescription('Install module');
-	}
+        $this->setName('module:register')
+            ->setDescription('Install module');
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	protected function execute(InputInterface $input, OutputInterface $output)
-	{
-		$module = new Module($input->getArgument('module'));
-		$module->register();
-		$output->writeln(sprintf('registered <info>%s</info>', $module->getName()));
-	}
+    /**
+     * {@inheritdoc}
+     */
+    protected function execute(InputInterface $input, OutputInterface $output)
+    {
+        $module = new Module($input->getArgument('module'));
+        $module->register();
+        $output->writeln(sprintf('registered <info>%s</info>', $module->getName()));
+    }
 }
\ No newline at end of file

src/Module/Command/LoadCommand.php

Braces +1 added lines, -2 removed lines

@@ -75,8 +75,7 @@
 			try
 			{
 				$module->register();
-			}
-			catch (ModuleInstallException $e)
+			} catch (ModuleInstallException $e)
 			{
 				$output->writeln(sprintf('<comment>%s</comment>', $e->getMessage()), OutputInterface::VERBOSITY_VERBOSE);
 				$output->writeln(sprintf('Module loaded, but <error>not registered</error>. You need to do it yourself in admin panel.', $module->getName()));

Indentation +58 added lines, -58 removed lines

@@ -20,72 +20,72 @@
  */
 class LoadCommand extends ModuleCommand
 {
-	use CanRestartTrait;
+    use CanRestartTrait;
 
-	/**
-	 * {@inheritdoc}
-	 */
-	protected function configure()
-	{
-		parent::configure();
+    /**
+     * {@inheritdoc}
+     */
+    protected function configure()
+    {
+        parent::configure();
 
-		$this->setName('module:load')
-			->setDescription('Load and install module from Marketplace')
-			->addOption('no-update', 'nu', InputOption::VALUE_NONE, 'Don\' update module')
-			->addOption('no-register', 'ni', InputOption::VALUE_NONE, 'Load only, don\' register module')
-			->addOption('beta', 'b', InputOption::VALUE_NONE, 'Allow the installation of beta releases');
-	}
+        $this->setName('module:load')
+            ->setDescription('Load and install module from Marketplace')
+            ->addOption('no-update', 'nu', InputOption::VALUE_NONE, 'Don\' update module')
+            ->addOption('no-register', 'ni', InputOption::VALUE_NONE, 'Load only, don\' register module')
+            ->addOption('beta', 'b', InputOption::VALUE_NONE, 'Allow the installation of beta releases');
+    }
 
-	/**
-	 * {@inheritdoc}
-	 */
-	protected function execute(InputInterface $input, OutputInterface $output)
-	{
-		$module = new Module($input->getArgument('module'));
+    /**
+     * {@inheritdoc}
+     */
+    protected function execute(InputInterface $input, OutputInterface $output)
+    {
+        $module = new Module($input->getArgument('module'));
 
-		if (!$module->isThirdParty())
-		{
-			$output->writeln('<info>Loading kernel modules is unsupported</info>');
-		}
+        if (!$module->isThirdParty())
+        {
+            $output->writeln('<info>Loading kernel modules is unsupported</info>');
+        }
 
-		if ($input->getOption('beta'))
-		{
-			$module->setBeta();
-		}
+        if ($input->getOption('beta'))
+        {
+            $module->setBeta();
+        }
 
-		$module->load();
+        $module->load();
 
-		if (!$input->getOption('no-update'))
-		{
-			$modulesUpdated = null;
-			while ($module->update($modulesUpdated))
-			{
-				if (is_array($modulesUpdated))
-				{
-					foreach ($modulesUpdated as $moduleName => $moduleVersion)
-					{
-						$output->writeln(sprintf('updated %s to <info>%s</info>', $moduleName, $moduleVersion));
-					}
-				}
-				return $this->restartScript($input, $output);
-			}
-		}
+        if (!$input->getOption('no-update'))
+        {
+            $modulesUpdated = null;
+            while ($module->update($modulesUpdated))
+            {
+                if (is_array($modulesUpdated))
+                {
+                    foreach ($modulesUpdated as $moduleName => $moduleVersion)
+                    {
+                        $output->writeln(sprintf('updated %s to <info>%s</info>', $moduleName, $moduleVersion));
+                    }
+                }
+                return $this->restartScript($input, $output);
+            }
+        }
 
-		if (!$input->getOption('no-register'))
-		{
-			try
-			{
-				$module->register();
-			}
-			catch (ModuleInstallException $e)
-			{
-				$output->writeln(sprintf('<comment>%s</comment>', $e->getMessage()), OutputInterface::VERBOSITY_VERBOSE);
-				$output->writeln(sprintf('Module loaded, but <error>not registered</error>. You need to do it yourself in admin panel.', $module->getName()));
-			}
-		}
+        if (!$input->getOption('no-register'))
+        {
+            try
+            {
+                $module->register();
+            }
+            catch (ModuleInstallException $e)
+            {
+                $output->writeln(sprintf('<comment>%s</comment>', $e->getMessage()), OutputInterface::VERBOSITY_VERBOSE);
+                $output->writeln(sprintf('Module loaded, but <error>not registered</error>. You need to do it yourself in admin panel.', $module->getName()));
+            }
+        }
 
-		$output->writeln(sprintf('installed <info>%s</info>', $module->getName()));
+        $output->writeln(sprintf('installed <info>%s</info>', $module->getName()));
 
-		return 0;
-	}
+        return 0;
+    }
 }
\ No newline at end of file

src/Cache/Command/ClearCommand.php

Braces +1 added lines, -2 removed lines

@@ -51,8 +51,7 @@
             if (Cache::clearCache(true))
             {
                 $output->writeln('<info>All Bitrix cache was deleted</info>');
-            }
-            else
+            } else
             {
                 $output->writeln('<error>Error deleting Bitrix cache</error>');
             }

Spacing +2 added lines, -2 removed lines

@@ -61,13 +61,13 @@
         if ($dir)
         {
             $cache->cleanDir($dir);
-            $output->writeln('<info>Bitrix cache by "/' . BX_ROOT . '/cache/' . $dir . '" dir was deleted</info>');
+            $output->writeln('<info>Bitrix cache by "/'.BX_ROOT.'/cache/'.$dir.'" dir was deleted</info>');
         }
 
         if ($tag)
         {
             Application::getInstance()->getTaggedCache()->clearByTag($tag);
-            $output->writeln('<info>Bitrix cache by tag "' . $tag . '" was deleted</info>');
+            $output->writeln('<info>Bitrix cache by tag "'.$tag.'" was deleted</info>');
         }
     }
 }
\ No newline at end of file

src/Agent/AgentTrait.php

Braces +1 added lines, -2 removed lines

@@ -108,8 +108,7 @@
             {
                 // @todo warning
             }
-        }
-        else
+        } else
         {
             // @todo warning
         }