nordsoftware / lumen-fractal

src/Contracts/FractalService.php

Doc Comments +4 added lines, -2 removed lines

@@ -13,7 +13,7 @@ 
      * Serializes a single item.
      *
      * @param mixed                             $data
-     * @param TransformerAbstract|callable|null $transformer
+     * @param null|TransformerAbstract $transformer
      * @param string|null                       $resourceKey
      *
      * @return FractalBuilder
@@ -25,7 +25,7 @@ 
      * Serializes a collection of items.
      *
      * @param mixed                             $data
-     * @param TransformerAbstract|callable|null $transformer
+     * @param null|TransformerAbstract $transformer
      * @param string|null                       $resourceKey
      *
      * @return FractalBuilder
@@ -40,6 +40,7 @@ 
      * @param string|array $includes
      *
      * @see http://fractal.thephpleague.com/transformers#including-data
+     * @return void
      */
     public function parseIncludes($includes);
 
@@ -50,6 +51,7 @@ 
      * @param SerializerAbstract $serializer
      *
      * @see http://fractal.thephpleague.com/serializers/
+     * @return void
      */
     public function setDefaultSerializer(SerializerAbstract $serializer);
 }

src/FractalServiceProvider.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Illuminate\Contracts\Config\Repository as ConfigRepository;
 use Illuminate\Contracts\Container\Container;
 use Illuminate\Support\ServiceProvider;
-use Laravel\Lumen\Application;
 use Nord\Lumen\Fractal\Contracts\FractalService as FractalServiceContract;
 
 class FractalServiceProvider extends ServiceProvider

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
      */
     protected function registerBindings(Container $container, ConfigRepository $config)
     {
-        $container->singleton(FractalService::class, function () use ($config) {
+        $container->singleton(FractalService::class, function() use ($config) {
             $fractal = new FractalService();
 
             $this->configureService($fractal, $config[self::CONFIG_KEY]);

tests/unit/FractalMiddlewareTest.php

Spacing +2 added lines, -2 removed lines

@@ -34,11 +34,11 @@
      */
     public function testAssertParseInclude()
     {
-        $this->specify('verify middleware parse include', function () {
+        $this->specify('verify middleware parse include', function() {
             $req = new Request();
             $req->offsetSet('include', 'foo,bar,baz');
 
-            verify($this->middleware->handle($req, function () {
+            verify($this->middleware->handle($req, function() {
                 return true;
             }))->equals(true);
         });

tests/unit/FractalServiceProviderTest.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
      */
     public function testAssertCanBeRegistered()
     {
-        $this->specify('verify serviceProvider is registered', function () {
+        $this->specify('verify serviceProvider is registered', function() {
             $service = $this->app->make(FractalService::class);
             verify($service)->isInstanceOf(FractalService::class);
         });
@@ -41,7 +41,7 @@ 
      */
     public function testAssertFacade()
     {
-        $this->specify('verify serviceProvider facade', function () {
+        $this->specify('verify serviceProvider facade', function() {
             verify(FractalFacade::getFacadeRoot())->isInstanceOf(FractalService::class);
         });
     }

tests/unit/FractalServiceTest.php

Spacing +18 added lines, -18 removed lines

@@ -53,12 +53,12 @@ 
      */
     public function testItem()
     {
-        $this->specify('The key "data" is required.', function () {
+        $this->specify('The key "data" is required.', function() {
             $item = $this->service->item($this->book, $this->transformer)->toArray();
             verify($item)->hasKey('data');
         });
 
-        $this->specify('The book title must equal "Test Book".', function () {
+        $this->specify('The book title must equal "Test Book".', function() {
             $item = $this->service->item($this->book, $this->transformer)->toArray();
             verify($item['data']['title'])->equals('Test Book');
         });
@@ -69,7 +69,7 @@ 
      */
     public function testCollection()
     {
-        $this->specify('Array does not contain specified amount of items', function () {
+        $this->specify('Array does not contain specified amount of items', function() {
             $collection = $this->service->collection([$this->book], $this->transformer)->toArray();
             verify(count($collection['data']))->equals(1);
             verify(count($collection['data']))->equals(1);
@@ -81,12 +81,12 @@ 
      */
     public function testAuthorInclude()
     {
-        $this->specify('The key "data" is required.', function () {
+        $this->specify('The key "data" is required.', function() {
             $item = $this->service->item($this->book, $this->transformer)->toArray();
             verify($item)->hasKey('data');
         });
 
-        $this->specify('Author last name must be "Author".', function () {
+        $this->specify('Author last name must be "Author".', function() {
             $item = $this->service->item($this->book, $this->transformer)->toArray();
             verify($item['data']['author'])->hasKey('data');
             verify($item['data']['author']['data'])->hasKey('lastName');
@@ -103,7 +103,7 @@ 
             'foo' => 'bar'
         ];
 
-        $this->specify('The key "meta" is required for item.', function () use ($meta) {
+        $this->specify('The key "meta" is required for item.', function() use ($meta) {
             $item = $this->service->item($this->book, $this->transformer)
                 ->setMeta($meta)
                 ->toArray();
@@ -111,7 +111,7 @@ 
             verify($item['meta'])->equals($meta);
         });
 
-        $this->specify('The key "meta" is required for collection.', function () use ($meta) {
+        $this->specify('The key "meta" is required for collection.', function() use ($meta) {
             $collection = $this->service->collection([$this->book], $this->transformer)
                 ->setMeta($meta)
                 ->toArray();
@@ -125,12 +125,12 @@ 
      */
     public function testAssertJson()
     {
-        $this->specify('The item has to be in JSON format.', function () {
+        $this->specify('The item has to be in JSON format.', function() {
             $item = $this->service->item($this->book, $this->transformer)->toJson();
             verify($item)->equals('{"data":{"title":"Test Book","publisher":"Test Publisher","author":{"data":{"firstName":"Test","lastName":"Author"}}}}');
         });
 
-        $this->specify('The collection has to be in JSON format.', function () {
+        $this->specify('The collection has to be in JSON format.', function() {
             $collection = $this->service->collection([$this->book], $this->transformer)->toJson();
             verify($collection)->equals('{"data":[{"title":"Test Book","publisher":"Test Publisher","author":{"data":{"firstName":"Test","lastName":"Author"}}}]}');
         });
@@ -141,7 +141,7 @@ 
      */
     public function testAssertSerializer()
     {
-        $this->specify('The serializer is array serializer', function () {
+        $this->specify('The serializer is array serializer', function() {
             $builder = $this->service->item($this->book, $this->transformer);
             $builder->setSerializer(new ArraySerializer());
             $item = $builder->toArray();
@@ -155,7 +155,7 @@ 
             ]);
         });
 
-        $this->specify('The serializer is data array serializer', function () {
+        $this->specify('The serializer is data array serializer', function() {
             $builder = $this->service->item($this->book, $this->transformer);
             $builder->setSerializer(new DataArraySerializer());
             $item = $builder->toArray();
@@ -179,19 +179,19 @@ 
      */
     public function testAssertResourceKey()
     {
-        $this->specify('The fractal builder resource key can be set.', function () {
+        $this->specify('The fractal builder resource key can be set.', function() {
             $item = $this->service->item($this->book, $this->transformer);
             $item->setResourceKey('book');
             $array = $item->toArray();
             verify($array)->hasKey('data');
         });
 
-        $this->specify('The fractal service can set the builder resource key.', function () {
+        $this->specify('The fractal service can set the builder resource key.', function() {
             $item = $this->service->item($this->book, $this->transformer, 'book')->toArray();
             verify($item)->hasKey('data');
         });
 
-        $this->specify('The fractal builder resource key has to be valid.', function () {
+        $this->specify('The fractal builder resource key has to be valid.', function() {
             $item = $this->service->item($this->book, $this->transformer);
             $item->setResourceKey(123);
         }, ['throws' => 'Nord\Lumen\Fractal\Exceptions\InvalidArgument']);
@@ -202,7 +202,7 @@ 
      */
     public function testAssertPaginator()
     {
-        $this->specify('The collection can have a paginator', function () {
+        $this->specify('The collection can have a paginator', function() {
             $books = [$this->book];
             $collection = $this->service->collection($books, $this->transformer)
                 ->setPaginator(new BookPaginator($books))
@@ -211,7 +211,7 @@ 
             verify($collection['meta'])->hasKey('pagination');
         });
 
-        $this->specify('The item cannot have a paginator', function () {
+        $this->specify('The item cannot have a paginator', function() {
             $this->service->item($this->book, $this->transformer)
                 ->setPaginator(new BookPaginator([]))
                 ->toArray();
@@ -223,14 +223,14 @@ 
      */
     public function testAssertCursor()
     {
-        $this->specify('The collection can have a cursor', function () {
+        $this->specify('The collection can have a cursor', function() {
             $collection = $this->service->collection([$this->book], $this->transformer)
                 ->setCursor(new Cursor())
                 ->toArray();
             verify(count($collection['data']))->equals(1);
         });
 
-        $this->specify('The item cannot have a cursor', function () {
+        $this->specify('The item cannot have a cursor', function() {
             $this->service->item($this->book, $this->transformer)
                 ->setCursor(new Cursor())
                 ->toArray();

tests/unit/_bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
 <?php
 // Here you can initialize variables that will be available to your tests
 
-require_once __DIR__ . '/../_support/Mock/MockApplication.php';
+require_once __DIR__.'/../_support/Mock/MockApplication.php';