noplanman / wp-to-diaspora

lib/class-wp2d-api.php

Doc Comments +2 added lines, -2 removed lines

@@ -629,7 +629,7 @@ 
 	 * @param string $url  The URL to request.
 	 * @param array  $args Arguments to be posted with the request.
 	 *
-	 * @return object An object containing details about this request.
+	 * @return string An object containing details about this request.
 	 */
 	private function request( $url, array $args = [] ) {
 		// Prefix the full pod URL if necessary.
@@ -700,7 +700,7 @@ 
 	 *
 	 * @see   WP_Error::__construct()
 	 *
-	 * @param string|int $code    Error code.
+	 * @param string $code    Error code.
 	 * @param string     $message Error message.
 	 * @param mixed      $data    Error data.
 	 */

Spacing +13 added lines, -13 removed lines

@@ -102,14 +102,14 @@ 
 	 *
 	 * @var array
 	 */
-	private $aspects = [];
+	private $aspects = [ ];
 
 	/**
 	 * The list of user's connected services, which get set after ever http request.
 	 *
 	 * @var array
 	 */
-	private $services = [];
+	private $services = [ ];
 
 	/**
 	 * List of regex expressions used to filter out details from http request responses.
@@ -382,8 +382,8 @@ 
 		$this->is_logged_in = false;
 		$this->username     = null;
 		$this->password     = null;
-		$this->aspects      = [];
-		$this->services     = [];
+		$this->aspects      = [ ];
+		$this->services     = [ ];
 	}
 
 	/**
@@ -395,7 +395,7 @@ 
 		$this->logout();
 		$this->last_error   = null;
 		$this->token        = null;
-		$this->cookies      = [];
+		$this->cookies      = [ ];
 		$this->last_request = null;
 	}
 
@@ -408,7 +408,7 @@ 
 	 *
 	 * @return bool|object Return the response data of the new diaspora* post if successfully posted, else false.
 	 */
-	public function post( $text, $aspects = 'public', array $extra_data = [] ) {
+	public function post( $text, $aspects = 'public', array $extra_data = [ ] ) {
 		// Are we logged in?
 		if ( ! $this->check_login() ) {
 			return false;
@@ -600,11 +600,11 @@ 
 			$raw_list = json_decode( $this->parse_regex( $type, $response->body ) );
 			if ( is_array( $raw_list ) ) {
 				// In case this fetch is forced, empty the list.
-				$list = [];
+				$list = [ ];
 
 				if ( 'aspects' === $type ) {
 					// Add the 'public' aspect, as it's global and not user specific.
-					$list['public'] = __( 'Public', 'wp-to-diaspora' );
+					$list[ 'public' ] = __( 'Public', 'wp-to-diaspora' );
 
 					// Add all user specific aspects.
 					foreach ( $raw_list as $aspect ) {
@@ -631,7 +631,7 @@ 
 	 *
 	 * @return object An object containing details about this request.
 	 */
-	private function request( $url, array $args = [] ) {
+	private function request( $url, array $args = [ ] ) {
 		// Prefix the full pod URL if necessary.
 		if ( 0 === strpos( $url, '/' ) ) {
 			$url = $this->get_pod_url( $url );
@@ -648,12 +648,12 @@ 
 		// If the certificate bundle has been downloaded manually, use that instead.
 		// NOTE: This should actually never be necessary, it's a fallback!
 		if ( file_exists( WP2D_DIR . '/cacert.pem' ) ) {
-			$defaults['sslcertificates'] = WP2D_DIR . '/cacert.pem';
+			$defaults[ 'sslcertificates' ] = WP2D_DIR . '/cacert.pem';
 		}
 
 		// Set the correct cookie.
 		if ( ! empty( $this->cookies ) ) {
-			$defaults['cookies'] = $this->cookies;
+			$defaults[ 'cookies' ] = $this->cookies;
 		}
 
 		$args = wp_parse_args( $args, $defaults );
@@ -685,8 +685,8 @@ 
 		}
 
 		// Save the latest cookies.
-		if ( isset( $response['cookies'] ) ) {
-			$this->cookies = $response['cookies'];
+		if ( isset( $response[ 'cookies' ] ) ) {
+			$this->cookies = $response[ 'cookies' ];
 		}
 
 		// Return the last request details.

lib/class-wp2d-options.php

Doc Comments +4 added lines, -4 removed lines

@@ -869,7 +869,7 @@ 
 	/**
 	 * Validate checkboxes, make them either true or false.
 	 *
-	 * @param string|array $checkboxes Checkboxes to validate.
+	 * @param string[] $checkboxes Checkboxes to validate.
 	 * @param array        $options    Options values themselves.
 	 *
 	 * @return array The validated options.
@@ -885,7 +885,7 @@ 
 	/**
 	 * Validate single-select fields and make sure their selected value are valid.
 	 *
-	 * @param string|array $selects Name(s) of the select fields.
+	 * @param string $selects Name(s) of the select fields.
 	 * @param array        $options Options values themselves.
 	 *
 	 * @return array The validated options.
@@ -903,7 +903,7 @@ 
 	/**
 	 * Validate multi-select fields and make sure their selected values are valid.
 	 *
-	 * @param string|array $selects Name(s) of the select fields.
+	 * @param string $selects Name(s) of the select fields.
 	 * @param array        $options Options values themselves.
 	 *
 	 * @return array The validated options.
@@ -963,7 +963,7 @@ 
 	 * Validate the passed aspects or services.
 	 *
 	 * @param array $aspects_services List of aspects or services that need to be validated.
-	 * @param array $default          Default value if not valid.
+	 * @param string[] $default          Default value if not valid.
 	 *
 	 * @return array The validated list of aspects or services.
 	 */

Spacing +30 added lines, -30 removed lines

@@ -27,8 +27,8 @@ 
 	 * @var array
 	 */
 	private static $default_options = [
-		'aspects_list'       => [],
-		'services_list'      => [],
+		'aspects_list'       => [ ],
+		'services_list'      => [ ],
 		'post_to_diaspora'   => true,
 		'enabled_post_types' => [ 'post' ],
 		'fullentrylink'      => true,
@@ -36,7 +36,7 @@ 
 		'tags_to_post'       => [ 'global', 'custom', 'post' ],
 		'global_tags'        => '',
 		'aspects'            => [ 'public' ],
-		'services'           => [],
+		'services'           => [ ],
 		'auth_key_hash'      => '',
 		'version'            => WP2D_VERSION,
 	];
@@ -106,7 +106,7 @@ 
 	 * @return string Return the currently selected tab.
 	 */
 	private function current_tab( $default = 'defaults' ) {
-		$tab = sanitize_key( $_GET['tab'] ?? $default ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended
+		$tab = sanitize_key( $_GET[ 'tab' ] ?? $default ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended
 
 		// If the pod settings aren't configured yet, open the 'Setup' tab.
 		if ( ! $this->is_pod_set_up() ) {
@@ -125,13 +125,13 @@ 
 	 */
 	private function options_page_tabs( $return = false ) {
 		// The array defining all options sections to be shown as tabs.
-		$tabs = [];
+		$tabs = [ ];
 		if ( $this->is_pod_set_up() ) {
-			$tabs['defaults'] = __( 'Defaults', 'wp-to-diaspora' );
+			$tabs[ 'defaults' ] = __( 'Defaults', 'wp-to-diaspora' );
 		}
 
 		// Add the 'Setup' tab to the end of the list.
-		$tabs['setup'] = __( 'Setup', 'wp-to-diaspora' ) . '<span id="pod-connection-status" class="dashicons-before hidden"></span><span class="spinner"></span>';
+		$tabs[ 'setup' ] = __( 'Setup', 'wp-to-diaspora' ) . '<span id="pod-connection-status" class="dashicons-before hidden"></span><span class="spinner"></span>';
 
 		// Container for all options tabs.
 		$out = '<h2 id="options-tabs" class="nav-tab-wrapper">';
@@ -149,7 +149,7 @@ 
 			return $tabs;
 		}
 
-		return [];
+		return [ ];
 	}
 
 
@@ -225,7 +225,7 @@ 
 				do_settings_sections( 'wp_to_diaspora_settings' );
 
 				// Get the name of the current tab, if set, else take the first one from the list.
-				$tab = $this->current_tab( $page_tabs[0] );
+				$tab = $this->current_tab( $page_tabs[ 0 ] );
 
 				// Add Save and Reset buttons.
 				echo '<input id="submit-' . esc_attr( $tab ) . '" name="wp_to_diaspora_settings[submit_' . esc_attr( $tab ) . ']" type="submit" class="button-primary" value="' . esc_attr__( 'Save Changes', 'wp-to-diaspora' ) . '" />&nbsp;';
@@ -773,14 +773,14 @@ 
 					esc_url( 'https://' . $this->get_option( 'pod' ) . '/services' ),
 					esc_html__( 'Show available services on my pod.', 'wp-to-diaspora' )
 				);
-				$empty_label    = esc_html__( 'No services connected yet.', 'wp-to-diaspora' );
+				$empty_label = esc_html__( 'No services connected yet.', 'wp-to-diaspora' );
 				break;
 
 			default:
 				return;
 		}
 
-		$items = array_filter( (array) $items ) ?: [];
+		$items = array_filter( (array) $items ) ? : [ ];
 
 		// Special case for this field if it's displayed on the settings page.
 		$on_settings_page = ( 'settings_page_wp_to_diaspora' === get_current_screen()->id );
@@ -930,19 +930,19 @@ 
 		/* Validate all settings before saving to the database. */
 
 		// Saving the pod setup details.
-		if ( isset( $input['submit_setup'] ) ) {
-			$input['pod']      = trim( sanitize_text_field( $input['pod'] ), ' /' );
-			$input['username'] = sanitize_text_field( $input['username'] );
-			$input['password'] = sanitize_text_field( $input['password'] );
+		if ( isset( $input[ 'submit_setup' ] ) ) {
+			$input[ 'pod' ]      = trim( sanitize_text_field( $input[ 'pod' ] ), ' /' );
+			$input[ 'username' ] = sanitize_text_field( $input[ 'username' ] );
+			$input[ 'password' ] = sanitize_text_field( $input[ 'password' ] );
 
 			// If password is blank, it hasn't been changed.
 			// If new password is equal to the encrypted password already saved, it was just passed again. It happens everytime update_option('wp_to_diaspora_settings') is called.
-			if ( '' === $input['password'] || $this->get_option( 'password' ) === $input['password'] ) {
+			if ( '' === $input[ 'password' ] || $this->get_option( 'password' ) === $input[ 'password' ] ) {
 				// Attempt a password upgrade if applicable.
 				$this->attempt_password_upgrade( true );
-				$input['password'] = $this->get_option( 'password' );
+				$input[ 'password' ] = $this->get_option( 'password' );
 			} else {
-				$input['password'] = WP2D_Helpers::encrypt( $input['password'] );
+				$input[ 'password' ] = WP2D_Helpers::encrypt( $input[ 'password' ] );
 			}
 
 			// Keep a note of the current AUTH_KEY.
@@ -950,15 +950,15 @@ 
 
 			// This is for when JS in not enabled, to make sure that the aspects and services
 			// are re-fetched when displaying the options page after saving.
-			if ( isset( $input['no_js'] ) ) {
+			if ( isset( $input[ 'no_js' ] ) ) {
 				set_transient( 'wp2d_no_js_force_refetch', true );
 			}
 		}
 
 		// Saving the default options.
-		if ( isset( $input['submit_defaults'] ) ) {
-			if ( ! isset( $input['enabled_post_types'] ) ) {
-				$input['enabled_post_types'] = [];
+		if ( isset( $input[ 'submit_defaults' ] ) ) {
+			if ( ! isset( $input[ 'enabled_post_types' ] ) ) {
+				$input[ 'enabled_post_types' ] = [ ];
 			}
 
 			// Checkboxes.
@@ -971,26 +971,26 @@ 
 			$this->validate_multi_selects( 'tags_to_post', $input );
 
 			// Get unique, non-empty, trimmed tags and clean them up.
-			$this->validate_tags( $input['global_tags'] );
+			$this->validate_tags( $input[ 'global_tags' ] );
 
 			// Clean up the list of aspects. If the list is empty, only use the 'Public' aspect.
-			$this->validate_aspects_services( $input['aspects'], [ 'public' ] );
+			$this->validate_aspects_services( $input[ 'aspects' ], [ 'public' ] );
 
 			// Clean up the list of services.
-			$this->validate_aspects_services( $input['services'] );
+			$this->validate_aspects_services( $input[ 'services' ] );
 		}
 
 		// Reset to defaults.
-		if ( isset( $input['reset_defaults'] ) ) {
+		if ( isset( $input[ 'reset_defaults' ] ) ) {
 			// Set the input to the default options.
 			$input = self::$default_options;
 
 			// Don't reset the fetched lists of aspects and services.
-			unset( $input['pod_list'], $input['aspects_list'], $input['services_list'] );
+			unset( $input[ 'pod_list' ], $input[ 'aspects_list' ], $input[ 'services_list' ] );
 		}
 
 		// Unset all unused input fields.
-		unset( $input['submit_defaults'], $input['reset_defaults'], $input['submit_setup'] );
+		unset( $input[ 'submit_defaults' ], $input[ 'reset_defaults' ], $input[ 'submit_setup' ] );
 
 		// Parse inputs with default options and return.
 		return wp_parse_args( $input, array_merge( self::$default_options, self::$options ) );
@@ -1048,7 +1048,7 @@ 
 					}
 				}
 			} else {
-				$options[ $select ] = [];
+				$options[ $select ] = [ ];
 			}
 		}
 
@@ -1097,7 +1097,7 @@ 
 	 *
 	 * @return array The validated list of aspects or services.
 	 */
-	public function validate_aspects_services( &$aspects_services, array $default = [] ) {
+	public function validate_aspects_services( &$aspects_services, array $default = [ ] ) {
 		if ( empty( $aspects_services ) || ! is_array( $aspects_services ) ) {
 			$aspects_services = $default;
 		} else {

Braces +13 added lines, -5 removed lines

@@ -599,8 +599,11 @@ 
 		if ( 'settings_page_wp_to_diaspora' === get_current_screen()->id ) : ?>
 			<label><?php echo $checkbox; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?><?php esc_html_e( 'Yes', 'wp-to-diaspora' ); ?></label>
 			<p class="description"><?php echo esc_html( $description ); ?></p>
-		<?php else : ?>
-			<label title="<?php echo esc_attr( $description ); ?>"><?php echo $checkbox; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?><?php esc_html_e( 'Show "Posted at" link?', 'wp-to-diaspora' ); ?></label>
+		<?php else {
+	: ?>
+			<label title="<?php echo esc_attr( $description );
+}
+?>"><?php echo $checkbox; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?><?php esc_html_e( 'Show "Posted at" link?', 'wp-to-diaspora' ); ?></label>
 		<?php endif;
 	}
 
@@ -639,9 +642,11 @@ 
 
 		<?php if ( $on_settings_page ) : ?>
 			<p class="description"><?php echo esc_html( $description ); ?></p>
-		<?php else : ?>
+		<?php else {
+	: ?>
 			</label>
 		<?php endif;
+}
 	}
 
 	/**
@@ -720,8 +725,11 @@ 
 				<?php foreach ( $list as $id => $name ) : ?>
 					<label><input type="checkbox" name="wp_to_diaspora_settings[<?php echo esc_attr( $type ); ?>][]" value="<?php echo esc_attr( $id ); ?>" <?php checked( in_array( $id, $items, false ) ); // phpcs:ignore WordPress.PHP.StrictInArray.FoundNonStrictFalse ?>><?php echo esc_html( $name ); ?></label>
 				<?php endforeach; ?>
-			<?php else : ?>
-				<label><?php echo $empty_label; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></label>
+			<?php else {
+	: ?>
+				<label><?php echo $empty_label;
+}
+// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></label>
 			<?php endif; ?>
 		</div>
 		<p class="description">

lib/class-wp2d.php

Doc Comments +2 added lines, -2 removed lines

@@ -276,7 +276,7 @@ 
 	 *
 	 * @param array $links Links to display for plugin on plugins page.
 	 *
-	 * @return array Links to display for plugin on plugins page.
+	 * @return string[] Links to display for plugin on plugins page.
 	 */
 	public function settings_link( $links ) {
 		$links[] = '<a href="' . esc_url( admin_url( 'options-general.php?page=wp_to_diaspora' ) ) . '">' . __( 'Settings', 'wp-to-diaspora' ) . '</a>';
@@ -353,7 +353,7 @@ 
 	/**
 	 * Check the pod connection status.
 	 *
-	 * @return bool The status of the connection.
+	 * @return boolean|null The status of the connection.
 	 */
 	private function check_pod_connection_status() {
 		$options = WP2D_Options::instance();

Spacing +11 added lines, -11 removed lines

@@ -71,7 +71,7 @@ 
 	 */
 	private function constants() {
 		// Are we in debugging mode?
-		if ( isset( $_GET['debugging'] ) ) { // phpcs:ignore
+		if ( isset( $_GET[ 'debugging' ] ) ) { // phpcs:ignore
 			define( 'WP2D_DEBUGGING', true );
 		}
 
@@ -91,7 +91,7 @@ 
 	 */
 	private function version_check() {
 		// Check for version requirements.
-		if ( version_compare( PHP_VERSION, $this->min_php, '<' ) || version_compare( $GLOBALS['wp_version'], $this->min_wp, '<' ) ) {
+		if ( version_compare( PHP_VERSION, $this->min_php, '<' ) || version_compare( $GLOBALS[ 'wp_version' ], $this->min_wp, '<' ) ) {
 			add_action( 'admin_notices', [ $this, 'deactivate' ] );
 
 			return false;
@@ -110,12 +110,12 @@ 
 		deactivate_plugins( WP2D_BASENAME );
 
 		// Get rid of the "Plugin activated" message.
-		unset( $_GET['activate'] ); // phpcs:ignore
+		unset( $_GET[ 'activate' ] ); // phpcs:ignore
 
 		// Then display the admin notice.
 		?>
 		<div class="error">
-			<p><?php echo esc_html( sprintf( 'WP to diaspora* requires at least WordPress %1$s (you have %2$s) and PHP %3$s (you have %4$s)!', $this->min_wp, $GLOBALS['wp_version'], $this->min_php, PHP_VERSION ) ); ?></p>
+			<p><?php echo esc_html( sprintf( 'WP to diaspora* requires at least WordPress %1$s (you have %2$s) and PHP %3$s (you have %4$s)!', $this->min_wp, $GLOBALS[ 'wp_version' ], $this->min_php, PHP_VERSION ) ); ?></p>
 		</div>
 		<?php
 	}
@@ -221,16 +221,16 @@ 
 	 */
 	public function admin_load_scripts() {
 		// Get the enabled post types to load the script for.
-		$enabled_post_types = WP2D_Options::instance()->get_option( 'enabled_post_types', [] );
+		$enabled_post_types = WP2D_Options::instance()->get_option( 'enabled_post_types', [ ] );
 
 		// Get the screen to find out where we are.
 		$screen = get_current_screen();
 
 		// Only load the styles and scripts on the settings page and the allowed post types.
 		if ( 'settings_page_wp_to_diaspora' === $screen->id || ( in_array( $screen->post_type, $enabled_post_types, true ) && 'post' === $screen->base ) ) {
-			wp_enqueue_style( 'tag-it', plugins_url( '/css/tag-it.min.css', WP2D_BASENAME ), [], WP2D_VERSION );
-			wp_enqueue_style( 'chosen', plugins_url( '/css/chosen.min.css', WP2D_BASENAME ), [], WP2D_VERSION );
-			wp_enqueue_style( 'wp-to-diaspora-admin', plugins_url( '/css/wp-to-diaspora.css', WP2D_BASENAME ), [], WP2D_VERSION );
+			wp_enqueue_style( 'tag-it', plugins_url( '/css/tag-it.min.css', WP2D_BASENAME ), [ ], WP2D_VERSION );
+			wp_enqueue_style( 'chosen', plugins_url( '/css/chosen.min.css', WP2D_BASENAME ), [ ], WP2D_VERSION );
+			wp_enqueue_style( 'wp-to-diaspora-admin', plugins_url( '/css/wp-to-diaspora.css', WP2D_BASENAME ), [ ], WP2D_VERSION );
 			wp_enqueue_script( 'chosen', plugins_url( '/js/chosen.jquery.min.js', WP2D_BASENAME ), [ 'jquery' ], WP2D_VERSION, true );
 			wp_enqueue_script( 'tag-it', plugins_url( '/js/tag-it.jquery.min.js', WP2D_BASENAME ), [ 'jquery', 'jquery-ui-autocomplete' ], WP2D_VERSION, true );
 			wp_enqueue_script( 'wp-to-diaspora-admin', plugins_url( '/js/wp-to-diaspora.js', WP2D_BASENAME ), [ 'jquery' ], WP2D_VERSION, true );
@@ -279,7 +279,7 @@ 
 	 * @return array Links to display for plugin on plugins page.
 	 */
 	public function settings_link( $links ) {
-		$links[] = '<a href="' . esc_url( admin_url( 'options-general.php?page=wp_to_diaspora' ) ) . '">' . __( 'Settings', 'wp-to-diaspora' ) . '</a>';
+		$links[ ] = '<a href="' . esc_url( admin_url( 'options-general.php?page=wp_to_diaspora' ) ) . '">' . __( 'Settings', 'wp-to-diaspora' ) . '</a>';
 
 		return $links;
 	}
@@ -373,7 +373,7 @@ 
 	 * @todo esc_html
 	 */
 	public function check_pod_connection_status_callback() {
-		if ( ! defined( 'WP2D_DEBUGGING' ) && isset( $_REQUEST['debugging'] ) ) { // phpcs:ignore
+		if ( ! defined( 'WP2D_DEBUGGING' ) && isset( $_REQUEST[ 'debugging' ] ) ) { // phpcs:ignore
 			define( 'WP2D_DEBUGGING', true );
 		}
 
@@ -391,7 +391,7 @@ 
 		if ( true === $status ) {
 			wp_send_json_success( $data );
 		} elseif ( false === $status && $this->load_api()->has_last_error() ) {
-			$data['message'] = $this->load_api()->get_last_error() . ' ' . WP2D_Contextual_Help::get_help_tab_quick_link( $this->load_api()->get_last_error_object() );
+			$data[ 'message' ] = $this->load_api()->get_last_error() . ' ' . WP2D_Contextual_Help::get_help_tab_quick_link( $this->load_api()->get_last_error_object() );
 			wp_send_json_error( $data );
 		}
 		// If $status === null, do nothing.

Braces +4 added lines, -2 removed lines

@@ -71,7 +71,8 @@ 
 	 */
 	private function constants() {
 		// Are we in debugging mode?
-		if ( isset( $_GET['debugging'] ) ) { // phpcs:ignore
+		if ( isset( $_GET['debugging'] ) ) {
+// phpcs:ignore
 			define( 'WP2D_DEBUGGING', true );
 		}
 
@@ -373,7 +374,8 @@ 
 	 * @todo esc_html
 	 */
 	public function check_pod_connection_status_callback() {
-		if ( ! defined( 'WP2D_DEBUGGING' ) && isset( $_REQUEST['debugging'] ) ) { // phpcs:ignore
+		if ( ! defined( 'WP2D_DEBUGGING' ) && isset( $_REQUEST['debugging'] ) ) {
+// phpcs:ignore
 			define( 'WP2D_DEBUGGING', true );
 		}
 

lib/class-wp2d-helpers.php

Braces +2 added lines, -1 removed lines

@@ -32,7 +32,8 @@
 		// Make sure we're in debug mode.
 		if ( defined( 'WP2D_DEBUGGING' ) && true === WP2D_DEBUGGING ) {
 			$d = '';
-			foreach ( debug_backtrace() as $dbt ) { // phpcs:ignore
+			foreach ( debug_backtrace() as $dbt ) {
+// phpcs:ignore
 				extract( $dbt ); // phpcs:ignore
 				// Only trace back as far as the plugin goes.
 				if ( strstr( $file, plugin_dir_path( __DIR__ ) ) ) {

lib/class-wp2d-post.php

Braces +6 added lines, -3 removed lines

@@ -806,7 +806,8 @@ 
 			$latest_post = end( $diaspora_post_history );
 
 			// Only show if this post is showing a message and the post is a fresh share.
-			if ( isset( $_GET['message'] ) && $post->post_modified === $latest_post['created_at'] ) { // phpcs:ignore
+			if ( isset( $_GET['message'] ) && $post->post_modified === $latest_post['created_at'] ) {
+// phpcs:ignore
 				printf(
 					'<div class="updated notice is-dismissible"><p>%1$s <a href="%2$s" target="_blank">%3$s</a></p></div>',
 					esc_html__( 'Successfully posted to diaspora*.', 'wp-to-diaspora' ),
@@ -824,7 +825,8 @@ 
 	 */
 	public function ignore_post_error() {
 		// If "Ignore" link has been clicked, delete the post error meta data.
-		if ( isset( $_GET['wp2d_ignore_post_error'], $_GET['post'] ) ) { // phpcs:ignore
+		if ( isset( $_GET['wp2d_ignore_post_error'], $_GET['post'] ) ) {
+// phpcs:ignore
 			delete_post_meta( absint( $_GET['post'] ), '_wp_to_diaspora_post_error' ); // phpcs:ignore
 		}
 	}
@@ -858,7 +860,8 @@ 
 			$latest_post = end( $diaspora_post_history );
 
 			// Only show if this post is a fresh share.
-			if ( get_post( $post_id )->post_modified === $latest_post['created_at'] ) { // phpcs:ignore
+			if ( get_post( $post_id )->post_modified === $latest_post['created_at'] ) {
+// phpcs:ignore
 				wp_send_json_success( [
 					'message' => esc_html__( 'Successfully posted to diaspora*.', 'wp-to-diaspora' ),
 					'action'  => [

Spacing +30 added lines, -30 removed lines

@@ -277,7 +277,7 @@ 
 
 		// Unset post_to_diaspora meta field to prevent mistakenly republishing to diaspora*.
 		$meta                     = get_post_meta( $post_id, '_wp_to_diaspora', true );
-		$meta['post_to_diaspora'] = false;
+		$meta[ 'post_to_diaspora' ] = false;
 		update_post_meta( $post_id, '_wp_to_diaspora', $meta );
 
 		// Prevent any duplicate hook firing.
@@ -319,7 +319,7 @@ 
 	private function get_full_content() {
 		// Only allow certain shortcodes.
 		global $shortcode_tags;
-		$shortcode_tags_bkp = [];
+		$shortcode_tags_bkp = [ ];
 
 		foreach ( $shortcode_tags as $shortcode_tag => $shortcode_function ) {
 			if ( ! in_array( $shortcode_tag, apply_filters( 'wp2d_shortcodes_filter', [ 'wp_caption', 'caption', 'gallery' ] ), true ) ) {
@@ -407,12 +407,12 @@ 
 		$options       = WP2D_Options::instance();
 		$tags_to_post  = $this->tags_to_post;
 		$tags_to_add   = '';
-		$diaspora_tags = [];
+		$diaspora_tags = [ ];
 
 		// Add any diaspora* tags?
 		if ( ! empty( $tags_to_post ) ) {
 			// The diaspora* tags to add to the post.
-			$diaspora_tags_tmp = [];
+			$diaspora_tags_tmp = [ ];
 
 			// Add global tags?
 			$global_tags = $options->get_option( 'global_tags' );
@@ -438,7 +438,7 @@ 
 
 			// Get all the tags and list them all nicely in a row.
 			foreach ( $diaspora_tags_tmp as $tag ) {
-				$diaspora_tags[] = '#' . $tag;
+				$diaspora_tags[ ] = '#' . $tag;
 			}
 
 			// Add all the found tags.
@@ -498,11 +498,11 @@ 
 	private function save_to_history( $response ) {
 		// Make sure the post history is an array.
 		if ( empty( $this->post_history ) ) {
-			$this->post_history = [];
+			$this->post_history = [ ];
 		}
 
 		// Add a new entry to the history.
-		$this->post_history[] = [
+		$this->post_history[ ] = [
 			'id'         => $response->id,
 			'guid'       => $response->guid,
 			'created_at' => $this->post->post_modified,
@@ -588,8 +588,8 @@ 
 		$content = do_shortcode( $content );
 
 		// If a caption attribute is defined, we'll add it after the image.
-		if ( isset( $attr['caption'] ) && '' !== $attr['caption'] ) {
-			$content .= "\n" . $this->get_img_caption( $attr['caption'] );
+		if ( isset( $attr[ 'caption' ] ) && '' !== $attr[ 'caption' ] ) {
+			$content .= "\n" . $this->get_img_caption( $attr[ 'caption' ] );
 		}
 
 		return $content;
@@ -606,7 +606,7 @@ 
 	 */
 	public function custom_gallery_shortcode( $attr ) {
 		// Try user value and fall back to default value in WordPress.
-		$captiontag = $attr['captiontag'] ?? ( current_theme_supports( 'html5', 'gallery' ) ? 'figcaption' : 'dd' );
+		$captiontag = $attr[ 'captiontag' ] ?? ( current_theme_supports( 'html5', 'gallery' ) ? 'figcaption' : 'dd' );
 
 		// Let WordPress create the regular gallery.
 		$gallery = gallery_shortcode( $attr );
@@ -629,7 +629,7 @@ 
 	 * @return string Prettified gallery image caption.
 	 */
 	public function custom_gallery_regex_callback( $m ) {
-		return $this->get_img_caption( $m[2] );
+		return $this->get_img_caption( $m[ 2 ] );
 	}
 
 	/*
@@ -672,18 +672,18 @@ 
 		$options = WP2D_Options::instance();
 
 		// Make sure we have some value for post meta fields.
-		$this->custom_tags = $this->custom_tags ?: [];
+		$this->custom_tags = $this->custom_tags ? : [ ];
 
 		// If this post is already published, don't post again to diaspora* by default.
 		$this->post_to_diaspora = ( $this->post_to_diaspora && 'publish' !== get_post_status( $this->ID ) );
-		$this->aspects          = $this->aspects ?: [];
-		$this->services         = $this->services ?: [];
+		$this->aspects          = $this->aspects ? : [ ];
+		$this->services         = $this->services ? : [ ];
 
 		// Have we already posted on diaspora*?
 		$diaspora_post_url = '#';
 		if ( is_array( $this->post_history ) ) {
 			$latest_post       = end( $this->post_history );
-			$diaspora_post_url = $latest_post['post_url'];
+			$diaspora_post_url = $latest_post[ 'post_url' ];
 		}
 		?>
 		<p<?php echo '#' === $diaspora_post_url ? ' style="display: none;"' : ''; ?>><a id="diaspora-post-url" href="<?php echo esc_attr( $diaspora_post_url ); ?>" target="_blank"><?php esc_html_e( 'Already posted to diaspora*.', 'wp-to-diaspora' ); ?></a></p>
@@ -718,7 +718,7 @@ 
 		/* OK, it's safe for us to save the data now. */
 
 		// Meta data to save.
-		$meta_to_save = $_POST['wp_to_diaspora_settings']; // phpcs:ignore
+		$meta_to_save = $_POST[ 'wp_to_diaspora_settings' ]; // phpcs:ignore
 		$options      = WP2D_Options::instance();
 
 		// Checkboxes.
@@ -731,13 +731,13 @@ 
 		$options->validate_multi_selects( 'tags_to_post', $meta_to_save );
 
 		// Save custom tags as array.
-		$options->validate_tags( $meta_to_save['custom_tags'] );
+		$options->validate_tags( $meta_to_save[ 'custom_tags' ] );
 
 		// Clean up the list of aspects. If the list is empty, only use the 'Public' aspect.
-		$options->validate_aspects_services( $meta_to_save['aspects'], [ 'public' ] );
+		$options->validate_aspects_services( $meta_to_save[ 'aspects' ], [ 'public' ] );
 
 		// Clean up the list of services.
-		$options->validate_aspects_services( $meta_to_save['services'] );
+		$options->validate_aspects_services( $meta_to_save[ 'services' ] );
 
 		// Update the meta data for this post.
 		update_post_meta( $post_id, '_wp_to_diaspora', $meta_to_save );
@@ -752,7 +752,7 @@ 
 	 */
 	private function is_safe_to_save() {
 		// Verify that our nonce is set and  valid.
-		if ( ! ( isset( $_POST['wp_to_diaspora_meta_box_nonce'] ) && wp_verify_nonce( sanitize_key( $_POST['wp_to_diaspora_meta_box_nonce'] ), 'wp_to_diaspora_meta_box' ) ) ) {
+		if ( ! ( isset( $_POST[ 'wp_to_diaspora_meta_box_nonce' ] ) && wp_verify_nonce( sanitize_key( $_POST[ 'wp_to_diaspora_meta_box_nonce' ] ), 'wp_to_diaspora_meta_box' ) ) ) {
 			return false;
 		}
 
@@ -762,13 +762,13 @@ 
 		}
 
 		// Check the user's permissions.
-		$permission = ( isset( $_POST['post_type'] ) && 'page' === $_POST['post_type'] ) ? 'edit_pages' : 'edit_posts';
+		$permission = ( isset( $_POST[ 'post_type' ] ) && 'page' === $_POST[ 'post_type' ] ) ? 'edit_pages' : 'edit_posts';
 		if ( ! current_user_can( $permission, $this->ID ) ) {
 			return false;
 		}
 
 		// Make real sure that we have some meta data to save.
-		if ( ! isset( $_POST['wp_to_diaspora_settings'] ) ) {
+		if ( ! isset( $_POST[ 'wp_to_diaspora_settings' ] ) ) {
 			return false;
 		}
 
@@ -797,7 +797,7 @@ 
 				'<div class="error notice is-dismissible"><p>%1$s %2$s %3$s <a href="%4$s">%5$s</a></p></div>',
 				esc_html__( 'Failed to post to diaspora*.', 'wp-to-diaspora' ),
 				esc_html( $error->get_error_message() ),
-				$help_link,  // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
+				$help_link, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 				esc_url( add_query_arg( 'wp2d_ignore_post_error', '' ) ),
 				esc_html__( 'Ignore', 'wp-to-diaspora' )
 			);
@@ -806,11 +806,11 @@ 
 			$latest_post = end( $diaspora_post_history );
 
 			// Only show if this post is showing a message and the post is a fresh share.
-			if ( isset( $_GET['message'] ) && $post->post_modified === $latest_post['created_at'] ) { // phpcs:ignore
+			if ( isset( $_GET[ 'message' ] ) && $post->post_modified === $latest_post[ 'created_at' ] ) { // phpcs:ignore
 				printf(
 					'<div class="updated notice is-dismissible"><p>%1$s <a href="%2$s" target="_blank">%3$s</a></p></div>',
 					esc_html__( 'Successfully posted to diaspora*.', 'wp-to-diaspora' ),
-					esc_url( $latest_post['post_url'] ),
+					esc_url( $latest_post[ 'post_url' ] ),
 					esc_html__( 'View Post', 'wp-to-diaspora' )
 				);
 			}
@@ -824,8 +824,8 @@ 
 	 */
 	public function ignore_post_error() {
 		// If "Ignore" link has been clicked, delete the post error meta data.
-		if ( isset( $_GET['wp2d_ignore_post_error'], $_GET['post'] ) ) { // phpcs:ignore
-			delete_post_meta( absint( $_GET['post'] ), '_wp_to_diaspora_post_error' ); // phpcs:ignore
+		if ( isset( $_GET[ 'wp2d_ignore_post_error' ], $_GET[ 'post' ] ) ) { // phpcs:ignore
+			delete_post_meta( absint( $_GET[ 'post' ] ), '_wp_to_diaspora_post_error' ); // phpcs:ignore
 		}
 	}
 
@@ -841,7 +841,7 @@ 
 			] );
 		}
 
-		$post_id = sanitize_key( $_REQUEST['post_id'] ?? '' );
+		$post_id = sanitize_key( $_REQUEST[ 'post_id' ] ?? '' );
 		if ( ! is_numeric( $post_id ) ) {
 			return;
 		}
@@ -858,12 +858,12 @@ 
 			$latest_post = end( $diaspora_post_history );
 
 			// Only show if this post is a fresh share.
-			if ( get_post( $post_id )->post_modified === $latest_post['created_at'] ) { // phpcs:ignore
+			if ( get_post( $post_id )->post_modified === $latest_post[ 'created_at' ] ) { // phpcs:ignore
 				wp_send_json_success( [
 					'message' => esc_html__( 'Successfully posted to diaspora*.', 'wp-to-diaspora' ),
 					'action'  => [
 						'label' => esc_html__( 'View Post', 'wp-to-diaspora' ),
-						'url'   => esc_url( $latest_post['post_url'] ),
+						'url'   => esc_url( $latest_post[ 'post_url' ] ),
 					],
 				] );
 			}

lib/class-wp2d-contextual-help.php

Spacing +1 added lines, -1 removed lines

@@ -255,7 +255,7 @@
 	public static function get_help_tab_quick_link( $error ) {
 		$help_tab = '';
 		if ( is_wp_error( $error ) && ( $error_data = $error->get_error_data() ) && array_key_exists( 'help_tab', $error_data ) ) {
-			$help_tab = $error_data['help_tab'];
+			$help_tab = $error_data[ 'help_tab' ];
 		} elseif ( is_string( $error ) ) {
 			$help_tab = $error;
 		}