noplanman / wp-to-diaspora

lib/class-api.php

Doc Comments +2 added lines, -2 removed lines

@@ -596,7 +596,7 @@ 
 	 *
 	 * @param string $url  The URL to request.
 	 * @param array  $args Arguments to be posted with the request.
-	 * @return object An object containing details about this request.
+	 * @return string An object containing details about this request.
 	 */
 	private function _request( $url, $args = array() ) {
 		// Prefix the full pod URL if necessary.
@@ -665,7 +665,7 @@ 
 	 * @see WP_Error::__construct()
 	 * @since 1.6.0
 	 *
-	 * @param  string|int $code    Error code.
+	 * @param  string $code    Error code.
 	 * @param  string     $message Error message.
 	 * @param  mixed      $data    Error data.
 	 */

Spacing +5 added lines, -5 removed lines

@@ -571,7 +571,7 @@ 
 				switch ( $type ) {
 					case 'aspects':
 						// Add the 'public' aspect, as it's global and not user specific.
-						$list['public'] = __( 'Public', 'wp-to-diaspora' );
+						$list[ 'public' ] = __( 'Public', 'wp-to-diaspora' );
 
 						// Add all user specific aspects.
 						foreach ( $raw_list as $aspect ) {
@@ -615,12 +615,12 @@ 
 		// If the certificate bundle has been downloaded manually, use that instead.
 		// NOTE: This should actually never be necessary, it's a fallback!
 		if ( file_exists( WP2D_DIR . '/cacert.pem' ) ) {
-			$defaults['sslcertificates'] = WP2D_DIR . '/cacert.pem';
+			$defaults[ 'sslcertificates' ] = WP2D_DIR . '/cacert.pem';
 		}
 
 		// Set the correct cookie.
 		if ( ! empty( $this->_cookies ) ) {
-			$defaults['cookies'] = $this->_cookies;
+			$defaults[ 'cookies' ] = $this->_cookies;
 		}
 
 		$args = wp_parse_args( $args, $defaults );
@@ -651,8 +651,8 @@ 
 		}
 
 		// Save the latest cookies.
-		if ( isset( $response['cookies'] ) ) {
-			$this->_cookies = $response['cookies'];
+		if ( isset( $response[ 'cookies' ] ) ) {
+			$this->_cookies = $response[ 'cookies' ];
 		}
 
 		// Return the last request details.

lib/class-options.php

Doc Comments +4 added lines, -4 removed lines

@@ -737,7 +737,7 @@ 
 	/**
 	 * Validate checkboxes, make them either true or false.
 	 *
-	 * @param string|array $checkboxes Checkboxes to validate.
+	 * @param string[] $checkboxes Checkboxes to validate.
 	 * @param array        $options    Options values themselves.
 	 * @return array The validated options.
 	 */
@@ -751,7 +751,7 @@ 
 	/**
 	 * Validate single-select fields and make sure their selected value are valid.
 	 *
-	 * @param string|array $selects Name(s) of the select fields.
+	 * @param string $selects Name(s) of the select fields.
 	 * @param array        $options Options values themselves.
 	 * @return array The validated options.
 	 */
@@ -767,7 +767,7 @@ 
 	/**
 	 * Validate multi-select fields and make sure their selected values are valid.
 	 *
-	 * @param string|array $selects Name(s) of the select fields.
+	 * @param string $selects Name(s) of the select fields.
 	 * @param array        $options Options values themselves.
 	 * @return array The validated options.
 	 */
@@ -821,7 +821,7 @@ 
 	 * Validate the passed aspects or services.
 	 *
 	 * @param array $aspects_services List of aspects or services that need to be validated.
-	 * @param array $default          Default value if not valid.
+	 * @param string[] $default          Default value if not valid.
 	 * @return array The validated list of aspects or services.
 	 */
 	public function validate_aspects_services( &$aspects_services, $default = array() ) {

Braces +13 added lines, -5 removed lines

@@ -435,8 +435,11 @@ 
 		if ( 'settings_page_wp_to_diaspora' === get_current_screen()->id ) : ?>
 			<label><?php echo $checkbox; ?><?php esc_html_e( 'Yes' ); ?></label>
 			<p class="description"><?php echo esc_html( $description ); ?></p>
-		<?php else : ?>
-			<label title="<?php echo esc_attr( $description ); ?>"><?php echo $checkbox; ?><?php esc_html_e( 'Show "Posted at" link?', 'wp-to-diaspora' ); ?></label>
+		<?php else {
+	: ?>
+			<label title="<?php echo esc_attr( $description );
+}
+?>"><?php echo $checkbox; ?><?php esc_html_e( 'Show "Posted at" link?', 'wp-to-diaspora' ); ?></label>
 		<?php endif;
 	}
 
@@ -474,9 +477,11 @@ 
 
 		<?php if ( $on_settings_page ) : ?>
 			<p class="description"><?php echo esc_html( $description ); ?></p>
-		<?php else : ?>
+		<?php else {
+	: ?>
 			</label>
 		<?php endif;
+}
 	}
 
 	/**
@@ -558,8 +563,11 @@ 
 				<?php foreach ( $list as $id => $name ) : ?>
 					<label><input type="checkbox" name="wp_to_diaspora_settings[<?php echo esc_attr( $type ); ?>][]" value="<?php echo esc_attr( $id ); ?>" <?php checked( in_array( $id, $items ) ); ?>><?php echo esc_html( $name ); ?></label>
 				<?php endforeach; ?>
-			<?php else : ?>
-				<label><?php echo $empty_label; ?></label>
+			<?php else {
+	: ?>
+				<label><?php echo $empty_label;
+}
+?></label>
 			<?php endif; ?>
 		</div>
 		<p class="description">

Spacing +27 added lines, -27 removed lines

@@ -104,7 +104,7 @@ 
 	 * @return string Return the currently selected tab.
 	 */
 	private function _current_tab( $default = 'defaults' ) {
-		$tab = ( isset ( $_GET['tab'] ) ? $_GET['tab'] : $default );
+		$tab = ( isset ( $_GET[ 'tab' ] ) ? $_GET[ 'tab' ] : $default );
 
 		// If the pod settings aren't configured yet, open the 'Setup' tab.
 		if ( ! $this->is_pod_set_up() ) {
@@ -124,11 +124,11 @@ 
 		// The array defining all options sections to be shown as tabs.
 		$tabs = array();
 		if ( $this->is_pod_set_up() ) {
-			$tabs['defaults'] = __( 'Defaults', 'wp-to-diaspora' );
+			$tabs[ 'defaults' ] = __( 'Defaults', 'wp-to-diaspora' );
 		}
 
 		// Add the 'Setup' tab to the end of the list.
-		$tabs['setup'] = __( 'Setup', 'wp-to-diaspora' ) . '<span id="pod-connection-status" class="dashicons-before hidden"></span><span class="spinner"></span>';
+		$tabs[ 'setup' ] = __( 'Setup', 'wp-to-diaspora' ) . '<span id="pod-connection-status" class="dashicons-before hidden"></span><span class="spinner"></span>';
 
 		// Container for all options tabs.
 		$out = '<h2 id="options-tabs" class="nav-tab-wrapper">';
@@ -220,7 +220,7 @@ 
 				do_settings_sections( 'wp_to_diaspora_settings' );
 
 				// Get the name of the current tab, if set, else take the first one from the list.
-				$tab = $this->_current_tab( $page_tabs[0] );
+				$tab = $this->_current_tab( $page_tabs[ 0 ] );
 
 				// Add Save and Reset buttons.
 				echo '<input id="submit-' . esc_attr( $tab ) . '" name="wp_to_diaspora_settings[submit_' . esc_attr( $tab ) . ']" type="submit" class="button-primary" value="' . esc_attr__( 'Save Changes' ) . '" />&nbsp;';
@@ -598,7 +598,7 @@ 
 		<select id="tags-to-post" multiple data-placeholder="<?php esc_attr_e( 'No tags', 'wp-to-diaspora' ); ?>" class="chosen" name="wp_to_diaspora_settings[tags_to_post][]">
 			<option value="global" <?php selected( in_array( 'global', $tags_to_post ) ); ?>><?php esc_html_e( 'Global tags', 'wp-to-diaspora' ); ?></option>
 			<option value="custom" <?php selected( in_array( 'custom', $tags_to_post ) ); ?>><?php esc_html_e( 'Custom tags', 'wp-to-diaspora' ); ?></option>
-			<option value="post"   <?php selected( in_array( 'post',   $tags_to_post ) ); ?>><?php esc_html_e( 'Post tags',   'wp-to-diaspora' ); ?></option>
+			<option value="post"   <?php selected( in_array( 'post', $tags_to_post ) ); ?>><?php esc_html_e( 'Post tags', 'wp-to-diaspora' ); ?></option>
 		</select>
 
 		<?php if ( $on_settings_page ) : ?>
@@ -664,14 +664,14 @@ 
 					esc_url( 'https://' . $this->get_option( 'pod' ) . '/services' ),
 					esc_html__( 'Show available services on my pod.', 'wp-to-diaspora' )
 				);
-				$empty_label    = esc_html__( 'No services connected yet.', 'wp-to-diaspora' );
+				$empty_label = esc_html__( 'No services connected yet.', 'wp-to-diaspora' );
 				break;
 
 			default:
 				return;
 		}
 
-		$items = array_filter( (array) $items ) ?: array();
+		$items = array_filter( (array) $items ) ? : array();
 
 		// Special case for this field if it's displayed on the settings page.
 		$on_settings_page = ( 'settings_page_wp_to_diaspora' === get_current_screen()->id );
@@ -798,30 +798,30 @@ 
 		/* Validate all settings before saving to the database. */
 
 		// Saving the pod setup details.
-		if ( isset( $input['submit_setup'] ) ) {
-			$input['pod']      = trim( sanitize_text_field( $input['pod'] ), ' /' );
-			$input['username'] = sanitize_text_field( $input['username'] );
-			$input['password'] = sanitize_text_field( $input['password'] );
+		if ( isset( $input[ 'submit_setup' ] ) ) {
+			$input[ 'pod' ]      = trim( sanitize_text_field( $input[ 'pod' ] ), ' /' );
+			$input[ 'username' ] = sanitize_text_field( $input[ 'username' ] );
+			$input[ 'password' ] = sanitize_text_field( $input[ 'password' ] );
 
 			// If password is blank, it hasn't been changed.
 			// If new password is equal to the encrypted password already saved, it was just passed again. It happens everytime update_option('wp_to_diaspora_settings') is called.
-			if ( '' === $input['password'] || $this->get_option( 'password' ) === $input['password'] ) {
-				$input['password'] = $this->get_option( 'password' );
+			if ( '' === $input[ 'password' ] || $this->get_option( 'password' ) === $input[ 'password' ] ) {
+				$input[ 'password' ] = $this->get_option( 'password' );
 			} else {
-				$input['password'] = WP2D_Helpers::encrypt( $input['password'] );
+				$input[ 'password' ] = WP2D_Helpers::encrypt( $input[ 'password' ] );
 			}
 
 			// This is for when JS in not enabled, to make sure that the aspects and services
 			// are refetched when displaying the options page after saving.
-			if ( isset( $input['no_js'] ) ) {
+			if ( isset( $input[ 'no_js' ] ) ) {
 				set_transient( 'wp2d_no_js_force_refetch', true );
 			}
 		}
 
 		// Saving the default options.
-		if ( isset( $input['submit_defaults'] ) ) {
-			if ( ! isset( $input['enabled_post_types'] ) ) {
-				$input['enabled_post_types'] = array();
+		if ( isset( $input[ 'submit_defaults' ] ) ) {
+			if ( ! isset( $input[ 'enabled_post_types' ] ) ) {
+				$input[ 'enabled_post_types' ] = array();
 			}
 
 			// Checkboxes.
@@ -834,29 +834,29 @@ 
 			$this->validate_multi_selects( 'tags_to_post', $input );
 
 			// Get unique, non-empty, trimmed tags and clean them up.
-			$this->validate_tags( $input['global_tags'] );
+			$this->validate_tags( $input[ 'global_tags' ] );
 
 			// Clean up the list of aspects. If the list is empty, only use the 'Public' aspect.
-			$this->validate_aspects_services( $input['aspects'], array( 'public' ) );
+			$this->validate_aspects_services( $input[ 'aspects' ], array( 'public' ) );
 
 			// Clean up the list of services.
-			$this->validate_aspects_services( $input['services'] );
+			$this->validate_aspects_services( $input[ 'services' ] );
 		}
 
 		// Reset to defaults.
-		if ( isset( $input['reset_defaults'] ) ) {
+		if ( isset( $input[ 'reset_defaults' ] ) ) {
 			// Set the input to the default options.
 			$input = self::$_default_options;
 
 			// Don't reset the fetched lists of aspects and services.
-			unset( $input['aspects_list'] );
-			unset( $input['services_list'] );
+			unset( $input[ 'aspects_list' ] );
+			unset( $input[ 'services_list' ] );
 		}
 
 		// Unset all unused input fields.
-		unset( $input['submit_defaults'] );
-		unset( $input['reset_defaults'] );
-		unset( $input['submit_setup'] );
+		unset( $input[ 'submit_defaults' ] );
+		unset( $input[ 'reset_defaults' ] );
+		unset( $input[ 'submit_setup' ] );
 
 		// Parse inputs with default options and return.
 		return wp_parse_args( $input, array_merge( self::$_default_options, self::$_options ) );

lib/class-post.php

Doc Comments +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
 	 *
 	 * @param integer $post_id ID of the post being saved.
 	 * @param WP_Post $post    Post object being saved.
-	 * @return boolean If the post was posted successfully.
+	 * @return false|null If the post was posted successfully.
 	 */
 	public function post( $post_id, $post ) {
 		$this->_assign_wp_post( $post );

Spacing +24 added lines, -24 removed lines

@@ -250,7 +250,7 @@ 
 
 				// Unset post_to_diaspora meta field to prevent mistakenly republishing to diaspora*.
 				$meta = get_post_meta( $post_id, '_wp_to_diaspora', true );
-				$meta['post_to_diaspora'] = false;
+				$meta[ 'post_to_diaspora' ] = false;
 				update_post_meta( $post_id, '_wp_to_diaspora', $meta );
 			}
 		} else {
@@ -393,7 +393,7 @@ 
 			// Get all the tags and list them all nicely in a row.
 			$diaspora_tags_clean = array();
 			foreach ( $diaspora_tags as $tag ) {
-				$diaspora_tags_clean[] = '#' . $tag;
+				$diaspora_tags_clean[ ] = '#' . $tag;
 			}
 
 			// Add all the found tags.
@@ -453,7 +453,7 @@ 
 		}
 
 		// Add a new entry to the history.
-		$this->post_history[] = array(
+		$this->post_history[ ] = array(
 			'id'         => $response->id,
 			'guid'       => $response->guid,
 			'created_at' => $this->post->post_modified,
@@ -507,7 +507,7 @@ 
 			return '';
 		}
 
-		$default = sprintf( '<blockquote>%s</blockquote>',  $caption );
+		$default = sprintf( '<blockquote>%s</blockquote>', $caption );
 
 		/**
 		 * Filter the image caption to be displayed after images with captions.
@@ -535,8 +535,8 @@ 
 		$content = do_shortcode( $content );
 
 		// If a caption attribute is defined, we'll add it after the image.
-		if ( isset( $attr['caption'] ) && '' !== $attr['caption'] ) {
-			$content .= "\n" . $this->get_img_caption( $attr['caption'] );
+		if ( isset( $attr[ 'caption' ] ) && '' !== $attr[ 'caption' ] ) {
+			$content .= "\n" . $this->get_img_caption( $attr[ 'caption' ] );
 		}
 
 		return $content;
@@ -555,8 +555,8 @@ 
 		$captiontag = ( current_theme_supports( 'html5', 'gallery' ) ) ? 'figcaption' : 'dd';
 
 		// User value.
-		if ( isset( $attr['captiontag'] ) ) {
-			$captiontag = $attr['captiontag'];
+		if ( isset( $attr[ 'captiontag' ] ) ) {
+			$captiontag = $attr[ 'captiontag' ];
 		}
 
 		// Let WordPress create the regular gallery.
@@ -579,7 +579,7 @@ 
 	 * @return string Prettified gallery image caption.
 	 */
 	public function custom_gallery_regex_callback( $m ) {
-		return $this->get_img_caption( $m[2] );
+		return $this->get_img_caption( $m[ 2 ] );
 	}
 
 	/*
@@ -622,18 +622,18 @@ 
 		$options = WP2D_Options::instance();
 
 		// Make sure we have some value for post meta fields.
-		$this->custom_tags = $this->custom_tags ?: array();
+		$this->custom_tags = $this->custom_tags ? : array();
 
 		// If this post is already published, don't post again to diaspora* by default.
 		$this->post_to_diaspora = ( $this->post_to_diaspora && 'publish' !== get_post_status( $this->ID ) );
-		$this->aspects          = $this->aspects  ?: array();
-		$this->services         = $this->services ?: array();
+		$this->aspects          = $this->aspects ? : array();
+		$this->services         = $this->services ? : array();
 
 		// Have we already posted on diaspora*?
 		if ( is_array( $this->post_history ) ) {
 			$latest_post = end( $this->post_history );
 			?>
-			<p><a href="<?php echo esc_attr( $latest_post['post_url'] ); ?>" target="_blank"><?php esc_html_e( 'Already posted to diaspora*.', 'wp-to-diaspora' ); ?></a></p>
+			<p><a href="<?php echo esc_attr( $latest_post[ 'post_url' ] ); ?>" target="_blank"><?php esc_html_e( 'Already posted to diaspora*.', 'wp-to-diaspora' ); ?></a></p>
 			<?php
 		}
 		?>
@@ -668,7 +668,7 @@ 
 		/* OK, it's safe for us to save the data now. */
 
 		// Meta data to save.
-		$meta_to_save = $_POST['wp_to_diaspora_settings'];
+		$meta_to_save = $_POST[ 'wp_to_diaspora_settings' ];
 		$options = WP2D_Options::instance();
 
 		// Checkboxes.
@@ -681,13 +681,13 @@ 
 		$options->validate_multi_selects( 'tags_to_post', $meta_to_save );
 
 		// Save custom tags as array.
-		$options->validate_tags( $meta_to_save['custom_tags'] );
+		$options->validate_tags( $meta_to_save[ 'custom_tags' ] );
 
 		// Clean up the list of aspects. If the list is empty, only use the 'Public' aspect.
-		$options->validate_aspects_services( $meta_to_save['aspects'], array( 'public' ) );
+		$options->validate_aspects_services( $meta_to_save[ 'aspects' ], array( 'public' ) );
 
 		// Clean up the list of services.
-		$options->validate_aspects_services( $meta_to_save['services'] );
+		$options->validate_aspects_services( $meta_to_save[ 'services' ] );
 
 		// Update the meta data for this post.
 		update_post_meta( $post_id, '_wp_to_diaspora', $meta_to_save );
@@ -702,7 +702,7 @@ 
 	 */
 	private function _is_safe_to_save() {
 		// Verify that our nonce is set and  valid.
-		if ( ! ( isset( $_POST['wp_to_diaspora_meta_box_nonce'] ) && wp_verify_nonce( $_POST['wp_to_diaspora_meta_box_nonce'], 'wp_to_diaspora_meta_box' ) ) ) {
+		if ( ! ( isset( $_POST[ 'wp_to_diaspora_meta_box_nonce' ] ) && wp_verify_nonce( $_POST[ 'wp_to_diaspora_meta_box_nonce' ], 'wp_to_diaspora_meta_box' ) ) ) {
 			return false;
 		}
 
@@ -712,13 +712,13 @@ 
 		}
 
 		// Check the user's permissions.
-		$permission = ( isset( $_POST['post_type'] ) && 'page' === $_POST['post_type'] ) ? 'edit_pages' : 'edit_posts';
+		$permission = ( isset( $_POST[ 'post_type' ] ) && 'page' === $_POST[ 'post_type' ] ) ? 'edit_pages' : 'edit_posts';
 		if ( ! current_user_can( $permission, $this->ID ) ) {
 			return false;
 		}
 
 		// Make real sure that we have some meta data to save.
-		if ( ! isset( $_POST['wp_to_diaspora_settings'] ) ) {
+		if ( ! isset( $_POST[ 'wp_to_diaspora_settings' ] ) ) {
 			return false;
 		}
 
@@ -755,10 +755,10 @@ 
 			$latest_post = end( $diaspora_post_history );
 
 			// Only show if this post is showing a message and the post is a fresh share.
-			if ( isset( $_GET['message'] ) && $post->post_modified === $latest_post['created_at'] ) {
+			if ( isset( $_GET[ 'message' ] ) && $post->post_modified === $latest_post[ 'created_at' ] ) {
 				printf( '<div class="updated notice is-dismissible"><p>%1$s <a href="%2$s" target="_blank">%3$s</a></p></div>',
 					esc_html__( 'Successfully posted to diaspora*.', 'wp-to-diaspora' ),
-					esc_url( $latest_post['post_url'] ),
+					esc_url( $latest_post[ 'post_url' ] ),
 					esc_html__( 'View Post' )
 				);
 			}
@@ -772,8 +772,8 @@ 
 	 */
 	public function ignore_post_error() {
 		// If "Ignore" link has been clicked, delete the post error meta data.
-		if ( isset( $_GET['wp2d_ignore_post_error'], $_GET['post'] ) ) {
-			delete_post_meta( $_GET['post'], '_wp_to_diaspora_post_error' );
+		if ( isset( $_GET[ 'wp2d_ignore_post_error' ], $_GET[ 'post' ] ) ) {
+			delete_post_meta( $_GET[ 'post' ], '_wp_to_diaspora_post_error' );
 		}
 	}
 }

wp-to-diaspora.php

Doc Comments +2 added lines, -2 removed lines

@@ -287,7 +287,7 @@ 
 	 * Add the "Settings" link to the plugins page.
 	 *
 	 * @param array $links Links to display for plugin on plugins page.
-	 * @return array Links to display for plugin on plugins page.
+	 * @return string[] Links to display for plugin on plugins page.
 	 */
 	public function settings_link( $links ) {
 		$links[] = '<a href="' . admin_url( 'options-general.php?page=wp_to_diaspora' ) . '">' . __( 'Settings' ) . '</a>';
@@ -400,7 +400,7 @@ 
 	/**
 	 * Check the pod connection status.
 	 *
-	 * @return string The status of the connection.
+	 * @return boolean|null The status of the connection.
 	 */
 	private function _check_pod_connection_status() {
 		$options = WP2D_Options::instance();

Spacing +8 added lines, -8 removed lines

@@ -99,7 +99,7 @@ 
 	 */
 	private function _constants() {
 		// Are we in debugging mode?
-		if ( isset( $_GET['debugging'] ) ) {
+		if ( isset( $_GET[ 'debugging' ] ) ) {
 			define( 'WP2D_DEBUGGING', true );
 		}
 
@@ -117,7 +117,7 @@ 
 	 */
 	private function _version_check() {
 		// Check for version requirements.
-		if ( version_compare( $GLOBALS['wp_version'], $this->_min_wp, '<' )
+		if ( version_compare( $GLOBALS[ 'wp_version' ], $this->_min_wp, '<' )
 			|| version_compare( PHP_VERSION, $this->_min_php, '<' ) ) {
 			add_action( 'admin_notices', array( $this, 'deactivate' ) );
 			return false;
@@ -136,12 +136,12 @@ 
 		deactivate_plugins( plugin_basename( __FILE__ ) );
 
 		// Get rid of the "Plugin activated" message.
-		unset( $_GET['activate'] );
+		unset( $_GET[ 'activate' ] );
 
 		// Then display the admin notice.
 		?>
 		<div class="error">
-			<p><?php echo esc_html( sprintf( 'WP to diaspora* requires at least WordPress %1$s (you have %2$s) and PHP %3$s (you have %4$s)!', $this->_min_wp, $GLOBALS['wp_version'], $this->_min_php, PHP_VERSION ) ); ?></p>
+			<p><?php echo esc_html( sprintf( 'WP to diaspora* requires at least WordPress %1$s (you have %2$s) and PHP %3$s (you have %4$s)!', $this->_min_wp, $GLOBALS[ 'wp_version' ], $this->_min_php, PHP_VERSION ) ); ?></p>
 		</div>
 		<?php
 	}
@@ -236,7 +236,7 @@ 
 				$tags_to_post = array_filter( array(
 					( ( false !== strpos( $tags_to_post_old, 'g' ) ) ? 'global' : null ),
 					( ( false !== strpos( $tags_to_post_old, 'c' ) ) ? 'custom' : null ),
-					( ( false !== strpos( $tags_to_post_old, 'p' ) ) ? 'post'   : null ),
+					( ( false !== strpos( $tags_to_post_old, 'p' ) ) ? 'post' : null ),
 				) );
 				$options->set_option( 'tags_to_post', $tags_to_post );
 			}
@@ -290,7 +290,7 @@ 
 	 * @return array Links to display for plugin on plugins page.
 	 */
 	public function settings_link( $links ) {
-		$links[] = '<a href="' . admin_url( 'options-general.php?page=wp_to_diaspora' ) . '">' . __( 'Settings' ) . '</a>';
+		$links[ ] = '<a href="' . admin_url( 'options-general.php?page=wp_to_diaspora' ) . '">' . __( 'Settings' ) . '</a>';
 		return $links;
 	}
 
@@ -378,7 +378,7 @@ 
 	 * @todo esc_html
 	 */
 	public function check_pod_connection_status_callback() {
-		if ( isset( $_REQUEST['debugging'] ) && ! defined( 'WP2D_DEBUGGING' ) ) {
+		if ( isset( $_REQUEST[ 'debugging' ] ) && ! defined( 'WP2D_DEBUGGING' ) ) {
 			define( 'WP2D_DEBUGGING', true );
 		}
 
@@ -392,7 +392,7 @@ 
 		if ( true === $status ) {
 			wp_send_json_success( $data );
 		} elseif ( false === $status && $this->_load_api()->has_last_error() ) {
-			$data['message'] = $this->_load_api()->get_last_error() . ' ' . WP2D_Contextual_Help::get_help_tab_quick_link( $this->_load_api()->get_last_error_object() );
+			$data[ 'message' ] = $this->_load_api()->get_last_error() . ' ' . WP2D_Contextual_Help::get_help_tab_quick_link( $this->_load_api()->get_last_error_object() );
 			wp_send_json_error( $data );
 		}
 		// If $status === null, do nothing.

lib/class-contextual-help.php

Spacing +15 added lines, -15 removed lines

@@ -41,11 +41,11 @@ 
 	 * @since 1.5.0
 	 */
 	private function _constants() {
-		define( 'WP2D_EXT_WPORG',         esc_url( 'https://wordpress.org/plugins/wp-to-diaspora' ) );
-		define( 'WP2D_EXT_I18N',          esc_url( 'https://poeditor.com/join/project?hash=c085b3654a5e04c69ec942e0f136716a' ) );
-		define( 'WP2D_EXT_GH',            esc_url( 'https://github.com/DiasPHPora/wp-to-diaspora' ) );
-		define( 'WP2D_EXT_DONATE',        esc_url( 'https://github.com/DiasPHPora/wp-to-diaspora#donate' ) );
-		define( 'WP2D_EXT_GH_ISSUES',     esc_url( 'https://github.com/DiasPHPora/wp-to-diaspora/issues' ) );
+		define( 'WP2D_EXT_WPORG', esc_url( 'https://wordpress.org/plugins/wp-to-diaspora' ) );
+		define( 'WP2D_EXT_I18N', esc_url( 'https://poeditor.com/join/project?hash=c085b3654a5e04c69ec942e0f136716a' ) );
+		define( 'WP2D_EXT_GH', esc_url( 'https://github.com/DiasPHPora/wp-to-diaspora' ) );
+		define( 'WP2D_EXT_DONATE', esc_url( 'https://github.com/DiasPHPora/wp-to-diaspora#donate' ) );
+		define( 'WP2D_EXT_GH_ISSUES', esc_url( 'https://github.com/DiasPHPora/wp-to-diaspora/issues' ) );
 		define( 'WP2D_EXT_GH_ISSUES_NEW', esc_url( 'https://github.com/DiasPHPora/wp-to-diaspora/issues/new' ) );
 	}
 
@@ -89,10 +89,10 @@ 
 		get_current_screen()->set_help_sidebar(
 			'<p><strong>' . esc_html__( 'WP to diaspora*', 'wp-to-diaspora' ) . '</strong></p>
 			<ul>
-				<li><a href="' . WP2D_EXT_GH     . '" target="_blank">GitHub</a>
-				<li><a href="' . WP2D_EXT_WPORG  . '" target="_blank">WordPress.org</a>
-				<li><a href="' . WP2D_EXT_I18N   . '" target="_blank">' . esc_html__( 'Help with translations', 'wp-to-diaspora' ) . '</a>
-				<li><a href="' . WP2D_EXT_DONATE . '" target="_blank">' . esc_html__( 'Make a donation', 'wp-to-diaspora' )        . '</a>
+				<li><a href="' . WP2D_EXT_GH . '" target="_blank">GitHub</a>
+				<li><a href="' . WP2D_EXT_WPORG . '" target="_blank">WordPress.org</a>
+				<li><a href="' . WP2D_EXT_I18N . '" target="_blank">' . esc_html__( 'Help with translations', 'wp-to-diaspora' ) . '</a>
+				<li><a href="' . WP2D_EXT_DONATE . '" target="_blank">' . esc_html__( 'Make a donation', 'wp-to-diaspora' ) . '</a>
 			</ul>'
 		);
 	}
@@ -150,7 +150,7 @@ 
 							<ul>
 								<li><strong>' . esc_html__( 'Global tags', 'wp-to-diaspora' ) . '</strong>: ' . esc_html__( 'Tags that apply to all posts.', 'wp-to-diaspora' ) . '
 								<li><strong>' . esc_html__( 'Custom tags', 'wp-to-diaspora' ) . '</strong>: ' . esc_html__( 'Tags that apply to individual posts (can be set on each post).', 'wp-to-diaspora' ) . '
-								<li><strong>' . esc_html__( 'Post tags',   'wp-to-diaspora' ) . '</strong>: ' . esc_html__( 'Default WordPress Tags of individual posts.', 'wp-to-diaspora' ) . '
+								<li><strong>' . esc_html__( 'Post tags', 'wp-to-diaspora' ) . '</strong>: ' . esc_html__( 'Default WordPress Tags of individual posts.', 'wp-to-diaspora' ) . '
 							</ul>
 					<li><strong>' . esc_html__( 'Global tags', 'wp-to-diaspora' ) . '</strong>: ' .
 						esc_html__( 'A list of tags that gets added to every post.', 'wp-to-diaspora' ) . '
@@ -217,10 +217,10 @@ 
 			'content' => '<p><strong>' . esc_html__( 'So you feel like contributing to the WP to diaspora* plugin? Great!', 'wp-to-diaspora' ) . '</strong></p>
 				<p>' . esc_html__( 'There are many different ways that you can help out with this plugin:', 'wp-to-diaspora' ) . '</p>
 				<ul>
-					<li><a href="' . WP2D_EXT_GH_ISSUES_NEW . '" target="_blank">' . esc_html__( 'Report a bug', 'wp-to-diaspora' )           . '</a>
-					<li><a href="' . WP2D_EXT_GH_ISSUES_NEW . '" target="_blank">' . esc_html__( 'Suggest a new feature', 'wp-to-diaspora' )  . '</a>
-					<li><a href="' . WP2D_EXT_I18N          . '" target="_blank">' . esc_html__( 'Help with translations', 'wp-to-diaspora' ) . '</a>
-					<li><a href="' . WP2D_EXT_DONATE        . '" target="_blank">' . esc_html__( 'Make a donation', 'wp-to-diaspora' )        . '</a>
+					<li><a href="' . WP2D_EXT_GH_ISSUES_NEW . '" target="_blank">' . esc_html__( 'Report a bug', 'wp-to-diaspora' ) . '</a>
+					<li><a href="' . WP2D_EXT_GH_ISSUES_NEW . '" target="_blank">' . esc_html__( 'Suggest a new feature', 'wp-to-diaspora' ) . '</a>
+					<li><a href="' . WP2D_EXT_I18N . '" target="_blank">' . esc_html__( 'Help with translations', 'wp-to-diaspora' ) . '</a>
+					<li><a href="' . WP2D_EXT_DONATE . '" target="_blank">' . esc_html__( 'Make a donation', 'wp-to-diaspora' ) . '</a>
 				</ul>',
 		) );
 	}
@@ -250,7 +250,7 @@ 
 	public static function get_help_tab_quick_link( $error ) {
 		$help_tab = '';
 		if ( is_wp_error( $error ) && ( $error_data = $error->get_error_data() ) && array_key_exists( 'help_tab', $error_data ) ) {
-			$help_tab = $error_data['help_tab'];
+			$help_tab = $error_data[ 'help_tab' ];
 		} elseif ( is_string( $error ) ) {
 			$help_tab = $error;
 		}