nixsolutions / ggf

app/Auth/Guard.php

Unused Use Statements -2 removed lines

@@ -8,9 +8,7 @@
 use Facebook\FacebookAuthorizationException;
 use Facebook\FacebookRequest;
 use Facebook\GraphUser;
-use Illuminate;
 use Illuminate\Support\Facades\Config;
-use Illuminate\Support\Facades\Request;
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Session;
 use Illuminate\Http\Request as HttpRequest;

app/Exceptions/Handler.php

Doc Comments -2 removed lines

@@ -26,7 +26,6 @@ 
      *
      * This is a great spot to send exceptions to Sentry, Bugsnag, etc
      * @name report
-     * @param Exception $e
      * @throws \Exception
      */
     public function report(Exception $exception)
@@ -38,7 +37,6 @@ 
      * Render an exception into an HTTP response.
      *
      * @param  \Illuminate\Http\Request $request
-     * @param  \Exception $e
      * @return \Illuminate\Http\Response
      */
     public function render($request, Exception $exception)

app/Http/Controllers/API/TeamController.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Http\Controllers\API;
 
-use App\Http\Requests\Tournament\RemoveTeam;
 use App\League;
 use App\Team;
 use App\TournamentTeam;

app/Http/Controllers/API/TeamMemberController.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Http\Controllers\API;
 
 use App\Http\Requests\Team\AssignTeamMember;
-use App\Http\Requests\Team\RemoveTeamMember;
 use App\Member;
 use App\TeamMember;
 use App\Transformers\TeamMemberSearchTransformer;

Spacing +2 added lines, -2 removed lines

@@ -135,8 +135,8 @@
         $tournamentId = Input::get('tournamentId');
         $collection = Member::with(['teamMembers', 'tournamentTeams'])->get();
 
-        $collection = $collection->filter(function ($member) use ($tournamentId) {
-            $team = $member->tournamentTeams->first(function ($tournamentTeam) use ($tournamentId) {
+        $collection = $collection->filter(function($member) use ($tournamentId) {
+            $team = $member->tournamentTeams->first(function($tournamentTeam) use ($tournamentId) {
                 return $tournamentTeam->tournamentId == $tournamentId;
             });
 

app/Http/Controllers/MatchController.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     /**
      * Store a newly created resource in storage.
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function store()
     {

app/Http/Requests/MatchUpdate.php

Doc Comments +2 added lines, -2 removed lines

@@ -65,7 +65,7 @@ 
     }
 
     /**
-     * @param $match
+     * @param Match $match
      * @param $tournament
      * @return bool
      */
@@ -86,7 +86,7 @@ 
     }
 
     /**
-     * @param $match
+     * @param Match $match
      * @param $tournament Tournament
      * @return bool
      */

Spacing +2 added lines, -2 removed lines

@@ -43,13 +43,13 @@
         $match = Match::findOrFail($matchId)->replicate();
         $tournament = $match->tournament()->get()->first();
 
-        Validator::extend('round_active', function ($attribute, $value, $parameters) use ($match, $tournament) {
+        Validator::extend('round_active', function($attribute, $value, $parameters) use ($match, $tournament) {
             return $this->isRoundActive($match, $tournament);
         });
 
         Validator::extend(
             'round_finished_for_pair',
-            function ($attribute, $value, $parameters) use ($match, $tournament) {
+            function($attribute, $value, $parameters) use ($match, $tournament) {
                 $match->status = $value;
                 return $this->isRoundFinishedForPair($match, $tournament);
             }

app/Jobs/Tournament/DrawKnockOut.php

Doc Comments +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
     protected $round;
 
     /**
-     * @return array
+     * @return integer[]
      */
     private static function listOfAvailableTeamsAmount()
     {
@@ -131,7 +131,7 @@ 
 
     /**
      * @name savePairs
-     * @param $pairs
+     * @param Collection $pairs
      * @param string $gameType
      */
     protected function savePairs($pairs, $gameType = Match::GAME_TYPE_QUALIFY)

Spacing +3 added lines, -3 removed lines

@@ -112,18 +112,18 @@
 
             return $this->teams->chunk(2);
         } else {
-            $currentPairs = $tournament->getPairs()->filter(function ($pair) use ($round) {
+            $currentPairs = $tournament->getPairs()->filter(function($pair) use ($round) {
                 return $pair->get('round') === $round - 1;
             });
 
             $roundWinners = new Collection();
 
-            $currentPairs->each(function ($pair) use ($tournament, $roundWinners) {
+            $currentPairs->each(function($pair) use ($tournament, $roundWinners) {
                 // detect pair winner
                 $roundWinners->push($tournament->getScore($pair->get('matches'))->first());
             });
 
-            return $this->teams->filter(function ($team) use ($roundWinners) {
+            return $this->teams->filter(function($team) use ($roundWinners) {
                 return $roundWinners->pluck('teamId')->contains($team['id']);
             })->chunk(2);
         }

app/Tournament.php

Doc Comments +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getAvailableMembersType()
     {
@@ -67,7 +67,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getAvailableTypes()
     {
@@ -79,7 +79,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getAvailableStatuses()
     {

Spacing +6 added lines, -6 removed lines

@@ -100,7 +100,7 @@ 
         // get pairs of current round matches
         $pairs = new Collection();
 
-        $this->matches->map(function ($match) use ($pairs) {
+        $this->matches->map(function($match) use ($pairs) {
 
             $pairId = [$match->homeTournamentTeam->id, $match->awayTournamentTeam->id];
             sort($pairId);
@@ -179,7 +179,7 @@ 
     {
         $score = new Collection();
 
-        $matches->map(function ($match) use ($score) {
+        $matches->map(function($match) use ($score) {
 
             $homeTeam = $score->pull($match->homeTournamentTeam->id);
             $awayTeam = $score->pull($match->awayTournamentTeam->id);
@@ -216,13 +216,13 @@ 
                 );
             }
 
-            $teams =$this->matchScore($match, $homeTeam, $awayTeam);
+            $teams = $this->matchScore($match, $homeTeam, $awayTeam);
             $score->put($match->homeTournamentTeam->id, $teams['homeTeam']);
             $score->put($match->awayTournamentTeam->id, $teams['awayTeam']);
         });
 
         // sort by points and goal difference
-        $score = $score->sort(function ($a, $b) {
+        $score = $score->sort(function($a, $b) {
             if ($b['points'] === $a['points']) {
                 return $b['goalsDifference'] - $a['goalsDifference'];
             }
@@ -232,7 +232,7 @@ 
 
         $previousRow = null;
         $position = 1;
-        $score = $score->map(function ($row) use (&$previousRow, &$position) {
+        $score = $score->map(function($row) use (&$previousRow, &$position) {
             if ($previousRow
                 && $previousRow['points'] > 0
                 && $previousRow['points'] == $row['points']
@@ -252,7 +252,7 @@ 
         });
 
         // alphabetical sort for teams on the same position
-        $score = $score->sortBy(function ($team) {
+        $score = $score->sortBy(function($team) {
             return $team['position'] . '-' . $team['name'];
         }, SORT_NUMERIC);
 

app/Http/Controllers/API/MatchController.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
         }
 
         if ($teamId) {
-            $collection->where(function ($query) use ($teamId) {
+            $collection->where(function($query) use ($teamId) {
                 $query->where('homeTournamentTeamId', $teamId)
                     ->orWhere('awayTournamentTeamId', $teamId);
             });