Passed
Pull Request — master (#4596)
by
unknown
09:47 queued 03:00
created
sources/folders.class.php 3 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,8 @@
 block discarded – undo
73 73
         }
74 74
 
75 75
         if (!$this->isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin)) {
76
-           if ($parent_id != 0 && $user_can_create_root_folder == false )
77
-               return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
76
+            if ($parent_id != 0 && $user_can_create_root_folder == false )
77
+                return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
78 78
         }
79 79
 
80 80
         if (!$this->checkDuplicateFolderAllowed($title) && $personal_folder == 0) {
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -73,8 +73,9 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         if (!$this->isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin)) {
76
-           if ($parent_id != 0 && $user_can_create_root_folder == false )
77
-               return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
76
+           if ($parent_id != 0 && $user_can_create_root_folder == false ) {
77
+                          return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
78
+           }
78 79
         }
79 80
 
80 81
         if (!$this->checkDuplicateFolderAllowed($title) && $personal_folder == 0) {
@@ -435,8 +436,9 @@  discard block
 block discarded – undo
435 436
             )['count'];
436 437
 
437 438
             // Don't insert duplicates
438
-            if ($count > 0)
439
-                continue;
439
+            if ($count > 0) {
440
+                            continue;
441
+            }
440 442
 
441 443
             // Insert new background task
442 444
             DB::insert(
Please login to merge, or discard this patch.
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         if (!$this->isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin)) {
76
-           if ($parent_id != 0 && $user_can_create_root_folder == false )
76
+           if ($parent_id != 0 && $user_can_create_root_folder == false)
77 77
                return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
78 78
         }
79 79
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
         $parentComplexity = $this->checkComplexityLevel($parentFolderData, $complexity, $parent_id);
87 87
         if (isset($parentComplexity ['error']) && $parentComplexity['error'] === true) {
88
-            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder') . " [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
88
+            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder')." [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
89 89
         }
90 90
 
91 91
         return $this->createFolder($params, array_merge($parentFolderData, $parentComplexity));
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
         ) {
135 135
             DB::query(
136 136
                 'SELECT *
137
-                FROM ' . prefixTable('nested_tree') . '
137
+                FROM ' . prefixTable('nested_tree').'
138 138
                 WHERE title = %s AND personal_folder = 0',
139 139
                 $title
140 140
             );
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         //check if parent folder is personal
159 159
         $data = DB::queryfirstrow(
160 160
             'SELECT personal_folder, bloquer_creation, bloquer_modification
161
-            FROM ' . prefixTable('nested_tree') . '
161
+            FROM ' . prefixTable('nested_tree').'
162 162
             WHERE id = %i',
163 163
             $parent_id
164 164
         );
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
             // get complexity level for this folder
198 198
             $data = DB::queryfirstrow(
199 199
                 'SELECT valeur
200
-                FROM ' . prefixTable('misc') . '
200
+                FROM ' . prefixTable('misc').'
201 201
                 WHERE intitule = %i AND type = %s',
202 202
                 $parent_id,
203 203
                 'complex'
@@ -248,11 +248,11 @@  discard block
 block discarded – undo
248 248
      */
249 249
     private function canCreateFolder($isPersonal, $user_is_admin, $user_is_manager, $user_can_manage_all_users, $user_can_create_root_folder)
250 250
     {
251
-        return (int)$isPersonal === 1 ||
252
-            (int)$user_is_admin === 1 ||
253
-            ((int)$user_is_manager === 1 || (int)$user_can_manage_all_users === 1) ||
251
+        return (int) $isPersonal === 1 ||
252
+            (int) $user_is_admin === 1 ||
253
+            ((int) $user_is_manager === 1 || (int) $user_can_manage_all_users === 1) ||
254 254
             ($this->settings['enable_user_can_create_folders'] ?? false) ||
255
-            ((int)$user_can_create_root_folder === 1);
255
+            ((int) $user_can_create_root_folder === 1);
256 256
     }
257 257
 
258 258
     /**
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
         $path = '';
333 333
         $tree_path = $tree->getPath(0, false);
334 334
         foreach ($tree_path as $fld) {
335
-            $path .= empty($path) ? $fld->title : '/' . $fld->title;
335
+            $path .= empty($path) ? $fld->title : '/'.$fld->title;
336 336
         }
337 337
 
338 338
         $new_json = [
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
             "is_visible_active" => 0,
347 347
         ];
348 348
 
349
-        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM ' . prefixTable('cache_tree') . ' WHERE user_id = %i', (int)$user_id);
349
+        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM '.prefixTable('cache_tree').' WHERE user_id = %i', (int) $user_id);
350 350
 
351 351
         if (empty($cache_tree)) {
352 352
             DB::insert(prefixTable('cache_tree'), [
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
                 'folders' => json_encode($folders),
367 367
                 'visible_folders' => json_encode($visible_folders),
368 368
                 'timestamp' => time(),
369
-            ], 'increment_id = %i', (int)$cache_tree['increment_id']);
369
+            ], 'increment_id = %i', (int) $cache_tree['increment_id']);
370 370
         }
371 371
     }
372 372
 
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
     private function manageFolderPermissions($parent_id, $newId, $user_roles, $access_rights, $user_is_admin)
377 377
     {
378 378
         if ($this->settings['subfolder_rights_as_parent'] ?? false) {
379
-            $rows = DB::query('SELECT role_id, type FROM ' . prefixTable('roles_values') . ' WHERE folder_id = %i', $parent_id);
379
+            $rows = DB::query('SELECT role_id, type FROM '.prefixTable('roles_values').' WHERE folder_id = %i', $parent_id);
380 380
             foreach ($rows as $record) {
381 381
                 DB::insert(prefixTable('roles_values'), [
382 382
                     'role_id' => $record['role_id'],
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
                     'type' => $record['type'],
385 385
                 ]);
386 386
             }
387
-        } elseif ((int)$user_is_admin !== 1) {
387
+        } elseif ((int) $user_is_admin !== 1) {
388 388
             foreach (array_unique(explode(';', $user_roles)) as $role) {
389 389
                 if (!empty($role)) {
390 390
                     DB::insert(prefixTable('roles_values'), [
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
      */
403 403
     private function copyCustomFieldsCategories($parent_id, $newId)
404 404
     {
405
-        $rows = DB::query('SELECT id_category FROM ' . prefixTable('categories_folders') . ' WHERE id_folder = %i', $parent_id);
405
+        $rows = DB::query('SELECT id_category FROM '.prefixTable('categories_folders').' WHERE id_folder = %i', $parent_id);
406 406
         foreach ($rows as $record) {
407 407
             DB::insert(prefixTable('categories_folders'), [
408 408
                 'id_category' => $record['id_category'],
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
             // Search for existing job
428 428
             $count = DB::queryFirstRow(
429 429
                 'SELECT COUNT(*) AS count
430
-                FROM ' . prefixTable('background_tasks') . '
430
+                FROM ' . prefixTable('background_tasks').'
431 431
                 WHERE is_in_progress = %i AND process_type = %s AND arguments = %s',
432 432
                 0,
433 433
                 'user_build_cache_tree',
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
         return [
462 462
             'error' => true,
463 463
             'message' => $message,
464
-            'newId' => '' . $newIdSuffix,
464
+            'newId' => ''.$newIdSuffix,
465 465
         ];
466 466
     }
467 467
 }
Please login to merge, or discard this patch.
api/Model/ItemModel.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -342,8 +342,8 @@
 block discarded – undo
342 342
         );
343 343
 
344 344
         if (DB::count() > 0 && (
345
-	     (isset($SETTINGS['duplicate_item']) && (int) $SETTINGS['duplicate_item'] === 0)
346
-	     && (int) $itemInfos['personal_folder'] === 0)
345
+            (isset($SETTINGS['duplicate_item']) && (int) $SETTINGS['duplicate_item'] === 0)
346
+         && (int) $itemInfos['personal_folder'] === 0)
347 347
         ) {
348 348
             throw new Exception('Similar item already exists. Duplicates are not allowed.');
349 349
         }
Please login to merge, or discard this patch.