Passed
Pull Request — master (#4596)
by
unknown
09:47 queued 03:00
created
pages/profile.js.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('profile') === false) {
74 74
     // Not allowed page
75 75
     $session->set('system-error_code', ERR_NOT_ALLOWED);
76
-    include $SETTINGS['cpassman_dir'] . '/error.php';
76
+    include $SETTINGS['cpassman_dir'].'/error.php';
77 77
     exit;
78 78
 }
79 79
 ?>
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     })
98 98
 
99 99
     // Select user properties
100
-    $('#profile-user-language option[value=<?php echo $session->get('user-language');?>').attr('selected','selected');
100
+    $('#profile-user-language option[value=<?php echo $session->get('user-language'); ?>').attr('selected','selected');
101 101
 
102 102
 
103 103
     // AVATAR IMPORT
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
 
296 296
                     // reload page in case of language change
297 297
                     if ($('#profile-user-language').val()
298
-                        && $('#profile-user-language').val().toLowerCase() !== '<?php echo $session->get('user-language');?>') {
298
+                        && $('#profile-user-language').val().toLowerCase() !== '<?php echo $session->get('user-language'); ?>') {
299 299
                         // prepare reload
300 300
                         $(this).delay(3000).queue(function() {
301 301
                             document.location.href = "index.php?page=profile";
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
                         // Inform user
307 307
                         toastr.remove();
308 308
                         toastr.info(
309
-                            '<?php echo $lang->get('alert_page_will_reload') . ' ... ' . $lang->get('please_wait'); ?>',
309
+                            '<?php echo $lang->get('alert_page_will_reload').' ... '.$lang->get('please_wait'); ?>',
310 310
                             '', {
311 311
                                 timeOut: 3000,
312 312
                                 progressBar: true
@@ -410,27 +410,27 @@  discard block
 block discarded – undo
410 410
         "defaultText": "<?php echo $lang->get('index_pw_level_txt'); ?>",
411 411
         "ratings": [
412 412
             {
413
-                "minScore": <?php echo TP_PW_STRENGTH_1;?>,
413
+                "minScore": <?php echo TP_PW_STRENGTH_1; ?>,
414 414
                 "className": "meterWarn",
415 415
                 "text": "<?php echo $lang->get('complex_level1'); ?>"
416 416
             },
417 417
             {
418
-                "minScore": <?php echo TP_PW_STRENGTH_2;?>,
418
+                "minScore": <?php echo TP_PW_STRENGTH_2; ?>,
419 419
                 "className": "meterWarn",
420 420
                 "text": "<?php echo $lang->get('complex_level2'); ?>"
421 421
             },
422 422
             {
423
-                "minScore": <?php echo TP_PW_STRENGTH_3;?>,
423
+                "minScore": <?php echo TP_PW_STRENGTH_3; ?>,
424 424
                 "className": "meterGood",
425 425
                 "text": "<?php echo $lang->get('complex_level3'); ?>"
426 426
             },
427 427
             {
428
-                "minScore": <?php echo TP_PW_STRENGTH_4;?>,
428
+                "minScore": <?php echo TP_PW_STRENGTH_4; ?>,
429 429
                 "className": "meterGood",
430 430
                 "text": "<?php echo $lang->get('complex_level4'); ?>"
431 431
             },
432 432
             {
433
-                "minScore": <?php echo TP_PW_STRENGTH_5;?>,
433
+                "minScore": <?php echo TP_PW_STRENGTH_5; ?>,
434 434
                 "className": "meterExcel",
435 435
                 "text": "<?php echo $lang->get('complex_level5'); ?>"
436 436
             }
@@ -523,27 +523,27 @@  discard block
 block discarded – undo
523 523
         "defaultText": "<?php echo $lang->get('index_pw_level_txt'); ?>",
524 524
         "ratings": [
525 525
             {
526
-                "minScore": <?php echo TP_PW_STRENGTH_1;?>,
526
+                "minScore": <?php echo TP_PW_STRENGTH_1; ?>,
527 527
                 "className": "meterWarn",
528 528
                 "text": "<?php echo $lang->get('complex_level1'); ?>"
529 529
             },
530 530
             {
531
-                "minScore": <?php echo TP_PW_STRENGTH_2;?>,
531
+                "minScore": <?php echo TP_PW_STRENGTH_2; ?>,
532 532
                 "className": "meterWarn",
533 533
                 "text": "<?php echo $lang->get('complex_level2'); ?>"
534 534
             },
535 535
             {
536
-                "minScore": <?php echo TP_PW_STRENGTH_3;?>,
536
+                "minScore": <?php echo TP_PW_STRENGTH_3; ?>,
537 537
                 "className": "meterGood",
538 538
                 "text": "<?php echo $lang->get('complex_level3'); ?>"
539 539
             },
540 540
             {
541
-                "minScore": <?php echo TP_PW_STRENGTH_4;?>,
541
+                "minScore": <?php echo TP_PW_STRENGTH_4; ?>,
542 542
                 "className": "meterGood",
543 543
                 "text": "<?php echo $lang->get('complex_level4'); ?>"
544 544
             },
545 545
             {
546
-                "minScore": <?php echo TP_PW_STRENGTH_5;?>,
546
+                "minScore": <?php echo TP_PW_STRENGTH_5; ?>,
547 547
                 "className": "meterExcel",
548 548
                 "text": "<?php echo $lang->get('complex_level5'); ?>"
549 549
             }
@@ -559,7 +559,7 @@  discard block
 block discarded – undo
559 559
         }
560 560
     });
561 561
 
562
-    $('#profile-keys_download-date').text('<?php echo null === $session->get('user-keys_recovery_time') ? $lang->get('none') : date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $session->get('user-keys_recovery_time')); ?>');
562
+    $('#profile-keys_download-date').text('<?php echo null === $session->get('user-keys_recovery_time') ? $lang->get('none') : date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $session->get('user-keys_recovery_time')); ?>');
563 563
 
564 564
     $("#open-dialog-keys-download").on('click', function(event) {
565 565
         event.preventDefault();
Please login to merge, or discard this patch.
scripts/task_maintenance_clean_orphan_objects.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -126,64 +126,64 @@
 block discarded – undo
126 126
 
127 127
     // Delete all item keys for which no user exist
128 128
     DB::query(
129
-        'DELETE k FROM ' . prefixTable('sharekeys_items') . ' k
130
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
129
+        'DELETE k FROM '.prefixTable('sharekeys_items').' k
130
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
131 131
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
132 132
     );
133 133
 
134 134
     // Delete all files keys for which no user exist
135 135
     DB::query(
136
-        'DELETE k FROM ' . prefixTable('sharekeys_files') . ' k
137
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
136
+        'DELETE k FROM '.prefixTable('sharekeys_files').' k
137
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
138 138
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
139 139
     );
140 140
 
141 141
     // Delete all fields keys for which no user exist
142 142
     DB::query(
143
-        'DELETE k FROM ' . prefixTable('sharekeys_fields') . ' k
144
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
143
+        'DELETE k FROM '.prefixTable('sharekeys_fields').' k
144
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
145 145
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
146 146
     );
147 147
 
148 148
     // Delete all item logs for which no user exist
149 149
     DB::query(
150
-        'DELETE l FROM ' . prefixTable('log_items') . ' l
151
-        LEFT JOIN ' . prefixTable('users') . ' u ON l.id_user = u.id
150
+        'DELETE l FROM '.prefixTable('log_items').' l
151
+        LEFT JOIN ' . prefixTable('users').' u ON l.id_user = u.id
152 152
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
153 153
     );
154 154
 
155 155
     // Delete all system logs for which no user exist
156 156
     DB::query(
157
-        'DELETE l FROM ' . prefixTable('log_system') . ' l
158
-        LEFT JOIN ' . prefixTable('users') . ' u ON l.qui = u.id
157
+        'DELETE l FROM '.prefixTable('log_system').' l
158
+        LEFT JOIN ' . prefixTable('users').' u ON l.qui = u.id
159 159
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
160 160
     );
161 161
 
162 162
     // Delete all item keys for which no object exist
163 163
     DB::query(
164
-        'DELETE k FROM ' . prefixTable('sharekeys_items') . ' k
165
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
164
+        'DELETE k FROM '.prefixTable('sharekeys_items').' k
165
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
166 166
         WHERE i.id IS NULL'
167 167
     );
168 168
 
169 169
     // Delete all files keys for which no object exist
170 170
     DB::query(
171
-        'DELETE k FROM ' . prefixTable('sharekeys_files') . ' k
172
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
171
+        'DELETE k FROM '.prefixTable('sharekeys_files').' k
172
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
173 173
         WHERE i.id IS NULL'
174 174
     );
175 175
 
176 176
     // Delete all fields keys for which no object exist
177 177
     DB::query(
178
-        'DELETE k FROM ' . prefixTable('sharekeys_fields') . ' k
179
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
178
+        'DELETE k FROM '.prefixTable('sharekeys_fields').' k
179
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
180 180
         WHERE i.id IS NULL'
181 181
     );
182 182
 
183 183
     // Delete all item logs for which no object exist
184 184
     DB::query(
185
-        'DELETE l FROM ' . prefixTable('log_items') . ' l
186
-        LEFT JOIN ' . prefixTable('items') . ' i ON l.id_item = i.id
185
+        'DELETE l FROM '.prefixTable('log_items').' l
186
+        LEFT JOIN ' . prefixTable('items').' i ON l.id_item = i.id
187 187
         WHERE i.id IS NULL'
188 188
     );
189 189
 
Please login to merge, or discard this patch.
sources/folders.class.php 3 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,8 @@
 block discarded – undo
73 73
         }
74 74
 
75 75
         if (!$this->isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin)) {
76
-           if ($parent_id != 0 && $user_can_create_root_folder == false )
77
-               return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
76
+            if ($parent_id != 0 && $user_can_create_root_folder == false )
77
+                return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
78 78
         }
79 79
 
80 80
         if (!$this->checkDuplicateFolderAllowed($title) && $personal_folder == 0) {
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -73,8 +73,9 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         if (!$this->isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin)) {
76
-           if ($parent_id != 0 && $user_can_create_root_folder == false )
77
-               return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
76
+           if ($parent_id != 0 && $user_can_create_root_folder == false ) {
77
+                          return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
78
+           }
78 79
         }
79 80
 
80 81
         if (!$this->checkDuplicateFolderAllowed($title) && $personal_folder == 0) {
@@ -435,8 +436,9 @@  discard block
 block discarded – undo
435 436
             )['count'];
436 437
 
437 438
             // Don't insert duplicates
438
-            if ($count > 0)
439
-                continue;
439
+            if ($count > 0) {
440
+                            continue;
441
+            }
440 442
 
441 443
             // Insert new background task
442 444
             DB::insert(
Please login to merge, or discard this patch.
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         if (!$this->isParentFolderAllowed($parent_id, $user_accessible_folders, $user_is_admin)) {
76
-           if ($parent_id != 0 && $user_can_create_root_folder == false )
76
+           if ($parent_id != 0 && $user_can_create_root_folder == false)
77 77
                return $this->errorResponse($this->lang->get('error_folder_not_allowed_for_this_user'));
78 78
         }
79 79
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
         $parentComplexity = $this->checkComplexityLevel($parentFolderData, $complexity, $parent_id);
87 87
         if (isset($parentComplexity ['error']) && $parentComplexity['error'] === true) {
88
-            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder') . " [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
88
+            return $this->errorResponse($this->lang->get('error_folder_complexity_lower_than_top_folder')." [<b>{$this->settings['TP_PW_COMPLEXITY'][$parentComplexity['valeur']][1]}</b>]");
89 89
         }
90 90
 
91 91
         return $this->createFolder($params, array_merge($parentFolderData, $parentComplexity));
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
         ) {
135 135
             DB::query(
136 136
                 'SELECT *
137
-                FROM ' . prefixTable('nested_tree') . '
137
+                FROM ' . prefixTable('nested_tree').'
138 138
                 WHERE title = %s AND personal_folder = 0',
139 139
                 $title
140 140
             );
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         //check if parent folder is personal
159 159
         $data = DB::queryfirstrow(
160 160
             'SELECT personal_folder, bloquer_creation, bloquer_modification
161
-            FROM ' . prefixTable('nested_tree') . '
161
+            FROM ' . prefixTable('nested_tree').'
162 162
             WHERE id = %i',
163 163
             $parent_id
164 164
         );
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
             // get complexity level for this folder
198 198
             $data = DB::queryfirstrow(
199 199
                 'SELECT valeur
200
-                FROM ' . prefixTable('misc') . '
200
+                FROM ' . prefixTable('misc').'
201 201
                 WHERE intitule = %i AND type = %s',
202 202
                 $parent_id,
203 203
                 'complex'
@@ -248,11 +248,11 @@  discard block
 block discarded – undo
248 248
      */
249 249
     private function canCreateFolder($isPersonal, $user_is_admin, $user_is_manager, $user_can_manage_all_users, $user_can_create_root_folder)
250 250
     {
251
-        return (int)$isPersonal === 1 ||
252
-            (int)$user_is_admin === 1 ||
253
-            ((int)$user_is_manager === 1 || (int)$user_can_manage_all_users === 1) ||
251
+        return (int) $isPersonal === 1 ||
252
+            (int) $user_is_admin === 1 ||
253
+            ((int) $user_is_manager === 1 || (int) $user_can_manage_all_users === 1) ||
254 254
             ($this->settings['enable_user_can_create_folders'] ?? false) ||
255
-            ((int)$user_can_create_root_folder === 1);
255
+            ((int) $user_can_create_root_folder === 1);
256 256
     }
257 257
 
258 258
     /**
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
         $path = '';
333 333
         $tree_path = $tree->getPath(0, false);
334 334
         foreach ($tree_path as $fld) {
335
-            $path .= empty($path) ? $fld->title : '/' . $fld->title;
335
+            $path .= empty($path) ? $fld->title : '/'.$fld->title;
336 336
         }
337 337
 
338 338
         $new_json = [
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
             "is_visible_active" => 0,
347 347
         ];
348 348
 
349
-        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM ' . prefixTable('cache_tree') . ' WHERE user_id = %i', (int)$user_id);
349
+        $cache_tree = DB::queryFirstRow('SELECT increment_id, folders, visible_folders FROM '.prefixTable('cache_tree').' WHERE user_id = %i', (int) $user_id);
350 350
 
351 351
         if (empty($cache_tree)) {
352 352
             DB::insert(prefixTable('cache_tree'), [
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
                 'folders' => json_encode($folders),
367 367
                 'visible_folders' => json_encode($visible_folders),
368 368
                 'timestamp' => time(),
369
-            ], 'increment_id = %i', (int)$cache_tree['increment_id']);
369
+            ], 'increment_id = %i', (int) $cache_tree['increment_id']);
370 370
         }
371 371
     }
372 372
 
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
     private function manageFolderPermissions($parent_id, $newId, $user_roles, $access_rights, $user_is_admin)
377 377
     {
378 378
         if ($this->settings['subfolder_rights_as_parent'] ?? false) {
379
-            $rows = DB::query('SELECT role_id, type FROM ' . prefixTable('roles_values') . ' WHERE folder_id = %i', $parent_id);
379
+            $rows = DB::query('SELECT role_id, type FROM '.prefixTable('roles_values').' WHERE folder_id = %i', $parent_id);
380 380
             foreach ($rows as $record) {
381 381
                 DB::insert(prefixTable('roles_values'), [
382 382
                     'role_id' => $record['role_id'],
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
                     'type' => $record['type'],
385 385
                 ]);
386 386
             }
387
-        } elseif ((int)$user_is_admin !== 1) {
387
+        } elseif ((int) $user_is_admin !== 1) {
388 388
             foreach (array_unique(explode(';', $user_roles)) as $role) {
389 389
                 if (!empty($role)) {
390 390
                     DB::insert(prefixTable('roles_values'), [
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
      */
403 403
     private function copyCustomFieldsCategories($parent_id, $newId)
404 404
     {
405
-        $rows = DB::query('SELECT id_category FROM ' . prefixTable('categories_folders') . ' WHERE id_folder = %i', $parent_id);
405
+        $rows = DB::query('SELECT id_category FROM '.prefixTable('categories_folders').' WHERE id_folder = %i', $parent_id);
406 406
         foreach ($rows as $record) {
407 407
             DB::insert(prefixTable('categories_folders'), [
408 408
                 'id_category' => $record['id_category'],
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
             // Search for existing job
428 428
             $count = DB::queryFirstRow(
429 429
                 'SELECT COUNT(*) AS count
430
-                FROM ' . prefixTable('background_tasks') . '
430
+                FROM ' . prefixTable('background_tasks').'
431 431
                 WHERE is_in_progress = %i AND process_type = %s AND arguments = %s',
432 432
                 0,
433 433
                 'user_build_cache_tree',
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
         return [
462 462
             'error' => true,
463 463
             'message' => $message,
464
-            'newId' => '' . $newIdSuffix,
464
+            'newId' => ''.$newIdSuffix,
465 465
         ];
466 466
     }
467 467
 }
Please login to merge, or discard this patch.