Passed
Push — master ( a18ce8...b2aaae )
by Nils
06:35 queued 16s
created
pages/import.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
     || isset($SETTINGS['allow_import']) === false || (int) $SETTINGS['allow_import'] !== 1) {
71 71
     // Not allowed page
72 72
     $session->set('system-error_code', ERR_NOT_ALLOWED);
73
-    include $SETTINGS['cpassman_dir'] . '/error.php';
73
+    include $SETTINGS['cpassman_dir'].'/error.php';
74 74
     exit;
75 75
 }
76 76
 
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
  
86 86
 if ((int) $session->get('user-admin') === 1) {
87 87
     $folderOptions = '';
88
-    $rows = DB::query('SELECT id, title FROM ' . prefixTable('nested_tree') . ' WHERE personal_folder = %i', 0);
88
+    $rows = DB::query('SELECT id, title FROM '.prefixTable('nested_tree').' WHERE personal_folder = %i', 0);
89 89
     foreach ($rows as $record) {
90
-        $folderOptions .= '<option value="' . $record['id'] . '">' . htmlspecialchars($record['title'], ENT_QUOTES, 'UTF-8') . '</option>';
90
+        $folderOptions .= '<option value="'.$record['id'].'">'.htmlspecialchars($record['title'], ENT_QUOTES, 'UTF-8').'</option>';
91 91
     }
92 92
 }
93 93
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
                                         <?php
190 190
 $complexitySelect = '';
191 191
 foreach (TP_PW_COMPLEXITY as $level) {
192
-    $complexitySelect .= '<option value="' . $level[0] . '">' . $level[1] . '</option>';
192
+    $complexitySelect .= '<option value="'.$level[0].'">'.$level[1].'</option>';
193 193
 }
194 194
 echo $complexitySelect;
195 195
                                         ?>
Please login to merge, or discard this patch.
pages/import.js.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('import') === false) {
73 73
     // Not allowed page
74 74
     $session->set('system-error_code', ERR_NOT_ALLOWED);
75
-    include $SETTINGS['cpassman_dir'] . '/error.php';
75
+    include $SETTINGS['cpassman_dir'].'/error.php';
76 76
     exit;
77 77
 }
78 78
 ?>
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
                     const errorMessages = JSON.parse(response.message);
512 512
                     let errorHtml = '<ul>';
513 513
                     errorMessages.forEach(function(error) {
514
-                        errorHtml += '<li><?php echo $lang->get('import_error_folder_creation');?> "<b>'+error.errorPath+'</b>": '+error.errorMessage+'</li>';
514
+                        errorHtml += '<li><?php echo $lang->get('import_error_folder_creation'); ?> "<b>'+error.errorPath+'</b>": '+error.errorMessage+'</li>';
515 515
                     });
516 516
 
517 517
                     $('#import-feedback-progress-text').html(
@@ -997,7 +997,7 @@  discard block
 block discarded – undo
997 997
                                     // Isolate first item
998 998
                                     if (itemsList.length > 0) {
999 999
                                         $('#import-feedback-progress-text')
1000
-                                            .html('<i class="fa-solid fa-cog fa-spin ml-4 mr-2"></i><?php echo $lang->get('operation_progress');?> ('+((counter*100)/itemsNumber).toFixed(0)+'%)');
1000
+                                            .html('<i class="fa-solid fa-cog fa-spin ml-4 mr-2"></i><?php echo $lang->get('operation_progress'); ?> ('+((counter*100)/itemsNumber).toFixed(0)+'%)');
1001 1001
 
1002 1002
                                         data = {
1003 1003
                                             'edit-all': $('#import-keepass-edit-all-checkbox').prop('checked') === true ? 1 : 0,
Please login to merge, or discard this patch.
sources/expired.datatables.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 ) {
77 77
     // Not allowed page
78 78
     $session->set('system-error_code', ERR_NOT_ALLOWED);
79
-    include $SETTINGS['cpassman_dir'] . '/error.php';
79
+    include $SETTINGS['cpassman_dir'].'/error.php';
80 80
     exit;
81 81
 }
82 82
 
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 // Is a date sent?
102 102
 $dateCriteria = $request->query->get('dateCriteria');
103 103
 if ($dateCriteria !== null && !empty($dateCriteria)) {
104
-    $sWhere .= ' AND a.del_value < ' . round(filter_var($dateCriteria, FILTER_SANITIZE_NUMBER_INT) / 1000, 0);
104
+    $sWhere .= ' AND a.del_value < '.round(filter_var($dateCriteria, FILTER_SANITIZE_NUMBER_INT) / 1000, 0);
105 105
 }
106 106
 //echo $sWhere;
107 107
 /* BUILD QUERY */
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 $start = $request->query->getInt('start', 0);
111 111
 $length = $request->query->getInt('length', -1);
112 112
 if ($length !== -1) {
113
-    $sLimit = ' LIMIT ' . $start . ', ' . $length;
113
+    $sLimit = ' LIMIT '.$start.', '.$length;
114 114
 }
115 115
 
116 116
 //Ordering
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         $columnIndex = filter_var($order[0]['column'], FILTER_SANITIZE_NUMBER_INT);
124 124
 
125 125
         if (array_key_exists($columnIndex, $aColumns)) {
126
-            $sOrder .= $aColumns[$columnIndex] . ' ' . $order[0]['dir'];
126
+            $sOrder .= $aColumns[$columnIndex].' '.$order[0]['dir'];
127 127
         }
128 128
 
129 129
         // Supprimez la virgule finale si elle existe
@@ -147,9 +147,9 @@  discard block
 block discarded – undo
147 147
 
148 148
     if ($letter !== '' && $letter !== 'None') {
149 149
         $sWhere .= ' AND ';
150
-        $sWhere .= $aColumns[1] . " LIKE '" . $letter . "%' OR ";
151
-        $sWhere .= $aColumns[2] . " LIKE '" . $letter . "%' OR ";
152
-        $sWhere .= $aColumns[3] . " LIKE '" . $letter . "%' ";
150
+        $sWhere .= $aColumns[1]." LIKE '".$letter."%' OR ";
151
+        $sWhere .= $aColumns[2]." LIKE '".$letter."%' OR ";
152
+        $sWhere .= $aColumns[3]." LIKE '".$letter."%' ";
153 153
     }
154 154
 }
155 155
 
@@ -160,26 +160,26 @@  discard block
 block discarded – undo
160 160
 
161 161
         if ($searchValue !== '') {
162 162
             $sWhere = ' AND ';
163
-            $sWhere .= $aColumns[1] . " LIKE '" . $searchValue . "%' OR ";
164
-            $sWhere .= $aColumns[2] . " LIKE '" . $searchValue . "%' OR ";
165
-            $sWhere .= $aColumns[3] . " LIKE '" . $searchValue . "%' ";
163
+            $sWhere .= $aColumns[1]." LIKE '".$searchValue."%' OR ";
164
+            $sWhere .= $aColumns[2]." LIKE '".$searchValue."%' OR ";
165
+            $sWhere .= $aColumns[3]." LIKE '".$searchValue."%' ";
166 166
         }
167 167
     }
168 168
 }
169 169
 
170 170
 $rows = DB::query(
171 171
     'SELECT a.item_id, i.label, a.del_value, i.id_tree
172
-    FROM ' . prefixTable('automatic_del') . ' AS a
173
-    INNER JOIN ' . prefixTable('items') . ' AS i ON (i.id = a.item_id)' .
172
+    FROM ' . prefixTable('automatic_del').' AS a
173
+    INNER JOIN ' . prefixTable('items').' AS i ON (i.id = a.item_id)'.
174 174
     $sWhere.
175 175
     (string) $sOrder
176 176
 );
177 177
 $iTotal = DB::count();
178 178
 $rows = DB::query(
179 179
     'SELECT a.item_id, i.label, a.del_value, i.id_tree
180
-    FROM ' . prefixTable('automatic_del') . ' AS a
181
-    INNER JOIN ' . prefixTable('items') . ' AS i ON (i.id = a.item_id)' .
182
-        $sWhere .
180
+    FROM ' . prefixTable('automatic_del').' AS a
181
+    INNER JOIN ' . prefixTable('items').' AS i ON (i.id = a.item_id)'.
182
+        $sWhere.
183 183
         $sLimit
184 184
 );
185 185
 $iFilteredTotal = DB::count();
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
    * Output
188 188
 */
189 189
 $sOutput = '{';
190
-$sOutput .= '"sEcho": '. (int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT) . ', ';
190
+$sOutput .= '"sEcho": '.(int) $request->query->filter('draw', FILTER_SANITIZE_NUMBER_INT).', ';
191 191
 $sOutput .= '"iTotalRecords": '.$iTotal.', ';
192 192
 $sOutput .= '"iTotalDisplayRecords": '.$iTotal.', ';
193 193
 $sOutput .= '"aaData": ';
@@ -201,18 +201,18 @@  discard block
 block discarded – undo
201 201
     // start the line
202 202
     $sOutput .= '[';
203 203
     // Column 1
204
-    $sOutput .= '"<i class=\"fas fa-external-link-alt pointer text-primary mr-2\" onclick=\"showItemCard($(this))\" data-item-id=\"' . $record['item_id'] . '\"  data-item-tree-id=\"' . $record['id_tree'] . '\"></i>", ';
204
+    $sOutput .= '"<i class=\"fas fa-external-link-alt pointer text-primary mr-2\" onclick=\"showItemCard($(this))\" data-item-id=\"'.$record['item_id'].'\"  data-item-tree-id=\"'.$record['id_tree'].'\"></i>", ';
205 205
     // Column 2
206
-    $sOutput .= '"' . $record['label'] . '", ';
206
+    $sOutput .= '"'.$record['label'].'", ';
207 207
     // Column 3
208
-    $sOutput .= '"' . date($SETTINGS['date_format'] . ' ' . $SETTINGS['time_format'], (int) $record['del_value']) . '", ';
208
+    $sOutput .= '"'.date($SETTINGS['date_format'].' '.$SETTINGS['time_format'], (int) $record['del_value']).'", ';
209 209
     // Column 4
210 210
     $path = [];
211 211
     $treeDesc = $tree->getPath($record['id_tree'], true);
212 212
     foreach ($treeDesc as $t) {
213 213
         array_push($path, $t->title);
214 214
     }
215
-    $sOutput .= '"' . implode('<i class=\"fas fa-angle-right ml-1 mr-1\"></i>', $path) . '"],';
215
+    $sOutput .= '"'.implode('<i class=\"fas fa-angle-right ml-1 mr-1\"></i>', $path).'"],';
216 216
 }
217 217
 
218 218
 if (count($rows) > 0) {
Please login to merge, or discard this patch.
sources/utilities.queries.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 ) {
78 78
     // Not allowed page
79 79
     $session->set('system-error_code', ERR_NOT_ALLOWED);
80
-    include $SETTINGS['cpassman_dir'] . '/error.php';
80
+    include $SETTINGS['cpassman_dir'].'/error.php';
81 81
     exit;
82 82
 }
83 83
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             $arrFolders = array();
129 129
             $rows = DB::query(
130 130
                 'SELECT valeur, intitule
131
-                FROM ' . prefixTable('misc') . '
131
+                FROM ' . prefixTable('misc').'
132 132
                 WHERE type  = %s',
133 133
                 'folder_deleted'
134 134
             );
@@ -151,11 +151,11 @@  discard block
 block discarded – undo
151 151
                 i.id as id, i.label as label,
152 152
                 i.id_tree as id_tree, l.date as date, n.title as folder_title,
153 153
                 a.del_enabled as del_enabled, a.del_value as del_value, a.del_type as del_type
154
-                FROM ' . prefixTable('log_items') . ' as l
155
-                INNER JOIN ' . prefixTable('items') . ' as i ON (l.id_item=i.id)
156
-                LEFT JOIN ' . prefixTable('users') . ' as u ON (l.id_user=u.id)
157
-                LEFT JOIN ' . prefixTable('nested_tree') . ' as n ON (i.id_tree=n.id)
158
-                INNER JOIN ' . prefixTable('automatic_del') . ' as a ON (l.id_item = a.item_id)
154
+                FROM ' . prefixTable('log_items').' as l
155
+                INNER JOIN ' . prefixTable('items').' as i ON (l.id_item=i.id)
156
+                LEFT JOIN ' . prefixTable('users').' as u ON (l.id_user=u.id)
157
+                LEFT JOIN ' . prefixTable('nested_tree').' as n ON (i.id_tree=n.id)
158
+                INNER JOIN ' . prefixTable('automatic_del').' as a ON (l.id_item = a.item_id)
159 159
                 WHERE i.inactif = %i
160 160
                 AND l.action = %s',
161 161
                 1,
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                             'label' => $record['label'],
178 178
                             'date' => date($SETTINGS['date_format'], (int) $record['date']),
179 179
                             'login' => $record['login'],
180
-                            'name' => $record['name'] . ' ' . $record['lastname'],
180
+                            'name' => $record['name'].' '.$record['lastname'],
181 181
                             'folder_label' => $record['folder_title'],
182 182
                             'folder_deleted' => $thisFolder,
183 183
                             'del_enabled' => (bool) $record['del_enabled'],
@@ -238,10 +238,10 @@  discard block
 block discarded – undo
238 238
             foreach ($post_folders as $folderId) {
239 239
                 $data = DB::queryFirstRow(
240 240
                     'SELECT valeur
241
-                    FROM ' . prefixTable('misc') . "
241
+                    FROM ' . prefixTable('misc')."
242 242
                     WHERE type = 'folder_deleted'
243 243
                     AND intitule = %s",
244
-                    'f' . $folderId
244
+                    'f'.$folderId
245 245
                 );
246 246
                 if ((int) $data['valeur'] !== 0) {
247 247
                     $folderData = explode(', ', $data['valeur']);
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
                         prefixTable('misc'),
269 269
                         'type = %s AND intitule = %s',
270 270
                         'folder_deleted',
271
-                        'f' . $folderId
271
+                        'f'.$folderId
272 272
                     );
273 273
 
274 274
                     // Restore all items in this folder
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
                     // Get list of all items in thos folder
285 285
                     $items = DB::query(
286 286
                         'SELECT id
287
-                        FROM ' . prefixTable('items') . '
287
+                        FROM ' . prefixTable('items').'
288 288
                         WHERE id_tree = %i',
289 289
                         $folderId
290 290
                     );
@@ -373,10 +373,10 @@  discard block
 block discarded – undo
373 373
             foreach ($post_folders as $folderId) {
374 374
                 $data = DB::queryFirstRow(
375 375
                     'SELECT valeur
376
-                    FROM ' . prefixTable('misc') . "
376
+                    FROM ' . prefixTable('misc')."
377 377
                     WHERE type = 'folder_deleted'
378 378
                     AND intitule = %s",
379
-                    'f' . $folderId
379
+                    'f'.$folderId
380 380
                 );
381 381
                 if ((int) $data['valeur'] !== 0) {
382 382
                     $exploded = explode(',', $data['valeur']);
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
                         prefixTable('misc'),
388 388
                         'type = %s AND intitule = %s',
389 389
                         'folder_deleted',
390
-                        'f' . $folderData[0]
390
+                        'f'.$folderData[0]
391 391
                     );
392 392
 
393 393
                     // Delete all items in this folder
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
                     // Get list of all items in thos folder
402 402
                     $items = DB::query(
403 403
                         'SELECT id
404
-                        FROM ' . prefixTable('items') . '
404
+                        FROM ' . prefixTable('items').'
405 405
                         WHERE id_tree = %i',
406 406
                         $folderData[0]
407 407
                     );
@@ -418,7 +418,7 @@  discard block
 block discarded – undo
418 418
                         // Delete all fields
419 419
                         $fields = DB::query(
420 420
                             'SELECT id
421
-                            FROM ' . prefixTable('categories_items') . '
421
+                            FROM ' . prefixTable('categories_items').'
422 422
                             WHERE item_id = %i',
423 423
                             $folderData[0]
424 424
                         );
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
                         // Delete all files
439 439
                         $files = DB::query(
440 440
                             'SELECT id
441
-                            FROM ' . prefixTable('files') . '
441
+                            FROM ' . prefixTable('files').'
442 442
                             WHERE id_item = %i',
443 443
                             $folderData[0]
444 444
                         );
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
                 // Delete sharekey fields
496 496
                 $itemFields = DB::query(
497 497
                     'SELECT id
498
-                    FROM ' . prefixTable('categories_items') . '
498
+                    FROM ' . prefixTable('categories_items').'
499 499
                     WHERE item_id = %i',
500 500
                     $itemId
501 501
                 );
@@ -510,7 +510,7 @@  discard block
 block discarded – undo
510 510
                 // Delete sharekey files
511 511
                 $itemFiles = DB::query(
512 512
                     'SELECT id
513
-                    FROM ' . prefixTable('files') . '
513
+                    FROM ' . prefixTable('files').'
514 514
                     WHERE id_item = %i',
515 515
                     $itemId
516 516
                 );
@@ -587,7 +587,7 @@  discard block
 block discarded – undo
587 587
             ) {
588 588
                 if ($post_log_type === 'items') {
589 589
                     DB::query(
590
-                        'SELECT * FROM ' . prefixTable('log_items') . '
590
+                        'SELECT * FROM '.prefixTable('log_items').'
591 591
                         WHERE (date BETWEEN %i AND %i)'
592 592
                         . ($post_filter_action === 'all' ? '' : ' AND action = "'.$post_filter_action.'"')
593 593
                         . ((int) $post_filter_user === -1 ? '' : ' AND id_user = '.(int) $post_filter_user),
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
                 } elseif ($post_log_type === 'connections') {
608 608
                     //db::debugmode(true);
609 609
                     DB::query(
610
-                        'SELECT * FROM ' . prefixTable('log_system') . '
610
+                        'SELECT * FROM '.prefixTable('log_system').'
611 611
                         WHERE type=%s '
612 612
                         . 'AND (date BETWEEN %i AND %i)'
613 613
                         . ($post_filter_action === 'all' ? '' : ' AND action = '.$post_filter_action)
@@ -630,7 +630,7 @@  discard block
 block discarded – undo
630 630
                     );
631 631
                 } elseif ($post_log_type === 'errors') {
632 632
                     DB::query(
633
-                        'SELECT * FROM ' . prefixTable('log_system') . ' WHERE type=%s ' .
633
+                        'SELECT * FROM '.prefixTable('log_system').' WHERE type=%s '.
634 634
                             'AND (date BETWEEN %i AND %i)',
635 635
                         'error',
636 636
                         $post_date_from,
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
                     );
648 648
                 } elseif ($post_log_type === 'copy') {
649 649
                     DB::query(
650
-                        'SELECT * FROM ' . prefixTable('log_items') . ' WHERE action=%s ' .
650
+                        'SELECT * FROM '.prefixTable('log_items').' WHERE action=%s '.
651 651
                             'AND (date BETWEEN %i AND %i)',
652 652
                         'at_copy',
653 653
                         $post_date_from,
@@ -664,7 +664,7 @@  discard block
 block discarded – undo
664 664
                     );
665 665
                 } elseif ($post_log_type === 'admin') {
666 666
                     DB::query(
667
-                        'SELECT * FROM ' . prefixTable('log_system') . ' WHERE type=%s ' .
667
+                        'SELECT * FROM '.prefixTable('log_system').' WHERE type=%s '.
668 668
                             'AND (date BETWEEN %i AND %i)',
669 669
                         'admin_action',
670 670
                         $post_date_from,
@@ -681,7 +681,7 @@  discard block
 block discarded – undo
681 681
                     );
682 682
                 } elseif ($post_log_type === 'failed') {
683 683
                     DB::query(
684
-                        'SELECT * FROM ' . prefixTable('log_system') . ' WHERE type=%s ' .
684
+                        'SELECT * FROM '.prefixTable('log_system').' WHERE type=%s '.
685 685
                             'AND (date BETWEEN %i AND %i)',
686 686
                         'failed_auth',
687 687
                         $post_date_from,
@@ -752,19 +752,19 @@  discard block
 block discarded – undo
752 752
             // Get info about task
753 753
             $taskInfo = DB::queryFirstRow(
754 754
                 'SELECT p.process_type as process_type
755
-                FROM ' . prefixTable('background_tasks') . ' as p
755
+                FROM ' . prefixTable('background_tasks').' as p
756 756
                 WHERE p.increment_id = %i',
757 757
                 $post_id
758 758
             );
759 759
             if ($taskInfo !== null) {
760 760
                 // delete task
761 761
                 DB::query(
762
-                    'DELETE FROM ' . prefixTable('background_subtasks') . '
762
+                    'DELETE FROM '.prefixTable('background_subtasks').'
763 763
                     WHERE task_id = %i',
764 764
                     $post_id
765 765
                 );
766 766
                 DB::query(
767
-                    'DELETE FROM ' . prefixTable('background_tasks') . '
767
+                    'DELETE FROM '.prefixTable('background_tasks').'
768 768
                     WHERE increment_id = %i',
769 769
                     $post_id
770 770
                 );
@@ -831,7 +831,7 @@  discard block
 block discarded – undo
831 831
                         ->setDayOfMonth('*')
832 832
                         ->setMonths('*')
833 833
                         ->setDayOfWeek('*')
834
-                        ->setTaskCommandLine($phpBinaryPath . ' ' . $SETTINGS['cpassman_dir'] . '/sources/scheduler.php')
834
+                        ->setTaskCommandLine($phpBinaryPath.' '.$SETTINGS['cpassman_dir'].'/sources/scheduler.php')
835 835
                         ->setComments('Teampass scheduler');
836 836
                     
837 837
                     $crontabRepository->addJob($crontabJob);
Please login to merge, or discard this patch.