Passed
Push — teampass_3.0 ( 09962f...7cabaf )
by Nils
04:19
created
sources/upload.files.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -57,16 +57,16 @@  discard block
 block discarded – undo
57 57
 }
58 58
 
59 59
 /* do checks */
60
-require_once $SETTINGS['cpassman_dir'] . '/includes/config/include.php';
61
-require_once $SETTINGS['cpassman_dir'] . '/sources/checks.php';
60
+require_once $SETTINGS['cpassman_dir'].'/includes/config/include.php';
61
+require_once $SETTINGS['cpassman_dir'].'/sources/checks.php';
62 62
 if (!checkUser($_SESSION['user_id'], $_SESSION['key'], 'items', $SETTINGS)) {
63 63
     $_SESSION['error']['code'] = ERR_NOT_ALLOWED; //not allowed page
64
-    include $SETTINGS['cpassman_dir'] . '/error.php';
64
+    include $SETTINGS['cpassman_dir'].'/error.php';
65 65
     exit();
66 66
 }
67 67
 
68 68
 // load functions
69
-require_once $SETTINGS['cpassman_dir'] . '/sources/main.functions.php';
69
+require_once $SETTINGS['cpassman_dir'].'/sources/main.functions.php';
70 70
 
71 71
 // Prepare POST variables
72 72
 $post_user_token = filter_input(INPUT_POST, 'user_token', FILTER_SANITIZE_STRING);
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     } else {
102 102
         // check if token is expired
103 103
         $data = DB::queryFirstRow(
104
-            'SELECT end_timestamp FROM ' . prefixTable('tokens') . ' WHERE user_id = %i AND token = %s',
104
+            'SELECT end_timestamp FROM '.prefixTable('tokens').' WHERE user_id = %i AND token = %s',
105 105
             $_SESSION['user_id'],
106 106
             $post_user_token
107 107
         );
@@ -125,12 +125,12 @@  discard block
 block discarded – undo
125 125
 
126 126
 // HTTP headers for no cache etc
127 127
 header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
128
-header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
128
+header('Last-Modified: '.gmdate('D, d M Y H:i:s').' GMT');
129 129
 header('Cache-Control: no-store, no-cache, must-revalidate');
130 130
 header('Cache-Control: post-check=0, pre-check=0', false);
131 131
 
132 132
 if (null !== $post_type_upload && $post_type_upload === 'upload_profile_photo') {
133
-    $targetDir = $SETTINGS['cpassman_dir'] . '/includes/avatars';
133
+    $targetDir = $SETTINGS['cpassman_dir'].'/includes/avatars';
134 134
 } else {
135 135
     $targetDir = $SETTINGS['path_to_files_folder'];
136 136
 }
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 
192 192
 // Validate file name (for our purposes we'll just remove invalid characters)
193 193
 $file_name = preg_replace(
194
-    '/[^' . $valid_chars_regex . '\.]/',
194
+    '/[^'.$valid_chars_regex.'\.]/',
195 195
     '',
196 196
     filter_var(
197 197
         strtolower(basename($_FILES['file']['name'])),
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     )
200 200
 );
201 201
 if (strlen($file_name) == 0 || strlen($file_name) > $MAX_FILENAME_LENGTH) {
202
-    handleUploadError('Invalid file name: ' . $file_name . '.');
202
+    handleUploadError('Invalid file name: '.$file_name.'.');
203 203
     return false;
204 204
 }
205 205
 
@@ -214,8 +214,8 @@  discard block
 block discarded – undo
214 214
         $ext,
215 215
         explode(
216 216
             ',',
217
-            $SETTINGS['upload_docext'] . ',' . $SETTINGS['upload_imagesext'] .
218
-                ',' . $SETTINGS['upload_pkgext'] . ',' . $SETTINGS['upload_otherext']
217
+            $SETTINGS['upload_docext'].','.$SETTINGS['upload_imagesext'].
218
+                ','.$SETTINGS['upload_pkgext'].','.$SETTINGS['upload_otherext']
219 219
         )
220 220
     ) === false
221 221
     && $post_type_upload !== 'import_items_from_keepass'
@@ -226,28 +226,28 @@  discard block
 block discarded – undo
226 226
 
227 227
 // is destination folder writable
228 228
 if (is_writable($SETTINGS['path_to_files_folder']) === false) {
229
-    handleUploadError('Not enough permissions on folder ' . $SETTINGS['path_to_files_folder'] . '.');
229
+    handleUploadError('Not enough permissions on folder '.$SETTINGS['path_to_files_folder'].'.');
230 230
     return false;
231 231
 }
232 232
 
233 233
 // Clean the fileName for security reasons
234 234
 $fileName = preg_replace('/[^\w\.]+/', '_', $fileName);
235
-$fileName = preg_replace('/[^' . $valid_chars_regex . '\.]/', '', strtolower(basename($fileName)));
235
+$fileName = preg_replace('/[^'.$valid_chars_regex.'\.]/', '', strtolower(basename($fileName)));
236 236
 
237 237
 // Make sure the fileName is unique but only if chunking is disabled
238
-if ($chunks < 2 && file_exists($targetDir . DIRECTORY_SEPARATOR . $fileName)) {
238
+if ($chunks < 2 && file_exists($targetDir.DIRECTORY_SEPARATOR.$fileName)) {
239 239
     $fileNameA = substr($fileName, 0, strlen($ext));
240 240
     $fileNameB = substr($fileName, strlen($ext));
241 241
 
242 242
     $count = 1;
243
-    while (file_exists($targetDir . DIRECTORY_SEPARATOR . $fileNameA . '_' . $count . $fileNameB)) {
243
+    while (file_exists($targetDir.DIRECTORY_SEPARATOR.$fileNameA.'_'.$count.$fileNameB)) {
244 244
         ++$count;
245 245
     }
246 246
 
247
-    $fileName = $fileNameA . '_' . $count . $fileNameB;
247
+    $fileName = $fileNameA.'_'.$count.$fileNameB;
248 248
 }
249 249
 
250
-$filePath = $targetDir . DIRECTORY_SEPARATOR . $fileName;
250
+$filePath = $targetDir.DIRECTORY_SEPARATOR.$fileName;
251 251
 
252 252
 // Create target dir
253 253
 if (!file_exists($targetDir)) {
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 // Remove old temp files
262 262
 if ($cleanupTargetDir && is_dir($targetDir) && ($dir = opendir($targetDir))) {
263 263
     while (($file = readdir($dir)) !== false) {
264
-        $tmpfilePath = $targetDir . DIRECTORY_SEPARATOR . $file;
264
+        $tmpfilePath = $targetDir.DIRECTORY_SEPARATOR.$file;
265 265
 
266 266
         // Remove temp file if it is older than the max age and is not the current file
267 267
         if (
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 $newFileName = bin2hex(GenerateCryptKey(16, false, true, true, false, true, $SETTINGS));
352 352
 
353 353
 //Connect to mysql server
354
-require_once $SETTINGS['cpassman_dir'] . '/includes/libraries/Database/Meekrodb/db.class.php';
354
+require_once $SETTINGS['cpassman_dir'].'/includes/libraries/Database/Meekrodb/db.class.php';
355 355
 DB::$host = DB_HOST;
356 356
 DB::$user = DB_USER;
357 357
 DB::$password = defuseReturnDecrypted(DB_PASSWD, $SETTINGS);
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
 ) {
368 368
     rename(
369 369
         $filePath,
370
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName
370
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName
371 371
     );
372 372
 
373 373
     // Add in DB
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 ) {
397 397
     rename(
398 398
         $filePath,
399
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName
399
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName
400 400
     );
401 401
 
402 402
     // Add in DB
@@ -429,13 +429,13 @@  discard block
 block discarded – undo
429 429
     // rename the file
430 430
     rename(
431 431
         $filePath,
432
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName . '.' . $ext
432
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName.'.'.$ext
433 433
     );
434 434
 
435 435
     // make thumbnail
436 436
     $ret = makeThumbnail(
437
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName . '.' . $ext,
438
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName . '_thumb' . '.' . $ext,
437
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName.'.'.$ext,
438
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName.'_thumb'.'.'.$ext,
439 439
         40
440 440
     );
441 441
 
@@ -446,21 +446,21 @@  discard block
 block discarded – undo
446 446
     }
447 447
 
448 448
     // get current avatar and delete it
449
-    $data = DB::queryFirstRow('SELECT avatar, avatar_thumb FROM ' . prefixTable('users') . ' WHERE id=%i', $_SESSION['user_id']);
450
-    fileDelete($targetDir . DIRECTORY_SEPARATOR . $data['avatar'], $SETTINGS);
451
-    fileDelete($targetDir . DIRECTORY_SEPARATOR . $data['avatar_thumb'], $SETTINGS);
449
+    $data = DB::queryFirstRow('SELECT avatar, avatar_thumb FROM '.prefixTable('users').' WHERE id=%i', $_SESSION['user_id']);
450
+    fileDelete($targetDir.DIRECTORY_SEPARATOR.$data['avatar'], $SETTINGS);
451
+    fileDelete($targetDir.DIRECTORY_SEPARATOR.$data['avatar_thumb'], $SETTINGS);
452 452
 
453 453
     // store in DB the new avatar
454 454
     DB::query(
455
-        'UPDATE ' . prefixTable('users') . "
456
-        SET avatar='" . $newFileName . '.' . $ext . "', avatar_thumb='" . $newFileName . '_thumb' . '.' . $ext . "'
455
+        'UPDATE '.prefixTable('users')."
456
+        SET avatar='" . $newFileName.'.'.$ext."', avatar_thumb='".$newFileName.'_thumb'.'.'.$ext."'
457 457
         WHERE id=%i",
458 458
         $_SESSION['user_id']
459 459
     );
460 460
 
461 461
     // store in session
462
-    $_SESSION['user_avatar'] = $newFileName . '.' . $ext;
463
-    $_SESSION['user_avatar_thumb'] = $newFileName . '_thumb' . '.' . $ext;
462
+    $_SESSION['user_avatar'] = $newFileName.'.'.$ext;
463
+    $_SESSION['user_avatar_thumb'] = $newFileName.'_thumb'.'.'.$ext;
464 464
 
465 465
     // return info
466 466
     echo prepareExchangedData(
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
 ) {
480 480
     rename(
481 481
         $filePath,
482
-        $targetDir . DIRECTORY_SEPARATOR . $newFileName
482
+        $targetDir.DIRECTORY_SEPARATOR.$newFileName
483 483
     );
484 484
 
485 485
     // Add in DB
Please login to merge, or discard this patch.
sources/import.queries.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
             $config->setIgnoreHeaderLine('true');
166 166
             // extract data from CSV file
167 167
             $interpreter = new Interpreter();
168
-            $interpreter->addObserver(function (array $row) use (&$valuesToImport) {
168
+            $interpreter->addObserver(function(array $row) use (&$valuesToImport) {
169 169
                 $valuesToImport[] = array(
170 170
                     'Label' => $row[0],
171 171
                     'Login' => $row[1],
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
 
463 463
         // Decrypt and retreive data in JSON format
464 464
         $receivedParameters = prepareExchangedData(
465
-            $SETTINGS['cpassman_dir'],$post_data,
465
+            $SETTINGS['cpassman_dir'], $post_data,
466 466
             'decode'
467 467
         );
468 468
         $post_operation_id = filter_var($receivedParameters['file'], FILTER_SANITIZE_STRING);
@@ -512,10 +512,10 @@  discard block
 block discarded – undo
512 512
         {
513 513
             // Manage entries
514 514
             if (isset($array['Entry']) === true) {
515
-                foreach($array['Entry'] as $key => $value) {
515
+                foreach ($array['Entry'] as $key => $value) {
516 516
                     if (isset($value['String']) === true) {
517 517
                         $itemDefinition = [];
518
-                        for($i = 0; $i < count($value['String']); ++$i) {
518
+                        for ($i = 0; $i < count($value['String']); ++$i) {
519 519
                             $itemDefinition[$value['String'][$i]['Key']] = is_array($value['String'][$i]['Value']) === false ? $value['String'][$i]['Value'] : '';
520 520
                         }
521 521
                         $itemDefinition['parentFolderId'] = $previousFolder;
@@ -545,12 +545,12 @@  discard block
 block discarded – undo
545 545
             // Manage GROUPS
546 546
             if (isset($array['Group']) === true) {
547 547
                 $currentFolderId = $previousFolder;
548
-                if (is_array($array['Group'])=== true) {
548
+                if (is_array($array['Group']) === true) {
549 549
                     if (isset($array['Group']['UUID']) === true) {
550 550
                         // build expect array format
551 551
                         $array['Group'] = [$array['Group']];
552 552
                     }
553
-                    foreach($array['Group'] as $key => $value){
553
+                    foreach ($array['Group'] as $key => $value) {
554 554
                         // Add this new folder
555 555
                         array_push(
556 556
                             $newItemsToAdd['folders'],
@@ -626,7 +626,7 @@  discard block
 block discarded – undo
626 626
 
627 627
         // Decrypt and retreive data in JSON format
628 628
         $receivedParameters = prepareExchangedData(
629
-            $SETTINGS['cpassman_dir'],$post_data,
629
+            $SETTINGS['cpassman_dir'], $post_data,
630 630
             'decode'
631 631
         );
632 632
 
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
         ];
648 648
         $startPathLevel = 1;
649 649
 
650
-        foreach($post_folders as $folder) {
650
+        foreach ($post_folders as $folder) {
651 651
             // get parent id
652 652
             $parentId = $arrFolders[$folder['parentFolderId']];
653 653
 
@@ -700,7 +700,7 @@  discard block
 block discarded – undo
700 700
 
701 701
         // Decrypt and retreive data in JSON format
702 702
         $receivedParameters = prepareExchangedData(
703
-            $SETTINGS['cpassman_dir'],$post_data,
703
+            $SETTINGS['cpassman_dir'], $post_data,
704 704
             'decode'
705 705
         );
706 706
 
@@ -716,7 +716,7 @@  discard block
 block discarded – undo
716 716
         );
717 717
         $ret = '';
718 718
 
719
-        foreach($post_items as $item) {
719
+        foreach ($post_items as $item) {
720 720
             // get info about this folder
721 721
             $destinationFolderMore = DB::queryFirstRow(
722 722
                 'SELECT title FROM '.prefixTable('nested_tree').' WHERE id = %i',
@@ -941,7 +941,7 @@  discard block
 block discarded – undo
941 941
     ];
942 942
 }
943 943
 
944
-spl_autoload_register(function ($class) {
944
+spl_autoload_register(function($class) {
945 945
     $prefix = 'League\\Csv\\';
946 946
     $base_dir = __DIR__.'/src/';
947 947
     $len = strlen($prefix);
Please login to merge, or discard this patch.