nikhil-pandey / guitar-shop

app/Http/Controllers/API/GuitarController.php

Unused Use Statements -3 removed lines

@@ -4,9 +4,6 @@
 
 use App\Guitar;
 use App\Transformers\GuitarTransformer;
-use Illuminate\Http\Request;
-
-use App\Http\Requests;
 use App\Http\Controllers\Controller;
 
 class GuitarController extends Controller

app/Http/Controllers/GuitarController.php

Spacing +10 added lines, -10 removed lines

@@ -41,14 +41,14 @@ 
     public function store($id, Request $request)
     {
         $purchase = Purchase::findOrFail($id);
-        if ( ! $purchase->hasArrived() || ! $purchase->isPendingStorage()) {
-            return response(['purchase' => ['The purchase has not yet arrived or doesn\'t require addition of guitars.']],
+        if (!$purchase->hasArrived() || !$purchase->isPendingStorage()) {
+            return response([ 'purchase' => [ 'The purchase has not yet arrived or doesn\'t require addition of guitars.' ] ],
                 422);
         }
 
         $this->validate($request, [
-            'rack_id'   => 'required|exists:racks,id,make_id,' . $purchase->make_id,
-            'model_id'  => 'required|exists:models,id,make_id,' . $purchase->make_id,
+            'rack_id'   => 'required|exists:racks,id,make_id,'.$purchase->make_id,
+            'model_id'  => 'required|exists:models,id,make_id,'.$purchase->make_id,
             'colour'    => 'required|string|max:255',
             'damaged'   => 'boolean',
             'condition' => 'required_if:damaged,true',
@@ -57,10 +57,10 @@ 
 
         $rack = Rack::find($request->input('rack_id'));
         if ($rack->used >= $rack->capacity) {
-            return response(['rack_id' => ['The selected rack is full.']], 422);
+            return response([ 'rack_id' => [ 'The selected rack is full.' ] ], 422);
         }
 
-        $guitar = Guitar::create($request->only(['rack_id', 'model_id', 'colour', 'price']) + [
+        $guitar = Guitar::create($request->only([ 'rack_id', 'model_id', 'colour', 'price' ]) + [
                 'make_id'     => $purchase->make_id,
                 'purchase_id' => $purchase->id,
                 'damaged'     => $request->input('damaged'),
@@ -82,8 +82,8 @@ 
     {
         $guitar = Guitar::findOrFail($id);
         $this->validate($request, [
-            'rack_id'   => 'required|exists:racks,id,make_id,' . $guitar->make_id,
-            'model_id'  => 'required|exists:models,id,make_id,' . $guitar->make_id,
+            'rack_id'   => 'required|exists:racks,id,make_id,'.$guitar->make_id,
+            'model_id'  => 'required|exists:models,id,make_id,'.$guitar->make_id,
             'colour'    => 'required|string|max:255',
             'damaged'   => 'boolean',
             'condition' => 'required_if:damaged,true',
@@ -92,10 +92,10 @@ 
 
         $rack = Rack::find($request->input('rack_id'));
         if ($rack->used >= $rack->capacity) {
-            return response(['rack_id' => ['The selected rack is full.']], 422);
+            return response([ 'rack_id' => [ 'The selected rack is full.' ] ], 422);
         }
 
-        $guitar = $guitar->update($request->only(['rack_id', 'model_id', 'colour', 'price']) + [
+        $guitar = $guitar->update($request->only([ 'rack_id', 'model_id', 'colour', 'price' ]) + [
                 'damaged'   => $request->input('damaged'),
                 'condition' => $request->input('damaged') ? $request->input('condition') : null
             ]);

app/Http/routes.php

Spacing +8 added lines, -8 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 
-Route::group(['middleware' => 'web'], function ($router) {
-    $router->get('/', function () {
+Route::group([ 'middleware' => 'web' ], function($router) {
+    $router->get('/', function() {
         return redirect('/dashboard');
     });
 
@@ -35,11 +35,11 @@ 
     $router->put('api/notifications/{id}/dismiss', 'API\NotificationController@dismiss');
     $router->get('api/users/me', 'API\UserController@getCurrentUser');
 
-    $router->resource('makes', 'MakeController', ['except' => ['create', 'show', 'edit', 'update']]);
-    $router->resource('models', 'ModelController', ['except' => ['create', 'show', 'edit', 'update']]);
-    $router->resource('purchases', 'PurchaseController', ['except' => ['create', 'edit', 'update']]);
+    $router->resource('makes', 'MakeController', [ 'except' => [ 'create', 'show', 'edit', 'update' ] ]);
+    $router->resource('models', 'ModelController', [ 'except' => [ 'create', 'show', 'edit', 'update' ] ]);
+    $router->resource('purchases', 'PurchaseController', [ 'except' => [ 'create', 'edit', 'update' ] ]);
     $router->post('purchases/{id}/guitars', 'GuitarController@store');
-    $router->resource('suppliers', 'SupplierController', ['except' => ['create', 'show', 'edit', 'update']]);
-    $router->resource('warehouses', 'WarehouseController', ['except' => ['create', 'show', 'edit']]);
-    $router->resource('guitars', 'GuitarController', ['only' => ['index', 'update', 'delete']]);
+    $router->resource('suppliers', 'SupplierController', [ 'except' => [ 'create', 'show', 'edit', 'update' ] ]);
+    $router->resource('warehouses', 'WarehouseController', [ 'except' => [ 'create', 'show', 'edit' ] ]);
+    $router->resource('guitars', 'GuitarController', [ 'only' => [ 'index', 'update', 'delete' ] ]);
 });