CRUD::insert() - Code Metrics - Inspection of "create/request method" - nicollassilva/SimplePHP - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 268116...cc8508 )

by Nícollas

created 2020-07-21 17:27 UTC

CRUD::insert() A

↳ Parent: CRUD

Complexity

Conditions	4
Paths	9

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	13
c	1
b	0
f	0
nc	9
nop	2
dl	0
loc	17
rs	9.8333

<?php

namespace SimplePHP\Model;

use PDOException;

/**
 * Trait CRUD to SimplePHP
 * @package NicollasSilva\SimplePHP
 */
trait CRUD {

    /**
     * @param int $primary
     * @return bool
     */
    public function delete(int $primary): ?bool
    {
        try {
            $sql = $this->conn->prepare("DELETE FROM {$this->table} WHERE {$this->primary} = :primary");
            $sql->bindParam(':primary', $primary);
            return $sql->execute();
        } catch (PDOException $exception) {
            return null;
        }
    }

    /**
     * @param string $params
     * @param array $values
     * @param int $primary
     * @return PDOException|bool
     */
    public function update(String $params, Array $values, Int $primary)
    {
        try {
        $params = explode(',', $params);
        $data = [];
        $countParams = count($params);
        for ($i = 0; $i < $countParams; $i++) {
            $data[$i] = ":" . $params[$i] . $i . ", ";
        }
        $result = '';
        $final = array_map(null, $params, $data);
        foreach ($final as $key => $vals) {
            foreach ($vals as $chave => $val) {
                $result .= str_replace(':', ' = :', $val);
            }
        }
        $result = rtrim($result, ', ');
        $sql = $this->conn->prepare("UPDATE {$this->table} SET {$result} WHERE {$this->primary} = '{$primary}'");
        for ($i = 0; $i < $countParams; $i++) {
            $data[$i] = ":" . $params[$i] . $i;
        }
        $countData = count($data);
        for ($i = 0; $i < $countData; $i++) {
            $sql->bindParam($data[$i], $values[$i]);
        }
        return $sql->execute();
        } catch(PDOException $exception) {
            echo $exception->getMessage();
        }
    }

    /**
     * @param string $params
     * @param array $values
     * @return PDOException|bool
     */
    public function insert(String $params, Array $values)
    {
        try {
            $parameters = "(".$params.")";
            $params = explode(',', $params);
            $data = [];
                for($i = 0; $i < count($params); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                    $data[$i] = ":". $params[$i] . $i;
                }
            $valueBind = "(".implode(', ', $data).")";
            $sql = $this->conn->prepare("INSERT INTO {$this->table} $parameters VALUES $valueBind");
                for($i = 0; $i < count($params); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                    $sql->bindParam($data[$i], $values[$i]);
                }
            return $sql->execute();
        } catch(PDOException $exception) {
            echo $exception->getCode();
        }
    }
}


1			<?php
2
3			namespace SimplePHP\Model;
4
5			use PDOException;
6
7			/**
8			* Trait CRUD to SimplePHP
9			* @package NicollasSilva\SimplePHP
10			*/
11			trait CRUD {
12
13			/**
14			* @param int $primary
15			* @return bool
16			*/
17			public function delete(int $primary): ?bool
18			{
19			try {
20			$sql = $this->conn->prepare("DELETE FROM {$this->table} WHERE {$this->primary} = :primary");
21			$sql->bindParam(':primary', $primary);
22			return $sql->execute();
23			} catch (PDOException $exception) {
24			return null;
25			}
26			}
27
28			/**
29			* @param string $params
30			* @param array $values
31			* @param int $primary
32			* @return PDOException\|bool
33			*/
34			public function update(String $params, Array $values, Int $primary)
35			{
36			try {
37			$params = explode(',', $params);
38			$data = [];
39			$countParams = count($params);
40			for ($i = 0; $i < $countParams; $i++) {
41			$data[$i] = ":" . $params[$i] . $i . ", ";
42			}
43			$result = '';
44			$final = array_map(null, $params, $data);
45			foreach ($final as $key => $vals) {
46			foreach ($vals as $chave => $val) {
47			$result .= str_replace(':', ' = :', $val);
48			}
49			}
50			$result = rtrim($result, ', ');
51			$sql = $this->conn->prepare("UPDATE {$this->table} SET {$result} WHERE {$this->primary} = '{$primary}'");
52			for ($i = 0; $i < $countParams; $i++) {
53			$data[$i] = ":" . $params[$i] . $i;
54			}
55			$countData = count($data);
56			for ($i = 0; $i < $countData; $i++) {
57			$sql->bindParam($data[$i], $values[$i]);
58			}
59			return $sql->execute();
60			} catch(PDOException $exception) {
61			echo $exception->getMessage();
62			}
63			}
64
65			/**
66			* @param string $params
67			* @param array $values
68			* @return PDOException\|bool
69			*/
70			public function insert(String $params, Array $values)
71			{
72			try {
73			$parameters = "(".$params.")";
74			$params = explode(',', $params);
75			$data = [];
76			for($i = 0; $i < count($params); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2020-07-19 22:47 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
77			$data[$i] = ":". $params[$i] . $i;
78			}
79			$valueBind = "(".implode(', ', $data).")";
80			$sql = $this->conn->prepare("INSERT INTO {$this->table} $parameters VALUES $valueBind");
81			for($i = 0; $i < count($params); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2020-07-19 22:47 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
82			$sql->bindParam($data[$i], $values[$i]);
83			}
84			return $sql->execute();
85			} catch(PDOException $exception) {
86			echo $exception->getCode();
87			}
88			}
89			}
90

nicollassilva / SimplePHP

Push — master ( 268116...cc8508 )

CRUD::insert() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like