SimplePHP\Model\CRUD

Complexity

Total Complexity

13

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	8	2
B	update()	0	28	7
A	insert()	0	17	4

<?php

namespace SimplePHP\Model;

use PDOException;

/**
 * Trait CRUD to SimplePHP
 * @package NicollasSilva\SimplePHP
 */
trait CRUD {

    /**
     * @param int $primary
     * @return bool
     */
    public function delete(int $primary): ?bool
    {
        try {
            $sql = $this->conn->prepare("DELETE FROM {$this->table} WHERE {$this->primary} = :primary");
            $sql->bindParam(':primary', $primary);
            return $sql->execute();
        } catch (PDOException $exception) {
            return null;
        }
    }

    /**
     * @param string $params
     * @param array $values
     * @param int $primary
     * @return PDOException|bool
     */
    public function update(String $params, Array $values, Int $primary)
    {
        try {
        $params = explode(',', $params);
        $data = [];
        $countParams = count($params);
        for ($i = 0; $i < $countParams; $i++) {
            $data[$i] = ":" . $params[$i] . $i . ", ";
        }
        $result = '';
        $final = array_map(null, $params, $data);
        foreach ($final as $key => $vals) {
            foreach ($vals as $chave => $val) {
                $result .= str_replace(':', ' = :', $val);
            }
        }
        $result = rtrim($result, ', ');
        $sql = $this->conn->prepare("UPDATE {$this->table} SET {$result} WHERE {$this->primary} = '{$primary}'");
        for ($i = 0; $i < $countParams; $i++) {
            $data[$i] = ":" . $params[$i] . $i;
        }
        $countData = count($data);
        for ($i = 0; $i < $countData; $i++) {
            $sql->bindParam($data[$i], $values[$i]);
        }
        return $sql->execute();
        } catch(PDOException $exception) {
            echo $exception->getMessage();
        }
    }

    /**
     * @param string $params
     * @param array $values
     * @return PDOException|bool
     */
    public function insert(String $params, Array $values)
    {
        try {
            $parameters = "(".$params.")";
            $params = explode(',', $params);
            $data = [];
                for($i = 0; $i < count($params); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                    $data[$i] = ":". $params[$i] . $i;
                }
            $valueBind = "(".implode(', ', $data).")";
            $sql = $this->conn->prepare("INSERT INTO {$this->table} $parameters VALUES $valueBind");
                for($i = 0; $i < count($params); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                    $sql->bindParam($data[$i], $values[$i]);
                }
            return $sql->execute();
        } catch(PDOException $exception) {
            echo $exception->getCode();
        }
    }
}