Inspection of "added Vehicle Services" - nickcheek/AtdConnect - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (344029)

by Nicholas

created 2019-02-11 18:06 UTC

Status

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

@@ -3,80 +3,80 @@
 block discarded – undo
 namespace Nickcheek\Atdconnect\Services;
 
 class Vehicle {
-	use \Nickcheek\Atdconnect\Traits\ApiTrait;
+        use \Nickcheek\Atdconnect\Traits\ApiTrait;
 	
-	private $location;
-	private $wsdl;
+        private $location;
+        private $wsdl;
 	
-	private $vehicle = array();
+        private $vehicle = array();
 	
-	public $vehicleYear;
-	public $vehicleMake;
-	public $vehicleModel;
+        public $vehicleYear;
+        public $vehicleMake;
+        public $vehicleModel;
 
-	public function __construct()
-	{
-	    $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
-	    $this->location = $config->location;
-		$this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
+        public function __construct()
+        {
+                $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
+                $this->location = $config->location;
+                $this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
 		
-	}
+        }
 	
-	//************************************************
-    //               Vehicle Service
-    //************************************************
+        //************************************************
+        //               Vehicle Service
+        //************************************************
     
-    public  function getVehicleYear()
-    {
+        public  function getVehicleYear()
+        {
         return $this->apiCall('getVehicleYear','',$this->wsdl);
-    }
+        }
     
-    public  function getVehicleMake($year)
-    {	
-    	try { if (empty($year)) { throw new \Exception("A Vehicle Year Has Not Been Set."); } 
-    		return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
+        public  function getVehicleMake($year)
+        {	
+                try { if (empty($year)) { throw new \Exception("A Vehicle Year Has Not Been Set."); } 
+                        return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
         } catch (Exception $e) { return $e; }
-    }
+        }
 
-    public  function getVehicleModel($year,$make)
-    {	
+        public  function getVehicleModel($year,$make)
+        {	
     	
-    	try {if (empty($year)||empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set.");}
+                try {if (empty($year)||empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set.");}
     	
-        	return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
+                return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
         
         } catch (Exception $e) {return $e;}
-    }
+        }
 
     
-    public  function getVehicleTrim($year,$make,$model)
-    {
-    	try {if (empty($year)||empty($make)||empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
+        public  function getVehicleTrim($year,$make,$model)
+        {
+                try {if (empty($year)||empty($make)||empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
     	
-        	return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
+                return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
         
         } catch (Exception $e) {return $e;}
-    }
+        }
     
-    public function getVehicleTrimOption($year,$make,$model,$trim)
-    {
-    	try {if (empty($year)||empty($make)||empty($model)||empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
+        public function getVehicleTrimOption($year,$make,$model,$trim)
+        {
+                try {if (empty($year)||empty($make)||empty($model)||empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
     	
-	    	return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+                        return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
 	    	
-	    } catch (Exception $e) {return $e;}
+                } catch (Exception $e) {return $e;}
 	    
-    }
+        }
     
-    public function getVehiclePlusSizes($year,$make,$model,$trim)
-    {
-    	try {if (empty($year)||empty($make)||empty($model)||empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set.");}
+        public function getVehiclePlusSizes($year,$make,$model,$trim)
+        {
+                try {if (empty($year)||empty($make)||empty($model)||empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set.");}
     	
-	    	return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+                        return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
 	    	
-	    } catch (Exception $e) {return $e;}
+                } catch (Exception $e) {return $e;}
 	    
-    }
+        }
     
     
         

Please login to merge, or discard this patch.

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -16,7 +16,7 @@  discard block
 block discarded – undo
 
 	public function __construct()
 	{
-	    $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
+	    $config = include(realpath(dirname(__FILE__).'/../config/config.php'));
 	    $this->location = $config->location;
 		$this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
 		
@@ -28,53 +28,53 @@  discard block
 block discarded – undo
     
     public  function getVehicleYear()
     {
-        return $this->apiCall('getVehicleYear','',$this->wsdl);
+        return $this->apiCall('getVehicleYear', '', $this->wsdl);
     }
     
     public  function getVehicleMake($year)
     {	
     	try { if (empty($year)) { throw new \Exception("A Vehicle Year Has Not Been Set."); } 
-    		return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
+    		return $this->apiCall('getVehicleMake', ['vehicle' => ['year'=>$year]], $this->wsdl);
         } catch (Exception $e) { return $e; }
     }
 
-    public  function getVehicleModel($year,$make)
+    public  function getVehicleModel($year, $make)
     {	
     	
-    	try {if (empty($year)||empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set.");}
+    	try {if (empty($year) || empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set."); }
     	
-        	return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
+        	return $this->apiCall('getVehicleModel', ['vehicle' => ['year'=>$year, 'make'=>$make]], $this->wsdl);
         
-        } catch (Exception $e) {return $e;}
+        } catch (Exception $e) {return $e; }
     }
 
     
-    public  function getVehicleTrim($year,$make,$model)
+    public  function getVehicleTrim($year, $make, $model)
     {
-    	try {if (empty($year)||empty($make)||empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
+    	try {if (empty($year) || empty($make) || empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set."); }
     	
-        	return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
+        	return $this->apiCall('getVehicleTrim', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model]], $this->wsdl);
         
-        } catch (Exception $e) {return $e;}
+        } catch (Exception $e) {return $e; }
     }
     
-    public function getVehicleTrimOption($year,$make,$model,$trim)
+    public function getVehicleTrimOption($year, $make, $model, $trim)
     {
-    	try {if (empty($year)||empty($make)||empty($model)||empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
+    	try {if (empty($year) || empty($make) || empty($model) || empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set."); }
     	
-	    	return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+	    	return $this->apiCall('getVehicleTrimOption', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
 	    	
-	    } catch (Exception $e) {return $e;}
+	    } catch (Exception $e) {return $e; }
 	    
     }
     
-    public function getVehiclePlusSizes($year,$make,$model,$trim)
+    public function getVehiclePlusSizes($year, $make, $model, $trim)
     {
-    	try {if (empty($year)||empty($make)||empty($model)||empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set.");}
+    	try {if (empty($year) || empty($make) || empty($model) || empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set."); }
     	
-	    	return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+	    	return $this->apiCall('getVehiclePlusSizes', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
 	    	
-	    } catch (Exception $e) {return $e;}
+	    } catch (Exception $e) {return $e; }
 	    
     }
     

Please login to merge, or discard this patch.

		@@ -16,7 +16,7 @@ discard block
		block discarded – undo
16	16
17	17	public function __construct()
18	18	{
19		- $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
	19	+ $config = include(realpath(dirname(__FILE__).'/../config/config.php'));
20	20	$this->location = $config->location;
21	21	$this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
22	22
		@@ -28,53 +28,53 @@ discard block
		block discarded – undo
28	28
29	29	public function getVehicleYear()
30	30	{
31		- return $this->apiCall('getVehicleYear','',$this->wsdl);
	31	+ return $this->apiCall('getVehicleYear', '', $this->wsdl);
32	32	}
33	33
34	34	public function getVehicleMake($year)
35	35	{
36	36	try { if (empty($year)) { throw new \Exception("A Vehicle Year Has Not Been Set."); }
37		- return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
	37	+ return $this->apiCall('getVehicleMake', ['vehicle' => ['year'=>$year]], $this->wsdl);
38	38	} catch (Exception $e) { return $e; }
39	39	}
40	40
41		- public function getVehicleModel($year,$make)
	41	+ public function getVehicleModel($year, $make)
42	42	{
43	43
44		- try {if (empty($year)\|\|empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set.");}
	44	+ try {if (empty($year) \|\| empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set."); }
45	45
46		- return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
	46	+ return $this->apiCall('getVehicleModel', ['vehicle' => ['year'=>$year, 'make'=>$make]], $this->wsdl);
47	47
48		- } catch (Exception $e) {return $e;}
	48	+ } catch (Exception $e) {return $e; }
49	49	}
50	50
51	51
52		- public function getVehicleTrim($year,$make,$model)
	52	+ public function getVehicleTrim($year, $make, $model)
53	53	{
54		- try {if (empty($year)\|\|empty($make)\|\|empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
	54	+ try {if (empty($year) \|\| empty($make) \|\| empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set."); }
55	55
56		- return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
	56	+ return $this->apiCall('getVehicleTrim', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model]], $this->wsdl);
57	57
58		- } catch (Exception $e) {return $e;}
	58	+ } catch (Exception $e) {return $e; }
59	59	}
60	60
61		- public function getVehicleTrimOption($year,$make,$model,$trim)
	61	+ public function getVehicleTrimOption($year, $make, $model, $trim)
62	62	{
63		- try {if (empty($year)\|\|empty($make)\|\|empty($model)\|\|empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
	63	+ try {if (empty($year) \|\| empty($make) \|\| empty($model) \|\| empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set."); }
64	64
65		- return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	65	+ return $this->apiCall('getVehicleTrimOption', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
66	66
67		- } catch (Exception $e) {return $e;}
	67	+ } catch (Exception $e) {return $e; }
68	68
69	69	}
70	70
71		- public function getVehiclePlusSizes($year,$make,$model,$trim)
	71	+ public function getVehiclePlusSizes($year, $make, $model, $trim)
72	72	{
73		- try {if (empty($year)\|\|empty($make)\|\|empty($model)\|\|empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set.");}
	73	+ try {if (empty($year) \|\| empty($make) \|\| empty($model) \|\| empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set."); }
74	74
75		- return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	75	+ return $this->apiCall('getVehiclePlusSizes', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
76	76
77		- } catch (Exception $e) {return $e;}
	77	+ } catch (Exception $e) {return $e; }
78	78
79	79	}
80	80

		@@ -3,80 +3,80 @@
		block discarded – undo
3	3	namespace Nickcheek\Atdconnect\Services;
4	4
5	5	class Vehicle {
6		- use \Nickcheek\Atdconnect\Traits\ApiTrait;
	6	+ use \Nickcheek\Atdconnect\Traits\ApiTrait;
7	7
8		- private $location;
9		- private $wsdl;
	8	+ private $location;
	9	+ private $wsdl;
10	10
11		- private $vehicle = array();
	11	+ private $vehicle = array();
12	12
13		- public $vehicleYear;
14		- public $vehicleMake;
15		- public $vehicleModel;
	13	+ public $vehicleYear;
	14	+ public $vehicleMake;
	15	+ public $vehicleModel;
16	16
17		- public function __construct()
18		- {
19		- $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
20		- $this->location = $config->location;
21		- $this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
	17	+ public function __construct()
	18	+ {
	19	+ $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
	20	+ $this->location = $config->location;
	21	+ $this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
22	22
23		- }
	23	+ }
24	24
25		- //************************************************
26		- // Vehicle Service
27		- //************************************************
	25	+ //************************************************
	26	+ // Vehicle Service
	27	+ //************************************************
28	28
29		- public function getVehicleYear()
30		- {
	29	+ public function getVehicleYear()
	30	+ {
31	31	return $this->apiCall('getVehicleYear','',$this->wsdl);
32		- }
	32	+ }
33	33
34		- public function getVehicleMake($year)
35		- {
36		- try { if (empty($year)) { throw new \Exception("A Vehicle Year Has Not Been Set."); }
37		- return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
	34	+ public function getVehicleMake($year)
	35	+ {
	36	+ try { if (empty($year)) { throw new \Exception("A Vehicle Year Has Not Been Set."); }
	37	+ return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
38	38	} catch (Exception $e) { return $e; }
39		- }
	39	+ }
40	40
41		- public function getVehicleModel($year,$make)
42		- {
	41	+ public function getVehicleModel($year,$make)
	42	+ {
43	43
44		- try {if (empty($year)\|\|empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set.");}
	44	+ try {if (empty($year)\|\|empty($make)) {throw new \Exception("A Vehicle Year OR Make Has Not Been Set.");}
45	45
46		- return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
	46	+ return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
47	47
48	48	} catch (Exception $e) {return $e;}
49		- }
	49	+ }
50	50
51	51
52		- public function getVehicleTrim($year,$make,$model)
53		- {
54		- try {if (empty($year)\|\|empty($make)\|\|empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
	52	+ public function getVehicleTrim($year,$make,$model)
	53	+ {
	54	+ try {if (empty($year)\|\|empty($make)\|\|empty($model)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
55	55
56		- return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
	56	+ return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
57	57
58	58	} catch (Exception $e) {return $e;}
59		- }
	59	+ }
60	60
61		- public function getVehicleTrimOption($year,$make,$model,$trim)
62		- {
63		- try {if (empty($year)\|\|empty($make)\|\|empty($model)\|\|empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
	61	+ public function getVehicleTrimOption($year,$make,$model,$trim)
	62	+ {
	63	+ try {if (empty($year)\|\|empty($make)\|\|empty($model)\|\|empty($trim)) {throw new \Exception("A Vehicle Year, Make OR Model Has Not Been Set.");}
64	64
65		- return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	65	+ return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
66	66
67		- } catch (Exception $e) {return $e;}
	67	+ } catch (Exception $e) {return $e;}
68	68
69		- }
	69	+ }
70	70
71		- public function getVehiclePlusSizes($year,$make,$model,$trim)
72		- {
73		- try {if (empty($year)\|\|empty($make)\|\|empty($model)\|\|empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set.");}
	71	+ public function getVehiclePlusSizes($year,$make,$model,$trim)
	72	+ {
	73	+ try {if (empty($year)\|\|empty($make)\|\|empty($model)\|\|empty($trim)) {throw new \Exception("A Vehicle Year, Make, Model, or Trim Has Not Been Set.");}
74	74
75		- return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	75	+ return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
76	76
77		- } catch (Exception $e) {return $e;}
	77	+ } catch (Exception $e) {return $e;}
78	78
79		- }
	79	+ }
80	80
81	81
82	82

nickcheek / AtdConnect

Branch — master (344029)

Status

Category

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch