Inspection of "Fixed Spacing" - nickcheek/AtdConnect - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 026c65...8e7f14 )

by Nicholas

created 2019-02-06 16:07 UTC

Status

Indentation +69 added lines, -69 removed lines patch added patch discarded remove patch

@@ -7,19 +7,19 @@  discard block
 block discarded – undo
 class Atdconnect
 {
     
-    public static $wsshead;
+        public static $wsshead;
     
-    private static $brandwsdl = 'https://testws.atdconnect.com/ws/3_4/brandstyles.wsdl';
-    private static $locationwsdl = 'https://testws.atdconnect.com/ws/3_4/locations.wsdl';
-    private static $productwsdl = 'https://testws.atdconnect.com/ws/3_4/products.wsdl';
+        private static $brandwsdl = 'https://testws.atdconnect.com/ws/3_4/brandstyles.wsdl';
+        private static $locationwsdl = 'https://testws.atdconnect.com/ws/3_4/locations.wsdl';
+        private static $productwsdl = 'https://testws.atdconnect.com/ws/3_4/products.wsdl';
     
-    public function __construct($user, $pass, $client)
-    {
+        public function __construct($user, $pass, $client)
+        {
         self::$wsshead = $this->getWSSHeader($user, $pass, $client);
-    }
+        }
     
-    public static function getWSSHeader($user, $pass, $client)
-    {
+        public static function getWSSHeader($user, $pass, $client)
+        {
         $xml = '
 		<wsse:Security SOAP-ENV:mustUnderstand="1" xmlns:wsse="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd">
 		    <wsse:UsernameToken atd:clientId="' . $client . '" xmlns:atd="http://api.atdconnect.com/atd">
@@ -30,133 +30,133 @@  discard block
 block discarded – undo
 		';
         
         return new \SoapHeader('http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd', 'Security', new \SoapVar($xml, XSD_ANYXML), true);
-    }
+        }
     
     
     
-    //************************************************
-    //               Location Service
-    //************************************************
+        //************************************************
+        //               Location Service
+        //************************************************
     
-    public static function getLocationByCriteria()
-    {
+        public static function getLocationByCriteria()
+        {
         
         $client = new \SoapClient(self::$locationwsdl);
         $client->__setSoapHeaders(self::$wsshead);
         $response = $client->getLocationByCriteria();
         
         return $response;
-    }
+        }
     
-    public static function getLocationCutoffTimes($location = '1213421')
-    {
+        public static function getLocationCutoffTimes($location = '1213421')
+        {
         
         $client = new \SoapClient(self::$locationwsdl);
         $client->__setSoapHeaders(self::$wsshead);
         $response = $client->getLocationCutoffTimes(array(
-            'location' => $location
+                'location' => $location
         ));
         
         return $response;
-    }
+        }
     
-    public static function getDistributionCenter($dc = '059')
-    {
+        public static function getDistributionCenter($dc = '059')
+        {
         $client = new \SoapClient(self::$locationwsdl);
         $client->__setSoapHeaders(self::$wsshead);
         $response = $client->getDistributionCenter(array(
-            'servicingDC' => $dc
+                'servicingDC' => $dc
         ));
         
         return $response;
-    }
+        }
     
-    //************************************************
-    //               Brand Styles Service
-    //************************************************
+        //************************************************
+        //               Brand Styles Service
+        //************************************************
     
     
-    public static function getBrand($location, $product = null)
-    {
+        public static function getBrand($location, $product = null)
+        {
         $client = new \SoapClient(self::$brandwsdl);
         $client->__setSoapHeaders(self::$wsshead);
         $response = $client->getBrand(array(
-            'locationNumber' => $location,
-            'productGroup' => $product
+                'locationNumber' => $location,
+                'productGroup' => $product
         ));
         
         return $response;
-    }
+        }
     
-    public static function getStyle($location, $brand = null)
-    {
+        public static function getStyle($location, $brand = null)
+        {
         $client = new \SoapClient(self::$brandwsdl);
         $client->__setSoapHeaders(self::$wsshead);
         $response = $client->getBrand(array(
-            'locationNumber' => $location,
-            'brand' => $brand
+                'locationNumber' => $location,
+                'brand' => $brand
         ));
         
         return $response;
-    }
+        }
     
     
-    //************************************************
-    //               Products Service
-    //************************************************
+        //************************************************
+        //               Products Service
+        //************************************************
     
     
     
     
-    public static function getProdBrand($location, $product = null)
-    {
+        public static function getProdBrand($location, $product = null)
+        {
         $client = new \SoapClient(self::$productwsdl);
         $client->__setSoapHeaders(self::$wsshead);
         $response = $client->getBrand(array(
-            'locationNumber' => $location,
-            'productGroup' => $product
+                'locationNumber' => $location,
+                'productGroup' => $product
         ));
         
         return $response;
-    }
+        }
     
-    public static function getProductByCriteria()
-    {
+        public static function getProductByCriteria()
+        {
         
-    }
+        }
     
-    public static function getProductByKeyword()
-    {
+        public static function getProductByKeyword()
+        {
         
-    }
+        }
     
-    //************************************************
-    //               Order Service
-    //************************************************
+        //************************************************
+        //               Order Service
+        //************************************************
     
-    public static function placeOrder()
-    {
+        public static function placeOrder()
+        {
         
-    }
+        }
     
-    public static function previewOrder()
-    {
+        public static function previewOrder()
+        {
         
-    }
+        }
     
-    //************************************************
-    //               Order Status Service
-    //************************************************
+        //************************************************
+        //               Order Status Service
+        //************************************************
     
-    public static function getOrderDetail()
-    {
+        public static function getOrderDetail()
+        {
         
-    }
+        }
     
-    public static function getOrderStatusByCriteria()
-    {
+        public static function getOrderStatusByCriteria()
+        {
         
-    }
+        }
     
     
     

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,9 +22,9 @@
 block discarded – undo
     {
         $xml = '
 		<wsse:Security SOAP-ENV:mustUnderstand="1" xmlns:wsse="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd">
-		    <wsse:UsernameToken atd:clientId="' . $client . '" xmlns:atd="http://api.atdconnect.com/atd">
-		        <wsse:Username>' . $user . '</wsse:Username>
-		        <wsse:Password Type="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-username-token-profile-1.0#PasswordText">' . $pass . '</wsse:Password>
+		    <wsse:UsernameToken atd:clientId="' . $client.'" xmlns:atd="http://api.atdconnect.com/atd">
+		        <wsse:Username>' . $user.'</wsse:Username>
+		        <wsse:Password Type="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-username-token-profile-1.0#PasswordText">' . $pass.'</wsse:Password>
 		    </wsse:UsernameToken>
 		</wsse:Security>
 		';

Please login to merge, or discard this patch.

		@@ -7,19 +7,19 @@ discard block
		block discarded – undo
7	7	class Atdconnect
8	8	{
9	9
10		- public static $wsshead;
	10	+ public static $wsshead;
11	11
12		- private static $brandwsdl = 'https://testws.atdconnect.com/ws/3_4/brandstyles.wsdl';
13		- private static $locationwsdl = 'https://testws.atdconnect.com/ws/3_4/locations.wsdl';
14		- private static $productwsdl = 'https://testws.atdconnect.com/ws/3_4/products.wsdl';
	12	+ private static $brandwsdl = 'https://testws.atdconnect.com/ws/3_4/brandstyles.wsdl';
	13	+ private static $locationwsdl = 'https://testws.atdconnect.com/ws/3_4/locations.wsdl';
	14	+ private static $productwsdl = 'https://testws.atdconnect.com/ws/3_4/products.wsdl';
15	15
16		- public function __construct($user, $pass, $client)
17		- {
	16	+ public function __construct($user, $pass, $client)
	17	+ {
18	18	self::$wsshead = $this->getWSSHeader($user, $pass, $client);
19		- }
	19	+ }
20	20
21		- public static function getWSSHeader($user, $pass, $client)
22		- {
	21	+ public static function getWSSHeader($user, $pass, $client)
	22	+ {
23	23	$xml = '
24	24	<wsse:Security SOAP-ENV:mustUnderstand="1" xmlns:wsse="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd">
25	25	<wsse:UsernameToken atd:clientId="' . $client . '" xmlns:atd="http://api.atdconnect.com/atd">
		@@ -30,133 +30,133 @@ discard block
		block discarded – undo
30	30	';
31	31
32	32	return new \SoapHeader('http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd', 'Security', new \SoapVar($xml, XSD_ANYXML), true);
33		- }
	33	+ }
34	34
35	35
36	36
37		- //************************************************
38		- // Location Service
39		- //************************************************
	37	+ //************************************************
	38	+ // Location Service
	39	+ //************************************************
40	40
41		- public static function getLocationByCriteria()
42		- {
	41	+ public static function getLocationByCriteria()
	42	+ {
43	43
44	44	$client = new \SoapClient(self::$locationwsdl);
45	45	$client->__setSoapHeaders(self::$wsshead);
46	46	$response = $client->getLocationByCriteria();
47	47
48	48	return $response;
49		- }
	49	+ }
50	50
51		- public static function getLocationCutoffTimes($location = '1213421')
52		- {
	51	+ public static function getLocationCutoffTimes($location = '1213421')
	52	+ {
53	53
54	54	$client = new \SoapClient(self::$locationwsdl);
55	55	$client->__setSoapHeaders(self::$wsshead);
56	56	$response = $client->getLocationCutoffTimes(array(
57		- 'location' => $location
	57	+ 'location' => $location
58	58	));
59	59
60	60	return $response;
61		- }
	61	+ }
62	62
63		- public static function getDistributionCenter($dc = '059')
64		- {
	63	+ public static function getDistributionCenter($dc = '059')
	64	+ {
65	65	$client = new \SoapClient(self::$locationwsdl);
66	66	$client->__setSoapHeaders(self::$wsshead);
67	67	$response = $client->getDistributionCenter(array(
68		- 'servicingDC' => $dc
	68	+ 'servicingDC' => $dc
69	69	));
70	70
71	71	return $response;
72		- }
	72	+ }
73	73
74		- //************************************************
75		- // Brand Styles Service
76		- //************************************************
	74	+ //************************************************
	75	+ // Brand Styles Service
	76	+ //************************************************
77	77
78	78
79		- public static function getBrand($location, $product = null)
80		- {
	79	+ public static function getBrand($location, $product = null)
	80	+ {
81	81	$client = new \SoapClient(self::$brandwsdl);
82	82	$client->__setSoapHeaders(self::$wsshead);
83	83	$response = $client->getBrand(array(
84		- 'locationNumber' => $location,
85		- 'productGroup' => $product
	84	+ 'locationNumber' => $location,
	85	+ 'productGroup' => $product
86	86	));
87	87
88	88	return $response;
89		- }
	89	+ }
90	90
91		- public static function getStyle($location, $brand = null)
92		- {
	91	+ public static function getStyle($location, $brand = null)
	92	+ {
93	93	$client = new \SoapClient(self::$brandwsdl);
94	94	$client->__setSoapHeaders(self::$wsshead);
95	95	$response = $client->getBrand(array(
96		- 'locationNumber' => $location,
97		- 'brand' => $brand
	96	+ 'locationNumber' => $location,
	97	+ 'brand' => $brand
98	98	));
99	99
100	100	return $response;
101		- }
	101	+ }
102	102
103	103
104		- //************************************************
105		- // Products Service
106		- //************************************************
	104	+ //************************************************
	105	+ // Products Service
	106	+ //************************************************
107	107
108	108
109	109
110	110
111		- public static function getProdBrand($location, $product = null)
112		- {
	111	+ public static function getProdBrand($location, $product = null)
	112	+ {
113	113	$client = new \SoapClient(self::$productwsdl);
114	114	$client->__setSoapHeaders(self::$wsshead);
115	115	$response = $client->getBrand(array(
116		- 'locationNumber' => $location,
117		- 'productGroup' => $product
	116	+ 'locationNumber' => $location,
	117	+ 'productGroup' => $product
118	118	));
119	119
120	120	return $response;
121		- }
	121	+ }
122	122
123		- public static function getProductByCriteria()
124		- {
	123	+ public static function getProductByCriteria()
	124	+ {
125	125
126		- }
	126	+ }
127	127
128		- public static function getProductByKeyword()
129		- {
	128	+ public static function getProductByKeyword()
	129	+ {
130	130
131		- }
	131	+ }
132	132
133		- //************************************************
134		- // Order Service
135		- //************************************************
	133	+ //************************************************
	134	+ // Order Service
	135	+ //************************************************
136	136
137		- public static function placeOrder()
138		- {
	137	+ public static function placeOrder()
	138	+ {
139	139
140		- }
	140	+ }
141	141
142		- public static function previewOrder()
143		- {
	142	+ public static function previewOrder()
	143	+ {
144	144
145		- }
	145	+ }
146	146
147		- //************************************************
148		- // Order Status Service
149		- //************************************************
	147	+ //************************************************
	148	+ // Order Status Service
	149	+ //************************************************
150	150
151		- public static function getOrderDetail()
152		- {
	151	+ public static function getOrderDetail()
	152	+ {
153	153
154		- }
	154	+ }
155	155
156		- public static function getOrderStatusByCriteria()
157		- {
	156	+ public static function getOrderStatusByCriteria()
	157	+ {
158	158
159		- }
	159	+ }
160	160
161	161
162	162

		@@ -22,9 +22,9 @@
		block discarded – undo
22	22	{
23	23	$xml = '
24	24	<wsse:Security SOAP-ENV:mustUnderstand="1" xmlns:wsse="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd">
25		- <wsse:UsernameToken atd:clientId="' . $client . '" xmlns:atd="http://api.atdconnect.com/atd">
26		- <wsse:Username>' . $user . '</wsse:Username>
27		- <wsse:Password Type="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-username-token-profile-1.0#PasswordText">' . $pass . '</wsse:Password>
	25	+ <wsse:UsernameToken atd:clientId="' . $client.'" xmlns:atd="http://api.atdconnect.com/atd">
	26	+ <wsse:Username>' . $user.'</wsse:Username>
	27	+ <wsse:Password Type="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-username-token-profile-1.0#PasswordText">' . $pass.'</wsse:Password>
28	28	</wsse:UsernameToken>
29	29	</wsse:Security>
30	30	';

nickcheek / AtdConnect

Push — master ( 026c65...8e7f14 )

Status

Category

Indentation +69 added lines, -69 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch