Inspection of "refactor vehicle class" - nickcheek/AtdConnect - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (80f3f0)

by Nicholas

created 2019-02-11 19:42 UTC

Status

Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

@@ -3,75 +3,75 @@
 block discarded – undo
 namespace Nickcheek\Atdconnect\Services;
 
 class Vehicle {
-	use \Nickcheek\Atdconnect\Traits\ApiTrait;
+        use \Nickcheek\Atdconnect\Traits\ApiTrait;
 	
-	private $location;
-	private $wsdl;
+        private $location;
+        private $wsdl;
 		
-	public $vin;
+        public $vin;
 	
 
-	public function __construct()
-	{
-	    $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
-	    $this->location = $config->location;
-		$this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
+        public function __construct()
+        {
+                $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
+                $this->location = $config->location;
+                $this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
 		
-	}
+        }
 	
-	//************************************************
-    //               Vehicle Service
-    //************************************************
-    public  function getVehicleYear()
-    {
+        //************************************************
+        //               Vehicle Service
+        //************************************************
+        public  function getVehicleYear()
+        {
         return $this->apiCall('getVehicleYear','',$this->wsdl);
-    }
+        }
     
-    public  function getVehicleMake($year)
-    {	
-    	return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
-    }
+        public  function getVehicleMake($year)
+        {	
+                return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
+        }
 
-    public  function getVehicleModel($year,$make)
-    {	
+        public  function getVehicleModel($year,$make)
+        {	
         return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
-    }
+        }
 
     
-    public  function getVehicleTrim($year,$make,$model)
-    {
+        public  function getVehicleTrim($year,$make,$model)
+        {
         return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
-    }
+        }
     
-    public function getVehicleTrimOption($year,$make,$model,$trim)
-    {
-    	return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
-	}
+        public function getVehicleTrimOption($year,$make,$model,$trim)
+        {
+                return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+        }
     
-    public function getVehiclePlusSizes($year,$make,$model,$trim)
-    {
-    	return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
-	}
+        public function getVehiclePlusSizes($year,$make,$model,$trim)
+        {
+                return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+        }
     
-    public function getProductByFitment($year,$make,$model,$trim,$option)
-    {
-	  	return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim,'trimOption'=>$option]],$this->wsdl);
-	}
+        public function getProductByFitment($year,$make,$model,$trim,$option)
+        {
+                        return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim,'trimOption'=>$option]],$this->wsdl);
+        }
     
-    public function getVehicleByVehicleId($vID)
-    {
-	  	return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['vehicleId'=>$vID]],$this->wsdl);
-	}
+        public function getVehicleByVehicleId($vID)
+        {
+                        return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['vehicleId'=>$vID]],$this->wsdl);
+        }
     
-    public function getVehicleByLicensePlate($num,$state)
-    {
-	    return $this->apiCall('getVehicleByLicensePlate',['licensePlateNumber'=>$num,'licensePlateState' => $state],$this->wsdl);
-	}
+        public function getVehicleByLicensePlate($num,$state)
+        {
+                return $this->apiCall('getVehicleByLicensePlate',['licensePlateNumber'=>$num,'licensePlateState' => $state],$this->wsdl);
+        }
 	
-	public function getVehicleByVIN($vin)
-    {
-	    return $this->apiCall('getVehicleByVIN',['VIN'=>$vin],$this->wsdl);
-	}
+        public function getVehicleByVIN($vin)
+        {
+                return $this->apiCall('getVehicleByVIN',['VIN'=>$vin],$this->wsdl);
+        }
     
     
     

Please login to merge, or discard this patch.

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 	public function __construct()
 	{
-	    $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
+	    $config = include(realpath(dirname(__FILE__).'/../config/config.php'));
 	    $this->location = $config->location;
 		$this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
 		
@@ -24,53 +24,53 @@  discard block
 block discarded – undo
     //************************************************
     public  function getVehicleYear()
     {
-        return $this->apiCall('getVehicleYear','',$this->wsdl);
+        return $this->apiCall('getVehicleYear', '', $this->wsdl);
     }
     
     public  function getVehicleMake($year)
     {	
-    	return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
+    	return $this->apiCall('getVehicleMake', ['vehicle' => ['year'=>$year]], $this->wsdl);
     }
 
-    public  function getVehicleModel($year,$make)
+    public  function getVehicleModel($year, $make)
     {	
-        return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
+        return $this->apiCall('getVehicleModel', ['vehicle' => ['year'=>$year, 'make'=>$make]], $this->wsdl);
     }
 
     
-    public  function getVehicleTrim($year,$make,$model)
+    public  function getVehicleTrim($year, $make, $model)
     {
-        return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
+        return $this->apiCall('getVehicleTrim', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model]], $this->wsdl);
     }
     
-    public function getVehicleTrimOption($year,$make,$model,$trim)
+    public function getVehicleTrimOption($year, $make, $model, $trim)
     {
-    	return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+    	return $this->apiCall('getVehicleTrimOption', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
 	}
     
-    public function getVehiclePlusSizes($year,$make,$model,$trim)
+    public function getVehiclePlusSizes($year, $make, $model, $trim)
     {
-    	return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
+    	return $this->apiCall('getVehiclePlusSizes', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
 	}
     
-    public function getProductByFitment($year,$make,$model,$trim,$option)
+    public function getProductByFitment($year, $make, $model, $trim, $option)
     {
-	  	return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim,'trimOption'=>$option]],$this->wsdl);
+	  	return $this->apiCall('getProductByFitment', ['locationNumber'=>$this->location, 'vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim, 'trimOption'=>$option]], $this->wsdl);
 	}
     
     public function getVehicleByVehicleId($vID)
     {
-	  	return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['vehicleId'=>$vID]],$this->wsdl);
+	  	return $this->apiCall('getProductByFitment', ['locationNumber'=>$this->location, 'vehicle' => ['vehicleId'=>$vID]], $this->wsdl);
 	}
     
-    public function getVehicleByLicensePlate($num,$state)
+    public function getVehicleByLicensePlate($num, $state)
     {
-	    return $this->apiCall('getVehicleByLicensePlate',['licensePlateNumber'=>$num,'licensePlateState' => $state],$this->wsdl);
+	    return $this->apiCall('getVehicleByLicensePlate', ['licensePlateNumber'=>$num, 'licensePlateState' => $state], $this->wsdl);
 	}
 	
 	public function getVehicleByVIN($vin)
     {
-	    return $this->apiCall('getVehicleByVIN',['VIN'=>$vin],$this->wsdl);
+	    return $this->apiCall('getVehicleByVIN', ['VIN'=>$vin], $this->wsdl);
 	}
     
     

Please login to merge, or discard this patch.

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13
14	14	public function __construct()
15	15	{
16		- $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
	16	+ $config = include(realpath(dirname(__FILE__).'/../config/config.php'));
17	17	$this->location = $config->location;
18	18	$this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
19	19
		@@ -24,53 +24,53 @@ discard block
		block discarded – undo
24	24	//************************************************
25	25	public function getVehicleYear()
26	26	{
27		- return $this->apiCall('getVehicleYear','',$this->wsdl);
	27	+ return $this->apiCall('getVehicleYear', '', $this->wsdl);
28	28	}
29	29
30	30	public function getVehicleMake($year)
31	31	{
32		- return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
	32	+ return $this->apiCall('getVehicleMake', ['vehicle' => ['year'=>$year]], $this->wsdl);
33	33	}
34	34
35		- public function getVehicleModel($year,$make)
	35	+ public function getVehicleModel($year, $make)
36	36	{
37		- return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
	37	+ return $this->apiCall('getVehicleModel', ['vehicle' => ['year'=>$year, 'make'=>$make]], $this->wsdl);
38	38	}
39	39
40	40
41		- public function getVehicleTrim($year,$make,$model)
	41	+ public function getVehicleTrim($year, $make, $model)
42	42	{
43		- return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
	43	+ return $this->apiCall('getVehicleTrim', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model]], $this->wsdl);
44	44	}
45	45
46		- public function getVehicleTrimOption($year,$make,$model,$trim)
	46	+ public function getVehicleTrimOption($year, $make, $model, $trim)
47	47	{
48		- return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	48	+ return $this->apiCall('getVehicleTrimOption', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
49	49	}
50	50
51		- public function getVehiclePlusSizes($year,$make,$model,$trim)
	51	+ public function getVehiclePlusSizes($year, $make, $model, $trim)
52	52	{
53		- return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	53	+ return $this->apiCall('getVehiclePlusSizes', ['vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim]], $this->wsdl);
54	54	}
55	55
56		- public function getProductByFitment($year,$make,$model,$trim,$option)
	56	+ public function getProductByFitment($year, $make, $model, $trim, $option)
57	57	{
58		- return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim,'trimOption'=>$option]],$this->wsdl);
	58	+ return $this->apiCall('getProductByFitment', ['locationNumber'=>$this->location, 'vehicle' => ['year'=>$year, 'make'=>$make, 'model'=>$model, 'trim'=>$trim, 'trimOption'=>$option]], $this->wsdl);
59	59	}
60	60
61	61	public function getVehicleByVehicleId($vID)
62	62	{
63		- return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['vehicleId'=>$vID]],$this->wsdl);
	63	+ return $this->apiCall('getProductByFitment', ['locationNumber'=>$this->location, 'vehicle' => ['vehicleId'=>$vID]], $this->wsdl);
64	64	}
65	65
66		- public function getVehicleByLicensePlate($num,$state)
	66	+ public function getVehicleByLicensePlate($num, $state)
67	67	{
68		- return $this->apiCall('getVehicleByLicensePlate',['licensePlateNumber'=>$num,'licensePlateState' => $state],$this->wsdl);
	68	+ return $this->apiCall('getVehicleByLicensePlate', ['licensePlateNumber'=>$num, 'licensePlateState' => $state], $this->wsdl);
69	69	}
70	70
71	71	public function getVehicleByVIN($vin)
72	72	{
73		- return $this->apiCall('getVehicleByVIN',['VIN'=>$vin],$this->wsdl);
	73	+ return $this->apiCall('getVehicleByVIN', ['VIN'=>$vin], $this->wsdl);
74	74	}
75	75
76	76

		@@ -3,75 +3,75 @@
		block discarded – undo
3	3	namespace Nickcheek\Atdconnect\Services;
4	4
5	5	class Vehicle {
6		- use \Nickcheek\Atdconnect\Traits\ApiTrait;
	6	+ use \Nickcheek\Atdconnect\Traits\ApiTrait;
7	7
8		- private $location;
9		- private $wsdl;
	8	+ private $location;
	9	+ private $wsdl;
10	10
11		- public $vin;
	11	+ public $vin;
12	12
13	13
14		- public function __construct()
15		- {
16		- $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
17		- $this->location = $config->location;
18		- $this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
	14	+ public function __construct()
	15	+ {
	16	+ $config = include(realpath(dirname(__FILE__) . '/../config/config.php'));
	17	+ $this->location = $config->location;
	18	+ $this->wsdl = 'http://testws.atdconnect.com/ws/3_4/fitments.wsdl';
19	19
20		- }
	20	+ }
21	21
22		- //************************************************
23		- // Vehicle Service
24		- //************************************************
25		- public function getVehicleYear()
26		- {
	22	+ //************************************************
	23	+ // Vehicle Service
	24	+ //************************************************
	25	+ public function getVehicleYear()
	26	+ {
27	27	return $this->apiCall('getVehicleYear','',$this->wsdl);
28		- }
	28	+ }
29	29
30		- public function getVehicleMake($year)
31		- {
32		- return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
33		- }
	30	+ public function getVehicleMake($year)
	31	+ {
	32	+ return $this->apiCall('getVehicleMake',['vehicle' => ['year'=>$year]],$this->wsdl);
	33	+ }
34	34
35		- public function getVehicleModel($year,$make)
36		- {
	35	+ public function getVehicleModel($year,$make)
	36	+ {
37	37	return $this->apiCall('getVehicleModel',['vehicle' => ['year'=>$year,'make'=>$make]],$this->wsdl);
38		- }
	38	+ }
39	39
40	40
41		- public function getVehicleTrim($year,$make,$model)
42		- {
	41	+ public function getVehicleTrim($year,$make,$model)
	42	+ {
43	43	return $this->apiCall('getVehicleTrim',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model]],$this->wsdl);
44		- }
	44	+ }
45	45
46		- public function getVehicleTrimOption($year,$make,$model,$trim)
47		- {
48		- return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
49		- }
	46	+ public function getVehicleTrimOption($year,$make,$model,$trim)
	47	+ {
	48	+ return $this->apiCall('getVehicleTrimOption',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	49	+ }
50	50
51		- public function getVehiclePlusSizes($year,$make,$model,$trim)
52		- {
53		- return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
54		- }
	51	+ public function getVehiclePlusSizes($year,$make,$model,$trim)
	52	+ {
	53	+ return $this->apiCall('getVehiclePlusSizes',['vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim]],$this->wsdl);
	54	+ }
55	55
56		- public function getProductByFitment($year,$make,$model,$trim,$option)
57		- {
58		- return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim,'trimOption'=>$option]],$this->wsdl);
59		- }
	56	+ public function getProductByFitment($year,$make,$model,$trim,$option)
	57	+ {
	58	+ return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['year'=>$year,'make'=>$make,'model'=>$model,'trim'=>$trim,'trimOption'=>$option]],$this->wsdl);
	59	+ }
60	60
61		- public function getVehicleByVehicleId($vID)
62		- {
63		- return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['vehicleId'=>$vID]],$this->wsdl);
64		- }
	61	+ public function getVehicleByVehicleId($vID)
	62	+ {
	63	+ return $this->apiCall('getProductByFitment',['locationNumber'=>$this->location,'vehicle' => ['vehicleId'=>$vID]],$this->wsdl);
	64	+ }
65	65
66		- public function getVehicleByLicensePlate($num,$state)
67		- {
68		- return $this->apiCall('getVehicleByLicensePlate',['licensePlateNumber'=>$num,'licensePlateState' => $state],$this->wsdl);
69		- }
	66	+ public function getVehicleByLicensePlate($num,$state)
	67	+ {
	68	+ return $this->apiCall('getVehicleByLicensePlate',['licensePlateNumber'=>$num,'licensePlateState' => $state],$this->wsdl);
	69	+ }
70	70
71		- public function getVehicleByVIN($vin)
72		- {
73		- return $this->apiCall('getVehicleByVIN',['VIN'=>$vin],$this->wsdl);
74		- }
	71	+ public function getVehicleByVIN($vin)
	72	+ {
	73	+ return $this->apiCall('getVehicleByVIN',['VIN'=>$vin],$this->wsdl);
	74	+ }
75	75
76	76
77	77

nickcheek / AtdConnect

Branch — master (80f3f0)

Status

Category

Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch